https://github.com/python/cpython/commit/84c36c152a2bdf98f9cc7ce0e1db98e1f44... commit: 84c36c152a2bdf98f9cc7ce0e1db98e1f442a05e branch: 3.8 author: Victor Stinner <vstinner@python.org> committer: GitHub <noreply@github.com> date: 2019-11-22T13:39:36+01:00 summary: bpo-36854: Fix reference counter in PyInit__testcapi() (GH-17338) Increment properly Py_True/Py_False reference counter for _testcapi.WITH_PYMALLOC variable. files: M Modules/_testcapimodule.c diff --git a/Modules/_testcapimodule.c b/Modules/_testcapimodule.c index 46d772cff608e..b54071669cf99 100644 --- a/Modules/_testcapimodule.c +++ b/Modules/_testcapimodule.c @@ -6283,11 +6283,14 @@ PyInit__testcapi(void) PyModule_AddObject(m, "instancemethod", (PyObject *)&PyInstanceMethod_Type); PyModule_AddIntConstant(m, "the_number_three", 3); + PyObject *v; #ifdef WITH_PYMALLOC - PyModule_AddObject(m, "WITH_PYMALLOC", Py_True); + v = Py_True; #else - PyModule_AddObject(m, "WITH_PYMALLOC", Py_False); + v = Py_False; #endif + Py_INCREF(v); + PyModule_AddObject(m, "WITH_PYMALLOC", v); TestError = PyErr_NewException("_testcapi.error", NULL, NULL); Py_INCREF(TestError);