gh-109566: regrtest --fast-ci no longer enables --nowindows (#110121)
https://github.com/python/cpython/commit/5ae6c6d053311d411a077200f85698d51d5... commit: 5ae6c6d053311d411a077200f85698d51d5fe8b9 branch: main author: Victor Stinner <vstinner@python.org> committer: vstinner <vstinner@python.org> date: 2023-09-29T19:49:39Z summary: gh-109566: regrtest --fast-ci no longer enables --nowindows (#110121) The --nowindows option is deprecated and does nothing but logs a warning. files: M Lib/test/libregrtest/cmdline.py M Lib/test/test_regrtest.py diff --git a/Lib/test/libregrtest/cmdline.py b/Lib/test/libregrtest/cmdline.py index 0a863561d5273..8562a48446b4a 100644 --- a/Lib/test/libregrtest/cmdline.py +++ b/Lib/test/libregrtest/cmdline.py @@ -4,8 +4,6 @@ import sys from test.support import os_helper -from .utils import MS_WINDOWS - USAGE = """\ python -m test [options] [test_name1 [test_name2 ...]] @@ -414,7 +412,7 @@ def _parse_args(args, **kwargs): # Similar to options: # # -j0 --randomize --fail-env-changed --fail-rerun --rerun - # --slowest --verbose3 --nowindows + # --slowest --verbose3 if ns.use_mp is None: ns.use_mp = 0 ns.randomize = True @@ -424,8 +422,6 @@ def _parse_args(args, **kwargs): ns.rerun = True ns.print_slow = True ns.verbose3 = True - if MS_WINDOWS: - ns.nowindows = True # Silence alerts under Windows else: ns._add_python_opts = False diff --git a/Lib/test/test_regrtest.py b/Lib/test/test_regrtest.py index da1406def5554..c98b05abcea98 100644 --- a/Lib/test/test_regrtest.py +++ b/Lib/test/test_regrtest.py @@ -376,8 +376,6 @@ def test_unknown_option(self): def check_ci_mode(self, args, use_resources, rerun=True): ns = cmdline._parse_args(args) - if utils.MS_WINDOWS: - self.assertTrue(ns.nowindows) # Check Regrtest attributes which are more reliable than Namespace # which has an unclear API
participants (1)
-
vstinner