11 Jul
2017
11 Jul
'17
1:14 a.m.
2017-07-10 17:35 GMT+02:00 Guido van Rossum guido@python.org:
Often the committer has more context to write a proper commit message, and asking the contributor to do the squash is just wasting time (plus in general we *don't* want contributors to squash, since that loses the context for the review). So I'm with Sergey. This is how we do it in the mypy-related projects.
Oh, I noticed that comments were hidden after a rebase or squash. But I never understood the link between squash/rebase and hidden comments.
Ok, it makes sense to prefer merge and multiple commits to workaround UI limitations of GitHub PRs :-)
Victor