On Tue, 14 Feb 2017 at 09:19 Senthil Kumaran <senthil@uthcode.com> wrote:
On Tue, Feb 14, 2017 at 9:10 AM, Victor Stinner <victor.stinner@gmail.com> wrote:
Would it be possible to modify the workflow of GitHub pull requests to allow to click on Merge, but only merge a PR once tests complete and only if tests pass?
Yes, that is possible.
I am +1 in doing that. I hope others are on the same page. If in agreement, I will enable that in github.
It's called "Require status checks to pass before merging" and we can enable travis-ci to go green before allowing to merge.
The reason I didn't turn that on to begin with was I wanted to wait until we had proven to ourselves that our test suite was stable enough to not block PRs on a regular basis due to some flaky test. If people feel the tests are passing consistently when they should then I'm all for flipping on this protection.