On 20 Jan 2014 08:06, "Victor Stinner" <victor.stinner@gmail.com> wrote:
>
> Is it enough to know the python process and how to write good patches? I don't see why Yury would become but not Vajrasky Kok.

In this case, it's Yury's specific contributions to an orphan module and being a co-author of an accepted PEP related to that module that motivate my suggestion, rather than general bug fixing (which I agree would typically involve a wider range of contributions).

I see it as similar to the way we grant commit access to authors of "add a module to the standard library" PEPs as a matter of course so they can continue maintaining it.

Cheers,
Nick.

>
> I never liked how much time it takes to become a "core developer". Developers know what it means to be core developer and usually ensure that they don't make mistake.
>
> I didn't see Yury's work, so I'm unable to pronouce me about him. I'm just trying to figure out how his profile is different from Vajrasky's profile. By the way, I also proposed to mentor Vajrasky.
>
> Victor
>
> Le 19 janv. 2014 21:34, "Terry Reedy" <tjreedy@udel.edu> a écrit :
>
>> On 1/19/2014 1:30 AM, Nick Coghlan wrote:
>>>
>>> Hi,
>>>
>>> I'd like to suggest granting commit access to Yury Selivanov,
>>> primarily to assist with maintenance of the inspect module.
>>>
>>> That's currently an orphaned module in the experts index, and Yury was
>>> a driving force behind getting PEP 362 (the new introspection API)
>>> accepted for Python 3.3, and has also picked up on a number of
>>> introspection support issues we missed when adding other features to
>>> Python 3.4 (like inspect.signature not handling
>>> functools.partialmethod correctly - it simply didn't occur to me or
>>> Alon to add test cases for that). He's also created a reimplementation
>>> of inspect.getfullargspec for Python 3.4 (not yet merged, but close to
>>> being so) that will allow almost all existing introspection code to
>>> benefit from the Argument Clinic changes, not just the code that has
>>> been ported to the new PEP 362 introspection API.
>>>
>>> Yury's interested in the idea of commit access, and is comfortable
>>> with our approach to code review and automated testing. As usual when
>>> nominating someone, I'm happy to handle the mentoring period and
>>> addressing any questions Yury may have about the mechanics of actually
>>> pushing changes rather than having to wait for me or Larry or someone
>>> else to merge them on his behalf.
>>
>>
>> For anyone looking, he has posted on the tracker as both 'yselivanov' (2 years) and 'Yury.Selivanov' (3 1/2 years). He has submitted patches on about 12 issues, 7 closesd, and commented on another 10. These are mostly issue I have not be active on, but the numbers are typical for when we think about promoting someone.
>>
>> Terry
>>
>>
>> _______________________________________________
>> python-committers mailing list
>> python-committers@python.org
>> https://mail.python.org/mailman/listinfo/python-committers
>
>
> _______________________________________________
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
>