Abhilash Raj (maxking) wrote:
Hi, On August 19, 2019 9:35:02 AM UTC, Victor Stinner firstname.lastname@example.org wrote:
Hi, To create a 3.5 backport, I use the following commands (something like this, adapt names ;-): cd ~/python/3.5 git checkout -b fix_something35 git cherry-pick -x commit_sha1 # maybe fix conflicts or make further changes make ./python -m test -v test_modified_test # or better: ./python -m test -j0 -rW gh_pr.sh # my script to open a PR I consider that it's easy enough to not have a "backport to 3.5" label. Well, it is easier to use cherry_picker to do this:
$ cherry_picker <sha1> 3.5 That's all. It doesn't run tests but CI will do that so I guess they are similar :)
I asked to remove this label since it was misused by contributors who are not aware that 3.5 not longer accept bug fixes. Ah okay, I was just looking for this. I guess it makes sense, but I always
thought non core devs can't add labels.
Correct. Victor means core devs in this case. Basically people would find e.g. a spelling mistake and then just instinctively add all the backport labels without thinking about whether it should go into the security-only branches.
Tell me if you need help to do the backport. Note: there are many tools to open a pull requests on GitHub, but my script is working well for my workload so I never tried any other script ;-) Victor Abhilash