On Fri, Oct 16, 2020 at 11:58 AM Pablo Galindo Salgado <pablogsal@gmail.com> wrote:
We should simply mark the github actions "Tests / Ubuntu" CI as required.

+1 I completely agree with everything Gregory said.

+1 from me as well.

-Brett
 


On Fri, 16 Oct 2020 at 19:36, Gregory P. Smith <greg@krypto.org> wrote:


On Fri, Oct 16, 2020 at 1:42 AM Victor Stinner <vstinner@python.org> wrote:
Hi,

Python has no mandatory Linux CI job on pull requests anymore. Right
now Windows (x64) remains the only mandatory job. Please be careful to
manually check other CI before merging a PR.

--

We had to deal with at least 3 different issues on the Travis CI over
the last 6 months. The latest one (3rd issue) is on the Travis CI side
and is known for months. Sometimes, a Travis CI build completes but
the GitHub pull request is never updated. Since Travis CI was
mandatory, it was never possible to merge some pull requests. I also
noticed a 4th bug, sometimes a PR gets *two* Travis CI jobs on a PR
for the same Travis CI build, only one is updated, and so again, the
PR cannot be merged.

For all these reasons, Travis CI was made optional.

I would be nice to have a mandatory Linux job: "Tests / Ubuntu
(pull_request)" is a good candidate. But I didn't check if it's
reliable or not.

We should simply mark the github actions "Tests / Ubuntu" CI as required.

If we wind up not liking the behavior we can go back on it while we work something else out.  But it seems dangerous to not have any blocking Linux CI.  Linux is our most important platform.  With our dev sprint next week we'll discover if it gets in our way more often than helps rather quickly.

I cannot rightfully apply an automerge label to a code PR so long as we lack Linux CI to block a merge.

-gps
 

See https://github.com/python/core-workflow/issues/377 for the discussion.

Note: if someone manages to fix all Travis CI issues, we can
reconsider making it mandatory again. But it seems like most people
who tried (included me) are tired or bored by Travis CI.

Victor
--
Night gathers, and now my watch begins. It shall not end until my death.
_______________________________________________
python-committers mailing list -- python-committers@python.org
To unsubscribe send an email to python-committers-leave@python.org
https://mail.python.org/mailman3/lists/python-committers.python.org/
Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/JR7HIQHVECHPKH2LE46EACN73KCBLVKE/
Code of Conduct: https://www.python.org/psf/codeofconduct/
_______________________________________________
python-committers mailing list -- python-committers@python.org
To unsubscribe send an email to python-committers-leave@python.org
https://mail.python.org/mailman3/lists/python-committers.python.org/
Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/7YTWVS5OXH3NJQBSG55QBSXOMD6RECFG/
Code of Conduct: https://www.python.org/psf/codeofconduct/
_______________________________________________
python-committers mailing list -- python-committers@python.org
To unsubscribe send an email to python-committers-leave@python.org
https://mail.python.org/mailman3/lists/python-committers.python.org/
Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/PRZ6USPKAEVZHBO5MUWYDK37O3PYBSG4/
Code of Conduct: https://www.python.org/psf/codeofconduct/