Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

On 6/18/2018 2:37 PM, Brett Cannon wrote:

On Mon, 18 Jun 2018 at 11:17 Antoine Pitrou mailto:antoine@python.org> wrote:

Le 14/06/2018 à 04:30, Terry Reedy a écrit :
 > On 6/13/2018 7:03 PM, Carol Willing wrote:
 >> +1 With Victor's mentoring (1 or 2 months), I believe that it is
 >> reasonable to promote Pablo to a core developer either now or
after 3
 >> months of coaching.
 >>
 >> I would also like to see Cheryl Sabella who has been very active
on the
 >> bug tracker to also be promoted to a core developer.
 >
 > A bit off topic, but I would too, as she has been extremely
helpful with
 > IDLE.

It's very nice that we're getting new active contributors.
OTOH if Cheryl is mostly active on the bug tracker, does she need commit
rights in order to participate properly?

On the tracker, ordinary commit rights add the little symbol after your name and add your name to the drop down lists for Assigned and Nosy. (The latter, by the way, would be a reason to de-activate people inactive after several years.)

  Or did she also review PRs or submit some of her own?

In the last year, she has submitted roughly 70 PRs, about half for IDLE, and perhaps 2/3 have been merged. I still need to review her remaining IDLE PRs. The last few I merged with little or no changed. She has done some reviews, especially when asked, but obviously prefers writing.

On Github, the main effects of commits rights are addition to the list of possible reviewers, more weight to reviews (as far as github is concerned), and the possibility of pushing changes to both the PR branch and cpython.

Cheryl is actually the 6th most active contributor by commits over the past year: https://github.com/python/cpython/graphs/contributors?from=2017-06-18&to=2018-06-18&type=c (IOW only Victor, you, Yury, Terry, and Ned have more commits since 2017-06-18).