On 16.03.2017 00:49, Brett Cannon wrote:
On Wed, 15 Mar 2017 at 08:44 Berker Peksağ <berker.peksag@gmail.com> wrote:
On Mon, Mar 13, 2017 at 12:11 AM, Brett Cannon <brett@python.org> wrote:
On Sun, 12 Mar 2017 at 06:33 M.-A. Lemburg <mal@egenix.com> wrote:
On 10.03.2017 23:13, Brett Cannon wrote:
Fifth, anything I missed? :)
My main nit after the move is that messages to the checkin list no longer include the full patch. This makes reviews harder than necessary (you always have to go through the browser).
Is there some way this could be changed back to what we had previously or is this a hard limitation of github ?
It's a hard limitation of the GitHub-provided email solution. With
GitHub's
APIs and enough time someone could either come up with a custom email solution or a web page that showed this information (you literally just need to add ".diff" to the end of a URL to get the diff itself for a PR, e.g. https://github.com/python/cpython/pull/648.diff will redirect to a raw diff). There might also already be other solutions out there that do what you're after.
Obviously this all requires work on someone's part. :) (I've also moved completely off of an email-based workflow so I'm definitely not the right person to drive this sort of thing.)
I wrote https://github.com/berkerpeksag/cpython-emailer-webhook to solve this problem. It works and its output is almost same as the old one [1] I even wrote some tests and documentation, but I just noticed that I forgot to push to GitHub :)
If we all agree on the idea I can help with deploying it. I can use my own VPS for the initial deploy, but it would be nice to have a PSF backed server in the long term.
This would be fantastic :-) Thank you, Berker !
-- Marc-Andre Lemburg eGenix.com
Professional Python Services directly from the Experts (#1, Mar 16 2017)
Python Projects, Coaching and Consulting ... http://www.egenix.com/ Python Database Interfaces ... http://products.egenix.com/ Plone/Zope Database Interfaces ... http://zope.egenix.com/
::: We implement business ideas - efficiently in both time and costs :::
eGenix.com Software, Skills and Services GmbH Pastor-Loeh-Str.48 D-40764 Langenfeld, Germany. CEO Dipl.-Math. Marc-Andre Lemburg Registered at Amtsgericht Duesseldorf: HRB 46611 http://www.egenix.com/company/contact/ http://www.malemburg.com/