On 04/26/2017 10:35 PM, Terry Reedy wrote:
On 4/26/2017 1:45 PM, Brett Cannon wrote:
:) But they are at least executed which is what we're really measuring here and I think all Ethan and I are advocating for.
I thought Ethan was advocating for more -- a specific unittest for each line.
I'm hoping that's just poor wording, or each module would need hundreds of tests. ;)
What I am advocating is to have 100% test coverage -- but as Brett said, that's an aspirational goal. Said a different way: all code in Python is important enough to test; whether we can write those tests with our limited resources is a different matter.
I am well aware that writing good tests is hard. I am painfully aware of the frustration of having error-reporting code error out because it wasn't tested.
I agree that we shouldn't deny core developers from merging because of coverage statistics.
-- ~Ethan~