On Tue, Jan 5, 2016 at 7:38 AM, Nick Coghlan ncoghlan@gmail.com wrote:
On 5 January 2016 at 11:33, R. David Murray rdmurray@bitdance.com wrote:
On Tue, 05 Jan 2016 01:26:58 +0000, "Gregory P. Smith" greg@krypto.org wrote:
On Mon, Jan 4, 2016 at 12:34 PM R. David Murray rdmurray@bitdance.com wrote:
to have to do some extra work to make the hash links work in the bug tracker, since I don't think there's any a priori way to distinguish between hg hashes and git hashes.
Just ignore the remote possibility of short 32-bit hash prefix collisions (possible, but infrequent): the way to resolve that is when a hash lookup fails, to look it up in a translation index of former hg hashes. practical. good enough.
Yes, collision is not the problem, it's that you can't distinguish them without a lookup table or something. Which means we have to do more than just change the URL in the existing linkifier, which was my point.
In the specific case of Roundup, does the linkifier have the "date of comment" info available? If so, it could fairly readily assume that hashes prior to the cutover date are hg ones, and later ones are for git.
By looking at the code I don't see it readily available, but it might be possible to retrieve it somehow. However I think it's better to keep the linkifier simple and stupid and just delegate to https://hg.python.org/lookup/ .
Best Regards, Ezio Melotti
Cheers, Nick.
-- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia