GitHub workflow is nice when a single commit is enough to close an
issue. But what if a bug should be fixed in multiple branches? Is
there a way in GitHub to require one commit per branch to close an
issue?
I wasn't worried about automating that case... But it is something we do reasonably often for bug fixes (merge the PR to main plus PRs to backport to the past two releases) so it'd be a natural next step. It may be more difficult to automate and express as it becomes a logical "x and y and z -> close/fixed" concept.
If you predicate this automation on having switched to github issues, Those work differently than bpo. We could choose to always "close" after an issue is fixed in the first branch (usually main; though we occasionally have issues that are release-only and don't impact main) and use tags on issues to determine when they still need backports to past releases. The Issue's "open for backport to 3.9" tag being removed once the fixes land in the relevant release branch.
That gets complicated, I'd leave that up to whomever designs and implements our GH Issues workflow (PEP-581 and 588 or otherwise).
-gps
Victor
Le dim. 11 oct. 2020 à 21:16, Guido van Rossum <guido@python.org> a écrit :
>
> Once issues move to GitHub we’ll have this with no additional effort.
>
> On Sun, Oct 11, 2020 at 12:14 Gregory P. Smith <greg@krypto.org> wrote:
>>
>> We've got the automerge tag on GH, it+bot make it awesome. There's one more thing I'd like to see that could help with bug hygiene: A tag to close the associated bug as "fixed" after the merge happens.
>>
>> This doesn't have to be tied to automerge; in practice you'd find them used in unison somewhat often. More readily on features done on the main branch rather than bug fixes needing backports to multiple releases.
>>
>> We've had such a system at work for so long I don't even remember when it was added, but it has been a great time saver. Less more bugs laying around fixed but not marked as such. Less need for triagers to manually ask someone who has the permissions to change the bug state. Less unintentionally still open bugs in the way distracting people. Good all around.
>>
>> It isn't the primary way to close issues, but it helps in situations where it makes sense. I'd assume the same set of people allowed to add automerge should be allowed to add this label.
>>
>> -gps
>> _______________________________________________
>> python-committers mailing list -- python-committers@python.org
>> To unsubscribe send an email to python-committers-leave@python.org
>> https://mail.python.org/mailman3/lists/python-committers.python.org/
>> Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/RTIPINYIWF7IDEEJOVFTMGZPJ2SMYQC3/
>> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
> --
> --Guido (mobile)
> _______________________________________________
> python-committers mailing list -- python-committers@python.org
> To unsubscribe send an email to python-committers-leave@python.org
> https://mail.python.org/mailman3/lists/python-committers.python.org/
> Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/A6HPANBCT3RHXLBXMQMXCSMLVEQCRF4A/
> Code of Conduct: https://www.python.org/psf/codeofconduct/
--
Night gathers, and now my watch begins. It shall not end until my death.