Well he also wrote and implemented PEP 562 (overriding __getattr__ and __dir__ on modules). I'd be happy to tell him to gain other developers' trust before barging into other areas. But isn't that how all core devs work by default?
On Tue, Dec 5, 2017 at 5:07 PM, Victor Stinner <victor.stinner@gmail.com> wrote:
Hi Guido,
Since the typing module is out of my interest area, I didn't notice Ivan contributions, so it's hard for me to give an opinion.
Should I understand that he will mostly contribute to the typing module? If (in the beginning?) we restrict him to the typing module, I will simply rely on your judgment Guido. I know that you are following the topic closely and so are very good to estimate his skills.
I'm not talking about technically restricting Ivan to the typing module. It's more that I expect him to request an approval by other core developers if he wants to touch other parts of CPython. In my experience, developers are already doing that naturally, but I would prefer to clarify this point.
Victor
2017-12-06 2:00 GMT+01:00 Guido van Rossum <guido@python.org>:
I'd like to propose Ivan Levkivskyi as a new core committer. He's (re-)written most of the typing.py module and will do so again for Python 3.7, he's the sole or primary author on several PEPs (526, 544, 560, 562), is co-author on several more (483, 561) and has been acknowledged in yet others (557, 563).
He is responsible for at least 16 commits in master.
I have worked with him for a long time on typing.py and on mypy (where he is a core dev) and I can vouch for him completely.
-- --Guido van Rossum (python.org/~guido)
python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
-- --Guido van Rossum (python.org/~guido)