On Wed, 19 Jul 2017 at 08:18 R. David Murray rdmurray@bitdance.com wrote:
On Tue, 18 Jul 2017 23:13:41 -0000, Brett Cannon brett@python.org wrote:
Do realize that setting is part of requiring a review for pull requests:
https://help.github.com/articles/enabling-required-reviews-for-pull-requests... .
So in order to get this we would require all PRs, core dev or not, to receive an approving review from another core developer (I don't think an approving review from just anyone counts towards the minimum approval). There might be around this, but it will require some testing to make sure (see https://github.com/python/core-workflow/issues/94#issuecomment-316224864 ).
Ah, I thought we were already doing that, but of course we aren't. Nevermind :)
I was planning on bringing this up in a year or so once everyone was comfortable with the workflow. :)