I looked into this and it looks like there's a blindspot in the Github API reporting where it includes a bunch of checks that finished but doesn't list checks that haven't started yet at all. In this case the bot reports success because there are no pending checks.

Not sure how we can easily improve this since the event that triggers the bot simply doesn't contain the missing information. I'll dig further, maybe we can just list expected checks somehow in the config to avoid this.

- Ł



On 4 Sep 2021, at 23:42, Guido van Rossum <guido@python.org> wrote:

I see this all the time and just ignore it. I have a feeling it's due to the miss-islington bot being triggered by some event and checking in on the PR while it is still transitioning. Occasionally I see a very large string of these and assume she's just having a bad day. Also notice that in your PR there are actually two of those failure messages, the second one being suppressed by the GitHub UI.

But maybe Mariatta has a more reasoned explanation.

On Sat, Sep 4, 2021 at 1:47 PM Eric V. Smith <eric@trueblade.com> wrote:

https://github.com/python/cpython/pull/28163 has two messages of:

@ericvsmith: Status check is done, and it's a failure ❌ .

Followed by the merge messages, followed by:

@ericvsmith: Status check is done, and it's a success ✅ .

What do the failure messages mean? Is it because I didn't wait for the checks to complete before merging?

(It's a documentation only change that I previously committed to main without incident, so I didn't feel the need to wait for all of the checks to run before merging.)

Thanks for any insight.

Eric

_______________________________________________
python-committers mailing list -- python-committers@python.org
To unsubscribe send an email to python-committers-leave@python.org
https://mail.python.org/mailman3/lists/python-committers.python.org/
Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/U7A4R6TUGBD3KNAF3F2JJGNQ6V7B5G4D/
Code of Conduct: https://www.python.org/psf/codeofconduct/


--
--Guido van Rossum (python.org/~guido)
_______________________________________________
python-committers mailing list -- python-committers@python.org
To unsubscribe send an email to python-committers-leave@python.org
https://mail.python.org/mailman3/lists/python-committers.python.org/
Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/VO4XYHUIG6KM66NONOZMMPCQYOBP6YEB/
Code of Conduct: https://www.python.org/psf/codeofconduct/