On Thu, 24 Nov 2016 12:22:00 +0100, Victor Stinner <victor.stinner@gmail.com> wrote:
I know that tracking generated files is not pure, but it's very convenient, so please keep them: configure, Python/importlib.h, Python/importlib_external.h, etc.!
When testing Python on some "custom" operating systems, I already had enough issues to compile Python :-) For example, on OpenIndiana, Python wanted to rebuild the grammar but the system Python was 2.6 which didn't work (I don't recall the details). Moreover, the "make touch" command didn't work neither :-)
Right, tracking those artifacts is a long standing policy and exists for good reasons. Our policy is that the committed changes should be done with the "right" version of the tool to minimize churn, and I think we should maintain that policy even if we sometimes screw up.
(I thought we had actually introduced a check for it in the Makefile, but I guess not...that would make it inconvenient for someone to intentionally use a different version for a custom build.)
--David