OK, thank you.
Are you sure it's the right thing to do? I.e. a user can create a patch, ensure that it applies cleanly, and while he uploads it, someone pushes to the repo. No 'review' link, no notification.
Wouldn't it make sense to always show the review link, and let the user to resolve the conflicts if there are any?
On 2/3/2014, 12:20 PM, Antoine Pitrou wrote:
On lun., 2014-02-03 at 09:16 -0800, Guido van Rossum wrote:
IIRC the review link only appears if the patch applies cleanly.
And only if it applies cleanly on the default branch, IIRC :-)
python-committers mailing list email@example.com https://mail.python.org/mailman/listinfo/python-committers