18 Jul
2017
18 Jul
'17
6:10 p.m.
On 19 July 2017 at 09:37, Victor Stinner victor.stinner@gmail.com wrote:
Oh.
For backports, it's convenient to be able to merge without a review. I see many cores doing it and I like it.
For master, I don't know. Sometimes a PR is merged too fast, sometiles nobody reviews a PR even if it's good. So for the master branch, the dev takes its own responsability to merge ;-)
Right, "review required" settings can be useful, but they genuinely require a self-review option as an escape hatch in community projects, and GitHub doesn't currently offer that (it doesn't allow self-review at all, not even to mark your own PRs as still requiring further changes).
Cheers, Nick.
-- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia