If this cert change is impacting CI checks for everyone's PRs, I suspect all PRs will need to merge this change into their branch before they can pass CI.
Having CI depend on external network resources does not seem like a good idea.
-gps
On Wed, May 8, 2019 at 11:04 AM Antoine Pitrou antoine@python.org wrote:
Ah, there's already a PR at https://github.com/python/cpython/pull/13192, thanks to Gregory.
Regards
Antoine.
Le 08/05/2019 à 17:58, Antoine Pitrou a écrit :
Ok, apparently the SSL cert on self-signed.pythontest.net was changed but it wasn't updated in our source tree, hence the failure.
Regards
Antoine.
Le 08/05/2019 à 17:49, Mariatta a écrit :
If you can't merge from GitHub UI then you won't be able to do it from GitHub command line (it respects the same branch protection policy)
I don't think we should merge if tests are still failing. Perhaps the test should be adjusted to handle this spurious errors? Can it be marked as "allowed failure" or something like that?
On Wed, May 8, 2019, 8:32 AM Antoine Pitrou <antoine@python.org mailto:antoine@python.org> wrote:
Hello, There are spurious CI failures (SSL certificate issue intest_httplib).
Therefore the "Squash and merge" button is greyed out. How should I merge? Using the command-line instructions from Github? Regards Antoine. _______________________________________________ python-committers mailing list python-committers@python.org <mailto:python-committers@python.org> https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/