Fwd: Trunk and 3.0 branch are now open
---------- Forwarded message ---------- From: Benjamin Peterson musiccomposition@gmail.com Date: Thu, Aug 21, 2008 at 1:58 PM Subject: Re: [python-committers] Trunk and 3.0 branch are now open To: Brett Cannon brett@python.org
On Thu, Aug 21, 2008 at 1:30 PM, Brett Cannon brett@python.org wrote:
That's what I was thinking; either real name or username, which ever you remember at the time. Since we don't have a way to flag an issue with a patch as needing a committer review, either we just continually check for release blockers with patches or we email here saying what issues have a patch ready and just need a second review.
I've created a keyword, "needs review", that we can attach to issues. Then you use the "Needs review" query [1] to find them.
[1] http://bugs.python.org/issue?%40search_text=&title=&%40columns=title...
-Brett _______________________________________________ python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
-- Cheers, Benjamin Peterson "There's no place like 127.0.0.1."
Hm, I can't say how the "needs review" query works...
On Thu, Aug 21, 2008 at 12:00 PM, Benjamin Peterson musiccomposition@gmail.com wrote:
---------- Forwarded message ---------- From: Benjamin Peterson musiccomposition@gmail.com Date: Thu, Aug 21, 2008 at 1:58 PM Subject: Re: [python-committers] Trunk and 3.0 branch are now open To: Brett Cannon brett@python.org
On Thu, Aug 21, 2008 at 1:30 PM, Brett Cannon brett@python.org wrote:
That's what I was thinking; either real name or username, which ever you remember at the time. Since we don't have a way to flag an issue with a patch as needing a committer review, either we just continually check for release blockers with patches or we email here saying what issues have a patch ready and just need a second review.
I've created a keyword, "needs review", that we can attach to issues. Then you use the "Needs review" query [1] to find them.
[1] http://bugs.python.org/issue?%40search_text=&title=&%40columns=title...
-Brett _______________________________________________ python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
-- Cheers, Benjamin Peterson "There's no place like 127.0.0.1."
-- Cheers, Benjamin Peterson "There's no place like 127.0.0.1." _______________________________________________ python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
On Thu, Aug 21, 2008 at 1:18 PM, Guido van Rossum guido@python.org wrote:
Hm, I can't say how the "needs review" query works...
You can do the search yourself by going to Search and choosing "needs review" under the Keyword pull-down.
-Brett
On Thu, Aug 21, 2008 at 12:00 PM, Benjamin Peterson musiccomposition@gmail.com wrote:
---------- Forwarded message ---------- From: Benjamin Peterson musiccomposition@gmail.com Date: Thu, Aug 21, 2008 at 1:58 PM Subject: Re: [python-committers] Trunk and 3.0 branch are now open To: Brett Cannon brett@python.org
On Thu, Aug 21, 2008 at 1:30 PM, Brett Cannon brett@python.org wrote:
That's what I was thinking; either real name or username, which ever you remember at the time. Since we don't have a way to flag an issue with a patch as needing a committer review, either we just continually check for release blockers with patches or we email here saying what issues have a patch ready and just need a second review.
I've created a keyword, "needs review", that we can attach to issues. Then you use the "Needs review" query [1] to find them.
[1] http://bugs.python.org/issue?%40search_text=&title=&%40columns=title...
-Brett _______________________________________________ python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
-- Cheers, Benjamin Peterson "There's no place like 127.0.0.1."
-- Cheers, Benjamin Peterson "There's no place like 127.0.0.1." _______________________________________________ python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
-- --Guido van Rossum (home page: http://www.python.org/~guido/) _______________________________________________ python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
On Thu, Aug 21, 2008 at 3:30 PM, Brett Cannon brett@python.org wrote:
On Thu, Aug 21, 2008 at 1:18 PM, Guido van Rossum guido@python.org wrote:
Hm, I can't say how the "needs review" query works...
You can do the search yourself by going to Search and choosing "needs review" under the Keyword pull-down.
Or you can click "edit" by "Your queries" and select the "Needs review" query.
On Thu, Aug 21, 2008 at 12:00 PM, Benjamin Peterson musiccomposition@gmail.com wrote:
---------- Forwarded message ---------- From: Benjamin Peterson musiccomposition@gmail.com Date: Thu, Aug 21, 2008 at 1:58 PM Subject: Re: [python-committers] Trunk and 3.0 branch are now open To: Brett Cannon brett@python.org
On Thu, Aug 21, 2008 at 1:30 PM, Brett Cannon brett@python.org wrote:
That's what I was thinking; either real name or username, which ever you remember at the time. Since we don't have a way to flag an issue with a patch as needing a committer review, either we just continually check for release blockers with patches or we email here saying what issues have a patch ready and just need a second review.
I've created a keyword, "needs review", that we can attach to issues. Then you use the "Needs review" query [1] to find them.
This will work short-term until after final is out and we discuss how we want our triage process to go. And it is probably best not to deselect the "patch" keyword if you do set this keyword; they are not mutually exclusive.
-Brett
On Thu, Aug 21, 2008 at 3:31 PM, Brett Cannon brett@python.org wrote:
This will work short-term until after final is out and we discuss how we want our triage process to go. And it is probably best not to deselect the "patch" keyword if you do set this keyword; they are not mutually exclusive.
To help out your reviewers, you also might want to put your patch on Rietveld. I personally prefer using it instead of finding the files I need to compare the patch to manually and calculating out lines numbers etc.
-Brett
participants (3)
-
Benjamin Peterson -
Brett Cannon -
Guido van Rossum