Hi,
This guy rocks! He understood and fixed many subtle bugs like race conditions recently. Example from the NEWS of Python 3.3:
Issue #12060: Use sig_atomic_t type and volatile keyword in the signal module. Patch written by Charles-François Natali.
Issue #11849: Make it more likely for the system allocator to release free()d memory arenas on glibc-based systems. Patch by
Charles-François Natali.
- Issue #10517: After fork(), reinitialize the TLS used by the
PyGILState_* APIs, to avoid a crash with the pthread implementation in RHEL 5. Patch by Charles-François Natali.
- Issue #11650: PyOS_StdioReadline() retries fgets() if it was
interrupted (EINTR), for example if the program is stopped with CTRL+z on Mac OS X. Patch written by Charles-Francois Natali.
- Issue #11811: ssl.get_server_certificate() is now IPv6-compatible.
Patch by Charles-François Natali.
- Issue #8428: Fix a race condition in multiprocessing.Pool when
terminating worker processes: new processes would be spawned while the pool is being shut down. Patch by Charles-François Natali.
- Issue #11757: select.select() now raises ValueError when a negative
timeout is passed (previously, a select.error with EINVAL would be raised). Patch by Charles-François Natali.
etc.
I would to propose him to commit grant. What do you think?
Victor
On Sun, May 15, 2011 at 03:31, Victor Stinner victor.stinner@haypocalc.comwrote:
Hi,
This guy rocks! He understood and fixed many subtle bugs like race conditions recently. Example from the NEWS of Python 3.3:
- Issue #12060: Use sig_atomic_t type and volatile keyword in the signal
module. Patch written by Charles-François Natali.
- Issue #11849: Make it more likely for the system allocator to release
free()d memory arenas on glibc-based systems. Patch by Charles-François Natali.
- Issue #10517: After fork(), reinitialize the TLS used by the
PyGILState_* APIs, to avoid a crash with the pthread implementation in RHEL 5. Patch by Charles-François Natali.
- Issue #11650: PyOS_StdioReadline() retries fgets() if it was
interrupted (EINTR), for example if the program is stopped with CTRL+z on Mac OS X. Patch written by Charles-Francois Natali.
- Issue #11811: ssl.get_server_certificate() is now IPv6-compatible.
Patch by Charles-François Natali.
- Issue #8428: Fix a race condition in multiprocessing.Pool when
terminating worker processes: new processes would be spawned while the pool is being shut down. Patch by Charles-François Natali.
- Issue #11757: select.select() now raises ValueError when a negative
timeout is passed (previously, a select.error with EINVAL would be raised). Patch by Charles-François Natali.
etc.
I would to propose him to commit grant. What do you think?
Victor
+1, he's been involved in some tougher issues and has been active for a while now. I haven't looked at many of his patches but he has written several, and his comments on issues have been pretty thorough.
On Sun, May 15, 2011 at 12:07 PM, Brian Curtin brian.curtin@gmail.com wrote:
On Sun, May 15, 2011 at 03:31, Victor Stinner victor.stinner@haypocalc.com wrote:
Hi,
This guy rocks! He understood and fixed many subtle bugs like race conditions recently. Example from the NEWS of Python 3.3:
- Issue #12060: Use sig_atomic_t type and volatile keyword in the signal
module. Patch written by Charles-François Natali.
- Issue #11849: Make it more likely for the system allocator to release
free()d memory arenas on glibc-based systems. Patch by Charles-François Natali.
- Issue #10517: After fork(), reinitialize the TLS used by the
PyGILState_* APIs, to avoid a crash with the pthread implementation in RHEL 5. Patch by Charles-François Natali.
- Issue #11650: PyOS_StdioReadline() retries fgets() if it was
interrupted (EINTR), for example if the program is stopped with CTRL+z on Mac OS X. Patch written by Charles-Francois Natali.
- Issue #11811: ssl.get_server_certificate() is now IPv6-compatible.
Patch by Charles-François Natali.
- Issue #8428: Fix a race condition in multiprocessing.Pool when
terminating worker processes: new processes would be spawned while the pool is being shut down. Patch by Charles-François Natali.
- Issue #11757: select.select() now raises ValueError when a negative
timeout is passed (previously, a select.error with EINVAL would be raised). Patch by Charles-François Natali.
etc.
I would to propose him to commit grant. What do you think?
Victor
+1, he's been involved in some tougher issues and has been active for a while now. I haven't looked at many of his patches but he has written several, and his comments on issues have been pretty thorough.
Agreed
Le dimanche 15 mai 2011 à 10:31 +0200, Victor Stinner a écrit :
I would to propose him to commit grant. What do you think?
Including me, we have 4 votes for, none against.
I asked him and he would like to become a Python developer.
I will ask him for his SSH public key. Should he sign the contributor agreement before his first commit? I commited into Python one year without signing this paper! I will also ask him to sign the paper.
Victor
On Wed, May 18, 2011 at 4:53 PM, Victor Stinner victor.stinner@haypocalc.com wrote:
Le dimanche 15 mai 2011 à 10:31 +0200, Victor Stinner a écrit :
I would to propose him to commit grant. What do you think?
Including me, we have 4 votes for, none against.
I asked him and he would like to become a Python developer.
I will ask him for his SSH public key. Should he sign the contributor agreement before his first commit? I commited into Python one year without signing this paper! I will also ask him to sign the paper.
Victor
Yes; please have him sign and send in the contributor agreement, please.
For the record, and since the devguide commit (http://hg.python.org/devguide/rev/0e8e3057d7bc) didn't make it to python-checkins (because of http://hg.python.org/hooks/rev/aebbd6f606f3), I have made Charles-François a committer after he sent his SSH key.
Regards
Antoine.
Le mercredi 18 mai 2011 à 22:53 +0200, Victor Stinner a écrit :
Le dimanche 15 mai 2011 à 10:31 +0200, Victor Stinner a écrit :
I would to propose him to commit grant. What do you think?
Including me, we have 4 votes for, none against.
I asked him and he would like to become a Python developer.
I will ask him for his SSH public key. Should he sign the contributor agreement before his first commit? I commited into Python one year without signing this paper! I will also ask him to sign the paper.
Victor
python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
Please make sure he sends in a contributor agreement
On Fri, May 20, 2011 at 7:07 AM, Antoine Pitrou solipsis@pitrou.net wrote:
For the record, and since the devguide commit (http://hg.python.org/devguide/rev/0e8e3057d7bc) didn't make it to python-checkins (because of http://hg.python.org/hooks/rev/aebbd6f606f3), I have made Charles-François a committer after he sent his SSH key.
Regards
Antoine.
Le mercredi 18 mai 2011 à 22:53 +0200, Victor Stinner a écrit :
Le dimanche 15 mai 2011 à 10:31 +0200, Victor Stinner a écrit :
I would to propose him to commit grant. What do you think?
Including me, we have 4 votes for, none against.
I asked him and he would like to become a Python developer.
I will ask him for his SSH public key. Should he sign the contributor agreement before his first commit? I commited into Python one year without signing this paper! I will also ask him to sign the paper.
Victor
python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
Le vendredi 20 mai 2011 à 09:18 -0400, Jesse Noller a écrit :
Please make sure he sends in a contributor agreement
I am in contact with Charles-François. I asked me to sign the contributor agreement. I told him that it is possible to scan it and send the image to the PSF, but he answered that it's not written in the contributor agreement or in the dev guide. So I don't know if he will scan it and/or send the papier version.
Victor
(Not sure if this was sent on the first attempt)
Also please have him subscribe to python-committers.
Eric.
Victor Stinner victor.stinner@haypocalc.com wrote:
Le vendredi 20 mai 2011 à 09:18 -0400, Jesse Noller a écrit : > Please make sure he sends in a contributor agreement I am in contact with Charles-François. I asked me to sign the contributor agreement. I told him that it is possible to scan it and send the image to the PSF, but he answered that it's not written in the contributor agreement or in the dev guide. So I don't know if he will scan it and/or send the papier version. Victor_____________________________________________ python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
On Fri, May 20, 2011 at 9:42 AM, Victor Stinner victor.stinner@haypocalc.com wrote:
Le vendredi 20 mai 2011 à 09:18 -0400, Jesse Noller a écrit :
Please make sure he sends in a contributor agreement
I am in contact with Charles-François. I asked me to sign the contributor agreement. I told him that it is possible to scan it and send the image to the PSF, but he answered that it's not written in the contributor agreement or in the dev guide. So I don't know if he will scan it and/or send the papier version.
Victor
He can scan it, or take a photo and send it to us. Tell him to contact me if he has issues.
On Sat, May 21, 2011 at 12:07 AM, Jesse Noller jnoller@gmail.com wrote:
He can scan it, or take a photo and send it to us. Tell him to contact me if he has issues.
This comes up every time, so if we can't get the main pydotorg page fixed, we *really* should mention these two alternatives in the devguide.
Cheers, Nick.
On 20/05/2011 16:47, Nick Coghlan wrote:
On Sat, May 21, 2011 at 12:07 AM, Jesse Nollerjnoller@gmail.com wrote:
He can scan it, or take a photo and send it to us. Tell him to contact me if he has issues.
This comes up every time, so if we can't get the main pydotorg page fixed, we *really* should mention these two alternatives in the devguide.
If you want a page on pydotorg fixed you can either get checkin rights for the website and "just do it", or email the pydotorg-www mailing list with the page you want changed and the amendment you want.
http://mail.python.org/mailman/listinfo/pydotorg-www
All the best,
Michael Foord
Cheers, Nick.
In article 4DD693B0.4070704@python.org, Michael Foord mfoord@python.org wrote:
On 20/05/2011 16:47, Nick Coghlan wrote:
On Sat, May 21, 2011 at 12:07 AM, Jesse Nollerjnoller@gmail.com wrote:
He can scan it, or take a photo and send it to us. Tell him to contact me if he has issues.
This comes up every time, so if we can't get the main pydotorg page fixed, we *really* should mention these two alternatives in the devguide.
If you want a page on pydotorg fixed you can either get checkin rights for the website and "just do it" [...]
Done. Let me know if the wording should be changed.
http://www.python.org/psf/contrib/
--- data/psf/contrib/content.ht (revision 13781) +++ data/psf/contrib/content.ht (working copy) @@ -47,9 +47,9 @@ PSF Licensing FAQ</a>.
<h2>Submission instructions</h2> -We currently accept contributor forms either through postal mail, -or through fax. Please print a copy of the form, fill out your -name, address, and initial license, sign it, and send postal +We currently accept contributor forms through postal mail, fax, +or by email. Please print a copy of the form, fill out your +name, address, and initial license, sign it, and either send via postal mail to
<blockquote>Python Software Foundation<br> @@ -61,6 +61,9 @@
or send it by fax to +1 858 712 8966
+<p>or scan or take a photo of the signed form and email it to +<a href="mailto:psf@python.org">psf@python.org</a>.
<p>As the form is designed for future contributions, we ask past contributors to state that their past contributions are also covered under the form; we have one such form for past
On Sat, May 21, 2011 at 10:41 AM, Ned Deily nad@acm.org wrote:
In article 4DD693B0.4070704@python.org, Michael Foord mfoord@python.org wrote:
On 20/05/2011 16:47, Nick Coghlan wrote:
On Sat, May 21, 2011 at 12:07 AM, Jesse Nollerjnoller@gmail.com wrote:
He can scan it, or take a photo and send it to us. Tell him to contact me if he has issues.
This comes up every time, so if we can't get the main pydotorg page fixed, we *really* should mention these two alternatives in the devguide.
If you want a page on pydotorg fixed you can either get checkin rights for the website and "just do it" [...]
Done. Let me know if the wording should be changed.
Looks good to me - thanks!
It was one of those things where "must ask pydotorg to fix that" somehow never translated into actually *asking* pydotorg to fix it :)
Cheers, Nick.
participants (9)
-
Antoine Pitrou -
Brian Curtin -
Eric Smith -
Gregory P. Smith -
Jesse Noller -
Michael Foord -
Ned Deily -
Nick Coghlan -
Victor Stinner