GitHub: remove the "needs backport to 3.5" label?
Hi,
Python 3.5 entered security fix only mode. Should we now remove the "needs backport to 3.5" label? Other security only branches don't have this label neither (3.3 and 3.4).
Victor
On Wed, 9 Aug 2017 at 01:55 Victor Stinner victor.stinner@gmail.com wrote:
Hi,
Python 3.5 entered security fix only mode. Should we now remove the "needs backport to 3.5" label? Other security only branches don't have this label neither (3.3 and 3.4).
Seems reasonable to me since you will need to get Larry's attention and approval anyway for 3.5 changes now so the label isn't that useful. If there isn't a consensus to not do this I will remove the label probably Friday.
No one has said anything, so I will delete the label sometime today.
On Wed, 9 Aug 2017 at 12:20 Brett Cannon brett@python.org wrote:
On Wed, 9 Aug 2017 at 01:55 Victor Stinner victor.stinner@gmail.com wrote:
Hi,
Python 3.5 entered security fix only mode. Should we now remove the "needs backport to 3.5" label? Other security only branches don't have this label neither (3.3 and 3.4).
Seems reasonable to me since you will need to get Larry's attention and approval anyway for 3.5 changes now so the label isn't that useful. If there isn't a consensus to not do this I will remove the label probably Friday.
Just catching up with emails. +1 to removing the label.
On Aug 11, 2017 12:04 PM, "Brett Cannon" brett@python.org wrote:
No one has said anything, so I will delete the label sometime today.
On Wed, 9 Aug 2017 at 12:20 Brett Cannon brett@python.org wrote:
On Wed, 9 Aug 2017 at 01:55 Victor Stinner victor.stinner@gmail.com wrote:
Hi,
Python 3.5 entered security fix only mode. Should we now remove the "needs backport to 3.5" label? Other security only branches don't have this label neither (3.3 and 3.4).
Seems reasonable to me since you will need to get Larry's attention and approval anyway for 3.5 changes now so the label isn't that useful. If there isn't a consensus to not do this I will remove the label probably Friday.
python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
I just deleted the "backport to 3.5" label. I checked that no PRs only had that label before doing so (they all at least had a "backport to 3.6" label).
On Fri, 11 Aug 2017 at 14:05 Mariatta Wijaya mariatta.wijaya@gmail.com wrote:
Just catching up with emails. +1 to removing the label.
On Aug 11, 2017 12:04 PM, "Brett Cannon" brett@python.org wrote:
No one has said anything, so I will delete the label sometime today.
On Wed, 9 Aug 2017 at 12:20 Brett Cannon brett@python.org wrote:
On Wed, 9 Aug 2017 at 01:55 Victor Stinner victor.stinner@gmail.com wrote:
Hi,
Python 3.5 entered security fix only mode. Should we now remove the "needs backport to 3.5" label? Other security only branches don't have this label neither (3.3 and 3.4).
Seems reasonable to me since you will need to get Larry's attention and approval anyway for 3.5 changes now so the label isn't that useful. If there isn't a consensus to not do this I will remove the label probably Friday.
python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Thank you ;-) Welcome to a new world where only 2 backports are needed for bug fixes ;-)
Victor
Le 11 août 2017 23:49, "Brett Cannon" brett@python.org a écrit :
I just deleted the "backport to 3.5" label. I checked that no PRs only had that label before doing so (they all at least had a "backport to 3.6" label).
On Fri, 11 Aug 2017 at 14:05 Mariatta Wijaya mariatta.wijaya@gmail.com wrote:
Just catching up with emails. +1 to removing the label.
On Aug 11, 2017 12:04 PM, "Brett Cannon" brett@python.org wrote:
No one has said anything, so I will delete the label sometime today.
On Wed, 9 Aug 2017 at 12:20 Brett Cannon brett@python.org wrote:
On Wed, 9 Aug 2017 at 01:55 Victor Stinner victor.stinner@gmail.com wrote:
Hi,
Python 3.5 entered security fix only mode. Should we now remove the "needs backport to 3.5" label? Other security only branches don't have this label neither (3.3 and 3.4).
Seems reasonable to me since you will need to get Larry's attention and approval anyway for 3.5 changes now so the label isn't that useful. If there isn't a consensus to not do this I will remove the label probably Friday.
python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Sorry for posting on this very old thread, but it looks like we are using "Backport to X.Y" labels to also backport PRs and is needed as a trigger for the automation (miss-islington) to work.
I am not sure if this automation existed when this label was retired, but it looks useful to me now.
Yes, there are a very few PRs with security fixes that come up and can be manually backported, but I wonder if it hurts having the label around?
thanks, Abhilash
Hi,
To create a 3.5 backport, I use the following commands (something like this, adapt names ;-):
cd ~/python/3.5 git checkout -b fix_something35 git cherry-pick -x commit_sha1 # maybe fix conflicts or make further changes make ./python -m test -v test_modified_test # or better: ./python -m test -j0 -rW gh_pr.sh # my script to open a PR
I consider that it's easy enough to not have a "backport to 3.5" label.
I asked to remove this label since it was misused by contributors who are not aware that 3.5 not longer accept bug fixes.
Tell me if you need help to do the backport.
Note: there are many tools to open a pull requests on GitHub, but my script is working well for my workload so I never tried any other script ;-)
Victor
Night gathers, and now my watch begins. It shall not end until my death.
Hi,
On August 19, 2019 9:35:02 AM UTC, Victor Stinner vstinner@redhat.com wrote:
Hi,
To create a 3.5 backport, I use the following commands (something like this, adapt names ;-):
cd ~/python/3.5 git checkout -b fix_something35 git cherry-pick -x commit_sha1 # maybe fix conflicts or make further changes make ./python -m test -v test_modified_test # or better: ./python -m test -j0 -rW gh_pr.sh # my script to open a PR
I consider that it's easy enough to not have a "backport to 3.5" label.
Well, it is easier to use cherry_picker to do this:
$ cherry_picker <sha1> 3.5
That's all. It doesn't run tests but CI will do that so I guess they are similar :)
I asked to remove this label since it was misused by contributors who are not aware that 3.5 not longer accept bug fixes.
Ah okay, I was just looking for this. I guess it makes sense, but I always thought non core devs can't add labels.
Tell me if you need help to do the backport.
Note: there are many tools to open a pull requests on GitHub, but my script is working well for my workload so I never tried any other script ;-)
Victor
Abhilash
Abhilash Raj (maxking) wrote:
Hi, On August 19, 2019 9:35:02 AM UTC, Victor Stinner vstinner@redhat.com wrote:
Hi, To create a 3.5 backport, I use the following commands (something like this, adapt names ;-): cd ~/python/3.5 git checkout -b fix_something35 git cherry-pick -x commit_sha1 # maybe fix conflicts or make further changes make ./python -m test -v test_modified_test # or better: ./python -m test -j0 -rW gh_pr.sh # my script to open a PR I consider that it's easy enough to not have a "backport to 3.5" label. Well, it is easier to use cherry_picker to do this:
$ cherry_picker <sha1> 3.5 That's all. It doesn't run tests but CI will do that so I guess they are similar :)
I asked to remove this label since it was misused by contributors who are not aware that 3.5 not longer accept bug fixes. Ah okay, I was just looking for this. I guess it makes sense, but I always
thought non core devs can't add labels.
Correct. Victor means core devs in this case. Basically people would find e.g. a spelling mistake and then just instinctively add all the backport labels without thinking about whether it should go into the security-only branches.
Tell me if you need help to do the backport. Note: there are many tools to open a pull requests on GitHub, but my script is working well for my workload so I never tried any other script ;-) Victor Abhilash
On Mon, Aug 19, 2019, at 1:19 PM, Brett Cannon wrote:
Abhilash Raj (maxking) wrote:
Hi, On August 19, 2019 9:35:02 AM UTC, Victor Stinner vstinner@redhat.com wrote:
Hi, To create a 3.5 backport, I use the following commands (something like this, adapt names ;-): cd ~/python/3.5 git checkout -b fix_something35 git cherry-pick -x commit_sha1 # maybe fix conflicts or make further changes make ./python -m test -v test_modified_test # or better: ./python -m test -j0 -rW gh_pr.sh # my script to open a PR I consider that it's easy enough to not have a "backport to 3.5" label. Well, it is easier to use cherry_picker to do this:
$ cherry_picker <sha1> 3.5 That's all. It doesn't run tests but CI will do that so I guess they are similar :)
I asked to remove this label since it was misused by contributors who are not aware that 3.5 not longer accept bug fixes. Ah okay, I was just looking for this. I guess it makes sense, but I always
thought non core devs can't add labels.
Correct. Victor means core devs in this case. Basically people would find e.g. a spelling mistake and then just instinctively add all the backport labels without thinking about whether it should go into the security-only branches.
Thanks for clarifying Brett!
Tell me if you need help to do the backport. Note: there are many tools to open a pull requests on GitHub, but my script is working well for my workload so I never tried any other script ;-) Victor Abhilash
python-committers mailing list -- python-committers@python.org To unsubscribe send an email to python-committers-leave@python.org https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/F... Code of Conduct: https://www.python.org/psf/codeofconduct/
Le 19/08/2019 à 17:51, Abhilash Raj (maxking) a écrit :
I asked to remove this label since it was misused by contributors who are not aware that 3.5 not longer accept bug fixes.
Ah okay, I was just looking for this. I guess it makes sense, but I always thought non core devs can't add labels.
Well, even core devs make mistakes. I'm checking the following table multiple times per month to remind which branches accept security fixes:
https://devguide.python.org/#status-of-python-branches
It takes me time to change my habits when a branch moves to security-fixes only, like Python 3.6. I just discussed backporting a *bugfix* to 3.6 yesterday ;-)
Victor
Night gathers, and now my watch begins. It shall not end until my death.
participants (6)
-
Abhilash Raj -
Abhilash Raj (maxking)
-
Brett Cannon -
Mariatta Wijaya -
Victor Stinner -
Victor Stinner