Barry Warsaw wrote:

On Sep 19, 2008, at 8:06 AM, Hirokazu Yamamoto wrote:

...

Hello. Can I commit VC6 related patch without review? I want to bump up external library versions (bsddb, sqlite3 etc) to follow PCBuild.

Since we're in release candidate, please have one of the Windows experts review your changes. If this is a blocker issue for the final release, open a bug and set the priority to 'release blocker' and attach your diff to the issue.

Barry,

sorry if you were aware of that already, but VC6 isn't the compiler for the official builds. The VC6 files are "only" alternative "Makefiles".

-- Gerhard

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

On Sep 22, 2008, at 4:02 AM, Mark Hammond wrote:

...

sorry if you were aware of that already, but VC6 isn't the compiler
for the official builds. The VC6 files are "only" alternative
"Makefiles".

As far as I'm concerned, +1 for Gerhard being able to checkin vc6
related makefiles to the trunk without review (notwithstanding any other restrictions imposed by the release manager, etc.)

I wasn't aware, thanks for the clarification. If it's not in the
critical path for building our Windows binaries, and Mark is rubber- stamping your changes <wink>, and Martin is okay with it, then as long
as the tree is open I'm okay with it. If it's not something we test,
and we break it, then we'll just have to fix it in a point release.

• -Barry

-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin)

iQCVAwUBSNePzHEjvBPtnXfVAQKbnQQAgDivYpJ9tXFXJY6vrgl3PyMbrfADEKnM HotR4JeI6wbM0Z5Uj5k+3MvGhCcphozd3FFr4Ig3VDFDWSesY2FR7LjHx7WnljmO gC2FEBhDgKPx/A0HpP6SqSbH7znHHZZ0FDYUZsWByDh3Y4rkR4bDhAOh9SDklz5z oUA+eVSagr4= =D0z4 -----END PGP SIGNATURE-----