Re: [Python-checkins] remove a strange non-ASCII character in _iomodule.c (GH-17239)
Replying to python-committers for visibility, although maybe python-dev would be better. That's not a "strange non-ASCII character"! That's a form feed (control-L), definitely defined by ASCII. There are plenty of these in the code. Some people (who won't be named, but match the regex "Barry") like them. I don't think we should start removing them. Eric On 11/18/2019 1:40 PM, Tal Einat wrote:
https://github.com/python/cpython/commit/bcc1cc5cc38b57ac55cbe710849374258d6... commit: bcc1cc5cc38b57ac55cbe710849374258d610a08 branch: master author: Tal Einat <taleinat+github@gmail.com> committer: GitHub <noreply@github.com> date: 2019-11-18T20:39:47+02:00 summary:
remove a strange non-ASCII character in _iomodule.c (GH-17239)
files: M Modules/_io/_iomodule.c
diff --git a/Modules/_io/_iomodule.c b/Modules/_io/_iomodule.c index 5932363f3af35..778b56d475ee5 100644 --- a/Modules/_io/_iomodule.c +++ b/Modules/_io/_iomodule.c @@ -503,7 +503,7 @@ _io_open_code_impl(PyObject *module, PyObject *path) { return PyFile_OpenCodeObject(path); } - + /* * Private helpers for the io module. */
_______________________________________________ Python-checkins mailing list Python-checkins@python.org https://mail.python.org/mailman/listinfo/python-checkins
On Mon, Nov 18, 2019 at 8:50 PM Eric V. Smith <eric@trueblade.com> wrote:
Replying to python-committers for visibility, although maybe python-dev would be better.
That's not a "strange non-ASCII character"! That's a form feed (control-L), definitely defined by ASCII.
There are plenty of these in the code. Some people (who won't be named, but match the regex "Barry") like them. I don't think we should start removing them.
Oh wow, I completely missed that! :blush:
Terribly sorry, I'll revert the change.
- Tal Einat
I don't think we need to revive ^L once it is removed.
The steering council decided there is no real "code owner". Codes are owned by everyone.
On the other hand, ^L is very minor control character nowadays. Many new people use many new editors. I don't believe every common editors support ^L well. And even though editor supports it, people may be confused by it.
If only few core developer likes ^L, why we need to add it even though it is removed by accident? What makes ^L more important than TAB?
Regards,
On Tue, Nov 19, 2019 at 3:52 AM Tal Einat <taleinat@gmail.com> wrote:
On Mon, Nov 18, 2019 at 8:50 PM Eric V. Smith <eric@trueblade.com> wrote:
Replying to python-committers for visibility, although maybe python-dev would be better.
That's not a "strange non-ASCII character"! That's a form feed (control-L), definitely defined by ASCII.
There are plenty of these in the code. Some people (who won't be named, but match the regex "Barry") like them. I don't think we should start removing them.
Oh wow, I completely missed that! :blush:
Terribly sorry, I'll revert the change.
- Tal Einat
python-committers mailing list -- python-committers@python.org To unsubscribe send an email to python-committers-leave@python.org https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/M... Code of Conduct: https://www.python.org/psf/codeofconduct/
-- Inada Naoki <songofacandy@gmail.com>
I removed it by mistake due to lack of knowledge, so I undid that mistake.
The status-quo appears to be that these are left in place. I've been told that there was previous discussion on this topic already and the status-quo was not broken. Personally I don't mind.
On Tue, Nov 19, 2019 at 6:19 AM Inada Naoki <songofacandy@gmail.com> wrote:
I don't think we need to revive ^L once it is removed.
The steering council decided there is no real "code owner". Codes are owned by everyone.
On the other hand, ^L is very minor control character nowadays. Many new people use many new editors. I don't believe every common editors support ^L well. And even though editor supports it, people may be confused by it.
If only few core developer likes ^L, why we need to add it even though it is removed by accident? What makes ^L more important than TAB?
Regards,
On Tue, Nov 19, 2019 at 3:52 AM Tal Einat <taleinat@gmail.com> wrote:
On Mon, Nov 18, 2019 at 8:50 PM Eric V. Smith <eric@trueblade.com>
wrote:
Replying to python-committers for visibility, although maybe python-dev would be better.
That's not a "strange non-ASCII character"! That's a form feed (control-L), definitely defined by ASCII.
There are plenty of these in the code. Some people (who won't be named, but match the regex "Barry") like them. I don't think we should start removing them.
Oh wow, I completely missed that! :blush:
Terribly sorry, I'll revert the change.
- Tal Einat
python-committers mailing list -- python-committers@python.org To unsubscribe send an email to python-committers-leave@python.org https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/M... Code of Conduct: https://www.python.org/psf/codeofconduct/
-- Inada Naoki <songofacandy@gmail.com>
There's probably an argument for being consistent, though. If there's only a single one of them in a given file, it may mean it's an accident. The best thing may be to "git annotate" who added it and ask them. I don't remember the _io module having form feed characters in its source code. But I haven't worked on it in a long time... cheers Antoine. Le 18/11/2019 à 19:47, Eric V. Smith a écrit :
Replying to python-committers for visibility, although maybe python-dev would be better.
That's not a "strange non-ASCII character"! That's a form feed (control-L), definitely defined by ASCII.
There are plenty of these in the code. Some people (who won't be named, but match the regex "Barry") like them. I don't think we should start removing them.
Eric
On 11/18/2019 1:40 PM, Tal Einat wrote:
https://github.com/python/cpython/commit/bcc1cc5cc38b57ac55cbe710849374258d6... commit: bcc1cc5cc38b57ac55cbe710849374258d610a08 branch: master author: Tal Einat <taleinat+github@gmail.com> committer: GitHub <noreply@github.com> date: 2019-11-18T20:39:47+02:00 summary:
remove a strange non-ASCII character in _iomodule.c (GH-17239)
files: M Modules/_io/_iomodule.c
diff --git a/Modules/_io/_iomodule.c b/Modules/_io/_iomodule.c index 5932363f3af35..778b56d475ee5 100644 --- a/Modules/_io/_iomodule.c +++ b/Modules/_io/_iomodule.c @@ -503,7 +503,7 @@ _io_open_code_impl(PyObject *module, PyObject *path) { return PyFile_OpenCodeObject(path); } - + /* * Private helpers for the io module. */
_______________________________________________ Python-checkins mailing list Python-checkins@python.org https://mail.python.org/mailman/listinfo/python-checkins
python-committers mailing list -- python-committers@python.org To unsubscribe send an email to python-committers-leave@python.org https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/G... Code of Conduct: https://www.python.org/psf/codeofconduct/
On Mon, Nov 18, 2019 at 8:53 PM Antoine Pitrou <antoine@python.org> wrote:
There's probably an argument for being consistent, though. If there's only a single one of them in a given file, it may mean it's an accident. The best thing may be to "git annotate" who added it and ask them.
I don't remember the _io module having form feed characters in its source code. But I haven't worked on it in a long time...
There are actually two of them in _iomodule.c. All the rest in the repository are in .py files.
(I did try to search for this char before making that change, but apparently my editor mishandled that search spectacularly.)
- Tal Einat
participants (4)
-
Antoine Pitrou -
Eric V. Smith -
Inada Naoki -
Tal Einat