Issues with hundreds of commits being opened and closed -- what's going on?
Occasionally I receive a sequence of emails from GitHub where a PR is requesting my review by some user, the-knights-who-say-ni responds with a CLA request, and then Bedevere closes it, without comment. Latest example: https://github.com/python/cpython/pull/5693
This seems to be some kind of user error -- the GitHub description is typically something like "<user> wants to merge 398 commits into master from 3.5". But this happens so frequently I would like to prevent this user error from happening in the first place.
Does anyone understand what these users are doing that causes such PRs to be created?
-- --Guido van Rossum (python.org/~guido)
On Thu, Feb 15, 2018 at 6:21 PM, Guido van Rossum guido@python.org wrote:
Occasionally I receive a sequence of emails from GitHub where a PR is requesting my review by some user, the-knights-who-say-ni responds with a CLA request, and then Bedevere closes it, without comment. Latest example: https://github.com/python/cpython/pull/5693
This seems to be some kind of user error -- the GitHub description is typically something like "<user> wants to merge 398 commits into master from 3.5". But this happens so frequently I would like to prevent this user error from happening in the first place.
Does anyone understand what these users are doing that causes such PRs to be created?
This is because GitHub allows anyone logged into the site to click the "New pull request" button on the branches page (https://github.com/python/cpython/branches). I reported this to GitHub several months ago and the last word was that they were "discussing it internally"; I'll bug them about it again.
-- Zach
I've also created https://github.com/python/bedevere/issues/69 so that the review requests from such PRs can be dismissed automatically.
Not sure if there's anything else we can do.
Will it help when bedevere close the PR, it can leave a comment say that "This PR is invalid. Ignore it" ?
Mariatta Wijaya
ᐧ
Ah. Makes sense. UI design is hard... Thanks!
On Thu, Feb 15, 2018 at 4:35 PM, Zachary Ware zachary.ware+pydev@gmail.com wrote:
On Thu, Feb 15, 2018 at 6:21 PM, Guido van Rossum guido@python.org wrote:
Occasionally I receive a sequence of emails from GitHub where a PR is requesting my review by some user, the-knights-who-say-ni responds with a CLA request, and then Bedevere closes it, without comment. Latest example: https://github.com/python/cpython/pull/5693
This seems to be some kind of user error -- the GitHub description is typically something like "<user> wants to merge 398 commits into master from 3.5". But this happens so frequently I would like to prevent this user error from happening in the first place.
Does anyone understand what these users are doing that causes such PRs to be created?
This is because GitHub allows anyone logged into the site to click the "New pull request" button on the branches page (https://github.com/python/cpython/branches). I reported this to GitHub several months ago and the last word was that they were "discussing it internally"; I'll bug them about it again.
-- Zach
python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
-- --Guido van Rossum (python.org/~guido)
On 2/15/2018 7:42 PM, Mariatta Wijaya wrote:
I've also created https://github.com/python/bedevere/issues/69 so that the review requests from such PRs can be dismissed automatically.
This is a great improvement over the PR being left open until someone manually closes it.
Not sure if there's anything else we can do.
We need GH to provide a hook so that our bot could vet a proposed PR *before* it is created and the review notices sent out (by GH).
Will it help when bedevere close the PR, it can leave a comment say that "This PR is invalid. Ignore it" ?
If that could be added to the same email, instead of sending yet another one, yes.
Would it be possible for Bedevere to run and possibly close *before* the Knight runs, so we get one less email?
Terry
participants (4)
-
Guido van Rossum -
Mariatta Wijaya -
Terry Reedy -
Zachary Ware