Hi,
I merged my pull request: https://github.com/python/cpython/pull/12
which has a commit message starting with "bpo-29524: ", but the issue wasn't updated (no new comment to mention the comit): http://bugs.python.org/issue29524
The final commit is: https://github.com/python/cpython/commit/c22bfaae83ab5436d008ac0d13e7b47cbe7...
Is it a known issue? Should I mention the issue number differently?
Victor
There was an issue up until sometime on Sunday where the SSL cert for bugs.python.org was being rejected (it was issued by StartCom who is being distrusted). The cert got replaced but if the webhook event for your merge got rejected due to the bad cert then it would have been dropped.
So if should be working, but you may have been caught in the SSL problem. If it persists then there's a problem in the hook-side of bugs.python.org that will need fixing.
On Sun, 12 Feb 2017 at 13:59 Victor Stinner victor.stinner@gmail.com wrote:
Hi,
I merged my pull request: https://github.com/python/cpython/pull/12
which has a commit message starting with "bpo-29524: ", but the issue wasn't updated (no new comment to mention the comit): http://bugs.python.org/issue29524
The final commit is:
https://github.com/python/cpython/commit/c22bfaae83ab5436d008ac0d13e7b47cbe7...
Is it a known issue? Should I mention the issue number differently?
Victor _______________________________________________ python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
I've been keeping an eye on the tracker logs and saw no errors. If you are still having problems after the SSL fix let me know.
On Mon, Feb 13, 2017 at 8:16 PM, Brett Cannon brett@python.org wrote:
There was an issue up until sometime on Sunday where the SSL cert for bugs.python.org was being rejected (it was issued by StartCom who is being distrusted). The cert got replaced but if the webhook event for your merge got rejected due to the bad cert then it would have been dropped.
So if should be working, but you may have been caught in the SSL problem. If it persists then there's a problem in the hook-side of bugs.python.org that will need fixing.
On Sun, 12 Feb 2017 at 13:59 Victor Stinner victor.stinner@gmail.com wrote:
Hi,
I merged my pull request: https://github.com/python/cpython/pull/12
which has a commit message starting with "bpo-29524: ", but the issue wasn't updated (no new comment to mention the comit): http://bugs.python.org/issue29524
The final commit is:
https://github.com/python/cpython/commit/c22bfaae83ab5436d008ac0d13e7b47cbe7...
Is it a known issue? Should I mention the issue number differently?
Victor _______________________________________________ python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
On Mon, Feb 13, 2017 at 11:16 AM, Brett Cannon brett@python.org wrote:
if the webhook event for your merge got rejected due to the bad cert then it would have been dropped.
A repo admin should be able to manually request that a failed webhook be retried. The webhook's page on GH has a list of all associated events, including failed attempts.
-eric
On Mon, 13 Feb 2017 at 16:19 Eric Snow ericsnowcurrently@gmail.com wrote:
On Mon, Feb 13, 2017 at 11:16 AM, Brett Cannon brett@python.org wrote:
if the webhook event for your merge got rejected due to the bad cert then it would have been dropped.
A repo admin should be able to manually request that a failed webhook be retried. The webhook's page on GH has a list of all associated events, including failed attempts.
Yes, but the sheer volume of events makes doing that extremely tedious.
On Mon, Feb 13, 2017 at 8:16 PM, Brett Cannon brett@python.org wrote:
There was an issue up until sometime on Sunday where the SSL cert for bugs.python.org was being rejected (it was issued by StartCom who is being distrusted). The cert got replaced but if the webhook event for your merge got rejected due to the bad cert then it would have been dropped.
Today I also spotted and fixed another issue, and verified that now the messages are showing up on bpo (see e.g. http://bugs.python.org/issue29557#msg287801). Let me know if there are other issues.
Best Regards, Ezio Melotti
So if should be working, but you may have been caught in the SSL problem. If it persists then there's a problem in the hook-side of bugs.python.org that will need fixing.
New changeset 72e81d00eee685cfe33aaddf2aa9feef2d07591f by Victor Stinner in branch 'master':
Ok, I confirm that I now get notifications. Cool :-)
New request (!): would it be possible to mention the author instead of the commiter? Or maybe mention both?
Thanks, Victor
On Thu, Feb 16, 2017 at 2:10 AM, Victor Stinner victor.stinner@gmail.com wrote:
New changeset 72e81d00eee685cfe33aaddf2aa9feef2d07591f by Victor Stinner in branch 'master':
Ok, I confirm that I now get notifications. Cool :-)
New request (!): would it be possible to mention the author instead of the commiter? Or maybe mention both?
If GitHub passes the information along (and it probably does), then it should be possible to have both. Please create an issue on the meta-tracker to keep track of this.
Best Regards, Ezio Melotti
Thanks, Victor
What and where is the meta-tracker? Is it http://github.com/python/core-workflow/?
Victor
2017-02-16 6:33 GMT+01:00 Ezio Melotti ezio.melotti@gmail.com:
On Thu, Feb 16, 2017 at 2:10 AM, Victor Stinner victor.stinner@gmail.com wrote:
New changeset 72e81d00eee685cfe33aaddf2aa9feef2d07591f by Victor Stinner in branch 'master':
Ok, I confirm that I now get notifications. Cool :-)
New request (!): would it be possible to mention the author instead of the commiter? Or maybe mention both?
If GitHub passes the information along (and it probably does), then it should be possible to have both. Please create an issue on the meta-tracker to keep track of this.
Best Regards, Ezio Melotti
Thanks, Victor
2017-02-16 11:42 GMT+02:00 Victor Stinner victor.stinner@gmail.com:
What and where is the meta-tracker? Is it http://github.com/python/core-workflow/?
On Thu, Feb 16, 2017, 02:25 Serhiy Storchaka, storchaka@gmail.com wrote:
2017-02-16 11:42 GMT+02:00 Victor Stinner victor.stinner@gmail.com:
What and where is the meta-tracker? Is it http://github.com/python/core-workflow/?
Serhiy's link is correct.
-Brett
python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
-
Brett Cannon -
Eric Snow -
Ezio Melotti -
Serhiy Storchaka -
Victor Stinner