Results of Pablo's promotion votes: Pablo is promoted as a core dev!
Hi,
The result of the vote to to promote Pablo Salingo Salgado as core developer after one week is positive: I declare that Pablo is now a core developer, congrats! I will follow the usual process to actually make him a core dev, and ask him to write a short introduction email to this list.
But I also noted that Pablo lacks experience to be fully autonomous on merging pull requests, so I also requires that Pablo will have to be strictly mentored by me for 3 months. By strict, I mean that Pablo will have to ask me to merge any pull request. This strict mentoring may be extended depending on Pablo's progress. As Eric Snow wrote, I vouch for Pablo: don't hesitate to blame me directly if anything goes wrong :-)
Giving more responsibilities to Pablo is part of the learning process. Reviewing as a core developer is different than a review as a contributor: core developers are expected to actually merge a pull request once they approve the change. Merging a pull request is a big responsibility and an investment in the long-term, because the committer is expected to fix regressions and issues related to this change for next months, if not next years.
Note: Cheryl Sabella has also been identified as an active contributor who may be promoted as well. I am already discussing with her about that for 1 month, but last month, Cheryl chose to wait. I will keep you in touch ;-)
Vote results.
Promote (+1): 8 votes
- Victor Stinner
- Terry Reedy
- Carol Willing
- Gregory P. Smith ("+0.5")
- Eric Snow
- Brett Cannon
- Nathaniel Smith
- Antoine Pitrou ("+0.5")
Wait (-1): 1 vote
- Berker Peksağ
Neutral (0): 1 vote
- Serhiy Storchaka ("-0")
Victor
Not trying to dispute the result (I’d have posted earlier if I was really concerned), but it sounds like you’ve signed up to mentor someone for three months. Under normal circumstances, the commit bit comes at the end of mentorship, not at the start.
Should we promote other mentees as well? I know there are a few who have been deliberately pursuing this recognition (as they attended the language summit and/or were specifically requested to attend the core sprint by their mentors).
Top-posted from my Windows 10 phone
From: Victor Stinner Sent: Tuesday, June 19, 2018 10:44 To: python-committers Subject: [python-committers] Results of Pablo's promotion votes: Pablo ispromoted as a core dev!
Hi,
The result of the vote to to promote Pablo Salingo Salgado as core developer after one week is positive: I declare that Pablo is now a core developer, congrats! I will follow the usual process to actually make him a core dev, and ask him to write a short introduction email to this list.
But I also noted that Pablo lacks experience to be fully autonomous on merging pull requests, so I also requires that Pablo will have to be strictly mentored by me for 3 months. By strict, I mean that Pablo will have to ask me to merge any pull request. This strict mentoring may be extended depending on Pablo's progress. As Eric Snow wrote, I vouch for Pablo: don't hesitate to blame me directly if anything goes wrong :-)
Giving more responsibilities to Pablo is part of the learning process. Reviewing as a core developer is different than a review as a contributor: core developers are expected to actually merge a pull request once they approve the change. Merging a pull request is a big responsibility and an investment in the long-term, because the committer is expected to fix regressions and issues related to this change for next months, if not next years.
Note: Cheryl Sabella has also been identified as an active contributor who may be promoted as well. I am already discussing with her about that for 1 month, but last month, Cheryl chose to wait. I will keep you in touch ;-)
Vote results.
Promote (+1): 8 votes
- Victor Stinner
- Terry Reedy
- Carol Willing
- Gregory P. Smith ("+0.5")
- Eric Snow
- Brett Cannon
- Nathaniel Smith
- Antoine Pitrou ("+0.5")
Wait (-1): 1 vote
- Berker Peksağ
Neutral (0): 1 vote
- Serhiy Storchaka ("-0")
Victor
python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
2018-06-19 19:43 GMT+02:00 Victor Stinner <vstinner@redhat.com>:
The result of the vote to to promote Pablo Salingo Salgado as core developer after one week is positive: I declare that Pablo is now a core developer, congrats! I will follow the usual process to actually make him a core dev, and ask him to write a short introduction email to this list.
Oh, I'm sorry, I made two typos in Pablo's full name :-( His name is: Pablo *Galindo* Salgado.
Victor
On Wed, Jun 20, 2018 at 2:20 AM, Victor Stinner <vstinner@redhat.com> wrote:
The result of the vote to to promote Pablo Salingo Salgado as core developer after one week is positive: I declare that Pablo is now a core developer.
I couldn't participate this in vote. I just want to thank you introducing a new developer.
Thank you, Senthil
Hi,
2018-06-19 19:43 GMT+02:00 Victor Stinner <vstinner@redhat.com>:
The result of the vote to to promote Pablo Salingo Salgado as core developer after one week is positive: I declare that Pablo is now a core developer, congrats! (...)
Giving more responsibilities to Pablo is part of the learning process. Reviewing as a core developer is different than a review as a contributor: core developers are expected to actually merge a pull request once they approve the change. Merging a pull request is a big responsibility and an investment in the long-term, because the committer is expected to fix regressions and issues related to this change for next months, if not next years.
Sadly, I was less available than I expected to review his work, and so I don't feel comfortable yet to stop mentoring.
I asked Pablo and he is fine if I extend the mentoring to the end of September. I expect that one extra month should be enough, but I will be in holiday most of August ;-)
Victor
On Tue, 31 Jul 2018 at 03:27 Victor Stinner <vstinner@redhat.com> wrote:
Hi,
2018-06-19 19:43 GMT+02:00 Victor Stinner <vstinner@redhat.com>:
The result of the vote to to promote Pablo Salingo Salgado as core developer after one week is positive: I declare that Pablo is now a core developer, congrats! (...)
Giving more responsibilities to Pablo is part of the learning process. Reviewing as a core developer is different than a review as a contributor: core developers are expected to actually merge a pull request once they approve the change. Merging a pull request is a big responsibility and an investment in the long-term, because the committer is expected to fix regressions and issues related to this change for next months, if not next years.
Sadly, I was less available than I expected to review his work, and so I don't feel comfortable yet to stop mentoring.
I asked Pablo and he is fine if I extend the mentoring to the end of September. I expect that one extra month should be enough, but I will be in holiday most of August ;-)
I just wanted to say thanks for thinking about this to begin with. It's very easy to set a new core dev loose and forget what it takes to get up and running.
2018-07-31 18:47 GMT+02:00 Brett Cannon <brett@python.org>:
I just wanted to say thanks for thinking about this to begin with. It's very easy to set a new core dev loose and forget what it takes to get up and running.
I like the idea of putting one mentor per newly promoted core developer. IMHO it reduces the pressure to promote a contributor.
Victor
On Tue, Jul 31, 2018 at 1:27 PM, Victor Stinner <vstinner@redhat.com> wrote:
Sadly, I was less available than I expected to review his work, and so I don't feel comfortable yet to stop mentoring.
I asked Pablo and he is fine if I extend the mentoring to the end of September. I expect that one extra month should be enough, but I will be in holiday most of August ;-)
+1
I've been reviewing some of Pablo's PRs in the past few weeks. What I've seen is a lot of great work and quick and positive reaction to reviews and feedback. I'm excited to have him join the core-dev team!
I too think he would benefit from additional mentoring, including specifically reviewing of his PRs. This is since I still often see various small issues in his PRs, usually minor things such as whitespace or out-of-date comments/docs/NEWS. This reminds me of myself in my early days of contributing to Python; KBK had to be patient with me until I learned to review my patches once more before submitting them, and reach a more consistently high quality.
- Tal Einat
participants (5)
-
Brett Cannon -
Senthil Kumaran -
Steve Dower -
Tal Einat -
Victor Stinner