Code review tool (rietveld) bug
Hello,
I'm having difficulty with replying to a message in rietveld.
Here's a screenshot of the exception: http://goo.gl/70iQ5v (AttributeError at /review/20356/publish)
Is this a known issue? Maybe I'm doing something wrong?
Yury
On lun., 2014-01-27 at 14:52 -0500, Yury Selivanov wrote:
Hello,
I'm having difficulty with replying to a message in rietveld.
Here's a screenshot of the exception: http://goo.gl/70iQ5v (AttributeError at /review/20356/publish)
Is this a known issue? Maybe I'm doing something wrong?
Have you tried more than once? I've experienced sporadic errors at times.
Regards
Antoine.
I've tried multiple times, yes.
Yury
On 1/27/2014, 2:56 PM, Antoine Pitrou wrote:
On lun., 2014-01-27 at 14:52 -0500, Yury Selivanov wrote:
Hello,
I'm having difficulty with replying to a message in rietveld.
Here's a screenshot of the exception: http://goo.gl/70iQ5v (AttributeError at /review/20356/publish)
Is this a known issue? Maybe I'm doing something wrong?
Have you tried more than once? I've experienced sporadic errors at times.
Regards
Antoine.
python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers
Perhaps I has something like this earlier. So wait and try again.
On Mon, Jan 27, 2014 at 9:52 PM, Yury Selivanov yselivanov.ml@gmail.com wrote:
Hello,
I'm having difficulty with replying to a message in rietveld.
Here's a screenshot of the exception: http://goo.gl/70iQ5v (AttributeError at /review/20356/publish)
Is this a known issue? Maybe I'm doing something wrong?
Yury _______________________________________________ python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers
On Mon, 27 Jan 2014 14:52:16 -0500, Yury Selivanov yselivanov.ml@gmail.com wrote:
Hello,
I'm having difficulty with replying to a message in rietveld.
Here's a screenshot of the exception: http://goo.gl/70iQ5v (AttributeError at /review/20356/publish)
Is this a known issue? Maybe I'm doing something wrong?
There have been occasional problems with the email interface in our rietveld instance. I'm not sure if your traceback matches the other problems, and I don't remember if those problems were actually solved. If you restart your session (starting from the bug tracker) does the problem reproduce?
--David
OK, I've tried another browser (regularly I use Safari, this time I was trying it with Chrome) -- same thing.
For those who want to try to reproduce it:
- Open http://bugs.python.org/issue20356
- Click 'review' for pos_only_format_02.patch
- Click on message from @larry
- Hit 'reply' link for it
- Erase everything from the text area and type something in
- Submit the form.
Yury
On 1/27/2014, 3:13 PM, R. David Murray wrote:
On Mon, 27 Jan 2014 14:52:16 -0500, Yury Selivanov yselivanov.ml@gmail.com wrote:
Hello,
I'm having difficulty with replying to a message in rietveld.
Here's a screenshot of the exception: http://goo.gl/70iQ5v (AttributeError at /review/20356/publish)
Is this a known issue? Maybe I'm doing something wrong?
There have been occasional problems with the email interface in our rietveld instance. I'm not sure if your traceback matches the other problems, and I don't remember if those problems were actually solved. If you restart your session (starting from the bug tracker) does the problem reproduce?
--David _______________________________________________ python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers
On lun., 2014-01-27 at 15:18 -0500, Yury Selivanov wrote:
OK, I've tried another browser (regularly I use Safari, this time I was trying it with Chrome) -- same thing.
For those who want to try to reproduce it:
- Open http://bugs.python.org/issue20356
- Click 'review' for pos_only_format_02.patch
- Click on message from @larry
- Hit 'reply' link for it
- Erase everything from the text area and type something in
- Submit the form.
Well, it worked here (Firefox). As a sidenote, why is Larry green on this page?
Regards
Antoine.
On more note:
I'm using open-id (google) to sign in on bugs.python.org
Yury
On 1/27/2014, 3:24 PM, Antoine Pitrou wrote:
On lun., 2014-01-27 at 15:18 -0500, Yury Selivanov wrote:
OK, I've tried another browser (regularly I use Safari, this time I was trying it with Chrome) -- same thing.
For those who want to try to reproduce it:
- Open http://bugs.python.org/issue20356
- Click 'review' for pos_only_format_02.patch
- Click on message from @larry
- Hit 'reply' link for it
- Erase everything from the text area and type something in
- Submit the form.
Well, it worked here (Firefox). As a sidenote, why is Larry green on this page?
Regards
Antoine.
python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers
Am 27.01.14 21:18, schrieb Yury Selivanov:
OK, I've tried another browser (regularly I use Safari, this time I was trying it with Chrome) -- same thing.
For those who want to try to reproduce it:
- Open http://bugs.python.org/issue20356
- Click 'review' for pos_only_format_02.patch
- Click on message from @larry
- Hit 'reply' link for it
- Erase everything from the text area and type something in
- Submit the form.
I can add a message just fine, but I think something is broken still.
Can you get your web browser to see the source of the reply form? I get
<form method="POST" action="/review/20356/publish"
id="message-reply-form">
<input type="hidden" name="xsrf_token"
value="7e667aa15c51043fea022aa837edaaa5"> <div></div> <input type="hidden" name="in_reply_to" value="" /> <input type="hidden" name="subject" value="fix formatting of positional-only parameters in inspect.Signature" /> <input type="hidden" name="message_only" value="1" /> <input type="submit" value="Send Message" /> <input type="button" value="Discard" name="discard" /> <input type="checkbox" name="send_mail" value="1" id="message-reply-send-mail" checked="checked" /> <label>Send mail to reviewers</label> </form>
I believe the issue is the hidden in_reply_to field.
a) it shouldn't be an empty string (I think); if it wasn't, Rietveld might actually make insert it in a threaded way. IIUC, js ought to have inserted a value for in_reply_to. b) if it is empty, it apparently crashes for you because it then finds that there is no message with the id "".
Looking a bit further - maybe Safari doesn't tell me the dynamic code. I also see
<a href="javascript:M_replyToMessage('0', '2014/01/25 11:25:44', 'larry', 'Message_2687')" id="message-reply-href-0">Reply</a>
which really ought to fill out the in_reply_to field (with Message_2687)
If anybody wants to investigate: the source of this is at
http://hg.python.org/tracker/rietveld
Regards, Martin
Martin,
On 1/27/2014, 5:01 PM, "Martin v. Löwis" wrote:
Am 27.01.14 21:18, schrieb Yury Selivanov:
OK, I've tried another browser (regularly I use Safari, this time I was trying it with Chrome) -- same thing.
For those who want to try to reproduce it:
- Open http://bugs.python.org/issue20356
- Click 'review' for pos_only_format_02.patch
- Click on message from @larry
- Hit 'reply' link for it
- Erase everything from the text area and type something in
- Submit the form.
I can add a message just fine, but I think something is broken still.
Can you get your web browser to see the source of the reply form? I get
<form method="POST" action="/review/20356/publish" id="message-reply-form"> <input type="hidden" name="xsrf_token"value="7e667aa15c51043fea022aa837edaaa5"> <div></div> <input type="hidden" name="in_reply_to" value="" /> <input type="hidden" name="subject" value="fix formatting of positional-only parameters in inspect.Signature" /> <input type="hidden" name="message_only" value="1" /> <input type="submit" value="Send Message" /> <input type="button" value="Discard" name="discard" /> <input type="checkbox" name="send_mail" value="1" id="message-reply-send-mail" checked="checked" /> <label>Send mail to reviewers</label> </form>
I believe the issue is the hidden in_reply_to field.
a) it shouldn't be an empty string (I think); if it wasn't, Rietveld might actually make insert it in a threaded way. IIUC, js ought to have inserted a value for in_reply_to. b) if it is empty, it apparently crashes for you because it then finds that there is no message with the id "".
Looking a bit further - maybe Safari doesn't tell me the dynamic code. I also see
<a href="javascript:M_replyToMessage('0', '2014/01/25 11:25:44', 'larry', 'Message_2687')" id="message-reply-href-0">Reply</a>
which really ought to fill out the in_reply_to field (with Message_2687)
Sure, here is the form markup:
<form method="POST" action="/review/20356/publish" id="message-reply-form"><textarea rows="7" cols="70" name="message" style=""></textarea> <input type="hidden" name="xsrf_token" value="769e2ad622940b39cde28df56f486977"> <div></div> <input type="hidden" name="in_reply_to" value="Message_2687"> <input type="hidden" name="subject" value="fix formatting of positional-only parameters in inspect.Signature"> <input type="hidden" name="message_only" value="1"> <input type="submit" value="Send Message"> <input type="button" value="Discard" name="discard"> <input type="checkbox" name="send_mail" value="1" id="message-reply-send-mail-0" checked="checked"> <label for="message-reply-send-mail-0">Send mail to reviewers</label> </form>
And here is what browser (Chrome, again) actually had sent to the server:
- message: Test
- xsrf_token: 769e2ad622940b39cde28df56f486977
- in_reply_to: Message_2687
- subject: fix formatting of positional-only parameters in inspect.Signature
- message_only: 1
- send_mail: 1
So, the JS code is clearly working.
Yury
Am 27.01.14 23:37, schrieb Yury Selivanov:
So, the JS code is clearly working.
Unfortunately, I have no idea what the root problem might be. a) I cannot reproduce it. Following your steps, I manage to post a reply every time. b) It really ought to work. The specific error suggests that the message lookup failed. However, the message in question is certainly there, and it does work for other people.
Feel free to submit a bug report to the metatracker, but chances are low that it gets fixed (unless by accident, e.g. when upgrading to a new Rietveld code base fixes the problem).
Regards, Martin
On 1/28/2014, 2:07 AM, "Martin v. Löwis" wrote:
Am 27.01.14 23:37, schrieb Yury Selivanov:
So, the JS code is clearly working.
Unfortunately, I have no idea what the root problem might be. a) I cannot reproduce it. Following your steps, I manage to post a reply every time. b) It really ought to work. The specific error suggests that the message lookup failed. However, the message in question is certainly there, and it does work for other people.
Feel free to submit a bug report to the metatracker, but chances are low that it gets fixed (unless by accident, e.g. when upgrading to a new Rietveld code base fixes the problem).
Martin,
Thank you for looking into this. I guess I'll try to debug this myself too, maybe on the weekend.
Yury
participants (6)
-
"Martin v. Löwis" -
Andrew Svetlov -
Antoine Pitrou -
Larry Hastings -
R. David Murray -
Yury Selivanov