How can I ignore email notifications on commits mentioning my GitHub handle on CPython forks?
Hi,
I'm getting more and more email notifications when a commit contains my GitHub handle ("@vstinner"). For example: "Automerge-Triggered-By: @vstinner".
The issue is that it's not only commits from the python/cpython GitHub project, but also on all forks of the python project. Example: https://github.com/zooba/cpython/commit/9a5e643483578c3a944ceb5aa511d6c24280...
"You are receiving this because you were mentioned."
Some email headers:
From: Anthony Sottile notifications@github.com To: "zooba/cpython" cpython@noreply.github.com Cc: Victor Stinner vstinner@python.org, Mention mention@noreply.github.com Reply-To: "zooba/cpython" reply+AABPMUP5SJOBYX4DLMTUTCN6PBBINEVBPLHAA72EO4@reply.github.com
List-ID: zooba/cpython
X-GitHub-Sender: asottile X-GitHub-Recipient: vstinner X-GitHub-Reason: mention
I can unsubscribe from each python project fork, but more and more people are forking Python, it doesn't scale :-(
In GitHub > Settings > Emails, I only see the email address used to "Receives notifications".
In GitHub > Settings > Notifications, I only see a global "Notifications for all repositories, teams, or conversations you’re watching." option ("[x] Email [x] Web and Mobile"). There is no granularity to filter where I'm mentioned (PR review, issue, commit, etc.).
It seems like Paul Ganssle has the same issue than me: https://twitter.com/pganssle/status/1379161385863643155
But the problem is that the "automerge" labels uses "Automerge-Triggered-By: @vstinner" syntax. Maybe a small enhancement would be to use ""Automerge-Triggered-By: vstinner" syntax instead (avoid the @).
Some developers put my handle in a commit message since it becomes the PR descriptor and sends ping me by email. But then my handle lands into the merged commit message, like:
" @vstinner noticed on
python-dev
that there is no what's new or porting entry for removal of asyncio
loop parameter. "
" @vstinner / @corona10, would you mind reviewing this? "
" The changes in this commit are all related to @vstinner's original review comments of the initial PEP 617 implementation PR. "
" * Added @vstinner News "
" Motivation for this PR (comment from @vstinner in bpo issue): "
I'm not asking you to stop mentioning me. I'm just asking for help how to filter these notifications?
Note: I'm using Gmail which only supports some filters, it doesn't support filtering on any email header.
Victor
Night gathers, and now my watch begins. It shall not end until my death.
On Tue, Apr 6, 2021 at 9:36 AM Victor Stinner vstinner@python.org wrote:
I'm getting more and more email notifications when a commit contains my GitHub handle ("@vstinner"). For example: "Automerge-Triggered-By: @vstinner".
Yes, this is a pretty substantial failing of GitHub for popular projects :(
But the problem is that the "automerge" labels uses "Automerge-Triggered-By: @vstinner" syntax. Maybe a small enhancement would be to use ""Automerge-Triggered-By: vstinner" syntax instead (avoid the @).
This is already done; see
https://github.com/python/miss-islington/commit/334c817cecf6c5c7f074ec7dbbad...
(we now use GH:vstinner to keep it clear that it's a GitHub handle
without triggering GitHub's automatic linking/mentioning).
Some developers put my handle in a commit message since it becomes the PR descriptor and sends ping me by email. But then my handle lands into the merged commit message, like: ... I'm not asking you to stop mentioning me. I'm just asking for help how to filter these notifications?
This is one of the several reasons that I don't like using the PR description as the commit message when using auto-merge :). I still think we ought to require a new comment with a special marker to contain the commit message. I haven't found time or motivation to actually try to make this change, though.
That change wouldn't help with existing messy commits, though, and those keep popping up when someone does something weird with their fork, like rebasing one stable branch on another. I'm afraid I don't have a good solution for that that doesn't risk masking the messages you might actually want to see :(
I think the real solution to this should come from Github if we can
convince them that it's worth their time to have a separate notification
category for these things. One short-term solution for this might be to
modify the commit messages that automerge uses. The simplest version of
this would be something like injecting a zero-width space after every @
that is followed by something that could plausibly be a GH username,
e.g. re.sub("@(?=[a-zA-Z0-9])", "@\u200b", commit_message). It would
read the same way but I think wouldn't trigger a mention.
We could presumably also make this a bit more targeted by actually trying to extract the mentioned user and checking if it's an actual GH user, and inject the ZWS only then.
We could also use something other than a ZWS. A ZWS is nice because it won't visually mangle the commit message at all, but it's bad because if someone copy-pastes something from the commit message they probably won't know that they have invisible formatting characters in it, and that might be immensely frustrating. "Only inject a ZWS in the event that it's a real user" won't necessarily help if people are including code snippets containing @classmethod https://github.com/classmethod in them.
Best, Paul
P.S. If anyone with communications channels to Github is planning to lobby for changes, I'd prefer a way to say, "Never notify me of @ messages in commit messages" followed by a special CC: address for easy filtering, followed by "Please don't notify me a second time when an identical commit shows up in a fork of a project I've already been notified for" (though all three of these would be good improvements with or without the others).
On 4/6/21 11:52 AM, Zachary Ware wrote:
On Tue, Apr 6, 2021 at 9:36 AM Victor Stinner vstinner@python.org wrote:
I'm getting more and more email notifications when a commit contains my GitHub handle ("@vstinner"). For example: "Automerge-Triggered-By: @vstinner". Yes, this is a pretty substantial failing of GitHub for popular projects :(
But the problem is that the "automerge" labels uses "Automerge-Triggered-By: @vstinner" syntax. Maybe a small enhancement would be to use ""Automerge-Triggered-By: vstinner" syntax instead (avoid the @). This is already done; see https://github.com/python/miss-islington/commit/334c817cecf6c5c7f074ec7dbbad... (we now use
GH:vstinnerto keep it clear that it's a GitHub handle without triggering GitHub's automatic linking/mentioning).Some developers put my handle in a commit message since it becomes the PR descriptor and sends ping me by email. But then my handle lands into the merged commit message, like: ... I'm not asking you to stop mentioning me. I'm just asking for help how to filter these notifications? This is one of the several reasons that I don't like using the PR description as the commit message when using auto-merge :). I still think we ought to require a new comment with a special marker to contain the commit message. I haven't found time or motivation to actually try to make this change, though.
That change wouldn't help with existing messy commits, though, and those keep popping up when someone does something weird with their fork, like rebasing one stable branch on another. I'm afraid I don't have a good solution for that that doesn't risk masking the messages you might actually want to see :(
python-committers mailing list -- python-committers@python.org To unsubscribe send an email to python-committers-leave@python.org https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/W... Code of Conduct: https://www.python.org/psf/codeofconduct/
P.S. If anyone with communications channels to Github is planning to lobby for changes, I'd prefer a way to say, "Never notify me of @ messages in commit messages" followed by a special CC: address for easy filtering, followed by "Please don't notify me a second time when an identical commit shows up in a fork of a project I've already been notified for" (though all three of these would be good improvements with or without the others).
I'm a member of GitHub OS Maintainers feedback group. I can share this issue with them later today.
This is one of the several reasons that I don't like using the PR description as the commit message when using auto-merge :).
I think this is a good motivation to use https://docs.github.com/en/github/collaborating-with-issues-and-pull-request... instead as you can write your own commit message there and schedule the merge.
On Tue, 6 Apr 2021 at 16:52, Zachary Ware zach@python.org wrote:
On Tue, Apr 6, 2021 at 9:36 AM Victor Stinner vstinner@python.org wrote:
I'm getting more and more email notifications when a commit contains my GitHub handle ("@vstinner"). For example: "Automerge-Triggered-By: @vstinner".
Yes, this is a pretty substantial failing of GitHub for popular projects :(
But the problem is that the "automerge" labels uses "Automerge-Triggered-By: @vstinner" syntax. Maybe a small enhancement would be to use ""Automerge-Triggered-By: vstinner" syntax instead (avoid the @).
This is already done; see
https://github.com/python/miss-islington/commit/334c817cecf6c5c7f074ec7dbbad... (we now use
GH:vstinnerto keep it clear that it's a GitHub handle without triggering GitHub's automatic linking/mentioning).Some developers put my handle in a commit message since it becomes the PR descriptor and sends ping me by email. But then my handle lands into the merged commit message, like: ... I'm not asking you to stop mentioning me. I'm just asking for help how to filter these notifications?
This is one of the several reasons that I don't like using the PR description as the commit message when using auto-merge :). I still think we ought to require a new comment with a special marker to contain the commit message. I haven't found time or motivation to actually try to make this change, though.
That change wouldn't help with existing messy commits, though, and those keep popping up when someone does something weird with their fork, like rebasing one stable branch on another. I'm afraid I don't have a good solution for that that doesn't risk masking the messages you might actually want to see :(
python-committers mailing list -- python-committers@python.org To unsubscribe send an email to python-committers-leave@python.org https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/W... Code of Conduct: https://www.python.org/psf/codeofconduct/
On Tue, Apr 6, 2021 at 6:41 PM Pablo Galindo Salgado pablogsal@gmail.com wrote:
I think this is a good motivation to use https://docs.github.com/en/github/collaborating-with-issues-and-pull-request... instead as you can write your own commit message there and schedule the merge.
By the way, currently when you merge a PR (manually), if you modify the commit title/message *and* the merge fails, DON'T CLICK on "try again", or the PR is merged with the old commit title/message without your changes :-( IMO it's a bug in the GitHub UI.
Victor
I don't have much to add (this occurs to me too and I just bulk-delete the messages) but I wonder if the problem might be caused by a situation where GitHub doesn't realize that a repo is a fork of cpython? I suppose that could happen if someone creates a fresh repo and pushes a local clone of cpython to it. I'll ask Zooba what he did.
--Guido van Rossum (python.org/~guido) *Pronouns: he/him **(why is my pronoun here?)* http://feministing.com/2015/02/03/how-using-they-as-a-singular-pronoun-can-c...
Steve Dower's workflow is to use git merge origin/master, and he did that earlier today, causing the most recent flurry. His repo is a fork of cpython but its master branch is 1000s of commits behind, so probably there's some bug in GitHub where the commits being merged are seen as new.
Mariatta, maybe this info helps the GitHub folks figure out how to fix this.
On Tue, Apr 6, 2021 at 10:02 AM Guido van Rossum guido@python.org wrote:
I don't have much to add (this occurs to me too and I just bulk-delete the messages) but I wonder if the problem might be caused by a situation where GitHub doesn't realize that a repo is a fork of cpython? I suppose that could happen if someone creates a fresh repo and pushes a local clone of cpython to it. I'll ask Zooba what he did.
--Guido van Rossum (python.org/~guido) *Pronouns: he/him **(why is my pronoun here?)* http://feministing.com/2015/02/03/how-using-they-as-a-singular-pronoun-can-c...
-- --Guido van Rossum (python.org/~guido) *Pronouns: he/him **(why is my pronoun here?)* http://feministing.com/2015/02/03/how-using-they-as-a-singular-pronoun-can-c...
Oh, there is an update! 3 days ago, a member of the GitHub "staff" wrote: "This should be fixed. Please do let us know if it is not." https://github.community/t/i-am-getting-notifications-due-to-being-mentioned...
Victor
On Tue, Apr 6, 2021 at 4:36 PM Victor Stinner vstinner@python.org wrote:
Hi,
I'm getting more and more email notifications when a commit contains my GitHub handle ("@vstinner"). For example: "Automerge-Triggered-By: @vstinner".
The issue is that it's not only commits from the python/cpython GitHub project, but also on all forks of the python project. Example: https://github.com/zooba/cpython/commit/9a5e643483578c3a944ceb5aa511d6c24280...
"You are receiving this because you were mentioned."
Some email headers:
From: Anthony Sottile notifications@github.com To: "zooba/cpython" cpython@noreply.github.com Cc: Victor Stinner vstinner@python.org, Mention mention@noreply.github.com Reply-To: "zooba/cpython" reply+AABPMUP5SJOBYX4DLMTUTCN6PBBINEVBPLHAA72EO4@reply.github.com
List-ID: zooba/cpython
List-Unsubscribe: mailto:unsub+AABPMUP5SJOBYX4DLMTUTCN6PBBINEVBPLHAA72EO4@reply.github.com, https://github.com/notifications/unsubscribe/AABPMUMREC2T2I5FM2JQBGLTHMDYNAN... X-GitHub-Sender: asottile X-GitHub-Recipient: vstinner X-GitHub-Reason: mention
I can unsubscribe from each python project fork, but more and more people are forking Python, it doesn't scale :-(
In GitHub > Settings > Emails, I only see the email address used to "Receives notifications".
In GitHub > Settings > Notifications, I only see a global "Notifications for all repositories, teams, or conversations you’re watching." option ("[x] Email [x] Web and Mobile"). There is no granularity to filter where I'm mentioned (PR review, issue, commit, etc.).
It seems like Paul Ganssle has the same issue than me: https://twitter.com/pganssle/status/1379161385863643155
But the problem is that the "automerge" labels uses "Automerge-Triggered-By: @vstinner" syntax. Maybe a small enhancement would be to use ""Automerge-Triggered-By: vstinner" syntax instead (avoid the @).
Some developers put my handle in a commit message since it becomes the PR descriptor and sends ping me by email. But then my handle lands into the merged commit message, like:
" @vstinner noticed on python-dev that there is no what's new or porting entry for removal of asyncio
loopparameter. "" @vstinner / @corona10, would you mind reviewing this? "
" The changes in this commit are all related to @vstinner's original review comments of the initial PEP 617 implementation PR. "
" * Added @vstinner News "
" Motivation for this PR (comment from @vstinner in bpo issue): "
I'm not asking you to stop mentioning me. I'm just asking for help how to filter these notifications?
Note: I'm using Gmail which only supports some filters, it doesn't support filtering on any email header.
Victor
Night gathers, and now my watch begins. It shall not end until my death.
-- Night gathers, and now my watch begins. It shall not end until my death.
participants (6)
-
Guido van Rossum -
Mariatta -
Pablo Galindo Salgado -
Paul Ganssle -
Victor Stinner -
Zachary Ware