Hello,
Another quick infrastructure question (is this the right list, btw?): I don't see 'review' links for some patches. Like in issue #14911, Kristján uploaded two patches, same day, almost same time, and I see a review link only for one of them.
Screenshot: http://goo.gl/HK2oer
Thanks, Yury
IIRC the review link only appears if the patch applies cleanly.
On Mon, Feb 3, 2014 at 9:03 AM, Yury Selivanov yselivanov.ml@gmail.comwrote:
Hello,
Another quick infrastructure question (is this the right list, btw?): I don't see 'review' links for some patches. Like in issue #14911, Kristján uploaded two patches, same day, almost same time, and I see a review link only for one of them.
Screenshot: http://goo.gl/HK2oer
Thanks, Yury
python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers
-- --Guido van Rossum (python.org/~guido)
OK, thank you.
Are you sure it's the right thing to do? I.e. a user can create a patch, ensure that it applies cleanly, and while he uploads it, someone pushes to the repo. No 'review' link, no notification.
Wouldn't it make sense to always show the review link, and let the user to resolve the conflicts if there are any?
Yury
On 2/3/2014, 12:20 PM, Antoine Pitrou wrote:
On lun., 2014-02-03 at 09:16 -0800, Guido van Rossum wrote:
IIRC the review link only appears if the patch applies cleanly. And only if it applies cleanly on the default branch, IIRC :-)
Regards
Antoine.
python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers
actually if your patch contains
"diff -r f4377699fd47 Lib/test/test_zipimport.py"
lines prior to the --- line as hg diff can emit, it'll do the right thing and show the review against the version of the file listed (or at least against it's branch head? that's an example taken from 3.3 for a patch that most definitely does not apply cleanly to default||3.4)
-gps
On Mon, Feb 3, 2014 at 9:20 AM, Antoine Pitrou solipsis@pitrou.net wrote:
On lun., 2014-02-03 at 09:16 -0800, Guido van Rossum wrote:
IIRC the review link only appears if the patch applies cleanly.
And only if it applies cleanly on the default branch, IIRC :-)
Regards
Antoine.
python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers
On Mon, Feb 3, 2014 at 11:03 AM, Yury Selivanov yselivanov.ml@gmail.com wrote:
Hello,
Another quick infrastructure question (is this the right list, btw?):
Core-mentorship is another good candidate.
I don't see 'review' links for some patches. Like in issue #14911, Kristján uploaded two patches, same day, almost same time, and I see a review link only for one of them.
As was recently explained to me, patches created in 'git' format (hg diff --git) will show a review link only if they apply cleanly to
default branch (so '--git' 2.7 patches will never show a review link
unless it just happens to apply to default as well). Patches created
without '--git' give the revision they're applied to, so as long as
they apply cleanly to that revision, they'll show a review link no
matter the branch.
-- Zach
On Mon, Feb 3, 2014 at 12:03 PM, Yury Selivanov yselivanov.ml@gmail.comwrote:
Hello,
Another quick infrastructure question (is this the right list, btw?):
There is always the meta bug tracker at http://psf.upfronthosting.co.za/roundup/meta/ for tracker issues.
participants (6)
-
Antoine Pitrou -
Brett Cannon -
Gregory P. Smith -
Guido van Rossum -
Yury Selivanov -
Zachary Ware