On Thu, 09 Jan 2014 16:23:59 +0200, Serhiy Storchaka storchaka@gmail.com wrote:

четвер, 09-січ-2014 09:51:22 Victor Stinner написано:

...

I noticed that Vajrasky Kok is very active on bugs.python.org. He produced many patches and contribued to various modules written in Python and C.

Search "Vajrasky Kok" in the Mercurial history to see how many contributions he made recently. On http://bugs.python.org his nickname is "vajrasky".

He knows the process of review and update his patch when he got remarks.

If you consider that he needs a mentor, I can be his mentor.

Vajrasky Kok is good candidate. He is very active and interested in Python maintaining, he is respondable. he makes review of others code. But his code still not mature. He is often doesn't noticed many details in first versions of his patches. He just lacks experience. I believe that a year late he will be more experienced.

Perhaps a mentor would help, but every Vajrasky patch, even simplest, should be reviewed. And in this case there are no many benefits from commit right (except moral encouragement).

Sorry, I'm -0.1 for right now.

I agree with this assessment. It might not take a year, but I don't think the time is quite yet. Please feel free to encourage him, though.

I feel like he's currently a bit too willing to whip up a patch to "fix something" without thinking through the consequences and alternatives...that is, without understanding the problem deeply enough to be reasonably sure that the fix is the *right* fix. He's getting better about that, though.

To put Serhiy's summary another way, we haven't quite reached the point where it would be easier for us if he could just commit his own patches.

--David

I agree with 'promising'. I cannot comment on 'ready' as I have not reviewed his patches much. My impression is that he has a talent for noticing glitches in the details of existing behavior and docs.

"He is often doesn't noticed many details in first versions of his patches."

If he has trouble being as critical of his own work, he would not be the first. It is a needed skill, though.

Has anyone communicated with him, perhaps privately, on how to improve his patches, so he learns by doing it himself? (I know very well that editing and commiting is often more expeditious if one wants the patch committed *now*.) Mentoring, if he wants it, could start now rather than after granting commit rights.

Terry

Hi,

2014/1/21 Ethan Furman ethan@stoneleaf.us:

...

Has anyone communicated with him, perhaps privately, on how to improve his patches, so he learns by doing it himself?

I contacted him before proposing to give him the commit access.

I then told him that he should just continue his contributions to reach the requested quality level of the Python project. He replied that it's hard to find easy issues and that Serhiy fixes most of them. Vajrasky prefers to hurry to propose a buggy patch, just to be the first one, instead of seen the issue stolen from Serhiy.

I experimented the difficult task of finding "easy" issues. I agree that it's a very hard task. Recent easy issues are closed in less than one week, sometimes in 24 hours. Old issues are usually hard, specific to an user or platform, tricky to implement, etc.

There is maybe something wrong in our process about easy issues?

Obviously, I asked asked Vajrasky to contact Serhiy to stop this race.

I have not, but am willing to if Victor would not be offended. I don't feel up to being an official mentor as the machinery and protocols are still new to me, but I think I could offer sound advice on how to improve his patch and debugging skills.

Oh please, do :-) I'm not offended. Or exchanges may be "public" in the mentor mailing list? As Vajrasky prefers.

Victor