"trivial" label replaced with "skip issue"
In preparation of fully moving over to blurb and per-file news entries (I don't have an ETA from Larry on when he plans to do explode Misc/NEWS into individual files), the "trivial" label has been replaced with a "skip issue" label to signal that the issue number check should be skipped. The plan is that when we start having a status check for news entries there will be a "skip news" label to skip that status check. Dropping the all-inclusive "trivial" label helps keep us honest and only skip checks that are truly appropriate for a PR since these are skipping information-tracking things.
I've also gone ahead and make the issue number check required on all branches since I think Bedevere has proven itself to be reliable enough to be a blocker and since we have the "skip" labels as an escape hatch.
On 07/14/2017 08:33 PM, Brett Cannon wrote:
In preparation of fully moving over to blurb and per-file news entries (I don't have an ETA from Larry on when he plans to do explode Misc/NEWS into individual files)
Sorry for the lack of communication; I've been traveling for two weeks and it's been stimulating. I plan to create the PRs during the EuroPython sprints (aka this weekend).
//arry/
2017-07-14 20:33 GMT+02:00 Brett Cannon <brett@python.org>:
In preparation of fully moving over to blurb and per-file news entries (I don't have an ETA from Larry on when he plans to do explode Misc/NEWS into individual files), ...
Oh, I wasn't aware of this plan. What is the benefit of converting old Misc/NEWS entries? Do you have an idea of many files we will get? Do we plan to remove old entries?
Victor
Getting rid of Misc/NEWS was the whole point. The benefit is that we get rid of Misc/NEWS collisions.
The other questions, you can answer for yourself by looking at the PRs.
They're all in a row, PR 2714 through PR 2719. 2719 is where most of
the conversation is happening.
https://github.com/python/cpython/pull/2719Right now I'm trying to figure out how to fix the Doc build. I don't think there are any other issues.
//arry/
On 07/16/2017 04:10 PM, Victor Stinner wrote:
2017-07-14 20:33 GMT+02:00 Brett Cannon <brett@python.org>:
In preparation of fully moving over to blurb and per-file news entries (I don't have an ETA from Larry on when he plans to do explode Misc/NEWS into individual files), ... Oh, I wasn't aware of this plan. What is the benefit of converting old Misc/NEWS entries? Do you have an idea of many files we will get? Do we plan to remove old entries?
Victor
python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
On Sun, Jul 16, 2017, 07:10 Victor Stinner, <victor.stinner@gmail.com> wrote:
2017-07-14 20:33 GMT+02:00 Brett Cannon <brett@python.org>:
In preparation of fully moving over to blurb and per-file news entries (I don't have an ETA from Larry on when he plans to do explode Misc/NEWS into individual files), ...
Oh, I wasn't aware of this plan.
Just a reminder all the major discussions about workflow changes happen on the core-workflow mailing list with smaller discussions on the core-workflow issue tracker. This specific change has been planned and discussed since the migration was nothing more than a PEP.
-brett
What is the benefit of converting old
Misc/NEWS entries? Do you have an idea of many files we will get? Do we plan to remove old entries?
Victor
2017-07-16 16:10 GMT+02:00 Victor Stinner <victor.stinner@gmail.com>:
What is the benefit of converting old Misc/NEWS entries?
I guess that the benefit is to use a single format for all NEWS entries. I understand that it will ease the build of the changelog.
Do you have an idea of many files we will get? Do we plan to remove old entries?
Before: 47 files in master. After: 546 files. Ok, it's not much.
I didn't know that blurb supports "packing" NEWS entries into a single file, like Misc/NEWS.d/3.5.0a1.rst which contains 598 entries. Cool!
My fear was to get 10,000 files in Misc/NEWS and starting to get performance issues with Git on some platforms.
With the PR #2719 (convert Misc/NEWS to blurb for master), the Git repository contains 4,340 files. On my laptop, I didn't notice any major performance related to that.
Victor
On Sun, 16 Jul 2017 at 15:22 Victor Stinner <victor.stinner@gmail.com> wrote:
2017-07-16 16:10 GMT+02:00 Victor Stinner <victor.stinner@gmail.com>:
What is the benefit of converting old Misc/NEWS entries?
I guess that the benefit is to use a single format for all NEWS entries. I understand that it will ease the build of the changelog.
It's to ease backporting since you will never have Misc/NEWS have a merge conflict ever again.
Do you have an idea of many files we will get? Do we plan to remove old entries?
Before: 47 files in master. After: 546 files. Ok, it's not much.
I didn't know that blurb supports "packing" NEWS entries into a single file, like Misc/NEWS.d/3.5.0a1.rst which contains 598 entries. Cool!
My fear was to get 10,000 files in Misc/NEWS and starting to get performance issues with Git on some platforms.
Yeah, I already had that fear for you. :)
With the PR #2719 (convert Misc/NEWS to blurb for master), the Git repository contains 4,340 files. On my laptop, I didn't notice any major performance related to that.
That was a design goal.
Le 17/07/2017 à 22:16, Brett Cannon a écrit :
On Sun, 16 Jul 2017 at 15:22 Victor Stinner <victor.stinner@gmail.com <mailto:victor.stinner@gmail.com>> wrote:
2017-07-16 16:10 GMT+02:00 Victor Stinner <victor.stinner@gmail.com <mailto:victor.stinner@gmail.com>>: > What is the benefit of converting old Misc/NEWS entries? I guess that the benefit is to use a single format for all NEWS entries. I understand that it will ease the build of the changelog.It's to ease backporting since you will never have Misc/NEWS have a merge conflict ever again.
Can I take the opportunity to say thank you again (both you and Larry) for the "blurb" tool? It really makes an important difference when contributing.
Regards
Antoine.
participants (4)
-
Antoine Pitrou -
Brett Cannon -
Larry Hastings -
Victor Stinner