What is CodeCov on pull request? Does anyone use it?
Hi,
There is a new "CodeCov" thing on Python pull requests which adds a giant comment with many numbers and statistics and then mark my pull request as "failed" (red).
I know the concept of code coverage, ok. But who uses this service? Does it *have to* send emails to say:
"Merging #18743 into master will increase coverage by 0.00%. The diff coverage is n/a."
https://github.com/python/cpython/pull/18743#issuecomment-593426007
My PR changes distutils, but the comment also says "Lib/ftplib.py 63.85% <0.00%> (-6.06%)". The service doesn't seem reliable. A distutils change should have no impact on ftplib coverage. Or someone should explain me how it's supposed to work.
https://devguide.python.org/coverage/ says nothing about CodeCov.
Would it be possible to disable this service?
Or can I opt-out somehow to no longer get emails from it nor see such comments on my PRs?
Victor
Night gathers, and now my watch begins. It shall not end until my death.
This is being discussed at https://bugs.python.org/issue39704
On Mon, Mar 2, 2020 at 9:44 PM Victor Stinner <vstinner@python.org> wrote:
Hi,
There is a new "CodeCov" thing on Python pull requests which adds a giant comment with many numbers and statistics and then mark my pull request as "failed" (red).
I know the concept of code coverage, ok. But who uses this service? Does it *have to* send emails to say:
"Merging #18743 into master will increase coverage by 0.00%. The diff coverage is n/a."
https://github.com/python/cpython/pull/18743#issuecomment-593426007
My PR changes distutils, but the comment also says "Lib/ftplib.py 63.85% <0.00%> (-6.06%)". The service doesn't seem reliable. A distutils change should have no impact on ftplib coverage. Or someone should explain me how it's supposed to work.
https://devguide.python.org/coverage/ says nothing about CodeCov.
Would it be possible to disable this service?
Or can I opt-out somehow to no longer get emails from it nor see such comments on my PRs?
Victor
Night gathers, and now my watch begins. It shall not end until my death.
python-committers mailing list -- python-committers@python.org To unsubscribe send an email to python-committers-leave@python.org https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/W... Code of Conduct: https://www.python.org/psf/codeofconduct/
-- Regards, Karthikeyan S
I find codecov useful, but I almost always turn that comment off, as you can see here: https://github.com/pganssle/zoneinfo/blob/1bdc68b447fa84faf41cb86d7816ab06fa...
I think it defaults to on and has a way of occasionally failing in such a way that it fires anyway, but this is very occasional in my experience.
I think we should definitely turn it off - the little github webhooks are enough to give you the information you want, and I find it very spammy.
On 3/2/20 11:13 AM, Victor Stinner wrote:
Hi,
There is a new "CodeCov" thing on Python pull requests which adds a giant comment with many numbers and statistics and then mark my pull request as "failed" (red).
I know the concept of code coverage, ok. But who uses this service? Does it *have to* send emails to say:
"Merging #18743 into master will increase coverage by 0.00%. The diff coverage is n/a."
https://github.com/python/cpython/pull/18743#issuecomment-593426007
My PR changes distutils, but the comment also says "Lib/ftplib.py 63.85% <0.00%> (-6.06%)". The service doesn't seem reliable. A distutils change should have no impact on ftplib coverage. Or someone should explain me how it's supposed to work.
https://devguide.python.org/coverage/ says nothing about CodeCov.
Would it be possible to disable this service?
Or can I opt-out somehow to no longer get emails from it nor see such comments on my PRs?
Victor
FYI we have codecov configured to turn off the comment (and have since I think we started using codecov). See the issue for more details about a potential bug on codecov's side.
participants (4)
-
Brett Cannon -
Karthikeyan -
Paul Ganssle -
Victor Stinner