Requesting reviews
I'm seeing a lot of review requests from github, asking for reviews from the Windows team. Many of the PRs don't as far as I can see have much Windows-specific about them. It doesn't bother me too much (I just ignore ones I don't have anything to say on) but I thought the idea of having the teams was to ask for specific experts to take a look when needed?
As I say, it's not a big deal for me, but I'm curious how others think the review teams should be used.
Paul
On 10/6/2017 8:16 AM, Paul Moore wrote:
I'm seeing a lot of review requests from github, asking for reviews from the Windows team. Many of the PRs don't as far as I can see have much Windows-specific about them. It doesn't bother me too much (I just ignore ones I don't have anything to say on) but I thought the idea of having the teams was to ask for specific experts to take a look when needed?
Perhaps people are asking for Windows-specific input in addition to input from themselves or other *nix experts, in case there is something they do not know about. If so, and you look and see nothing, it might be helpful to say so. Of course, it might help if the requesting person explains such requests.
tjr
On Fri, Oct 6, 2017 at 7:16 AM, Paul Moore p.f.moore@gmail.com wrote:
I'm seeing a lot of review requests from github, asking for reviews from the Windows team. Many of the PRs don't as far as I can see have much Windows-specific about them. It doesn't bother me too much (I just ignore ones I don't have anything to say on) but I thought the idea of having the teams was to ask for specific experts to take a look when needed?
As I say, it's not a big deal for me, but I'm curious how others think the review teams should be used.
Do you have some examples of superfluous requests? I don't think I've seen any, other than a rash of bad drive-by PRs that merge a maintenance branch into master, which GitHub should be working on preventing. See https://github.com/python/core-workflow/issues/168 for more on that.
-- Zach
Hmm, as an example, #2858, which seems to be about the AST (which I'm not familiar with). I don't particularly want to single this out as a problem, but it's an example of the sort of request that confuses me - I simply don't know what help I can offer. Maybe there is some suspicion that there might be a Windows element - but without some guidance, I'm not sure where to look.
Paul
On 6 October 2017 at 16:38, Zachary Ware zachary.ware+pydev@gmail.com wrote:
On Fri, Oct 6, 2017 at 7:16 AM, Paul Moore p.f.moore@gmail.com wrote:
I'm seeing a lot of review requests from github, asking for reviews from the Windows team. Many of the PRs don't as far as I can see have much Windows-specific about them. It doesn't bother me too much (I just ignore ones I don't have anything to say on) but I thought the idea of having the teams was to ask for specific experts to take a look when needed?
As I say, it's not a big deal for me, but I'm curious how others think the review teams should be used.
Do you have some examples of superfluous requests? I don't think I've seen any, other than a rash of bad drive-by PRs that merge a maintenance branch into master, which GitHub should be working on preventing. See https://github.com/python/core-workflow/issues/168 for more on that.
-- Zach
python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
The windows team is notified because the PR includes changes to PCBuild/*
Mariatta Wijaya
On Fri, Oct 6, 2017 at 8:51 AM, Paul Moore p.f.moore@gmail.com wrote:
Hmm, as an example, #2858, which seems to be about the AST (which I'm not familiar with). I don't particularly want to single this out as a problem, but it's an example of the sort of request that confuses me - I simply don't know what help I can offer. Maybe there is some suspicion that there might be a Windows element - but without some guidance, I'm not sure where to look.
Paul
On 6 October 2017 at 16:38, Zachary Ware zachary.ware+pydev@gmail.com wrote:
On Fri, Oct 6, 2017 at 7:16 AM, Paul Moore p.f.moore@gmail.com wrote:
I'm seeing a lot of review requests from github, asking for reviews from the Windows team. Many of the PRs don't as far as I can see have much Windows-specific about them. It doesn't bother me too much (I just ignore ones I don't have anything to say on) but I thought the idea of having the teams was to ask for specific experts to take a look when needed?
As I say, it's not a big deal for me, but I'm curious how others think the review teams should be used.
Do you have some examples of superfluous requests? I don't think I've seen any, other than a rash of bad drive-by PRs that merge a maintenance branch into master, which GitHub should be working on preventing. See https://github.com/python/core-workflow/issues/168 for more on that.
-- Zach
python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
On 6 October 2017 at 17:09, Mariatta Wijaya mariatta.wijaya@gmail.com wrote:
The windows team is notified because the PR includes changes to PCBuild/*
Ah cool. That explains it then - I hadn't spotted that (and didn't think of it).
Thanks Mariatta
Paul
On Fri, 06 Oct 2017 09:09:01 -0700, Mariatta Wijaya mariatta.wijaya@gmail.com wrote:
The windows team is notified because the PR includes changes to PCBuild/*
If you get a review request that says your review was requested "as a code owner", then it was an auto-request, it wasn't actually requested by the person named in the message (which I agree is confusing).
You can look through the diff to check for changes to PC, PCBuild, msi, or nuget to see if there are windows changes you do want to review. The config for the auto-review-requests is in .github/CODEOWNERS; the current windows team entries are:
# Windows
/PC/ @python/windows-team
/PCBuild/ @python/windows-team
# Windows installer packages
/Tools/msi/ @python/windows-team
/Tools/nuget/ @python/windows-teamOn 6 October 2017 at 17:58, R. David Murray rdmurray@bitdance.com wrote:
On Fri, 06 Oct 2017 09:09:01 -0700, Mariatta Wijaya mariatta.wijaya@gmail.com wrote:
The windows team is notified because the PR includes changes to PCBuild/*
If you get a review request that says your review was requested "as a code owner", then it was an auto-request, it wasn't actually requested by the person named in the message (which I agree is confusing).
Ah, right. Yes I had missed that nuance.
Thanks, I'm now much clearer on what's going on here. Thanks all for the explanations :-)
Paul
participants (5)
-
Mariatta Wijaya -
Paul Moore -
R. David Murray -
Terry Reedy -
Zachary Ware