Commit privileges for Daniel Urban
I'm proposing we grant commit privileges to Daniel Urban.
He's provided patches for a number of fixes and feature requests for 3.2 and 3.3, including a particularly thorny one in the metaclass machinery. He's been very responsive on the tracker, and accommodating of the occasional dramatic shift in direction for a patch based on mailing list feedback (most recently, the operator.build_class in C -> types.build_class in Python change).
Regards, Nick.
-- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
On Mon, May 14, 2012 at 9:23 PM, Nick Coghlan <ncoghlan@gmail.com> wrote:
I'm proposing we grant commit privileges to Daniel Urban.
He's provided patches for a number of fixes and feature requests for 3.2 and 3.3, including a particularly thorny one in the metaclass machinery. He's been very responsive on the tracker, and accommodating of the occasional dramatic shift in direction for a patch based on mailing list feedback (most recently, the operator.build_class in C -> types.build_class in Python change).
Nobody else has an opinion on this? Positive *or* negative?
Cheers, Nick.
-- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
I'm +1 on your recommendation alone
On May 15, 2012, at 8:59 PM, Nick Coghlan <ncoghlan@gmail.com> wrote:
On Mon, May 14, 2012 at 9:23 PM, Nick Coghlan <ncoghlan@gmail.com> wrote:
I'm proposing we grant commit privileges to Daniel Urban.
He's provided patches for a number of fixes and feature requests for 3.2 and 3.3, including a particularly thorny one in the metaclass machinery. He's been very responsive on the tracker, and accommodating of the occasional dramatic shift in direction for a patch based on mailing list feedback (most recently, the operator.build_class in C -> types.build_class in Python change).
Nobody else has an opinion on this? Positive *or* negative?
Cheers, Nick.
-- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
Zitat von Nick Coghlan <ncoghlan@gmail.com>:
On Mon, May 14, 2012 at 9:23 PM, Nick Coghlan <ncoghlan@gmail.com> wrote:
I'm proposing we grant commit privileges to Daniel Urban.
He's provided patches for a number of fixes and feature requests for 3.2 and 3.3, including a particularly thorny one in the metaclass machinery. He's been very responsive on the tracker, and accommodating of the occasional dramatic shift in direction for a patch based on mailing list feedback (most recently, the operator.build_class in C -> types.build_class in Python change).
Nobody else has an opinion on this? Positive *or* negative?
-0. I don't know who Daniel Urban is. It seems that he posted a total of four messages to python-dev this year, all related to a single feature of Python. My question now is whether he really *needs* commit privileges (or, rather, whether whoever checks in his changes at the moment would gain a desirable reduction of workload if Daniel could push changes himself).
Regards, Martin
On Wed, May 16, 2012 at 11:26 AM, <martin@v.loewis.de> wrote:
Zitat von Nick Coghlan <ncoghlan@gmail.com>:
On Mon, May 14, 2012 at 9:23 PM, Nick Coghlan <ncoghlan@gmail.com> wrote:
I'm proposing we grant commit privileges to Daniel Urban.
He's provided patches for a number of fixes and feature requests for 3.2 and 3.3, including a particularly thorny one in the metaclass machinery. He's been very responsive on the tracker, and accommodating of the occasional dramatic shift in direction for a patch based on mailing list feedback (most recently, the operator.build_class in C -> types.build_class in Python change).
Nobody else has an opinion on this? Positive *or* negative?
-0. I don't know who Daniel Urban is. It seems that he posted a total of four messages to python-dev this year, all related to a single feature of Python. My question now is whether he really *needs* commit privileges (or, rather, whether whoever checks in his changes at the moment would gain a desirable reduction of workload if Daniel could push changes himself).
Most of my interaction with Daniel has been through the tracker rather than python-dev, and it's specifically his work on fixing some (obscure) latent defects in the metaclass calculation for 3.2 that earned my respect (although he's worked on several other patches as well, the results of which can be seen in Misc/NEWS).
Regards, Nick.
-- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
Le mercredi 16 mai 2012 à 10:59 +1000, Nick Coghlan a écrit :
On Mon, May 14, 2012 at 9:23 PM, Nick Coghlan <ncoghlan@gmail.com> wrote:
I'm proposing we grant commit privileges to Daniel Urban.
He's provided patches for a number of fixes and feature requests for 3.2 and 3.3, including a particularly thorny one in the metaclass machinery. He's been very responsive on the tracker, and accommodating of the occasional dramatic shift in direction for a patch based on mailing list feedback (most recently, the operator.build_class in C -> types.build_class in Python change).
Nobody else has an opinion on this? Positive *or* negative?
Not having interacted with him, I can't really have an opinion :)
Regards
Antoine.
On Wed, 16 May 2012 10:59:57 +1000, Nick Coghlan <ncoghlan@gmail.com> wrote:
On Mon, May 14, 2012 at 9:23 PM, Nick Coghlan <ncoghlan@gmail.com> wrote:
I'm proposing we grant commit privileges to Daniel Urban.
He's provided patches for a number of fixes and feature requests for 3.2 and 3.3, including a particularly thorny one in the metaclass machinery. He's been very responsive on the tracker, and accommodating of the occasional dramatic shift in direction for a patch based on mailing list feedback (most recently, the operator.build_class in C -> types.build_class in Python change).
Nobody else has an opinion on this? Positive *or* negative?
Certainly not negative. I haven't taken a look at his patch history, but certainly the traffic I saw about the metaclass stuff gave me a very positive impression.
--David
On Thu, May 17, 2012 at 2:31 AM, R. David Murray <rdmurray@bitdance.com> wrote:
On Wed, 16 May 2012 10:59:57 +1000, Nick Coghlan <ncoghlan@gmail.com> wrote:
On Mon, May 14, 2012 at 9:23 PM, Nick Coghlan <ncoghlan@gmail.com> wrote:
I'm proposing we grant commit privileges to Daniel Urban.
He's provided patches for a number of fixes and feature requests for 3.2 and 3.3, including a particularly thorny one in the metaclass machinery. He's been very responsive on the tracker, and accommodating of the occasional dramatic shift in direction for a patch based on mailing list feedback (most recently, the operator.build_class in C -> types.build_class in Python change).
Nobody else has an opinion on this? Positive *or* negative?
Certainly not negative. I haven't taken a look at his patch history, but certainly the traffic I saw about the metaclass stuff gave me a very positive impression.
In the absence of any -1 votes, I'll get Daniel to send his public key through to the hgaccounts address. I'll still watch his commits and remind him that getting patches reviewed on the tracker first is still often the preferred approach, even for committers.
Cheers, Nick.
-- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
Hi Nick,
On Thu, May 17, 2012 at 12:44 PM, Nick Coghlan <ncoghlan@gmail.com> wrote:
In the absence of any -1 votes, I'll get Daniel to send his public key through to the hgaccounts address. I'll still watch his commits and remind him that getting patches reviewed on the tracker first is still often the preferred approach, even for committers.
One more thing to consider is, did he request for it ? If he requested and you are vouching, then +1. If not, I think, it may be helpful to ask him if he okay with the new privileges at this moment. :)
Thanks, Senthil
On Thu, May 17, 2012 at 2:44 PM, Nick Coghlan <ncoghlan@gmail.com> wrote:
In the absence of any -1 votes, I'll get Daniel to send his public key through to the hgaccounts address. I'll still watch his commits and remind him that getting patches reviewed on the tracker first is still often the preferred approach, even for committers.
On reflection, I decided to instead extend Daniel an offer that he could add me to the nosy list on any issues he was working on and I'd take a look.
An explicit offer to review any patches he submits seems like a sensible interim step prior to granting him direct push access.
Cheers, Nick.
-- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
On May 29, 2012, at 11:46 PM, Nick Coghlan wrote:
On Thu, May 17, 2012 at 2:44 PM, Nick Coghlan <ncoghlan@gmail.com> wrote:
In the absence of any -1 votes, I'll get Daniel to send his public key through to the hgaccounts address. I'll still watch his commits and remind him that getting patches reviewed on the tracker first is still often the preferred approach, even for committers.
On reflection, I decided to instead extend Daniel an offer that he could add me to the nosy list on any issues he was working on and I'd take a look.
An explicit offer to review any patches he submits seems like a sensible interim step prior to granting him direct push access.
Probably a bit less scary for him as well, we might hope. I know I am in trepidation of even looking at the codebase when I consider the chops of those who wrote most of it. He's going to make it!
regards Steve
PS: Will be leaving committers as soon as I find out how, but not for any other reason than bandwisth. I hope you all know where to find me if you need me. Devs-keep-devving. As you were.
Steve Holden steve@holdenweb.com, Holden Web, LLC http://holdenweb.com/ Python classes (and much more) through the web http://oreillyschool.com/ Conferences and technical event management at http://theopenbastion.com/ Next: Open Django Central Jun 8-9: http://opendjango.com/central/
On Tue, May 29, 2012 at 11:51 PM, Steve Holden <steve@holdenweb.com> wrote:
On May 29, 2012, at 11:46 PM, Nick Coghlan wrote:
On Thu, May 17, 2012 at 2:44 PM, Nick Coghlan <ncoghlan@gmail.com> wrote:
In the absence of any -1 votes, I'll get Daniel to send his public key
through to the hgaccounts address. I'll still watch his commits and
remind him that getting patches reviewed on the tracker first is still
often the preferred approach, even for committers.
On reflection, I decided to instead extend Daniel an offer that he could add me to the nosy list on any issues he was working on and I'd take a look.
An explicit offer to review any patches he submits seems like a sensible interim step prior to granting him direct push access.
Probably a bit less scary for him as well, we might hope. I know I am in trepidation of even looking at the codebase when I consider the chops of those who wrote most of it. He's going to make it!
regards Steve
PS: Will be leaving committers as soon as I find out how, but not for any other reason than bandwisth. I hope you all know where to find me if you need me. Devs-keep-devving. As you were.
I just unsubscribed you, Steve.
-Brett
-- Steve Holden steve@holdenweb.com, Holden Web, LLC http://holdenweb.com/ Python classes (and much more) through the web http://oreillyschool.com/ Conferences and technical event management at http://theopenbastion.com/ Next: Open Django Central Jun 8-9: http://opendjango.com/central/
python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
Is any one person in the dev community anxious to represent that community in the (hopefully forthcoming) "new new python.org" development. Probably a good time to talk about that, as the RFP is open.
I think I'd give bonus marks to anyone who offered (as one of the alternative styles) Jost's random multi-logoed blue designs, which I suspect might be a fond choice occasionally for some old-timers such as myself. No reason why history must be forgotten. We aren't the State Department.
regards Steve
PS: feel free to move to python-dev, where I no longer lurk.
On May 29, 2012, at 11:46 PM, Nick Coghlan wrote:
On Thu, May 17, 2012 at 2:44 PM, Nick Coghlan <ncoghlan@gmail.com> wrote:
In the absence of any -1 votes, I'll get Daniel to send his public key through to the hgaccounts address. I'll still watch his commits and remind him that getting patches reviewed on the tracker first is still often the preferred approach, even for committers.
On reflection, I decided to instead extend Daniel an offer that he could add me to the nosy list on any issues he was working on and I'd take a look.
An explicit offer to review any patches he submits seems like a sensible interim step prior to granting him direct push access.
Cheers, Nick.
-- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
-- Steve Holden steve@holdenweb.com, Holden Web, LLC http://holdenweb.com/ Python classes (and much more) through the web http://oreillyschool.com/ Conferences and technical event management at http://theopenbastion.com/ Next: Open Django Central Jun 8-9: http://opendjango.com/central/
On Wed, May 30, 2012 at 1:57 PM, Steve Holden <steve@holdenweb.com> wrote:
Is any one person in the dev community anxious to represent that community in the (hopefully forthcoming) "new new python.org" development. Probably a good time to talk about that, as the RFP is open.
I'd be happy to do it if nobody else volunteers. Maybe we can get some RSS feeds hooked up in appropriate places :)
Cheers, Nick.
-- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
In article <CADiSq7eqEUibMFvKjeCvH_CjvfUbd7kWKSzxG9dgUVpOxM=bTg@mail.gmail.com>, Nick Coghlan <ncoghlan@gmail.com> wrote:
On Wed, May 30, 2012 at 1:57 PM, Steve Holden <steve@holdenweb.com> wrote:
Is any one person in the dev community anxious to represent that community in the (hopefully forthcoming) "new new python.org" development. Probably a good time to talk about that, as the RFP is open.
I'd be happy to do it if nobody else volunteers. Maybe we can get some RSS feeds hooked up in appropriate places :)
It would be good to ensure that someone with recent experience managing Python releases is included in the process since the release managers are major content producers for python.org (i.e. the current /downloads section including release pages) and have their own particular needs for working with the web site..
-- Ned Deily, nad@acm.org
On May 30, 2012, at 9:14 PM, Ned Deily <nad@acm.org> wrote:
In article <CADiSq7eqEUibMFvKjeCvH_CjvfUbd7kWKSzxG9dgUVpOxM=bTg@mail.gmail.com>, Nick Coghlan <ncoghlan@gmail.com> wrote:
On Wed, May 30, 2012 at 1:57 PM, Steve Holden <steve@holdenweb.com> wrote:
Is any one person in the dev community anxious to represent that community in the (hopefully forthcoming) "new new python.org" development. Probably a good time to talk about that, as the RFP is open.
I'd be happy to do it if nobody else volunteers. Maybe we can get some RSS feeds hooked up in appropriate places :)
It would be good to ensure that someone with recent experience managing Python releases is included in the process since the release managers are major content producers for python.org (i.e. the current /downloads section including release pages) and have their own particular needs for working with the web site..
Please take a look at the RFP. It doesn't look to change the download manager process, and in fact forces an offline working/contributor mode so this workflow can stay close to what it is today.
In article <6ECDA7A0-E4CE-4EF9-BD14-0AC81F6DE17E@gmail.com>, Jesse Noller <jnoller@gmail.com> wrote:
In article <CADiSq7eqEUibMFvKjeCvH_CjvfUbd7kWKSzxG9dgUVpOxM=bTg@mail.gmail.com>, Nick Coghlan <ncoghlan@gmail.com> wrote:
On Wed, May 30, 2012 at 1:57 PM, Steve Holden <steve@holdenweb.com> wrote:
Is any one person in the dev community anxious to represent that community in the (hopefully forthcoming) "new new python.org" development. Probably a good time to talk about that, as the RFP is open.
I'd be happy to do it if nobody else volunteers. Maybe we can get some RSS feeds hooked up in appropriate places :)
It would be good to ensure that someone with recent experience managing Python releases is included in the process since the release managers are major content producers for python.org (i.e. the current /downloads section including release pages) and have their own particular needs for working with the web site.. Please take a look at the RFP. It doesn't look to change the download manager
On May 30, 2012, at 9:14 PM, Ned Deily <nad@acm.org> wrote: process, and in fact forces an offline working/contributor mode so this workflow can stay close to what it is today.
Jesse, I had read it and I think it's a good RFP. Kudos to all involved. My point was to address Steve's request for "any one person in the dev community". It seemed to me that the release managers are one of the most important content producers today on the web site so perhaps one of them should be considered as that representative. But perhaps I misunderstand what Steve was suggesting.
-- Ned Deily, nad@acm.org
On Thu, May 31, 2012 at 12:20 PM, Ned Deily <nad@acm.org> wrote:
Jesse, I had read it and I think it's a good RFP. Kudos to all involved. My point was to address Steve's request for "any one person in the dev community". It seemed to me that the release managers are one of the most important content producers today on the web site so perhaps one of them should be considered as that representative. But perhaps I misunderstand what Steve was suggesting.
I took the point to be having someone involved that can raise a red flag if something starts looking like a problem from the dev side and suggest things like "we should ask for the RMs feedback on this particular aspect". No need to have a large group involved every step of the way, but worth having a sufficiently broad range of viewpoints that most potential issues can be identified early before they have a chance to become real problems.
Cheers, Nick.
-- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
On May 30, 2012, at 10:56 PM, Nick Coghlan <ncoghlan@gmail.com> wrote:
On Thu, May 31, 2012 at 12:20 PM, Ned Deily <nad@acm.org> wrote:
Jesse, I had read it and I think it's a good RFP. Kudos to all involved. My point was to address Steve's request for "any one person in the dev community". It seemed to me that the release managers are one of the most important content producers today on the web site so perhaps one of them should be considered as that representative. But perhaps I misunderstand what Steve was suggesting.
I took the point to be having someone involved that can raise a red flag if something starts looking like a problem from the dev side and suggest things like "we should ask for the RMs feedback on this particular aspect". No need to have a large group involved every step of the way, but worth having a sufficiently broad range of viewpoints that most potential issues can be identified early before they have a chance to become real problems.
Cheers, Nick.
If you aren't subbed already I'll add you today
-- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
participants (9)
-
Antoine Pitrou -
Brett Cannon -
Jesse Noller -
martin＠v.loewis.de -
Ned Deily -
Nick Coghlan -
R. David Murray -
Senthil Kumaran -
Steve Holden