Mailman 3 July 2000 - Python-Dev

sysconfig/SRE bug
by A.M. Kuchling July 1, 2000

July 1, 2000

sysconfig.py contains a pattern that breaks SRE: >>> import re, pre >>> pre.compile(r"\${([A-Za-z][A-Za-z0-9_]*)}") <pre.RegexObject instance at 0x827a394> >>> re.compile(r"\${([A-Za-z][A-Za-z0-9_]*)}") Traceback (most recent call last): File "<stdin>", line 1, in ? File "/usr/lib/python2.0/sre.py", line 54, in compile return _compile(pattern, flags) ... File "/usr/lib/python2.0/sre_parse.py", line 538, in parse p = _parse(source, state) … [View More]

2 2

Hey! who changed sys.platform?!
by Greg Ward July 1, 2000

July 1, 2000

Curses! I just noticed that sys.platform in 1.6a2 (and the latest CVS from this morning) returns "linux2" on my PC, not "linux-i386". As I recall this decision is made in the configure script. Does anyone know why it changed? This is not the end of the world, but the OS name alone is not really enough on a multi-architecture OS... ...back to calling os.uname() myself, I guess. ;-( Greg -- Greg Ward - programmer-at-big gward(a)python.net http://starship.… [View More]

6 15

attribution? (was: CVS: python/dist/src/Objects unicodeobject.c,2.32,2.33)
by Greg Stein July 1, 2000

July 1, 2000

On Fri, Jun 30, 2000 at 07:58:23AM -0700, M.-A. Lemburg wrote: > Update of /cvsroot/python/python/dist/src/Objects > In directory slayer.i.sourceforge.net:/tmp/cvs-serv12549/Objects > > Modified Files: > unicodeobject.c > Log Message: > Marc-Andre Lemburg <mal(a)lemburg.com>: > A previous patch by Jack Jansen was accidently reverted. Is placing your email address into the log message really useful? After all, the checkin is already labeled as yours. I'm all … [View More]

2 1

Re: [Python-checkins] CVS: python/dist/src/Objects unicodeobject.c,2.31,2.32
by Sjoerd Mullender July 1, 2000

July 1, 2000

Why was the change that occurred in revision 2.31 reverted? Accident? The change log said: Jack Jansen: Use include "" instead of <>; and staticforward declarations On Fri, Jun 30 2000 "M.-A. Lemburg" wrote: > Update of /cvsroot/python/python/dist/src/Objects > In directory slayer.i.sourceforge.net:/tmp/cvs-serv25442/Objects > > Modified Files: > unicodeobject.c > Log Message: > Marc-Andre Lemburg <mal(a)lemburg.com>: > New buffer overflow checks for … [View More]formatting strings. > > By Trent Mick. > > Index: unicodeobject.c > =================================================================== > RCS file: /cvsroot/python/python/dist/src/Objects/unicodeobject.c,v > retrieving revision 2.31 > retrieving revision 2.32 > diff -C2 -r2.31 -r2.32 > *** unicodeobject.c 2000/06/29 00:06:39 2.31 > --- unicodeobject.c 2000/06/30 10:29:57 2.32 > *************** > *** 67,71 **** > #include "mymath.h" > #include "unicodeobject.h" > ! #include "ucnhash.h" > > #if defined(HAVE_LIMITS_H) > --- 67,71 ---- > #include "mymath.h" > #include "unicodeobject.h" > ! #include <ucnhash.h> > > #if defined(HAVE_LIMITS_H) > *************** > *** 1245,1249 **** > ucnFallthrough: > /* fall through on purpose */ > ! default: > *p++ = '\\'; > *p++ = (unsigned char)s[-1]; > --- 1245,1249 ---- > ucnFallthrough: > /* fall through on purpose */ > ! default: > *p++ = '\\'; > *p++ = (unsigned char)s[-1]; > *************** > *** 1252,1256 **** > } > if (_PyUnicode_Resize(v, (int)(p - buf))) > ! goto onError; > return (PyObject *)v; > > --- 1252,1256 ---- > } > if (_PyUnicode_Resize(v, (int)(p - buf))) > ! goto onError; > return (PyObject *)v; > > *************** > *** 4374,4377 **** > --- 4374,4378 ---- > static int > formatfloat(Py_UNICODE *buf, > + size_t buflen, > int flags, > int prec, > *************** > *** 4379,4382 **** > --- 4380,4385 ---- > PyObject *v) > { > + /* fmt = '%#.' + `prec` + `type` > + worst case length = 3 + 10 (len of INT_MAX) + 1 = 14 (use 20)*/ > char fmt[20]; > double x; > *************** > *** 4387,4395 **** > if (prec < 0) > prec = 6; > - if (prec > 50) > - prec = 50; /* Arbitrary limitation */ > if (type == 'f' && (fabs(x) / 1e25) >= 1e25) > type = 'g'; > sprintf(fmt, "%%%s.%d%c", (flags & F_ALT) ? "#" : "", prec, type); > return usprintf(buf, fmt, x); > } > --- 4390,4408 ---- > if (prec < 0) > prec = 6; > if (type == 'f' && (fabs(x) / 1e25) >= 1e25) > type = 'g'; > sprintf(fmt, "%%%s.%d%c", (flags & F_ALT) ? "#" : "", prec, type); > + /* worst case length calc to ensure no buffer overrun: > + fmt = %#.<prec>g > + buf = '-' + [0-9]*prec + '.' + 'e+' + (longest exp > + for any double rep.) > + len = 1 + prec + 1 + 2 + 5 = 9 + prec > + If prec=0 the effective precision is 1 (the leading digit is > + always given), therefore increase by one to 10+prec. */ > + if (buflen <= (size_t)10 + (size_t)prec) { > + PyErr_SetString(PyExc_OverflowError, > + "formatted float is too long (precision too long?)"); > + return -1; > + } > return usprintf(buf, fmt, x); > } > *************** > *** 4397,4400 **** > --- 4410,4414 ---- > static int > formatint(Py_UNICODE *buf, > + size_t buflen, > int flags, > int prec, > *************** > *** 4402,4405 **** > --- 4416,4421 ---- > PyObject *v) > { > + /* fmt = '%#.' + `prec` + 'l' + `type` > + worst case length = 3 + 10 (len of INT_MAX) + 1 + 1 = 15 (use 20)*/ > char fmt[20]; > long x; > *************** > *** 4410,4413 **** > --- 4426,4436 ---- > if (prec < 0) > prec = 1; > + /* buf = '+'/'-'/'0'/'0x' + '[0-9]'*max(prec,len(x in octal)) > + worst case buf = '0x' + [0-9]*prec, where prec >= 11 */ > + if (buflen <= 13 || buflen <= (size_t)2+(size_t)prec) { > + PyErr_SetString(PyExc_OverflowError, > + "formatted integer is too long (precision too long?)"); > + return -1; > + } > sprintf(fmt, "%%%s.%dl%c", (flags & F_ALT) ? "#" : "", prec, type); > return usprintf(buf, fmt, x); > *************** > *** 4416,4421 **** > static int > formatchar(Py_UNICODE *buf, > ! PyObject *v) > { > if (PyUnicode_Check(v)) { > if (PyUnicode_GET_SIZE(v) != 1) > --- 4439,4446 ---- > static int > formatchar(Py_UNICODE *buf, > ! size_t buflen, > ! PyObject *v) > { > + /* presume that the buffer is at least 2 characters long */ > if (PyUnicode_Check(v)) { > if (PyUnicode_GET_SIZE(v) != 1) > *************** > *** 4447,4450 **** > --- 4472,4485 ---- > } > > + /* fmt%(v1,v2,...) is roughly equivalent to sprintf(fmt, v1, v2, ...) > + > + FORMATBUFLEN is the length of the buffer in which the floats, ints, & > + chars are formatted. XXX This is a magic number. Each formatting > + routine does bounds checking to ensure no overflow, but a better > + solution may be to malloc a buffer of appropriate size for each > + format. For now, the current solution is sufficient. > + */ > + #define FORMATBUFLEN (size_t)120 > + > PyObject *PyUnicode_Format(PyObject *format, > PyObject *args) > *************** > *** 4506,4513 **** > PyObject *v = NULL; > PyObject *temp = NULL; > ! Py_UNICODE *buf; > Py_UNICODE sign; > int len; > ! Py_UNICODE tmpbuf[120]; /* For format{float,int,char}() */ > > fmt++; > --- 4541,4548 ---- > PyObject *v = NULL; > PyObject *temp = NULL; > ! Py_UNICODE *pbuf; > Py_UNICODE sign; > int len; > ! Py_UNICODE formatbuf[FORMATBUFLEN]; /* For format{float,int,char}() */ > > fmt++; > *************** > *** 4659,4664 **** > > case '%': > ! buf = tmpbuf; > ! buf[0] = '%'; > len = 1; > break; > --- 4694,4700 ---- > > case '%': > ! pbuf = formatbuf; > ! /* presume that buffer length is at least 1 */ > ! pbuf[0] = '%'; > len = 1; > break; > *************** > *** 4696,4700 **** > goto onError; > } > ! buf = PyUnicode_AS_UNICODE(temp); > len = PyUnicode_GET_SIZE(temp); > if (prec >= 0 && len > prec) > --- 4732,4736 ---- > goto onError; > } > ! pbuf = PyUnicode_AS_UNICODE(temp); > len = PyUnicode_GET_SIZE(temp); > if (prec >= 0 && len > prec) > *************** > *** 4710,4715 **** > if (c == 'i') > c = 'd'; > ! buf = tmpbuf; > ! len = formatint(buf, flags, prec, c, v); > if (len < 0) > goto onError; > --- 4746,4752 ---- > if (c == 'i') > c = 'd'; > ! pbuf = formatbuf; > ! len = formatint(pbuf, sizeof(formatbuf)/sizeof(Py_UNICODE), > ! flags, prec, c, v); > if (len < 0) > goto onError; > *************** > *** 4719,4725 **** > if ((flags&F_ALT) && > (c == 'x' || c == 'X') && > ! buf[0] == '0' && buf[1] == c) { > ! *res++ = *buf++; > ! *res++ = *buf++; > rescnt -= 2; > len -= 2; > --- 4756,4762 ---- > if ((flags&F_ALT) && > (c == 'x' || c == 'X') && > ! pbuf[0] == '0' && pbuf[1] == c) { > ! *res++ = *pbuf++; > ! *res++ = *pbuf++; > rescnt -= 2; > len -= 2; > *************** > *** 4736,4741 **** > case 'g': > case 'G': > ! buf = tmpbuf; > ! len = formatfloat(buf, flags, prec, c, v); > if (len < 0) > goto onError; > --- 4773,4779 ---- > case 'g': > case 'G': > ! pbuf = formatbuf; > ! len = formatfloat(pbuf, sizeof(formatbuf)/sizeof(Py_UNICODE), > ! flags, prec, c, v); > if (len < 0) > goto onError; > *************** > *** 4746,4751 **** > > case 'c': > ! buf = tmpbuf; > ! len = formatchar(buf, v); > if (len < 0) > goto onError; > --- 4784,4789 ---- > > case 'c': > ! pbuf = formatbuf; > ! len = formatchar(pbuf, sizeof(formatbuf)/sizeof(Py_UNICODE), v); > if (len < 0) > goto onError; > *************** > *** 4759,4764 **** > } > if (sign) { > ! if (*buf == '-' || *buf == '+') { > ! sign = *buf++; > len--; > } > --- 4797,4802 ---- > } > if (sign) { > ! if (*pbuf == '-' || *pbuf == '+') { > ! sign = *pbuf++; len--; > } > *************** > *** 4796,4800 **** > if (sign && fill == ' ') > *res++ = sign; > ! memcpy(res, buf, len * sizeof(Py_UNICODE)); > res += len; > rescnt -= len; > --- 4834,4838 ---- > if (sign && fill == ' ') > *res++ = sign; > ! memcpy(res, pbuf, len * sizeof(Py_UNICODE)); > res += len; > rescnt -= len; > > -- Sjoerd Mullender <sjoerd.mullender(a)oratrix.com> [View Less]

3 3

Re: [Python-checkins] CVS: python/dist/src/Lib/xml/sax __init__.py,NONE,1.1
by Greg Stein July 1, 2000

July 1, 2000

Do you really want to import that many items into the xml.sax module? IMO, be specific on what is imported into xml.sax for *convenience*. Don't just import the world. Also note that the import for SAXParseException is redundant. Cheers, -g On Thu, Jun 29, 2000 at 12:33:45PM -0700, Fred L. Drake wrote: > Update of /cvsroot/python/python/dist/src/Lib/xml/sax > In directory slayer.i.sourceforge.net:/tmp/cvs-serv5045 > > Added Files: > __init__.py > Log Message: > > … [View More]

1 0

New PythonLabs site revealed!
by Guido van Rossum July 1, 2000

July 1, 2000

Today, without much fanfare, we opened the new PythonLabs website. The design is by BeOpen's creative Director, Jun Simmons. Thanks to Jeremy Hylton, who did most of the actual HTML editing to get our contents in place. The new beta will be released via this site. And since you python-dev folks will find this out through my checkins anyway, let this be an advance warning that it will be called Python 2.0. Here's my explanation for the version bump (soon to be checked in to README): """ … [View More]

11 14

Python for Windows extensions updated for Python 2.0
by Mark Hammond June 30, 2000

June 30, 2000

Hi all, FYI - Ive just finished checking into CVS all the changes necessary for Python 2.0. So if you update the complete Python tree from sourceforge and the Win32 extensions trees from pythonpros, you should get successful builds of everything. I recommend that you seek-and-destroy Py*16* on your machine - this will ensure that if you have missed any extension modules, you get a nice "Python16.dll not found", rather than the thread-state crash that happens if that DLL does indeed still exist. Mark.

1 0

Idle breakage
by Neil Schemenauer June 30, 2000

June 30, 2000

Caused by _sre perhaps? $ python Tools/idle/idle.py Traceback (most recent call last): File "Tools/idle/idle.py", line 8, in ? IdleConf.load(idle_dir) File "Tools/idle/IdleConf.py", line 109, in load idleconf.read((os.path.join(dir, "config.txt"), genplatfile, platfile, File "/usr/local/lib/python2.0/ConfigParser.py", line 207, in read self.__read(fp, filename) File "/usr/local/lib/python2.0/ConfigParser.py", line 382, in __read raise e ConfigParser.ParsingError: File … [View More]

5 13

test_array failure on AIX
by Vladimir.Marangozov＠inrialpes.fr June 30, 2000

June 30, 2000

Any advice as to where I should look at and/or how to try fixing this? ~/python/CVS> ./python Lib/test/test_array.py **************************************** array after append: array('c', 'c') char array with 10 bytes of TESTFN appended: array('c', 'cThe quick ') char array with list appended: array('c', 'cThe quick abc') array of c after inserting another: array('c', 'ccThe quick abc') array of c converted to a list: ['c', 'c', 'T', 'h', 'e', ' ', 'q', 'u', 'i', 'c', 'k', ' ', 'a', '… [View More]

2 2

Windows build issues
by Neil Schemenauer June 30, 2000

June 30, 2000

A couple of things: PCbuild/readme.txt Should be updated for the new release. PC/config.h VC++ 5.0 will not compile python20 unless "#include <basetsd.h>" is commented out. Trent? WITH_CYCLE_GC should be uncommented if we want to have GC enabled in the beta. PCbuild/python20.dsp Line endings seem to be incorrect. Someone probably edited the file on a Unix machine and munched things up. VC++ 5.0 likes DOS line endings otherwise it refuses to load … [View More]

4 3