Mailman 3 May 2007 - Python-Dev

Strange behaviour with PyEval_EvalCode
by Joe Eagar 13 May '07

13 May '07

Hi I'm getting extremely odd behavior. First of all, why isn't PyEval_EvalCode documented anywhere? Anyway, I'm working on blender's python integration (it embeds python, as opposed to python embedding it). I have a function that executes a string buffer of python code, fetches a function from its global dictionary then calls it. When the function code returns a local variable, PyObject_Call() appears to be returning garbage. Strangely this is only happening with internal blender types, yet try however I might I can't find any refcounting errors to account for this. However adding an extra incref to a blender type creation function did appear to fix things and consistently return an object with reference count 1. The initial implementation used the same dictionary for the global and local dicts. I tried using separate dicts, but then the function wasn't being called at all (or at least I tested it by putting a "print "bleh"" in there, and it didn't work). Also, when I printed the refcount of the garbage data, it was garbage as well (so the entire piece of memory is bad, not just the data portion). Even more odd, the refcount of printing returned internal python types (which appears to otherwise work) steadily increase after each function call, despite being supposedly different objects. I'm not decrefing the variable in my debug versions, but nonetheless I would expect each consecutive execution of the function to return new objects with reference 1. I've tested with both python 2.4 and 2.5. Mostly with 2.4. This bug may be cropping up in other experimental blender python code as well. Here's the code in the string buffer: #BPYCONSTRAINT from Blender import * from Blender.Mathutils import * print "d" def doConstraint(inmat, tarmat, prop): a = Matrix() a.identity() a = a * TranslationMatrix(Vector(0, 0, 0)) print "t" a = tarmat return inmat print doConstraint(Matrix(), Matrix(), 0) Here's the code that executes the string buffer: PyObject *RunPython2( Text * text, PyObject * globaldict, PyObject *localdict ) { char *buf = NULL; /* The script text is compiled to Python bytecode and saved at text->compiled * to speed-up execution if the user executes the script multiple times */ if( !text->compiled ) { // if it wasn't already compiled, do it now buf = txt_to_buf( text ); text->compiled = Py_CompileString( buf, GetName( text ), Py_file_input ); MEM_freeN( buf ); if( PyErr_Occurred( ) ) { BPY_free_compiled_text( text ); return NULL; } } return PyEval_EvalCode( text->compiled, globaldict, localdict ); } . . .and heres the (rather long, and somewhat in a debugging state) function that calls the function in the script's global dictionary: void BPY_pyconstraint_eval(bPythonConstraint *con, float obmat[][4], short ownertype, void *ownerdata, float targetmat[][4]) { PyObject *srcmat, *tarmat, *idprop; PyObject *globals, *locals; PyObject *gkey, *gval; PyObject *retval; MatrixObject *retmat; Py_ssize_t ppos = 0; int row, col; if ( !con->text ) return; globals = CreateGlobalDictionary(); srcmat = newMatrixObject( (float*)obmat, 4, 4, Py_NEW ); tarmat = newMatrixObject( (float*)targetmat, 4, 4, Py_NEW ); idprop = BPy_Wrap_IDProperty( NULL, &con->prop, NULL); /* since I can't remember what the armature weakrefs do, I'll just leave this here commented out. Since this function was based on pydrivers. if( !setup_armature_weakrefs()){ fprintf( stderr, "Oops - weakref dict setup\n"); return result; } */ retval = RunPython2( con->text, globals, globals); if (retval) {Py_XDECREF( retval );} if ( retval == NULL ) { BPY_Err_Handle(con->text->id.name); ReleaseGlobalDictionary( globals ); /*free temp objects*/ Py_XDECREF( idprop ); Py_XDECREF( srcmat ); Py_XDECREF( tarmat ); return; } /*Now for the fun part! Try and find the functions we need.*/ while ( PyDict_Next(globals, &ppos, &gkey, &gval) ) { if ( PyString_Check(gkey) && strcmp(PyString_AsString(gkey), "doConstraint")==0 ) { if (PyFunction_Check(gval) ) { retval = PyObject_CallObject(gval, Py_BuildValue("OOO", srcmat, tarmat, idprop)); Py_XDECREF( retval ); } else { printf("ERROR: doConstraint is supposed to be a function!\n"); } break; } } if (!retval) { BPY_Err_Handle(con->text->id.name); /*free temp objects*/ ReleaseGlobalDictionary( globals ); Py_XDECREF( idprop ); Py_XDECREF( srcmat ); Py_XDECREF( tarmat ); return; } if (!PyObject_TypeCheck(retval, &matrix_Type)) { printf("Error in pyconstraint: Wrong return type for a pyconstraint!\n"); ReleaseGlobalDictionary( globals ); Py_XDECREF( idprop ); Py_XDECREF( srcmat ); Py_XDECREF( tarmat ); Py_XDECREF( retval ); return; } retmat = (MatrixObject*) retval; if (retmat->rowSize != 4 || retmat->colSize != 4) { printf("Error in pyconstraint: Matrix is the wrong size!\n"); ReleaseGlobalDictionary( globals ); Py_XDECREF( idprop ); Py_XDECREF( srcmat ); Py_XDECREF( tarmat ); Py_XDECREF( retval ); return; } //this is the reverse of code taken from newMatrix(). for(row = 0; row < 4; row++) { for(col = 0; col < 4; col++) { if (retmat->wrapped) obmat[row][col] = retmat->data.blend_data[row*4+col]; //[row][col]; else obmat[row][col] = retmat->data.py_data[row*4+col]; //[row][col]; } } /*clear globals*/ //ReleaseGlobalDictionary( globals ); /*free temp objects*/ //Py_XDECREF( idprop ); //Py_XDECREF( srcmat ); //Py_XDECREF( tarmat ); //Py_XDECREF( retval ); //PyDict_Clear(locals); //Py_XDECREF(locals); } Joe

1 1

Strange behaviour with PyEval_EvalCode
by Joe Eagar 13 May '07

13 May '07

Hi I'm getting extremely odd behavior. First of all, why isn't PyEval_EvalCode documented anywhere? Anyway, I'm working on blender's python integration (it embeds python, as opposed to python embedding it). I have a function that executes a string buffer of python code, fetches a function from its global dictionary then calls it. When the function code returns a local variable, PyObject_Call() appears to be returning garbage. Strangely this is only happening with internal blender types, yet try however I might I can't find any refcounting errors to account for this. The initial implementation used the same dictionary for the global and local dicts. I tried using separate dicts, but then the function wasn't being called at all (or at least I tested it by putting a "print "bleh"" in there, and it didn't work). Also, when I printed the refcount of the garbage data, it was garbage as well (so the entire piece of memory is bad, not just the data portion). I've tested with both python 2.4 and 2.5. Mostly with 2.4. This bug may be cropping up in other experimental blender python code as well. Here's the code in the string buffer: #BPYCONSTRAINT from Blender import * from Blender.Mathutils import * print "d" def doConstraint(inmat, tarmat, prop): a = Matrix() a.identity() a = a * TranslationMatrix(Vector(0, 0, 0)) print "t" a = tarmat return inmat print doConstraint(Matrix(), Matrix(), 0) Here's the code that executes the string buffer: PyObject *RunPython2( Text * text, PyObject * globaldict, PyObject *localdict ) { char *buf = NULL; /* The script text is compiled to Python bytecode and saved at text->compiled * to speed-up execution if the user executes the script multiple times */ if( !text->compiled ) { // if it wasn't already compiled, do it now buf = txt_to_buf( text ); text->compiled = Py_CompileString( buf, GetName( text ), Py_file_input ); MEM_freeN( buf ); if( PyErr_Occurred( ) ) { BPY_free_compiled_text( text ); return NULL; } } return PyEval_EvalCode( text->compiled, globaldict, localdict ); } . . .and heres the (rather long, and somewhat in a debugging state) function that calls the function in the script's global dictionary: void BPY_pyconstraint_eval(bPythonConstraint *con, float obmat[][4], short ownertype, void *ownerdata, float targetmat[][4]) { PyObject *srcmat, *tarmat, *idprop; PyObject *globals, *locals; PyObject *gkey, *gval; PyObject *retval; MatrixObject *retmat; Py_ssize_t ppos = 0; int row, col; if ( !con->text ) return; globals = CreateGlobalDictionary(); srcmat = newMatrixObject( (float*)obmat, 4, 4, Py_NEW ); tarmat = newMatrixObject( (float*)targetmat, 4, 4, Py_NEW ); idprop = BPy_Wrap_IDProperty( NULL, &con->prop, NULL); /* since I can't remember what the armature weakrefs do, I'll just leave this here commented out. Since this function was based on pydrivers. if( !setup_armature_weakrefs()){ fprintf( stderr, "Oops - weakref dict setup\n"); return result; } */ retval = RunPython2( con->text, globals, globals); if (retval) {Py_XDECREF( retval );} if ( retval == NULL ) { BPY_Err_Handle(con->text->id.name); ReleaseGlobalDictionary( globals ); /*free temp objects*/ Py_XDECREF( idprop ); Py_XDECREF( srcmat ); Py_XDECREF( tarmat ); return; } /*Now for the fun part! Try and find the functions we need.*/ while ( PyDict_Next(globals, &ppos, &gkey, &gval) ) { if ( PyString_Check(gkey) && strcmp(PyString_AsString(gkey), "doConstraint")==0 ) { if (PyFunction_Check(gval) ) { retval = PyObject_CallObject(gval, Py_BuildValue("OOO", srcmat, tarmat, idprop)); Py_XDECREF( retval ); } else { printf("ERROR: doConstraint is supposed to be a function!\n"); } break; } } if (!retval) { BPY_Err_Handle(con->text->id.name); /*free temp objects*/ ReleaseGlobalDictionary( globals ); Py_XDECREF( idprop ); Py_XDECREF( srcmat ); Py_XDECREF( tarmat ); return; } if (!PyObject_TypeCheck(retval, &matrix_Type)) { printf("Error in pyconstraint: Wrong return type for a pyconstraint!\n"); ReleaseGlobalDictionary( globals ); Py_XDECREF( idprop ); Py_XDECREF( srcmat ); Py_XDECREF( tarmat ); Py_XDECREF( retval ); return; } retmat = (MatrixObject*) retval; if (retmat->rowSize != 4 || retmat->colSize != 4) { printf("Error in pyconstraint: Matrix is the wrong size!\n"); ReleaseGlobalDictionary( globals ); Py_XDECREF( idprop ); Py_XDECREF( srcmat ); Py_XDECREF( tarmat ); Py_XDECREF( retval ); return; } //this is the reverse of code taken from newMatrix(). for(row = 0; row < 4; row++) { for(col = 0; col < 4; col++) { if (retmat->wrapped) obmat[row][col] = retmat->data.blend_data[row*4+col]; //[row][col]; else obmat[row][col] = retmat->data.py_data[row*4+col]; //[row][col]; } } /*clear globals*/ //ReleaseGlobalDictionary( globals ); /*free temp objects*/ //Py_XDECREF( idprop ); //Py_XDECREF( srcmat ); //Py_XDECREF( tarmat ); //Py_XDECREF( retval ); //PyDict_Clear(locals); //Py_XDECREF(locals); } Joe

3 2

generators and with
by tomer filiba 13 May '07

13 May '07

why not add __enter__ and __exit__ to generator objects? it's really a trivial addition: __enter__ returns self, __exit__ calls close(). it would be used to ensure close() is called when the generator is disposed, instead of doing that manually. typical usage would be: with mygenerator() as g: g.next() bar = g.send("foo") -tomer

3 2

Re: [Python-Dev] New operations in Decimal
by Raymond Hettinger 12 May '07

12 May '07

| > Am I losing my marbles, or is this a proposal to add the logical | > operations to FLOATING-POINT? | | Sort of. This is a proposal to keep compliant with the General Decimal | Arithmetic Specification, as we promised. | | http://www2.hursley.ibm.com/decimal/ > I oppose adding this illogical nonsense to Python. Who would ever use it? Doesn't matter. What is more important is that we provide a module that is fully compliant with the specification and passes all of its tests. The value is in the compliance, not in the relative value of individual parts of the spec. This is somewhat akin to modules supporting RFC specs or internet protocols. It is more important to be standard than it is to pick and choose the parts you like. The same is true of writing ANSI spec compilers -- you write to the spec, not to the language you wish had been adopted. While I question the sanity of the spec writers in this case, I do trust that overall, they have provided an extremely well thought-out spec, have gone through extensive discussion/feedback cycles, and have provided a thorough test-suite. It is as good as it gets. Raymond Hettinger

5 6

Re: [Python-Dev] New operations in Decimal
by Nick Maclaren 10 May '07

10 May '07

Ronald Oussoren <ronaldoussoren(a)mac.com> wrote: > On 27 Apr, 2007, at 20:39, Facundo Batista wrote: > > > - and (and), or (or), xor (xor) [CD]: Takes two logical operands, the > > result is the logical operation applied between each digit. > > "and" and "or" are keywords, you can't have methods with those names: Am I losing my marbles, or is this a proposal to add the logical operations to FLOATING-POINT? I may have missed a previous posting, in which case I apologise, but this is truly mind-boggling. Regards, Nick Maclaren, University of Cambridge Computing Service, New Museums Site, Pembroke Street, Cambridge CB2 3QH, England. Email: nmm1(a)cam.ac.uk Tel.: +44 1223 334761 Fax: +44 1223 334679

3 2

Hard-to-find problem with set().test_c_api()
by Guido van Rossum 10 May '07

10 May '07

Could anyone help me debug the following? This is in a debug build of the trunk. I've been banging my head against the wrong wall for too long to "see" the issue here... :-( $ ./python -S -c "set('abc').test_c_api()" [6872 refs] Fatal Python error: ../Objects/stringobject.c:4971 object at 0xb7f66ca0 has negative ref count -606348326 Aborted -- --Guido van Rossum (home page: http://www.python.org/~guido/)

1 1

Strange behaviour with PyEval_EvalCode
by Joe Eagar 10 May '07

10 May '07

[I'm re-sending this message cause it might've gotten lost; sorry if it ends up posting twice] Hi I'm getting extremely odd behavior. First of all, why isn't PyEval_EvalCode documented anywhere? Anyway, I'm working on blender's python integration (it embeds python, as opposed to python embedding it). I have a function that executes a string buffer of python code, fetches a function from its global dictionary then calls it. When the function code returns a local variable, PyObject_Call() appears to be returning garbage. The initial implementation used the same dictionary for the global and local dicts. I tried using separate dicts, but then the function wasn't being called at all (or at least I tested it by putting a "print "bleh"" in there, and it didn't work). I've tested with both python 2.4 and 2.5. Mostly with 2.4. This bug may be cropping up in other experimental blender python code as well. Here's the code in the string buffer: #BPYCONSTRAINT from Blender import * from Blender.Mathutils import * print "d" def doConstraint(inmat, tarmat, prop): a = Matrix() a.identity() a = a * TranslationMatrix(Vector(0, 0, 0)) print "t" a = tarmat return inmat print doConstraint(Matrix(), Matrix(), 0) Here's the code that executes the string buffer: PyObject *RunPython2( Text * text, PyObject * globaldict, PyObject *localdict ) { char *buf = NULL; /* The script text is compiled to Python bytecode and saved at text->compiled * to speed-up execution if the user executes the script multiple times */ if( !text->compiled ) { // if it wasn't already compiled, do it now buf = txt_to_buf( text ); text->compiled = Py_CompileString( buf, GetName( text ), Py_file_input ); MEM_freeN( buf ); if( PyErr_Occurred( ) ) { BPY_free_compiled_text( text ); return NULL; } } return PyEval_EvalCode( text->compiled, globaldict, localdict ); } . . .and heres the (rather long, and somewhat in a working state) function that calls the function in the script's global dictionary: void BPY_pyconstraint_eval(bPythonConstraint *con, float obmat[][4], short ownertype, void *ownerdata, float targetmat[][4]) { PyObject *srcmat, *tarmat, *idprop; PyObject *globals, *locals; PyObject *gkey, *gval; PyObject *retval; MatrixObject *retmat; Py_ssize_t ppos = 0; int row, col; if ( !con->text ) return; globals = CreateGlobalDictionary(); srcmat = newMatrixObject( (float*)obmat, 4, 4, Py_NEW ); tarmat = newMatrixObject( (float*)targetmat, 4, 4, Py_NEW ); idprop = BPy_Wrap_IDProperty( NULL, &con->prop, NULL); /* since I can't remember what the armature weakrefs do, I'll just leave this here commented out. Since this function was based on pydrivers. if( !setup_armature_weakrefs()){ fprintf( stderr, "Oops - weakref dict setup\n"); return result; } */ retval = RunPython2( con->text, globals, globals); if (retval) {Py_XDECREF( retval );} if ( retval == NULL ) { BPY_Err_Handle(con->text->id.name); ReleaseGlobalDictionary( globals ); /*free temp objects*/ Py_XDECREF( idprop ); Py_XDECREF( srcmat ); Py_XDECREF( tarmat ); return; } /*Now for the fun part! Try and find the functions we need.*/ while ( PyDict_Next(globals, &ppos, &gkey, &gval) ) { if ( PyString_Check(gkey) && strcmp(PyString_AsString(gkey), "doConstraint")==0 ) { if (PyFunction_Check(gval) ) { retval = PyObject_CallObject(gval, Py_BuildValue("OOO", srcmat, tarmat, idprop)); Py_XDECREF( retval ); } else { printf("ERROR: doConstraint is supposed to be a function!\n"); } break; } } if (!retval) { BPY_Err_Handle(con->text->id.name); /*free temp objects*/ ReleaseGlobalDictionary( globals ); Py_XDECREF( idprop ); Py_XDECREF( srcmat ); Py_XDECREF( tarmat ); return; } if (!PyObject_TypeCheck(retval, &matrix_Type)) { printf("Error in pyconstraint: Wrong return type for a pyconstraint!\n"); ReleaseGlobalDictionary( globals ); Py_XDECREF( idprop ); Py_XDECREF( srcmat ); Py_XDECREF( tarmat ); Py_XDECREF( retval ); return; } retmat = (MatrixObject*) retval; if (retmat->rowSize != 4 || retmat->colSize != 4) { printf("Error in pyconstraint: Matrix is the wrong size!\n"); ReleaseGlobalDictionary( globals ); Py_XDECREF( idprop ); Py_XDECREF( srcmat ); Py_XDECREF( tarmat ); Py_XDECREF( retval ); return; } //this is the reverse of code taken from newMatrix(). for(row = 0; row < 4; row++) { for(col = 0; col < 4; col++) { if (retmat->wrapped) obmat[row][col] = retmat->data.blend_data[row*4+col]; //[row][col]; else obmat[row][col] = retmat->data.py_data[row*4+col]; //[row][col]; } } /*clear globals*/ //ReleaseGlobalDictionary( globals ); /*free temp objects*/ //Py_XDECREF( idprop ); //Py_XDECREF( srcmat ); //Py_XDECREF( tarmat ); //Py_XDECREF( retval ); //PyDict_Clear(locals); //Py_XDECREF(locals); } Joe

1 0

\code or \constant in tex markup
by Neal Norwitz 10 May '07

10 May '07

Which is correct? $ egrep '(False|True)' Doc/lib/*.tex | grep -c \\constant{ 74 $ egrep '(False|True)' Doc/lib/*.tex | grep -c \\code{ 204 $ egrep 'None' Doc/lib/*.tex | grep -c \\code{ 512 $ egrep 'None' Doc/lib/*.tex | grep -c \\constant{ 83 n

2 1

Strange behaviour with PyEval_EvalCode
by Joe Eagar 10 May '07

10 May '07

[I'm re-sending this message cause it might've gotten lost; sorry if it ends up posting twice] Hi I'm getting extremely odd behavior. First of all, why isn't PyEval_EvalCode documented anywhere? Anyway, I'm working on blender's python integration (it embeds python, as opposed to python embedding it). I have a function that executes a string buffer of python code, fetches a function from its global dictionary then calls it. When the function code returns a local variable, PyObject_Call() appears to be returning garbage. The initial implementation used the same dictionary for the global and local dicts. I tried using separate dicts, but then the function wasn't being called at all (or at least I tested it by putting a "print "bleh"" in there, and it didn't work). I've tested with both python 2.4 and 2.5. Mostly with 2.4. This bug may be cropping up in other experimental blender python code as well. Here's the code in the string buffer: #BPYCONSTRAINT from Blender import * from Blender.Mathutils import * print "d" def doConstraint(inmat, tarmat, prop): a = Matrix() a.identity() a = a * TranslationMatrix(Vector(0, 0, 0)) print "t" a = tarmat return inmat print doConstraint(Matrix(), Matrix(), 0) Here's the code that executes the string buffer: PyObject *RunPython2( Text * text, PyObject * globaldict, PyObject *localdict ) { char *buf = NULL; /* The script text is compiled to Python bytecode and saved at text->compiled * to speed-up execution if the user executes the script multiple times */ if( !text->compiled ) { // if it wasn't already compiled, do it now buf = txt_to_buf( text ); text->compiled = Py_CompileString( buf, GetName( text ), Py_file_input ); MEM_freeN( buf ); if( PyErr_Occurred( ) ) { BPY_free_compiled_text( text ); return NULL; } } return PyEval_EvalCode( text->compiled, globaldict, localdict ); } . . .and heres the (rather long, and somewhat in a working state) function that calls the function in the script's global dictionary: void BPY_pyconstraint_eval(bPythonConstraint *con, float obmat[][4], short ownertype, void *ownerdata, float targetmat[][4]) { PyObject *srcmat, *tarmat, *idprop; PyObject *globals, *locals; PyObject *gkey, *gval; PyObject *retval; MatrixObject *retmat; Py_ssize_t ppos = 0; int row, col; if ( !con->text ) return; globals = CreateGlobalDictionary(); srcmat = newMatrixObject( (float*)obmat, 4, 4, Py_NEW ); tarmat = newMatrixObject( (float*)targetmat, 4, 4, Py_NEW ); idprop = BPy_Wrap_IDProperty( NULL, &con->prop, NULL); /* since I can't remember what the armature weakrefs do, I'll just leave this here commented out. Since this function was based on pydrivers. if( !setup_armature_weakrefs()){ fprintf( stderr, "Oops - weakref dict setup\n"); return result; } */ retval = RunPython2( con->text, globals, globals); if (retval) {Py_XDECREF( retval );} if ( retval == NULL ) { BPY_Err_Handle(con->text->id.name); ReleaseGlobalDictionary( globals ); /*free temp objects*/ Py_XDECREF( idprop ); Py_XDECREF( srcmat ); Py_XDECREF( tarmat ); return; } /*Now for the fun part! Try and find the functions we need.*/ while ( PyDict_Next(globals, &ppos, &gkey, &gval) ) { if ( PyString_Check(gkey) && strcmp(PyString_AsString(gkey), "doConstraint")==0 ) { if (PyFunction_Check(gval) ) { retval = PyObject_CallObject(gval, Py_BuildValue("OOO", srcmat, tarmat, idprop)); Py_XDECREF( retval ); } else { printf("ERROR: doConstraint is supposed to be a function!\n"); } break; } } if (!retval) { BPY_Err_Handle(con->text->id.name); /*free temp objects*/ ReleaseGlobalDictionary( globals ); Py_XDECREF( idprop ); Py_XDECREF( srcmat ); Py_XDECREF( tarmat ); return; } if (!PyObject_TypeCheck(retval, &matrix_Type)) { printf("Error in pyconstraint: Wrong return type for a pyconstraint!\n"); ReleaseGlobalDictionary( globals ); Py_XDECREF( idprop ); Py_XDECREF( srcmat ); Py_XDECREF( tarmat ); Py_XDECREF( retval ); return; } retmat = (MatrixObject*) retval; if (retmat->rowSize != 4 || retmat->colSize != 4) { printf("Error in pyconstraint: Matrix is the wrong size!\n"); ReleaseGlobalDictionary( globals ); Py_XDECREF( idprop ); Py_XDECREF( srcmat ); Py_XDECREF( tarmat ); Py_XDECREF( retval ); return; } //this is the reverse of code taken from newMatrix(). for(row = 0; row < 4; row++) { for(col = 0; col < 4; col++) { if (retmat->wrapped) obmat[row][col] = retmat->data.blend_data[row*4+col]; //[row][col]; else obmat[row][col] = retmat->data.py_data[row*4+col]; //[row][col]; } } /*clear globals*/ //ReleaseGlobalDictionary( globals ); /*free temp objects*/ //Py_XDECREF( idprop ); //Py_XDECREF( srcmat ); //Py_XDECREF( tarmat ); //Py_XDECREF( retval ); //PyDict_Clear(locals); //Py_XDECREF(locals); } Joe

1 0

Strange behaviour with PyEval_EvalCode
by Joe Eagar 10 May '07

10 May '07

Hi I'm getting extremely odd behavior. First of all, why isn't PyEval_EvalCode documented anywhere? Anyway, I'm working on blender's python integration (it embeds python, as opposed to python embedding it). I have a function that executes a string buffer of python code, fetches a function from its global dictionary then calls it. When the function code returns a local variable, PyObject_Call() appears to be returning garbage. The initial implementation used the same dictionary for the global and local dicts. I tried using separate dicts, but then the function wasn't being called at all (or at least I tested it by putting a "print "bleh"" in there, and it didn't work). I've tested with both python 2.4 and 2.5. Mostly with 2.4. This bug may be cropping up in other experimental blender python code as well. Here's the code in the string buffer: #BPYCONSTRAINT from Blender import * from Blender.Mathutils import * print "d" def doConstraint(inmat, tarmat, prop): a = Matrix() a.identity() a = a * TranslationMatrix(Vector(0, 0, 0)) print "t" a = tarmat return inmat print doConstraint(Matrix(), Matrix(), 0) Here's the code that executes the string buffer: PyObject *RunPython2( Text * text, PyObject * globaldict, PyObject *localdict ) { char *buf = NULL; /* The script text is compiled to Python bytecode and saved at text->compiled * to speed-up execution if the user executes the script multiple times */ if( !text->compiled ) { // if it wasn't already compiled, do it now buf = txt_to_buf( text ); text->compiled = Py_CompileString( buf, GetName( text ), Py_file_input ); MEM_freeN( buf ); if( PyErr_Occurred( ) ) { BPY_free_compiled_text( text ); return NULL; } } return PyEval_EvalCode( text->compiled, globaldict, localdict ); } . . .and heres the (rather long, and somewhat in a working state) function that calls the function in the script's global dictionary: void BPY_pyconstraint_eval(bPythonConstraint *con, float obmat[][4], short ownertype, void *ownerdata, float targetmat[][4]) { PyObject *srcmat, *tarmat, *idprop; PyObject *globals, *locals; PyObject *gkey, *gval; PyObject *retval; MatrixObject *retmat; Py_ssize_t ppos = 0; int row, col; if ( !con->text ) return; globals = CreateGlobalDictionary(); srcmat = newMatrixObject( (float*)obmat, 4, 4, Py_NEW ); tarmat = newMatrixObject( (float*)targetmat, 4, 4, Py_NEW ); idprop = BPy_Wrap_IDProperty( NULL, &con->prop, NULL); /* since I can't remember what the armature weakrefs do, I'll just leave this here commented out. Since this function was based on pydrivers. if( !setup_armature_weakrefs()){ fprintf( stderr, "Oops - weakref dict setup\n"); return result; } */ retval = RunPython2( con->text, globals, globals); if (retval) {Py_XDECREF( retval );} if ( retval == NULL ) { BPY_Err_Handle(con->text->id.name); ReleaseGlobalDictionary( globals ); /*free temp objects*/ Py_XDECREF( idprop ); Py_XDECREF( srcmat ); Py_XDECREF( tarmat ); return; } /*Now for the fun part! Try and find the functions we need.*/ while ( PyDict_Next(globals, &ppos, &gkey, &gval) ) { if ( PyString_Check(gkey) && strcmp(PyString_AsString(gkey), "doConstraint")==0 ) { if (PyFunction_Check(gval) ) { retval = PyObject_CallObject(gval, Py_BuildValue("OOO", srcmat, tarmat, idprop)); Py_XDECREF( retval ); } else { printf("ERROR: doConstraint is supposed to be a function!\n"); } break; } } if (!retval) { BPY_Err_Handle(con->text->id.name); /*free temp objects*/ ReleaseGlobalDictionary( globals ); Py_XDECREF( idprop ); Py_XDECREF( srcmat ); Py_XDECREF( tarmat ); return; } if (!PyObject_TypeCheck(retval, &matrix_Type)) { printf("Error in pyconstraint: Wrong return type for a pyconstraint!\n"); ReleaseGlobalDictionary( globals ); Py_XDECREF( idprop ); Py_XDECREF( srcmat ); Py_XDECREF( tarmat ); Py_XDECREF( retval ); return; } retmat = (MatrixObject*) retval; if (retmat->rowSize != 4 || retmat->colSize != 4) { printf("Error in pyconstraint: Matrix is the wrong size!\n"); ReleaseGlobalDictionary( globals ); Py_XDECREF( idprop ); Py_XDECREF( srcmat ); Py_XDECREF( tarmat ); Py_XDECREF( retval ); return; } //this is the reverse of code taken from newMatrix(). for(row = 0; row < 4; row++) { for(col = 0; col < 4; col++) { if (retmat->wrapped) obmat[row][col] = retmat->data.blend_data[row*4+col]; //[row][col]; else obmat[row][col] = retmat->data.py_data[row*4+col]; //[row][col]; } } /*clear globals*/ //ReleaseGlobalDictionary( globals ); /*free temp objects*/ //Py_XDECREF( idprop ); //Py_XDECREF( srcmat ); //Py_XDECREF( tarmat ); //Py_XDECREF( retval ); //PyDict_Clear(locals); //Py_XDECREF(locals); } Joe

1 0