Mailman 3 August 2010 - Python-Dev

Re: [Python-Dev] [Python-checkins] r83763 - in python/branches/py3k: Doc/library/signal.rst Lib/test/test_signal.py Misc/NEWS Modules/signalmodule.c
by Hirokazu Yamamoto Aug. 7, 2010

Aug. 7, 2010

This is the idea just popped up. :-) #define SIG(name) if (sig_num != SIG##name) SIG(ABRT) SIG(FPE) SIG(ILL) SIG(INT) SIG(SEGV) SIG(TERM) { PyErr_SetString(PyExc_ValueError, "signal number out of range"); return NULL; } #undef SIG

4 5

Re: [Python-Dev] [Python-checkins] r83778 - in python/branches/py3k/Lib/test: test_import.py test_sax.py test_sys.py test_urllib.py test_urllib2.py test_xml_etree.py
by Ezio Melotti Aug. 7, 2010

Aug. 7, 2010

Hi, On 07/08/2010 13.09, victor.stinner wrote: > Author: victor.stinner > Date: Sat Aug 7 12:09:35 2010 > New Revision: 83778 > > Log: > Issue #9425: skip tests if a filename is not encodable > > Modified: > python/branches/py3k/Lib/test/test_import.py > python/branches/py3k/Lib/test/test_sax.py > python/branches/py3k/Lib/test/test_sys.py > python/branches/py3k/Lib/test/test_urllib.py > python/branches/py3k/Lib/test/test_urllib2.py > python/branches/py3k/Lib/test/test_xml_etree.py > > Modified: python/branches/py3k/Lib/test/test_import.py > ============================================================================== > --- python/branches/py3k/Lib/test/test_import.py (original) > +++ python/branches/py3k/Lib/test/test_import.py Sat Aug 7 12:09:35 2010 > @@ -291,6 +291,11 @@ > > def test_import_by_filename(self): > path = os.path.abspath(TESTFN) > + encoding = sys.getfilesystemencoding() > + try: > + path.encode(encoding) > + except UnicodeEncodeError: > + self.skipTest('path is not encodable to {}'.format(encoding)) > with self.assertRaises(ImportError) as c: > __import__(path) > self.assertEqual("Import by filename is not supported.", > > Modified: python/branches/py3k/Lib/test/test_sax.py > ============================================================================== > --- python/branches/py3k/Lib/test/test_sax.py (original) > +++ python/branches/py3k/Lib/test/test_sax.py Sat Aug 7 12:09:35 2010 > @@ -18,6 +18,11 @@ > > TEST_XMLFILE = findfile("test.xml", subdir="xmltestdata") > TEST_XMLFILE_OUT = findfile("test.xml.out", subdir="xmltestdata") > +try: > + TEST_XMLFILE.encode("utf8") > + TEST_XMLFILE_OUT.encode("utf8") > +except UnicodeEncodeError: > + raise unittest.SkipTest("filename is not encodable to utf8") > > ns_uri = "http://www.python.org/xml-ns/saxtest/" > > > Modified: python/branches/py3k/Lib/test/test_sys.py > ============================================================================== > --- python/branches/py3k/Lib/test/test_sys.py (original) > +++ python/branches/py3k/Lib/test/test_sys.py Sat Aug 7 12:09:35 2010 > @@ -509,8 +509,10 @@ > p = subprocess.Popen([sys.executable, "-c", code], stderr=subprocess.PIPE) > stdout, stderr = p.communicate() > self.assertEqual(p.returncode, 1) > - self.assert_(b"UnicodeEncodeError:" in stderr, > - "%r not in %s" % (b"UniodeEncodeError:", ascii(stderr))) > + self.assertIn( > + br"UnicodeEncodeError: 'utf-8' codec can't encode character " > + br"'\udcff' in position 7: surrogates not allowed", > + stderr) This caused some failures in the buildbots: test test_sys failed -- Traceback (most recent call last): File "/home2/buildbot/slave/3.x.loewis-sun/build/Lib/test/test_sys.py", line 515, in test_main_invalid_unicode stderr) AssertionError: b"UnicodeEncodeError: 'utf-8' codec can't encode character '\\udcff' in position 7: surrogates not allowed" not found in b'Traceback (most recent call last):\n File "<string>", line 1, in<module>\nUnicodeEncodeError: \'ascii\' codec can\'t encode character \'\\xff\' in position 0: ordinal not in range(128)\n[32513 refs]\n' See http://www.python.org/dev/buildbot/all/builders/sparc%20solaris10%20gcc%203… > > def test_sys_flags(self): > self.assertTrue(sys.flags) > > Modified: python/branches/py3k/Lib/test/test_urllib.py > ============================================================================== > --- python/branches/py3k/Lib/test/test_urllib.py (original) > +++ python/branches/py3k/Lib/test/test_urllib.py Sat Aug 7 12:09:35 2010 > @@ -232,8 +232,12 @@ > except: pass > > def constructLocalFileUrl(self, filePath): > - return "file://%s" % urllib.request.pathname2url( > - os.path.abspath(filePath)) > + filePath = os.path.abspath(filePath) > + try: > + filePath.encode("utf8") > + except UnicodeEncodeError: > + raise unittest.SkipTest("filePath is not encodable to utf8") > + return "file://%s" % urllib.request.pathname2url(filePath) > > def createNewTempFile(self, data=b""): > """Creates a new temporary file containing the specified data, > > Modified: python/branches/py3k/Lib/test/test_urllib2.py > ============================================================================== > --- python/branches/py3k/Lib/test/test_urllib2.py (original) > +++ python/branches/py3k/Lib/test/test_urllib2.py Sat Aug 7 12:09:35 2010 > @@ -597,6 +597,10 @@ > > > def sanepathname2url(path): > + try: > + path.encode("utf8") > + except UnicodeEncodeError: > + raise unittest.SkipTest("path is not encodable to utf8") > urlpath = urllib.request.pathname2url(path) > if os.name == "nt" and urlpath.startswith("///"): > urlpath = urlpath[2:] > > Modified: python/branches/py3k/Lib/test/test_xml_etree.py > ============================================================================== > --- python/branches/py3k/Lib/test/test_xml_etree.py (original) > +++ python/branches/py3k/Lib/test/test_xml_etree.py Sat Aug 7 12:09:35 2010 > @@ -13,6 +13,7 @@ > > import sys > import cgi > +import unittest > > from test import support > from test.support import findfile > @@ -20,6 +21,10 @@ > from xml.etree import ElementTree as ET > > SIMPLE_XMLFILE = findfile("simple.xml", subdir="xmltestdata") > +try: > + SIMPLE_XMLFILE.encode("utf8") > +except UnicodeEncodeError: > + raise unittest.SkipTest("filename is not encodable to utf8") > SIMPLE_NS_XMLFILE = findfile("simple-ns.xml", subdir="xmltestdata") > > SAMPLE_XML = """\ > _______________________________________________ > Python-checkins mailing list > Python-checkins(a)python.org > http://mail.python.org/mailman/listinfo/python-checkins > Best Regards, Ezio Melotti

1 0

Re: [Python-Dev] [Python-checkins] r83763 - in python/branches/py3k: Doc/library/signal.rst Lib/test/test_signal.py Misc/NEWS Modules/signalmodule.c
by Ezio Melotti Aug. 7, 2010

Aug. 7, 2010

Hi, On 06/08/2010 22.27, brian.curtin wrote: > Author: brian.curtin > Date: Fri Aug 6 21:27:32 2010 > New Revision: 83763 > > Log: > Fix #9324: Add parameter validation to signal.signal on Windows in order > to prevent crashes. > > > Modified: > python/branches/py3k/Doc/library/signal.rst > python/branches/py3k/Lib/test/test_signal.py > python/branches/py3k/Misc/NEWS > python/branches/py3k/Modules/signalmodule.c > > Modified: python/branches/py3k/Doc/library/signal.rst > ============================================================================== > --- python/branches/py3k/Doc/library/signal.rst (original) > +++ python/branches/py3k/Doc/library/signal.rst Fri Aug 6 21:27:32 2010 > @@ -230,6 +230,10 @@ > see the :ref:`description in the type hierarchy<frame-objects>` or see the > attribute descriptions in the :mod:`inspect` module). > > + On Windows, :func:`signal` can only be called with :const:`SIGABRT`, > + :const:`SIGFPE`, :const:`SIGILL`, :const:`SIGINT`, :const:`SIGSEGV`, or > + :const:`SIGTERM`. A :exc:`ValueError` will be raised in any other case. > + > > .. _signal-example: > > > Modified: python/branches/py3k/Lib/test/test_signal.py > ============================================================================== > --- python/branches/py3k/Lib/test/test_signal.py (original) > +++ python/branches/py3k/Lib/test/test_signal.py Fri Aug 6 21:27:32 2010 > @@ -9,7 +9,7 @@ > import traceback > import sys, os, time, errno > > -if sys.platform[:3] in ('win', 'os2') or sys.platform == 'riscos': > +if sys.platform == 'os2' or sys.platform == 'riscos': > raise unittest.SkipTest("Can't test signal on %s" % \ > sys.platform) > > @@ -37,6 +37,7 @@ > return None > > > +(a)unittest.skipIf(sys.platform == "win32", "Not valid on Windows") In the previous chunk sys.platform[:3] was used instead of just sys.platform. Are there some other "winXX" platform that should be skipped too? > class InterProcessSignalTests(unittest.TestCase): > MAX_DURATION = 20 # Entire test should last at most 20 sec. > > @@ -186,6 +187,7 @@ > self.MAX_DURATION) > > > +(a)unittest.skipIf(sys.platform == "win32", "Not valid on Windows") > class BasicSignalTests(unittest.TestCase): > def trivial_signal_handler(self, *args): > pass > @@ -208,6 +210,23 @@ > self.assertEquals(signal.getsignal(signal.SIGHUP), hup) > > > +(a)unittest.skipUnless(sys.platform == "win32", "Windows specific") > +class WindowsSignalTests(unittest.TestCase): > + def test_issue9324(self): > + handler = lambda x, y: None > + signal.signal(signal.SIGABRT, handler) > + signal.signal(signal.SIGFPE, handler) > + signal.signal(signal.SIGILL, handler) > + signal.signal(signal.SIGINT, handler) > + signal.signal(signal.SIGSEGV, handler) > + signal.signal(signal.SIGTERM, handler) > + > + with self.assertRaises(ValueError): > + signal.signal(-1, handler) > + sinal.signal(7, handler) You should use two separate assertRaises here, otherwise the second line is not executed if the first one raises an error (and if the first doesn't raise an error but the second does the test will pass even if it shouldn't). This also masks the typo in the second line. > + > + > +(a)unittest.skipIf(sys.platform == "win32", "Not valid on Windows") > class WakeupSignalTests(unittest.TestCase): > TIMEOUT_FULL = 10 > TIMEOUT_HALF = 5 > @@ -253,14 +272,15 @@ > os.close(self.write) > signal.signal(signal.SIGALRM, self.alrm) > > +(a)unittest.skipIf(sys.platform == "win32", "Not valid on Windows") > class SiginterruptTest(unittest.TestCase): > - signum = signal.SIGUSR1 > > def setUp(self): > """Install a no-op signal handler that can be set to allow > interrupts or not, and arrange for the original signal handler to be > re-installed when the test is finished. > """ > + self.signum = signal.SIGUSR1 > oldhandler = signal.signal(self.signum, lambda x,y: None) > self.addCleanup(signal.signal, self.signum, oldhandler) > > @@ -354,7 +374,7 @@ > self.assertFalse(i) > > > - > +(a)unittest.skipIf(sys.platform == "win32", "Not valid on Windows") > class ItimerTest(unittest.TestCase): > def setUp(self): > self.hndl_called = False > @@ -463,8 +483,11 @@ > self.assertEqual(self.hndl_called, True) > > def test_main(): > - support.run_unittest(BasicSignalTests, InterProcessSignalTests, > - WakeupSignalTests, SiginterruptTest, ItimerTest) > + if sys.platform == "win32": > + support.run_unittest(WindowsSignalTests) > + else: > + support.run_unittest(BasicSignalTests, InterProcessSignalTests, > + WakeupSignalTests, SiginterruptTest, ItimerTest) Is this necessary? If the tests are marked with a skip decorator they will be skipped anyway (and also marked as skipped in the output). > > > if __name__ == "__main__": > > Modified: python/branches/py3k/Misc/NEWS > ============================================================================== > --- python/branches/py3k/Misc/NEWS (original) > +++ python/branches/py3k/Misc/NEWS Fri Aug 6 21:27:32 2010 > @@ -24,6 +24,9 @@ > Extensions > ---------- > > +- Issue #9324: Add parameter validation to signal.signal on Windows in order > + to prevent crashes. > + > - Issue #9526: Remove some outdated (int) casts that were preventing > the array module from working correctly with arrays of more than > 2**31 elements. > > Modified: python/branches/py3k/Modules/signalmodule.c > ============================================================================== > --- python/branches/py3k/Modules/signalmodule.c (original) > +++ python/branches/py3k/Modules/signalmodule.c Fri Aug 6 21:27:32 2010 > @@ -255,8 +255,23 @@ > int sig_num; > PyObject *old_handler; > void (*func)(int); > +#ifdef MS_WINDOWS > + int cur_sig, num_valid_sigs = 6; > + static int valid_sigs[] = {SIGABRT, SIGFPE, SIGILL, SIGINT, > + SIGSEGV, SIGTERM}; > + BOOL valid_sig = FALSE; > +#endif > if (!PyArg_ParseTuple(args, "iO:signal",&sig_num,&obj)) > return NULL; > +#ifdef MS_WINDOWS > + /* Validate that sig_num is one of the allowable signals */ > + for (cur_sig = 0; cur_sig< num_valid_sigs; cur_sig++) > + valid_sig |= (sig_num == valid_sigs[cur_sig]); > + if (!valid_sig) { > + PyErr_SetString(PyExc_ValueError, "signal number out of range"); > + return NULL; > + } > +#endif > #ifdef WITH_THREAD > if (PyThread_get_thread_ident() != main_thread) { > PyErr_SetString(PyExc_ValueError, > _______________________________________________ > Python-checkins mailing list > Python-checkins(a)python.org > http://mail.python.org/mailman/listinfo/python-checkins > Best Regards, Ezio Melotti

3 2

Re: [Python-Dev] [Python-checkins] r83763 - in python/branches/py3k: Doc/library/signal.rst Lib/test/test_signal.py Misc/NEWS Modules/signalmodule.c
by Hirokazu Yamamoto Aug. 7, 2010

Aug. 7, 2010

> + valid_sig |= (sig_num == valid_sigs[cur_sig]); I think ||= is more appropriate here.

1 0

(Windows) buildbots on 3.x
by Paul Moore Aug. 6, 2010

Aug. 6, 2010

On 3 August 2010 20:30, Barry Warsaw <barry(a)python.org> wrote: > Brian is looking at Windows now (the buildbots are > a sad and sorry story). There seems to be something distinctly wrong with the 3.x buildbots. A lot of test failures and timeouts. At first I assumed it was my buildslave going flaky (again :-() but it only affects the 3.x branch, and it seems to be hitting more than just my slave. From what I'm seeing, it's often test_io that's getting stalled and then sitting round until it times out. (But as I say, it's not obviously related to problems on my box as it's happening to others - see http://www.python.org/dev//buildbot/builders/x86%20XP-4%203.x/builds/2652 for example - and it's not happening on other branches). I haven't had time to look into it (and probably won't in the next few days) but it might be worth a look at some point if anyone has the time & inclination. Paul.

6 8

barry_as_FLUFL
by Jasper St. Pierre Aug. 5, 2010

Aug. 5, 2010

I was fooling around with Python 3.1 today, and I found this little nugget: >>> import __future__ >>> dir(__future__) ['CO_FUTURE_ABSOLUTE_IMPORT', 'CO_FUTURE_BARRY_AS_BDFL', 'CO_FUTURE_DIVISION', 'CO_FUTURE_PRINT_FUNCTION', 'CO_FUTURE_UNICODE_LITERALS', 'CO_FUTURE_WITH_STATEMENT', 'CO_GENERATOR_ALLOWED', 'CO_NESTED', '_Feature', '__all__', '__builtins__', '__doc__', '__file__', '__name__', '__package__', 'absolute_import', 'all_feature_names', 'barry_as_FLUFL', 'division', 'generators', 'nested_scopes', 'print_function', 'unicode_literals', 'with_statement'] hmm... BARRY_AS_BDFL and barry_as_FLUFL >>> from __future__ import barry_as_FLUFL >>> nothing noticable happened. I googled the latter, and found that it's an April Fools (of 2009!) checkin that was never reverted. http://mail.python.org/pipermail/python-checkins/2009-April/080796.html

8 7

Re: [Python-Dev] PEP 376 proposed changes for basic plugins support
by P.J. Eby Aug. 5, 2010

Aug. 5, 2010

At 02:03 AM 8/2/2010 +0200, Tarek Ziadé wrote: >but then we would be back to the problem mentioned about entry points: >installing projects can implicitly add a plugin and activate it, and break >existing applications that iterate over entry points without further >configuration. So being able to disable plugins from the beginning seems >important to me So which are these apps that don't allow configuration, and which are the plugins that break them? Have the issues been reported so that the authors can fix them? ISTM that the issue can only arise in cases where you are installing plugins to a *global* environment, rather than to an environment specific to the application. In the case of setuptools, for example, it's expected that a project will use 'setup_requires' to identify the plugins it wishes to use, apart from any that were intentionally installed globally. (The requested plugins are then added to sys.path only for the duration of the setup script execution.) Other applications have plugin directories where their plugins are to be installed, and still others have explicit configuration to enable named plugins. Even in the worst-case scenario, where an app has no plugin configuration and no private plugin directory, you can still control plugin availability by installing plugins to the directory where the application's main script is located, or point PYTHONPATH to point to a directory you've chosen to hold the plugins of your choice. So without specific examples of why this is a problem, it's hard to see why a special Python-specific set of configuration files is needed to resolve it, vs. say, encouraging application authors to use the available alternatives for doing plugin directories, config files, etc.

10 30

#2651 - KeyError does not round trip strings
by Łukasz Langa Aug. 5, 2010

Aug. 5, 2010

Hi guys, there's this 2 year old bug about making strings passed to KeyError round trip: http://bugs.python.org/issue2651 There are three things I like you to present opinions on. 0. The moratorium. Based on the old 2.x patch there I created a new one for py3k. It's been reviewed and it was actually quite close to it being committed when Georg reminded us that there's this moratorium situation. So, please -1 that change here or on the issue if you think it should be stopped until the moratorium ends. Georg, Antoine and Michael Foord seem to be +1 on it despite the moratorium. (guys, please correct me if I'm wrong) 1. The patch makes KeyError behave analogically to IOError so that the first arg is now a message and the second is the actual key. >>> raise KeyError("Key not found", "a Scotsman on a horse") Traceback (most recent call last): ... KeyError: 'Key not found: a Scotsman on a horse' This is backwards incompatible (which has been addressed for the stdlib in the patch). Now, for non-empty e.args, the key is stored in e.args[-1] whereas it used to in e.args[0]. We could swap the args to make it backwards compatible but then we lose consistency with IOError and the issue on the tracker was originally targetting consistency. 2. Some people suggest adding e.key to KeyError. I like the idea but in my opinion currently it is not implementable in a reliable way. a) if the party raising the exception does not pass any arguments, what would the expected behaviour of e.key be? `None` is a valid key so returning this can be misleading. b) if the party raising the exception passes one argument, how do we know it's a key and not a message? Take for instance "Set is empty" and such. Presenting e.key = "Set is empty" is just wrong. c) if the party raising the exception passes two arguments, we already know which one is the key. So in this case it would work well but at the same time it would be somewhat redundant. Antoine and Michael Foord suggest that we simply do a "best-effort thing" and present `None` if no args are passed and always treat the only argument as a key. It would be consistent with what's IOError is doing at the moment. I'm on the fence here myself. -- Best regards, Łukasz Langa tel. +48 791 080 144 WWW http://lukasz.langa.pl/

5 10

Windows
by Steve Holden Aug. 5, 2010

Aug. 5, 2010

It's a little disappointing to discover that despite the relatively large number of developers who have received MSDN licenses from Microsoft, none if us have the time to make sure that the buildbots are green for the 2.6.6 release. I wonder if anyone can think of a way we can get some Windows skillz into the group that could assist at ties like this. Some brainstorming might find a way through. regards Steve -- Steve Holden +1 571 484 6266 +1 800 494 3119 DjangoCon US September 7-9, 2010 http://djangocon.us/ See Python Video! http://python.mirocommunity.org/ Holden Web LLC http://www.holdenweb.com/

21 57

Drive suffix
by Rob Cliffe Aug. 5, 2010

Aug. 5, 2010

Is there a way of determining the suffix used after a drive letter to denote a drive, e.g. on Windows the ":" in r"C:\Dir\Subdir\File.Ext" ? Or is the colon so universal that it is considered unnecessary? Should it be in the os module somewhere (as far as I can tell, it isn't, although every other kind of file path component separator seems to be) ? Best wishes Rob Cliffe

9 9