Python-Dev January 2011

python-dev@python.org

100 participants
110 discussions

by "Martin v. Löwis"

I have been thinking about Unicode representation for some time now. This was triggered, on the one hand, by discussions with Glyph Lefkowitz (who complained that his server app consumes too much memory), and Carl Friedrich Bolz (who profiled Python applications to determine that Unicode strings are among the top consumers of memory in Python). On the other hand, this was triggered by the discussion on supporting surrogates in the library better. I'd like to propose PEP 393, which takes a different approach, addressing both problems simultaneously: by getting a flexible representation (one that can be either 1, 2, or 4 bytes), we can support the full range of Unicode on all systems, but still use only one byte per character for strings that are pure ASCII (which will be the majority of strings for the majority of users). You'll find the PEP at http://www.python.org/dev/peps/pep-0393/ For convenience, I include it below. Regards, Martin PEP: 393 Title: Flexible String Representation Version: $Revision: 88168 $ Last-Modified: $Date: 2011-01-24 21:14:21 +0100 (Mo, 24. Jan 2011) $ Author: Martin v. Löwis <martin(a)v.loewis.de> Status: Draft Type: Standards Track Content-Type: text/x-rst Created: 24-Jan-2010 Python-Version: 3.3 Post-History: Abstract ======== The Unicode string type is changed to support multiple internal representations, depending on the character with the largest Unicode ordinal (1, 2, or 4 bytes). This will allow a space-efficient representation in common cases, but give access to full UCS-4 on all systems. For compatibility with existing APIs, several representations may exist in parallel; over time, this compatibility should be phased out. Rationale ========= There are two classes of complaints about the current implementation of the unicode type: on systems only supporting UTF-16, users complain that non-BMP characters are not properly supported. On systems using UCS-4 internally (and also sometimes on systems using UCS-2), there is a complaint that Unicode strings take up too much memory - especially compared to Python 2.x, where the same code would often use ASCII strings (i.e. ASCII-encoded byte strings). With the proposed approach, ASCII-only Unicode strings will again use only one byte per character; while still allowing efficient indexing of strings containing non-BMP characters (as strings containing them will use 4 bytes per character). One problem with the approach is support for existing applications (e.g. extension modules). For compatibility, redundant representations may be computed. Applications are encouraged to phase out reliance on a specific internal representation if possible. As interaction with other libraries will often require some sort of internal representation, the specification choses UTF-8 as the recommended way of exposing strings to C code. For many strings (e.g. ASCII), multiple representations may actually share memory (e.g. the shortest form may be shared with the UTF-8 form if all characters are ASCII). With such sharing, the overhead of compatibility representations is reduced. Specification ============= The Unicode object structure is changed to this definition:: typedef struct { PyObject_HEAD Py_ssize_t length; void *str; Py_hash_t hash; int state; Py_ssize_t utf8_length; void *utf8; Py_ssize_t wstr_length; void *wstr; } PyUnicodeObject; These fields have the following interpretations: - length: number of code points in the string (result of sq_length) - str: shortest-form representation of the unicode string; the lower two bits of the pointer indicate the specific form: 01 => 1 byte (Latin-1); 11 => 2 byte (UCS-2); 11 => 4 byte (UCS-4); 00 => null pointer The string is null-terminated (in its respective representation). - hash, state: same as in Python 3.2 - utf8_length, utf8: UTF-8 representation (null-terminated) - wstr_length, wstr: representation in platform's wchar_t (null-terminated). If wchar_t is 16-bit, this form may use surrogate pairs (in which cast wstr_length differs form length). All three representations are optional, although the str form is considered the canonical representation which can be absent only while the string is being created. The Py_UNICODE type is still supported but deprecated. It is always defined as a typedef for wchar_t, so the wstr representation can double as Py_UNICODE representation. The str and utf8 pointers point to the same memory if the string uses only ASCII characters (using only Latin-1 is not sufficient). The str and wstr pointers point to the same memory if the string happens to fit exactly to the wchar_t type of the platform (i.e. uses some BMP-not-Latin-1 characters if sizeof(wchar_t) is 2, and uses some non-BMP characters if sizeof(wchar_t) is 4). If the string is created directly with the canonical representation (see below), this representation doesn't take a separate memory block, but is allocated right after the PyUnicodeObject struct. String Creation --------------- The recommended way to create a Unicode object is to use the function PyUnicode_New:: PyObject* PyUnicode_New(Py_ssize_t size, Py_UCS4 maxchar); Both parameters must denote the eventual size/range of the strings. In particular, codecs using this API must compute both the number of characters and the maximum character in advance. An string is allocated according to the specified size and character range and is null-terminated; the actual characters in it may be unitialized. PyUnicode_FromString and PyUnicode_FromStringAndSize remain supported for processing UTF-8 input; the input is decoded, and the UTF-8 representation is not yet set for the string. PyUnicode_FromUnicode remains supported but is deprecated. If the Py_UNICODE pointer is non-null, the str representation is set. If the pointer is NULL, a properly-sized wstr representation is allocated, which can be modified until PyUnicode_Finalize() is called (explicitly or implicitly). Resizing a Unicode string remains possible until it is finalized. PyUnicode_Finalize() converts a string containing only a wstr representation into the canonical representation. Unless wstr and str can share the memory, the wstr representation is discarded after the conversion. String Access ------------- The canonical representation can be accessed using two macros PyUnicode_Kind and PyUnicode_Data. PyUnicode_Kind gives one of the value PyUnicode_1BYTE (1), PyUnicode_2BYTE (2), or PyUnicode_4BYTE (3). PyUnicode_Data gives the void pointer to the data, masking out the pointer kind. All these functions call PyUnicode_Finalize in case the canonical representation hasn't been computed yet. A new function PyUnicode_AsUTF8 is provided to access the UTF-8 representation. It is thus identical to the existing _PyUnicode_AsString, which is removed. The function will compute the utf8 representation when first called. Since this representation will consume memory until the string object is released, applications should use the existing PyUnicode_AsUTF8String where possible (which generates a new string object every time). API that implicitly converts a string to a char* (such as the ParseTuple functions) will use this function to compute a conversion. PyUnicode_AsUnicode is deprecated; it computes the wstr representation on first use. String Operations ----------------- Various convenience functions will be provided to deal with the canonical representation, in particular with respect to concatenation and slicing. Stable ABI ---------- None of the functions in this PEP become part of the stable ABI. Copyright ========= This document has been placed in the public domain.

10 years, 8 months

fcmp() in test.support

by Eli Bendersky

I'm working on improving the .rst documentation of test.support (Issue 11015), and came upon the undocumented "fcmp" function that's being exported from test.support, along with a "FUZZ"constant. As I search through the tests (py3k trunk), I see fcmp() is being used only in two places in a fairly trivial way: 1. test_float: where it can be directly replaced by assertAlmostEqual from unittest 2. test_builtin: where the assertion can also be easily rewritten in terms of assertAlmostEqual Although fcmp seems to provide extra functionality over assertAlmostEqual, the above makes me think it should probably be removed altogether, or added to unittest if it's still deemed important. +/- ? Eli

10 years, 8 months

Beta version of the new devguide

by Brett Cannon

http://docs.python.org/devguide/ If you are a core developer and have a correction you want to make you can simply check out the devguide yourself (link is in the Resources section of the devguide) and make the corrections yourself. Otherwise reply here (you can email me directly but I already have instances of multiple people telling me about the same spelling mistake so it's nice to have it public so people know when I have been informed). As for what is left to do, there are a a few things. One is fixing some issues to allow test coverage to be run for the entire test suite (see the coverage docs to know what issues are tracking the problems). I will work on this next if no one beats me to it as both issues should be relatively simple to do. Two, what should the final URL be? Georg picked the current one and I am happy with it. Three, where should it be linked from? docs.python.org homepage? Four, what to do with www.python.org/dev/? Redirect for all the pages? Otherwise I consider the devguide ready to go. My next thing will be an "official" HOWTO on dealing with Python 2/3 porting/maintenance.

10 years, 8 months

Summary of Python tracker Issues

by Python tracker

ACTIVITY SUMMARY (2011-01-21 - 2011-01-28) Python tracker at http://bugs.python.org/ To view or respond to any of the issues listed below, click on the issue. Do NOT respond to this message. Issues counts and deltas: open 2567 (+40) closed 20262 (+34) total 22829 (+74) Open issues with patches: 1085 Issues opened (54) ================== #10042: total_ordering stack overflow http://bugs.python.org/issue10042 reopened by eric.araujo #10501: make_buildinfo regression with unquoted path http://bugs.python.org/issue10501 reopened by eli.bendersky #10708: Misc/porting should be folded into the development FAQ or the http://bugs.python.org/issue10708 reopened by pitrou #10976: json.loads() throws TypeError on bytes object http://bugs.python.org/issue10976 opened by hhas #10977: Concrete object C API needs abstract path for subclasses of bu http://bugs.python.org/issue10977 opened by rhettinger #10978: Add optional argument to Semaphore.release for releasing multi http://bugs.python.org/issue10978 opened by rhettinger #10979: setUpClass exception causes explosion with "-b" http://bugs.python.org/issue10979 opened by brandon-rhodes #10980: http.server Header Unicode Bug http://bugs.python.org/issue10980 opened by aronacher #10983: Errors in http.client.HTTPConnection class (python3) http://bugs.python.org/issue10983 opened by nooB #10984: argparse add_mutually_exclusive_group should accept existing a http://bugs.python.org/issue10984 opened by gotgenes #10988: Descriptor protocol documentation for super bindings is incorr http://bugs.python.org/issue10988 opened by Joshua.Arnold #10989: ssl.SSLContext(True).load_verify_locations(None, True) segfaul http://bugs.python.org/issue10989 opened by haypo #10990: tests mutating sys.gettrace() w/o re-instating previous state http://bugs.python.org/issue10990 opened by brett.cannon #10991: trace fails when test imported a temporary file http://bugs.python.org/issue10991 opened by brett.cannon #10992: tests failing when run under coverage http://bugs.python.org/issue10992 opened by brett.cannon #10994: implementation details in sys module http://bugs.python.org/issue10994 opened by fijall #10998: Remove last traces of -Q / sys.flags.division_warning / Py_Div http://bugs.python.org/issue10998 opened by eric.araujo #10999: os.chflags refers to stat constants, but the constants are not http://bugs.python.org/issue10999 opened by r.david.murray #11001: Various obvious errors in cookies documentation http://bugs.python.org/issue11001 opened by spookylukey #11003: os.system should be deprecated in favour of subprocess module http://bugs.python.org/issue11003 opened by Jakob.Bowyer #11005: Assertion error on RLock._acquire_restore http://bugs.python.org/issue11005 opened by haypo #11006: warnings with subprocess and pipe2 http://bugs.python.org/issue11006 opened by pitrou #11007: stack tracebacks should give the relevant class name http://bugs.python.org/issue11007 opened by stickwithjosh #11009: urllib.splituser is not documented http://bugs.python.org/issue11009 opened by techtonik #11011: More functools functions http://bugs.python.org/issue11011 opened by Jason.Baker #11012: Add log1p(), exp1m(), gamma(), and lgamma() to cmath http://bugs.python.org/issue11012 opened by rhettinger #11015: Bring test.support docs up to date http://bugs.python.org/issue11015 opened by ncoghlan #11021: email MIME-Version headers for each part in multipart message http://bugs.python.org/issue11021 opened by david.caro #11022: locale.setlocale() doesn't change I/O codec, os.environ does http://bugs.python.org/issue11022 opened by sdaoden #11023: pep 227 missing text http://bugs.python.org/issue11023 opened by aisaac #11025: Distutils2 install command without setup.py or setup.cfg creat http://bugs.python.org/issue11025 opened by Boris.FELD #11027: Implement sectionxform in configparser http://bugs.python.org/issue11027 opened by Kunjesh.Kaushik #11028: Implement the setup.py -> setup.cfg in mkcfg http://bugs.python.org/issue11028 opened by alaintty #11029: Crash, 2.7.1, Tkinter and threads and line drawing http://bugs.python.org/issue11029 opened by PythonInTheGrass #11030: regrtest - allow for relative path with --coverdir http://bugs.python.org/issue11030 opened by sandro.tosi #11031: regrtest - --testdir, new command-line option to specify alter http://bugs.python.org/issue11031 opened by sandro.tosi #11032: _string: formatter_field_name_split() and formatter_parser doe http://bugs.python.org/issue11032 opened by haypo #11033: ElementTree.fromstring doesn't work with Unicode http://bugs.python.org/issue11033 opened by Peter.Cai #11034: Build problem on Windows with MSVC++ Express 2008 http://bugs.python.org/issue11034 opened by eli.bendersky #11035: Segmentation fault http://bugs.python.org/issue11035 opened by Dmitry.Groshev #11037: How distutils2 handle namespaces http://bugs.python.org/issue11037 opened by sdouche #11038: Some commands should stop if Name and Version are missing http://bugs.python.org/issue11038 opened by gawel #11040: After registering a project to PyPI, classifiers fields aren't http://bugs.python.org/issue11040 opened by Julien.Miotte #11041: On the distutils2 documentation, 'requires-python' shouldn't b http://bugs.python.org/issue11041 opened by Julien.Miotte #11042: [PyPI CSS] Adding project urls onto a project page using regis http://bugs.python.org/issue11042 opened by Julien.Miotte #11043: On GNU/Linux (Ubuntu) distutils2.mkcfg shouldn't create an exe http://bugs.python.org/issue11043 opened by Julien.Miotte #11044: The description-file isn't handled by distutils2 http://bugs.python.org/issue11044 opened by Julien.Miotte #11045: shutil._make_tarball http://bugs.python.org/issue11045 opened by tarek #11046: darwin/MacOS X setup.py hack http://bugs.python.org/issue11046 opened by sdaoden #10997: Duplicate entries in IDLE "Recent Files" menu item on OS X http://bugs.python.org/issue10997 opened by ned.deily #11016: Add S_ISDOOR to the stat module http://bugs.python.org/issue11016 opened by pitrou #11024: imaplib: Time2Internaldate() returns localized strings http://bugs.python.org/issue11024 opened by spaetz #11036: Allow multiple files in the description-file metadata http://bugs.python.org/issue11036 opened by gawel #11047: Bad description for a change http://bugs.python.org/issue11047 opened by Oren_Held Most recent 15 issues with no replies (15) ========================================== #11047: Bad description for a change http://bugs.python.org/issue11047 #11044: The description-file isn't handled by distutils2 http://bugs.python.org/issue11044 #11043: On GNU/Linux (Ubuntu) distutils2.mkcfg shouldn't create an exe http://bugs.python.org/issue11043 #11042: [PyPI CSS] Adding project urls onto a project page using regis http://bugs.python.org/issue11042 #11041: On the distutils2 documentation, 'requires-python' shouldn't b http://bugs.python.org/issue11041 #11040: After registering a project to PyPI, classifiers fields aren't http://bugs.python.org/issue11040 #11038: Some commands should stop if Name and Version are missing http://bugs.python.org/issue11038 #11037: How distutils2 handle namespaces http://bugs.python.org/issue11037 #11036: Allow multiple files in the description-file metadata http://bugs.python.org/issue11036 #11033: ElementTree.fromstring doesn't work with Unicode http://bugs.python.org/issue11033 #11031: regrtest - --testdir, new command-line option to specify alter http://bugs.python.org/issue11031 #11030: regrtest - allow for relative path with --coverdir http://bugs.python.org/issue11030 #11028: Implement the setup.py -> setup.cfg in mkcfg http://bugs.python.org/issue11028 #11023: pep 227 missing text http://bugs.python.org/issue11023 #11012: Add log1p(), exp1m(), gamma(), and lgamma() to cmath http://bugs.python.org/issue11012 Most recent 15 issues waiting for review (15) ============================================= #11047: Bad description for a change http://bugs.python.org/issue11047 #11034: Build problem on Windows with MSVC++ Express 2008 http://bugs.python.org/issue11034 #11032: _string: formatter_field_name_split() and formatter_parser doe http://bugs.python.org/issue11032 #11031: regrtest - --testdir, new command-line option to specify alter http://bugs.python.org/issue11031 #11030: regrtest - allow for relative path with --coverdir http://bugs.python.org/issue11030 #11024: imaplib: Time2Internaldate() returns localized strings http://bugs.python.org/issue11024 #11015: Bring test.support docs up to date http://bugs.python.org/issue11015 #11011: More functools functions http://bugs.python.org/issue11011 #11001: Various obvious errors in cookies documentation http://bugs.python.org/issue11001 #10999: os.chflags refers to stat constants, but the constants are not http://bugs.python.org/issue10999 #10998: Remove last traces of -Q / sys.flags.division_warning / Py_Div http://bugs.python.org/issue10998 #10997: Duplicate entries in IDLE "Recent Files" menu item on OS X http://bugs.python.org/issue10997 #10992: tests failing when run under coverage http://bugs.python.org/issue10992 #10990: tests mutating sys.gettrace() w/o re-instating previous state http://bugs.python.org/issue10990 #10989: ssl.SSLContext(True).load_verify_locations(None, True) segfaul http://bugs.python.org/issue10989 Top 10 most discussed issues (10) ================================= #10990: tests mutating sys.gettrace() w/o re-instating previous state http://bugs.python.org/issue10990 22 msgs #9124: Mailbox module should use binary I/O, not text I/O http://bugs.python.org/issue9124 21 msgs #10848: Move test.regrtest from getopt to argparse http://bugs.python.org/issue10848 19 msgs #11034: Build problem on Windows with MSVC++ Express 2008 http://bugs.python.org/issue11034 12 msgs #5863: bz2.BZ2File should accept other file-like objects. http://bugs.python.org/issue5863 11 msgs #11027: Implement sectionxform in configparser http://bugs.python.org/issue11027 11 msgs #11016: Add S_ISDOOR to the stat module http://bugs.python.org/issue11016 11 msgs #10954: No warning for csv.writer API change http://bugs.python.org/issue10954 10 msgs #10994: implementation details in sys module http://bugs.python.org/issue10994 10 msgs #11022: locale.setlocale() doesn't change I/O codec, os.environ does http://bugs.python.org/issue11022 9 msgs Issues closed (34) ================== #4177: Crash in MIMEText on FreeBSD http://bugs.python.org/issue4177 closed by haypo #5097: asyncore.dispatcher_with_send undocumented http://bugs.python.org/issue5097 closed by giampaolo.rodola #5831: Doc mistake : threading.Timer is *not* a class http://bugs.python.org/issue5831 closed by eric.araujo #10948: Trouble with dir_util created dir cache http://bugs.python.org/issue10948 closed by eric.araujo #10949: logging.RotatingFileHandler not robust enough http://bugs.python.org/issue10949 closed by vinay.sajip #10952: Don't normalize module names to NFKC? http://bugs.python.org/issue10952 closed by haypo #10955: Possible regression with stdlib in zipfile http://bugs.python.org/issue10955 closed by haypo #10957: Python developer FAQ grammar error http://bugs.python.org/issue10957 closed by brett.cannon #10960: os.stat() does not mention that it follow symlinks by default http://bugs.python.org/issue10960 closed by r.david.murray #10970: "string".encode('base64') is not the same as base64.b64encode( http://bugs.python.org/issue10970 closed by terry.reedy #10973: OS X 10.6 IDLE, tkinter: Cocoa Tk 8.5 crash when composite cha http://bugs.python.org/issue10973 closed by ned.deily #10974: IDLE 3.x can crash decoding recent file list http://bugs.python.org/issue10974 closed by ned.deily #10975: #10961: Pydoc touchups in new 3.2 Web server (issue4090042) http://bugs.python.org/issue10975 closed by eric.araujo #10981: argparse: options starting with -- match substrings http://bugs.python.org/issue10981 closed by david.caro #10982: asyncore timeouts do not work correctly http://bugs.python.org/issue10982 closed by giampaolo.rodola #10985: test_sys triggers a fatal python error when run under coverage http://bugs.python.org/issue10985 closed by brett.cannon #10986: traceback's rendering behavior while throwing custom exception http://bugs.python.org/issue10986 closed by benjamin.peterson #10987: _pickle doesn't handle recursion limits properly http://bugs.python.org/issue10987 closed by pitrou #10993: HTTPSConnection does not close when call close() method http://bugs.python.org/issue10993 closed by tanakorn #10995: mailbox.py open() calls don't set encoding http://bugs.python.org/issue10995 closed by r.david.murray #10996: Typo in What's New in 3.2 http://bugs.python.org/issue10996 closed by rhettinger #11000: Doc: ast.parse parses source, not just expressions http://bugs.python.org/issue11000 closed by terry.reedy #11002: 'Upload' link on Files page is broken http://bugs.python.org/issue11002 closed by eric.araujo #11004: AssertionError on collections.deque().count(1) http://bugs.python.org/issue11004 closed by rhettinger #11008: logging.dictConfig not documented as new in version 2.7 http://bugs.python.org/issue11008 closed by vinay.sajip #11010: Unicode BOM left in loaded text http://bugs.python.org/issue11010 closed by loewis #11013: Build of 2.7 svn fails in readline http://bugs.python.org/issue11013 closed by brett.cannon #11014: 'filter' argument for Tarfile.add needs to be a keyword-only a http://bugs.python.org/issue11014 closed by rhettinger #11017: optparse: error: invalid integer value http://bugs.python.org/issue11017 closed by eric.araujo #11018: typo in test_bz2 http://bugs.python.org/issue11018 closed by pitrou #11019: BytesGenerator fails if the Message body is None http://bugs.python.org/issue11019 closed by r.david.murray #11020: Pyclbr broken because of missing 2-to-3 conversion http://bugs.python.org/issue11020 closed by rhettinger #11026: Distutils2 install command fail with python 2.5/2.7 http://bugs.python.org/issue11026 closed by Boris.FELD #11039: Use of 'L' specifier is inconsistent when printing long intege http://bugs.python.org/issue11039 closed by eric.smith

10 years, 8 months

getting stable URLs for major.minor versions

by Brett Cannon

Because of all the writing I have been doing lately, I have been pulling up a lot of URLs pointing to various Python releases based around minor versions (e.g., Python 2.7, not specifically 2.7.1). What has been somewhat annoying is that there are no URLs which act as a redirect to the latest release of a minor version. For instance, it would be great if http://www.python.org/2.7 redirected to the Python 2.7.1 page. Linking to the 2.7.0 release page seems off since it is out of date, but linking to 2.7.1 also seems silly as that will become out of date as the newest release of Python 2.7 at some point as well. Can we consider coming up with some URL scheme where people can link to a version of Python that always redirects to the newest release? Bonus points if we extend this to major versions, too. =) I am asking here since the RMs will have to be okay with doing this as part of the release plan. Get the ball rolling, I say we make http://www.python.org/version/2.7 and http://www.python.org/version/2 redirect to the 2.7.1 release page, etc. Personally I would rather have http://www.python.org/2.7 redirect to 2.7.1, but since that already redirects to 2.7.0 I doubt people would be okay with the change.

10 years, 8 months

Re: [Python-Dev] Import and unicode: part two

by Simon Cross

On Wed, Jan 19, 2011 at 5:01 PM, Simon Cross <hodgestar+pythondev(a)gmail.com> wrote: > On Wed, Jan 19, 2011 at 2:34 PM, Victor Stinner > <victor.stinner(a)haypocalc.com> wrote: >> (a) Python 3 doesn't support non-ASCII module names > > -0: I'm vaguely against this being supported because I'd rather not > have to deal with what happens when the guess regarding the filesystem > encoding is wrong. On the other hand, a general encouragement to stick > to ASCII module names is probably functionally equivalent without > imposing a hard restriction. I'm changing my vote on this to a +1 for two reasons: * Initially I thought this wasn't supported by Python at all but I see that currently it is supported but that support is broken (or at least limited to UTF-8 filesystem encodings). Since support is there, might as well make it better (especially if it tidies up the code base at the same time). * I still don't think it's a good idea to give modules non-ASCII names but the "consenting adults" approach suggests we should let people shoot themselves in the foot if they believe they have good reason to do so. Schiavo Simon

10 years, 8 months

Why do we bundle lib2to3 with Python? Was: Location of tests for packages

by Łukasz Langa

W dniu 2011-01-24 23:13, Benjamin Peterson pisze: > I prefer lib2to3 tests to stay in lib2to3/. On a related note, I had trouble myself with using outdated 2to3 and heard complaints about that at least a couple of times. What do we gain from bundling 2to3 with Python? -- Best regards, Łukasz Langa

10 years, 8 months

Re: [Python-Dev] r88178 - python/branches/py3k/Lib/test/crashers/underlying_dict.py

by Antoine Pitrou

On Tue, 25 Jan 2011 01:00:28 +0100 (CET) benjamin.peterson <python-checkins(a)python.org> wrote: > Author: benjamin.peterson > Date: Tue Jan 25 01:00:28 2011 > New Revision: 88178 > > Log: > another pretty crasher served up by pypy Some comments would be nice. Right now it looks pretty close to deliberately obfuscated code (especially with the call to gc.get_referrers()). Regards Antoine.

10 years, 8 months

Re: [Python-Dev] [Python-checkins] r88197 - python/branches/py3k/Lib/email/generator.py

by Brett Cannon

This broke the buildbots (R. David Murray thinks you may have forgotten to call super() in the 'payload is None' branch). Are you getting code reviews and fully running the test suite before committing? We are in RC. On Tue, Jan 25, 2011 at 16:39, victor.stinner <python-checkins(a)python.org> wrote: > Author: victor.stinner > Date: Wed Jan 26 01:39:19 2011 > New Revision: 88197 > > Log: > Fix BytesGenerator._handle_text() if the message has no payload (None) > > Modified: > python/branches/py3k/Lib/email/generator.py > > Modified: python/branches/py3k/Lib/email/generator.py > ============================================================================== > --- python/branches/py3k/Lib/email/generator.py (original) > +++ python/branches/py3k/Lib/email/generator.py Wed Jan 26 01:39:19 2011 > @@ -377,8 +377,11 @@ > def _handle_text(self, msg): > # If the string has surrogates the original source was bytes, so > # just write it back out. > - if _has_surrogates(msg._payload): > - self.write(msg._payload) > + payload = msg.get_payload() > + if payload is None: > + return > + if _has_surrogates(payload): > + self.write(payload) > else: > super(BytesGenerator,self)._handle_text(msg) > > _______________________________________________ > Python-checkins mailing list > Python-checkins(a)python.org > http://mail.python.org/mailman/listinfo/python-checkins >

10 years, 8 months

Re: [Python-Dev] [Python-checkins] r88197 - python/branches/py3k/Lib/email/generator.py

by Nick Coghlan

On Wed, Jan 26, 2011 at 10:39 AM, victor.stinner <python-checkins(a)python.org> wrote: > Author: victor.stinner > Date: Wed Jan 26 01:39:19 2011 > New Revision: 88197 > > Log: > Fix BytesGenerator._handle_text() if the message has no payload (None) Folks, for the peace of mind of python-checkins watchers, please remember to mention the reviewer's name when checking in fixes during the RC period (the last one I checked had been reviewed by Georg on the issue tracker, but it's hard to check without even an issue number to look up). Cheers, Nick. -- Nick Coghlan | ncoghlan(a)gmail.com | Brisbane, Australia

10 years, 8 months

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

2000

1999

Python-Dev January 2011