Mailman 3 October 2011 - Python-Dev

Re: [Python-Dev] cpython (3.2): I should be someone
by Georg Brandl Oct. 29, 2011

Oct. 29, 2011

On 10/28/11 22:05, florent.xicluna wrote: > http://hg.python.org/cpython/rev/6f56e81da8f6 > changeset: 73171:6f56e81da8f6 > branch: 3.2 > parent: 73167:09d0510e1c50 > user: Florent Xicluna <florent.xicluna(a)gmail.com> > date: Fri Oct 28 22:03:55 2011 +0200 > summary: > I should be someone > > files: > Doc/library/urllib.request.rst | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > > diff --git a/Doc/library/urllib.request.rst b/Doc/library/urllib.request.rst > --- a/Doc/library/urllib.request.rst > +++ b/Doc/library/urllib.request.rst > @@ -1257,11 +1257,11 @@ > pair: HTTP; protocol > pair: FTP; protocol > > -* Currently, only the following protocols are supported: HTTP, (versions 0.9 and > - 1.0), FTP, and local files. > +* Currently, only the following protocols are supported: HTTP (versions 0.9 and > + 1.0), FTP, and local files. > > -* The caching feature of :func:`urlretrieve` has been disabled until I find the > - time to hack proper processing of Expiration time headers. > +* The caching feature of :func:`urlretrieve` has been disabled until someone find > + the time to hack proper processing of Expiration time headers. In this case, s/find/finds/ :) Georg

1 0

Summary of Python tracker Issues
by Python tracker Oct. 28, 2011

Oct. 28, 2011

ACTIVITY SUMMARY (2011-10-21 - 2011-10-28) Python tracker at http://bugs.python.org/ To view or respond to any of the issues listed below, click on the issue. Do NOT respond to this message. Issues counts and deltas: open 3108 (+13) closed 21961 (+34) total 25069 (+47) Open issues with patches: 1324 Issues opened (33) ================== #10278: add time.wallclock() method http://bugs.python.org/issue10278 reopened by haypo #13241: llvm-gcc-4.2 miscompiles Python (XCode 4.1 on Mac OS 10.7) http://bugs.python.org/issue13241 opened by Oleg.Plakhotnyuk #13244: WebSocket schemes in urllib.parse http://bugs.python.org/issue13244 opened by oberstet #13245: sched.py kwargs addition and default time functions http://bugs.python.org/issue13245 opened by clach04 #13246: Py_UCS4_strlen and friends needn't be public http://bugs.python.org/issue13246 opened by pitrou #13247: os.path.abspath returns unicode paths as question marks http://bugs.python.org/issue13247 opened by ubershmekel #13248: deprecated in 3.2, should be removed in 3.3 http://bugs.python.org/issue13248 opened by flox #13249: argparse.ArgumentParser() lists arguments in the wrong order http://bugs.python.org/issue13249 opened by roysmith #13252: new decumulate() function in itertools module http://bugs.python.org/issue13252 opened by carlo.verre #13253: 2to3 fix_renames renames sys.maxint only in imports http://bugs.python.org/issue13253 opened by ezio.melotti #13254: maildir.items() broken http://bugs.python.org/issue13254 opened by marco.ghidinelli #13256: Document and test new socket options http://bugs.python.org/issue13256 opened by haypo #13257: Move importlib over to PEP 3151 exceptions http://bugs.python.org/issue13257 opened by brett.cannon #13262: IDLE opens partially hidden http://bugs.python.org/issue13262 opened by Aivar.Annamaa #13263: Group some os functions in submodules http://bugs.python.org/issue13263 opened by ezio.melotti #13264: Monkeypatching using metaclass http://bugs.python.org/issue13264 opened by Artem.Tomilov #13265: IDLE crashes when printing some unprintable characters. http://bugs.python.org/issue13265 opened by maniram.maniram #13266: Add inspect.unwrap(f) to easily unravel "__wrapped__" chains http://bugs.python.org/issue13266 opened by ncoghlan #13271: When -h is used with argparse, default values that fail should http://bugs.python.org/issue13271 opened by Joshua.Chia #13272: 2to3 fix_renames doesn't rename string.lowercase/uppercase/let http://bugs.python.org/issue13272 opened by ezio.melotti #13274: heapq pure python version uses islice without guarding for neg http://bugs.python.org/issue13274 opened by Ronny.Pfannschmidt #13275: Recommend xml.etree for XML processing http://bugs.python.org/issue13275 opened by ash #13276: distutils bdist_wininst created installer does not run the pos http://bugs.python.org/issue13276 opened by francisco #13277: tzinfo subclasses information http://bugs.python.org/issue13277 opened by orsenthil #13279: Add memcmp into unicode_compare for optimizing comparisons http://bugs.python.org/issue13279 opened by RichIsMyName #13280: argparse should use the new Formatter class http://bugs.python.org/issue13280 opened by poke #13281: robotparser.RobotFileParser ignores rules preceeded by a blank http://bugs.python.org/issue13281 opened by bernie9998 #13282: the table of contents in epub file is too long http://bugs.python.org/issue13282 opened by wrobell #13283: removal of two unused variable in locale.py http://bugs.python.org/issue13283 opened by nicoe #13284: email.utils.formatdate function does not handle timezones corr http://bugs.python.org/issue13284 opened by burak.arslan #13285: signal module ignores external signal changes http://bugs.python.org/issue13285 opened by vilya #13286: PEP 3151 breaks backward compatibility: it should be documente http://bugs.python.org/issue13286 opened by haypo #13287: urllib.request exposes too many names http://bugs.python.org/issue13287 opened by flox Most recent 15 issues with no replies (15) ========================================== #13283: removal of two unused variable in locale.py http://bugs.python.org/issue13283 #13282: the table of contents in epub file is too long http://bugs.python.org/issue13282 #13277: tzinfo subclasses information http://bugs.python.org/issue13277 #13276: distutils bdist_wininst created installer does not run the pos http://bugs.python.org/issue13276 #13272: 2to3 fix_renames doesn't rename string.lowercase/uppercase/let http://bugs.python.org/issue13272 #13262: IDLE opens partially hidden http://bugs.python.org/issue13262 #13257: Move importlib over to PEP 3151 exceptions http://bugs.python.org/issue13257 #13231: sys.settrace - document 'some other code blocks' for 'call' ev http://bugs.python.org/issue13231 #13229: Add shutil.filter_walk http://bugs.python.org/issue13229 #13217: Missing header dependencies in Makefile http://bugs.python.org/issue13217 #13213: generator.throw() behavior http://bugs.python.org/issue13213 #13204: sys.flags.__new__ crashes http://bugs.python.org/issue13204 #13198: Remove duplicate definition of write_record_file http://bugs.python.org/issue13198 #13191: Typo in argparse documentation http://bugs.python.org/issue13191 #13190: ConfigParser uses wrong newline on Windows http://bugs.python.org/issue13190 Most recent 15 issues waiting for review (15) ============================================= #13283: removal of two unused variable in locale.py http://bugs.python.org/issue13283 #13281: robotparser.RobotFileParser ignores rules preceeded by a blank http://bugs.python.org/issue13281 #13279: Add memcmp into unicode_compare for optimizing comparisons http://bugs.python.org/issue13279 #13256: Document and test new socket options http://bugs.python.org/issue13256 #13249: argparse.ArgumentParser() lists arguments in the wrong order http://bugs.python.org/issue13249 #13247: os.path.abspath returns unicode paths as question marks http://bugs.python.org/issue13247 #13245: sched.py kwargs addition and default time functions http://bugs.python.org/issue13245 #13244: WebSocket schemes in urllib.parse http://bugs.python.org/issue13244 #13240: sysconfig gives misleading results for USE_COMPUTED_GOTOS http://bugs.python.org/issue13240 #13238: Add shell command helpers to shutil module http://bugs.python.org/issue13238 #13234: os.listdir breaks with literal paths http://bugs.python.org/issue13234 #13224: Change str(class) to return only the class name http://bugs.python.org/issue13224 #13223: pydoc removes 'self' in HTML for method docstrings with exampl http://bugs.python.org/issue13223 #13218: test_ssl failures on Debian/Ubuntu http://bugs.python.org/issue13218 #13217: Missing header dependencies in Makefile http://bugs.python.org/issue13217 Top 10 most discussed issues (10) ================================= #13244: WebSocket schemes in urllib.parse http://bugs.python.org/issue13244 20 msgs #13238: Add shell command helpers to shutil module http://bugs.python.org/issue13238 16 msgs #13241: llvm-gcc-4.2 miscompiles Python (XCode 4.1 on Mac OS 10.7) http://bugs.python.org/issue13241 16 msgs #13247: os.path.abspath returns unicode paths as question marks http://bugs.python.org/issue13247 16 msgs #13237: subprocess docs should emphasise convenience functions http://bugs.python.org/issue13237 14 msgs #13234: os.listdir breaks with literal paths http://bugs.python.org/issue13234 12 msgs #13218: test_ssl failures on Debian/Ubuntu http://bugs.python.org/issue13218 11 msgs #13263: Group some os functions in submodules http://bugs.python.org/issue13263 10 msgs #12394: packaging: generate scripts from callable (dotted paths) http://bugs.python.org/issue12394 8 msgs #13193: test_packaging and test_distutils failures http://bugs.python.org/issue13193 8 msgs Issues closed (35) ================== #6216: Raise Unicode KEEPALIVE_SIZE_LIMIT from 9 to 32? http://bugs.python.org/issue6216 closed by pitrou #9980: str(float) failure http://bugs.python.org/issue9980 closed by mark.dickinson #10332: Multiprocessing maxtasksperchild results in hang http://bugs.python.org/issue10332 closed by neologix #10925: Document pure Python version of integer-to-float correctly-rou http://bugs.python.org/issue10925 closed by mark.dickinson #11183: Finer-grained exceptions for the ssl module http://bugs.python.org/issue11183 closed by pitrou #11447: test_pydoc refleak http://bugs.python.org/issue11447 closed by pitrou #12753: \N{...} neglects formal aliases and named sequences from Unico http://bugs.python.org/issue12753 closed by ezio.melotti #13016: selectmodule.c: refleak http://bugs.python.org/issue13016 closed by petri.lehtinen #13017: pyexpat.c: refleak http://bugs.python.org/issue13017 closed by petri.lehtinen #13018: dictobject.c: refleak http://bugs.python.org/issue13018 closed by petri.lehtinen #13105: Please elaborate on how 2.x and 3.x are different heads http://bugs.python.org/issue13105 closed by ncoghlan #13132: distutils sends non-RFC compliant HTTP request http://bugs.python.org/issue13132 closed by eric.araujo #13141: get rid of old threading API in the examples http://bugs.python.org/issue13141 closed by flox #13201: Implement comparison operators for range objects http://bugs.python.org/issue13201 closed by mark.dickinson #13207: os.path.expanduser breaks when using unicode character in the http://bugs.python.org/issue13207 closed by haypo #13216: Add cp65001 codec http://bugs.python.org/issue13216 closed by haypo #13226: Expose RTLD_* constants in the posix module http://bugs.python.org/issue13226 closed by haypo #13228: Add "Quick Start" section to the devguide index http://bugs.python.org/issue13228 closed by ezio.melotti #13232: Logging: Unicode Error http://bugs.python.org/issue13232 closed by python-dev #13242: Crash in test_pydoc http://bugs.python.org/issue13242 closed by pitrou #13243: _Py_identifier should be _Py_IDENTIFER http://bugs.python.org/issue13243 closed by meador.inge #13250: ctypes: reference leak in POINTER code http://bugs.python.org/issue13250 closed by loewis #13251: Update string description in datamodel.rst http://bugs.python.org/issue13251 closed by ezio.melotti #13255: wrong docstrings in array module http://bugs.python.org/issue13255 closed by flox #13258: replace hasattr(obj, '__call__') with callable(obj) http://bugs.python.org/issue13258 closed by python-dev #13259: __bytes__ not documented http://bugs.python.org/issue13259 closed by python-dev #13260: distutils and cross-compiling the extensions http://bugs.python.org/issue13260 closed by eric.araujo #13261: time.clock () has very low resolution on Linux http://bugs.python.org/issue13261 closed by haypo #13267: Add an option to disable importing orphaned bytecode files http://bugs.python.org/issue13267 closed by ncoghlan #13268: assert statement violates the documentation http://bugs.python.org/issue13268 closed by python-dev #13269: Document that "Remote hg repo" accepts remote branches http://bugs.python.org/issue13269 closed by python-dev #13270: all classes are new style http://bugs.python.org/issue13270 closed by flox #13273: HTMLParser improperly handling open tags when strict is False http://bugs.python.org/issue13273 closed by ezio.melotti #13278: Typo in documentation for sched module http://bugs.python.org/issue13278 closed by ezio.melotti #1548891: shlex (or perhaps cStringIO) and unicode strings http://bugs.python.org/issue1548891 closed by pitrou

1 0

Re: [Python-Dev] [Python-checkins] r88914 - tracker/instances/python-dev/html/issue.item.js
by Berker Peksağ Oct. 27, 2011

Oct. 27, 2011

Hi, On Wed, Oct 26, 2011 at 11:45 AM, ezio.melotti <python-checkins(a)python.org> wrote: > Author: ezio.melotti > Date: Wed Oct 26 10:45:41 2011 > New Revision: 88914 > > Log: > Mark automated messages with a different background. > > Modified: > tracker/instances/python-dev/html/issue.item.js > > Modified: tracker/instances/python-dev/html/issue.item.js > ============================================================================== > --- tracker/instances/python-dev/html/issue.item.js (original) > +++ tracker/instances/python-dev/html/issue.item.js Wed Oct 26 10:45:41 2011 > @@ -313,3 +313,14 @@ > if (link.length != 0) > link.attr('href', link.attr('href').split('?')[0]); > }); > + > + > +$(document).ready(function() { > + /* Mark automated messages with a different background */ > + $('table.messages th:nth-child(2)').each(function (i, e) { > + var e = $(e); > + if (/$python-dev$$/.test(e.text())) > + e.parent().next().find('td.content').css( > + 'background-color', '#efeff9'); > + }); > +}); I think this is shorter than $(document).ready(); $(function() { // ... }); See: http://stackoverflow.com/questions/3528509/document-readyfunction-vs-functi… --Berker > _______________________________________________ > Python-checkins mailing list > Python-checkins(a)python.org > http://mail.python.org/mailman/listinfo/python-checkins >

2 1

Use our strict mbcs codec instead of the Windows ANSI API
by Victor Stinner Oct. 26, 2011

Oct. 26, 2011

Hi, I propose to raise Unicode errors if a filename cannot be decoded on Windows, instead of creating a bogus filenames with questions marks. Because this change is incompatible with Python 3.2, even if such filenames are unusable and I consider the problem as a (Python?) bug, I would like your opinion on such change before working on a patch. -- Windows works internally on Unicode strings since Windows 95 (or something like that), but provides also an "ANSI" API using the ANSI code page and byte strings for backward compatibility. It was already proposed to drop completly the bytes API in our nt (os) module, but it may break the Python backward compatibility (and it is difficult to list Python programs using the bytes API to access the file system). The ANSI API uses MultiByteToWideChar (decode) and WideCharToMultiByte (encode) functions in the default mode (flags=0): MultiByteToWideChar() replaces undecodable bytes by '?' and WideCharToMultiByte() ignores unencodable characters (!!!). This behaviour produces invalid filenames (see for example the issue #13247) and *the user is unable to detect codec errors*. In Python 3.2, I changed the MBCS codec to make it strict: it raises a UnicodeEncodeError if a character cannot be encoded to the ANSI code page (e.g. encode Ł to cp1252) and a UnicodeDecodeError if a character cannot be decoded from the ANSI code page (e.g. b'\xff' from cp932). I propose to reuse our MBCS codec in strict mode (error handler="strict"), to notice directly encode/decode errors, with the Windows native (wide character) API. It should simplify the source code: replace 2 versions of a function by 1 version + optional code to decode arguments and/or encode the result. -- Read also the previous thread: [Python-Dev] Byte filenames in the posix module on Windows Wed Jun 8 00:23:20 CEST 2011 http://mail.python.org/pipermail/python-dev/2011-June/111831.html -- FYI I patched again Python MBCS codec: it now handles correclty ignore and replace mode (to encode and decode), but now also supports any error handler. -- We might use the PEP 383 to store undecoable bytes as surrogates (U+DC80- U+DCFF). But the situation is the opposite of the situtation on UNIX: on Windows, the problem is more on encoding (text->bytes) than on decoding (bytes->text). On UNIX, problems occur when the system is misconfigured (e.g. wrong locale encoding). On Windows, problems occur when your application uses the old (ANSI) API, whereas your filesystem is fully Unicode compliant and you created Unicode filenames with a program using the new (Windows) API. Only few programs are fully Unicode compliant. A lot of programs fail if a filename cannot be encoded to the ANSI code page (just 2 examples: Mercurial and Visual Studio). Victor

7 13

Re: [Python-Dev] [Python-checkins] cpython: Issue #13226: Add RTLD_xxx constants to the os module. These constants can by
by Petri Lehtinen Oct. 25, 2011

Oct. 25, 2011

Hi, victor.stinner wrote: > http://hg.python.org/cpython/rev/c75427c0da06 > changeset: 73127:c75427c0da06 > user: Victor Stinner <victor.stinner(a)haypocalc.com> > date: Tue Oct 25 13:34:04 2011 +0200 > summary: > Issue #13226: Add RTLD_xxx constants to the os module. These constants can by > used with sys.setdlopenflags(). > > files: > Doc/library/os.rst | 13 +++++++++++++ > Doc/library/sys.rst | 10 +++++----- > Lib/test/test_posix.py | 7 +++++++ > Misc/NEWS | 3 +++ > Modules/posixmodule.c | 26 ++++++++++++++++++++++++++ > 5 files changed, 54 insertions(+), 5 deletions(-) [snip] > diff --git a/Misc/NEWS b/Misc/NEWS > --- a/Misc/NEWS > +++ b/Misc/NEWS > @@ -341,6 +341,9 @@ > Library > ------- > > +- Issue #13226: Add RTLD_xxx constants to the os module. These constants can by Typo: s/by/be/ > + used with sys.setdlopenflags(). > + > - Issue #10278: Add clock_getres(), clock_gettime() and CLOCK_xxx constants to > the time module. time.clock_gettime(time.CLOCK_MONOTONIC) provides a > monotonic clock Petri

2 1

Modules of plat-* directories
by Victor Stinner Oct. 25, 2011

Oct. 25, 2011

Hi, I don't understand why we kept modules of the plat-* directories (e.g. Lib/plat-linux/CDROM.py). It looks like these modules are not used, except maybe some DL constants used by PyKDE4. Can't we move used constants to classic Python modules (e.g. the os module) and drop unused modules? These modules are not regenerated when Python is compiled, so I don't understand how values can be correct. For example, IN.INT_MAX is 2147483647, whereas it should be 9223372036854775807 on my 64-bit Linux. These values don't look reliable. I'm looking at these modules because Arfrever asked me to review a patch for h2py.py, a script to regenerate these modules: http://bugs.python.org/issue13032 He also suggested somewhere to regenerate these modules when Python is built. -- Python has builtin modules generated from C header files: - CDIO: sunos5 - CDROM: linux - DLFCN: linux, sunos5 - _emx_link: os2emx - grp: os2emx - IN: aix4, darwin, freebsd[45678], linux, netbsd1, os2emx, sunos5, unixware7 - pwd: os2emx - SOCKET: os2emx - STROPTS: sunos5, unixware7 - TYPES: linux, sunos5 CDROM/CDIO can be used to control the low-level CDROM API. CDROM is used by the cdsuite project: http://offog.org/code/cdsuite.html DLFCN is used by PyKDE4: sys.setdlopenflags(DLFCN.RTLD_NOW|DLFCN.RTLD_GLOBAL). I didn't know this sys function :-) (OS/2 platform is deprecated, see PEP 11.) The IN module is used by policykit to get INT_MAX (used to compute "MAX_DBUS_TIMEOUT = INT_MAX / 1000.0"). It was also used in SGI video demos of Python 1.4. STROPTS is not used. TYPES is used by other plat-* modules (IN, DLFCN, STROPTS). These modules contain non-working functions: def __STRING(x): return #x def __constant_le32_to_cpu(x): return ((__u32)(__le32)(x)) __STRING(x) returns None, "#x" is a comment in Python (in C, the preprocessor converts x to a string). Call __constant_le32_to_cpu() fails because __le32 is not defined. Even if __le32 was defined, the code doesn't look to be valid. Victor

3 9

Re: [Python-Dev] [Python-checkins] cpython: #13251: update string description in datamodel.rst.
by Petri Lehtinen Oct. 25, 2011

Oct. 25, 2011

Hi, ezio.melotti wrote: > http://hg.python.org/cpython/rev/11d18ebb2dd1 > changeset: 73116:11d18ebb2dd1 > user: Ezio Melotti <ezio.melotti(a)gmail.com> > date: Tue Oct 25 09:23:42 2011 +0300 > summary: > #13251: update string description in datamodel.rst. > > files: > Doc/reference/datamodel.rst | 20 ++++++++++---------- > 1 files changed, 10 insertions(+), 10 deletions(-) > > > diff --git a/Doc/reference/datamodel.rst b/Doc/reference/datamodel.rst > --- a/Doc/reference/datamodel.rst > +++ b/Doc/reference/datamodel.rst > @@ -276,16 +276,16 @@ > single: integer > single: Unicode > > - The items of a string object are Unicode code units. A Unicode code > - unit is represented by a string object of one item and can hold either > - a 16-bit or 32-bit value representing a Unicode ordinal (the maximum > - value for the ordinal is given in ``sys.maxunicode``, and depends on > - how Python is configured at compile time). Surrogate pairs may be > - present in the Unicode object, and will be reported as two separate > - items. The built-in functions :func:`chr` and :func:`ord` convert > - between code units and nonnegative integers representing the Unicode > - ordinals as defined in the Unicode Standard 3.0. Conversion from and to > - other encodings are possible through the string method :meth:`encode`. > + A string is a sequence of values that represent Unicode codepoints. > + All the codepoints in range ``U+0000 - U+10FFFF`` can be represented > + in a string. Python doesn't have a :c:type:`chr` type, and > + every characters in the string is represented as a string object typo ^ Should be "character", right? > + with length ``1``. The built-in function :func:`chr` converts a > + character to its codepoint (as an integer); :func:`ord` converts > + an integer in range ``0 - 10FFFF`` to the corresponding character. Actually chr() converts an integer to a string and ord() converts a string to an integer. chr and ord are swapped in your text. > + :meth:`str.encode` can be used to convert a :class:`str` to > + :class:`bytes` using the given encoding, and :meth:`bytes.decode` can > + be used to achieve the opposite. Petri

1 0

Re: [Python-Dev] memcmp performance
by Richard Saunders Oct. 25, 2011

Oct. 25, 2011

-On [20111024 09:22], Stefan Behnel (stefan_ml(a)behnel.de) wrote: >>I agree. Given that the analysis shows that the libc memcmp() is >>particularly fast on many Linux systems, it should be up to the Python >>package maintainers for these systems to set that option externally through >>the optimisation CFLAGS. Indeed, this is how I constructed my Python 3.3 and Python 2.7 : setenv CFLAGS '-fno-builtin-memcmp' just before I configured. I would like to revisit changing unicode_compare: adding a special arm for using memcmp when the "unicode kinds" are the same will only work in two specific instances: (1) the strings are the same kind, the char size is 1 * We could add THIS to unicode_compare, but it seems extremely specialized by itself (2) the strings are the same kind, the char size is >1, and checking for equality * Since unicode_compare can't detect equality checking, we can't really add this to unicode_compare at all The problem is, of course, that memcmp won't compare for less-than or greater-than correctly (unless on a BIG ENDIAN machine) for char sizes of 2 or 4. If we wanted to put memcmp in unicodeobject.c, it would probably need to go into PyUnicode_RichCompare (so we would have some more semantic information). I may try to put together a patch for that, if people think that's a good idea? It would be JUST adding a call to memcmp for two instances specified above. >From: Jeroen Ruigrok van der Werven <asmodai(a)in-nomine.org> >In the same stretch, stuff like this needs to be documented. Package >maintainers cannot be expected to follow each and every mailinglist's posts >for nuggets of information like this. Been there, done that, it's impossible >to keep track. I would like to second that: the whole point of a Makefile/configuration file is to capture knowledge like this so it doesn't get lost. I would prefer the option would be part of a standard build Python distributes, but as long as the information gets captured SOMEWHERE so that (say) Fedora Core 17 has Python 2.7 built with -fno-builtin-memcmp, I would be happy. Gooday, Richie

3 2

Case consistency [was: Re: [Python-checkins] cpython: Cleanup code: remove int/long idioms and simplify a while statement.]
by Jim Jewett Oct. 24, 2011

Oct. 24, 2011

Is there a reason to check for if s[:5] == 'pass ' or s[:5] == 'PASS ': instead of if s[:5].lower() == 'pass' ? If so, it should be documented; otherwise, I would rather see the more inclusive form, that would also allow things like "Pass" -jJ On Sun, Oct 23, 2011 at 4:21 PM, florent.xicluna <python-checkins(a)python.org> wrote: > http://hg.python.org/cpython/rev/67053b135ed9 > changeset: 73076:67053b135ed9 > user: Florent Xicluna <florent.xicluna(a)gmail.com> > date: Sun Oct 23 22:11:00 2011 +0200 > summary: > Cleanup code: remove int/long idioms and simplify a while statement. > diff --git a/Lib/ftplib.py b/Lib/ftplib.py > --- a/Lib/ftplib.py > +++ b/Lib/ftplib.py > @@ -175,10 +175,8 @@ > > # Internal: "sanitize" a string for printing > def sanitize(self, s): > - if s[:5] == 'pass ' or s[:5] == 'PASS ': > - i = len(s) > - while i > 5 and s[i-1] in {'\r', '\n'}: > - i = i-1 > + if s[:5] in {'pass ', 'PASS '}: > + i = len(s.rstrip('\r\n')) > s = s[:5] + '*'*(i-5) + s[i:] > return repr(s)

1 0

Re: [Python-Dev] cpython (3.2): Issue #13255: wrong docstrings in array module.
by Antoine Pitrou Oct. 24, 2011

Oct. 24, 2011

On Mon, 24 Oct 2011 13:17:53 +0200 florent.xicluna <python-checkins(a)python.org> wrote: > @@ -2557,7 +2557,7 @@ > extend() -- extend array by appending multiple elements from an iterable\n\ > fromfile() -- read items from a file object\n\ > fromlist() -- append items from the list\n\ > -fromstring() -- append items from the string\n\ > +frombytes() -- append items from the string\n\ > index() -- return index of first occurrence of an object\n\ > insert() -- insert a new item into the array at a provided position\n\ > pop() -- remove and return item (default last)\n\ > @@ -2565,7 +2565,7 @@ > reverse() -- reverse the order of the items in the array\n\ > tofile() -- write all items to a file object\n\ > tolist() -- return the array converted to an ordinary list\n\ > -tostring() -- return the array converted to a string\n\ > +tobytes() -- return the array converted to a string\n\ The alphabetical order should probably be kept. Regards Antoine.

1 0