Mailman 3 February 2011 - Python-Dev

Re: [Python-Dev] MSI: Remove dependency from win32com.client module (issue4080047)
by georg.brandl＠gmail.com Feb. 2, 2011

Feb. 2, 2011

On 2011/02/02 07:32:02, techtonik wrote: [...] Can you PLEASE take this off python-dev and move to an issue at bugs.python.org? At least remove python-dev from the CC, or we'll have to temporarily block messages from codereview. http://codereview.appspot.com/4080047/

1 0

Re: [Python-Dev] MSI: Remove dependency from win32com.client module (issue4080047)
by martin＠v.loewis.de Feb. 2, 2011

Feb. 2, 2011

On 2011/02/02 07:14:17, techtonik wrote: > On 2011/02/01 19:50:23, Martin v. Löwis wrote: > > On 2011/02/01 07:22:57, techtonik wrote: > > > It removes the dependency from msi.py making it easier to do the rest in > > > subsequent patches. > > > > What rest specifically? Why are the msilib changes needed for that? > The rest is to use ctypes, so that no external packages will be required to > build Python installer. Ah. That shouldn't be done. If … [View More]

1 0

Re: [Python-Dev] MSI: Remove dependency from win32com.client module (issue4080047)
by techtonik＠gmail.com Feb. 2, 2011

Feb. 2, 2011

On 2011/02/01 19:50:23, Martin v. Löwis wrote: > On 2011/02/01 07:22:57, techtonik wrote: > > It removes the dependency from msi.py making it easier to do the rest in > > subsequent patches. > What rest specifically? Why are the msilib changes needed for that? The rest is to use ctypes, so that no external packages will be required to build Python installer. http://codereview.appspot.com/4080047/

1 0

Re: [Python-Dev] MSI: Remove dependency from win32com.client module (issue4080047)
by techtonik＠gmail.com Feb. 2, 2011

Feb. 2, 2011

There is no b.p.o issue as it's not a bug, but a tiny copy/paste patch to clean up the code a bit while I am trying to understand how to add Python to the PATH. I see no reason for b.p.o bureaucracy. Mercurial-style workflow [1] is more beneficial to development as it doesn't require switching from console to browser for submitting changes. This way tiny changes can be integrated/updated more rapidly. 1. http://mercurial.selenic.com/wiki/ContributingChanges#The_basics:_patches_b… http://codereview.appspot.com/4080047/

12 20

Rietveld integration status (Was: MSI: Remove dependency from win32com.client module (issue4080047))
by anatoly techtonik Feb. 1, 2011

Feb. 1, 2011

On Tue, Feb 1, 2011 at 9:45 AM, Georg Brandl <g.brandl(a)gmx.net> wrote: > > A mailing list works only if you have a small group of core developers > who can independently organize the incoming mails using local tools, > such as the read/unread marking of the email client. For a larger > group this doesn't work (how do you assign a patch to someone using > a mailing list?). If you can filter patches by module (and it can be done automatically), then you won't need … [View More]

3 2

Re: [Python-Dev] MSI: Remove dependency from win32com.client module (issue4080047)
by martin＠v.loewis.de Feb. 1, 2011

Feb. 1, 2011

On 2011/02/01 07:22:57, techtonik wrote: > It removes the dependency from msi.py making it easier to do the rest in > subsequent patches. What rest specifically? Why are the msilib changes needed for that? http://codereview.appspot.com/4080047/

1 0

Mercurial style patch submission (Was: MSI: Remove dependency from win32com.client module (issue4080047))
by anatoly techtonik Feb. 1, 2011

Feb. 1, 2011

On Mon, Jan 31, 2011 at 10:54 PM, Antoine Pitrou <solipsis(a)pitrou.net> wrote: > On Mon, 31 Jan 2011 20:45:45 +0000 > techtonik(a)gmail.com wrote: >> I see no reason for b.p.o bureaucracy. Mercurial-style workflow [1] is >> more beneficial to development as it doesn't require switching from >> console to browser for submitting changes. > > Ok, why don't you contribute to Mercurial instead? If you don't want to receive a stupid answer, why don't you read the … [View More]

7 6

Re: [Python-Dev] MSI: Remove dependency from win32com.client module (issue4080047)
by techtonik＠gmail.com Feb. 1, 2011

Feb. 1, 2011

It removes the dependency from msi.py making it easier to do the rest in subsequent patches. http://codereview.appspot.com/4080047/

1 0

Re: [Python-Dev] MSI: Remove dependency from win32com.client module (issue4080047)
by martin＠v.loewis.de Feb. 1, 2011

Feb. 1, 2011

What's the rationale of this change? It certainly doesn't remove the dependency from win32com.client (i.e. the code continues to depend on win32com). http://codereview.appspot.com/4080047/

1 0