Python-Dev October 2012

python-dev@python.org

98 participants
95 discussions

Issue 8492 [was Re: [Python-dev] History stepping in interactive session?]

by Steven D'Aprano

Over on python-ideas, a question about readline was raised and, I think, resolved. But while investigating the question, it became obvious to me that the ability to inspect the current readline bindings from Python was both useful and important. I wrote: > I don't believe that there is any direct mechanism for querying the current > readline bindings in Python, But it was requested some time ago: http://bugs.python.org/issue8492 Is there anyone willing and able to give this issue some attention please? (Replies to python-dev only please.) -- Steven

8 years, 9 months

hg verify warnings

by Khalid Abu Bakr

Hello. Running hg verify on a newly checked out cpython repo on Windows Vista 32Bits yields three warnings: $ hg verify repository uses revlog format 1 checking changesets checking manifests crosschecking files in changesets and manifests checking files warning: copy source of 'Modules/_threadmodule.c' not in parents of 60ad83716733 warning: copy source of 'Objects/bytesobject.c' not in parents of 64bb1d258322 warning: copy source of 'Objects/stringobject.c' not in parents of 357e268e7c5f 9799 files, 79660 changesets, 176851 total revisions 3 warnings encountered! $ hg --version Mercurial Distributed SCM (version 2.3.2) (see http://mercurial.selenic.com for more information) Copyright (C) 2005-2012 Matt Mackall and others This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. I have checked out and tried to verify the cloned repo twice with the same results. So is this serious? Or can these warnings be safely ignored? Thanks.

8 years, 9 months

Re: [Python-Dev] [Python-checkins] cpython (merge 3.2 -> 3.3): Fixes Issue #16114: The subprocess module no longer provides a

by Chris Jerdonek

On Wed, Oct 10, 2012 at 3:52 AM, gregory.p.smith <python-checkins(a)python.org> wrote: > http://hg.python.org/cpython/rev/ee30d7ef70be > changeset: 79633:ee30d7ef70be > branch: 3.3 > parent: 79630:9451908da615 > parent: 79632:e938fa6be509 > user: Gregory P. Smith <greg(a)krypto.org> > date: Wed Oct 10 03:44:47 2012 -0700 > summary: > Fixes Issue #16114: The subprocess module no longer provides a > misleading error message stating that args[0] did not exist when > either the cwd or executable keyword arguments specified a path that > did not exist. > + def test_exception_cwd(self): > + """Test error in the child raised in the parent for a bad cwd.""" > + desired_exception = self._get_chdir_exception() > try: > p = subprocess.Popen([sys.executable, "-c", ""], > - cwd=nonexistent_dir) > + cwd=self._nonexistent_dir) > except OSError as e: > # Test that the child process chdir failure actually makes > # it up to the parent process as the correct exception. > @@ -1064,6 +1070,33 @@ > else: > self.fail("Expected OSError: %s" % desired_exception) I was on this issue but didn't have an opportunity to comment. It would be cleaner to use the self.assertRaises() pattern here and also probably better to share code across the three test methods which are nearly identical to one another (there is a fourth scenario I would also add of shell=True). I would also check for FileNotFoundError instead of OSError in the 3.3 and later versions. --Chris > > + def test_exception_bad_executable(self): > + """Test error in the child raised in the parent for a bad executable.""" > + desired_exception = self._get_chdir_exception() > + try: > + p = subprocess.Popen([sys.executable, "-c", ""], > + executable=self._nonexistent_dir) > + except OSError as e: > + # Test that the child process exec failure actually makes > + # it up to the parent process as the correct exception. > + self.assertEqual(desired_exception.errno, e.errno) > + self.assertEqual(desired_exception.strerror, e.strerror) > + else: > + self.fail("Expected OSError: %s" % desired_exception) > + > + def test_exception_bad_args_0(self): > + """Test error in the child raised in the parent for a bad args[0].""" > + desired_exception = self._get_chdir_exception() > + try: > + p = subprocess.Popen([self._nonexistent_dir, "-c", ""]) > + except OSError as e: > + # Test that the child process exec failure actually makes > + # it up to the parent process as the correct exception. > + self.assertEqual(desired_exception.errno, e.errno) > + self.assertEqual(desired_exception.strerror, e.strerror) > + else: > + self.fail("Expected OSError: %s" % desired_exception) > + > def test_restore_signals(self): > # Code coverage for both values of restore_signals to make sure it > # at least does not blow up. > diff --git a/Misc/NEWS b/Misc/NEWS > --- a/Misc/NEWS > +++ b/Misc/NEWS > @@ -37,6 +37,10 @@ > Library > ------- > > +- Issue #16114: The subprocess module no longer provides a misleading error > + message stating that args[0] did not exist when either the cwd or executable > + keyword arguments specified a path that did not exist. > + > - Issue #16169: Fix ctypes.WinError()'s confusion between errno and winerror. > > - Issue #16089: Allow ElementTree.TreeBuilder to work again with a non-Element > diff --git a/Modules/_posixsubprocess.c b/Modules/_posixsubprocess.c > --- a/Modules/_posixsubprocess.c > +++ b/Modules/_posixsubprocess.c > @@ -356,7 +356,7 @@ > PyObject *preexec_fn, > PyObject *preexec_fn_args_tuple) > { > - int i, saved_errno, unused; > + int i, saved_errno, unused, reached_preexec = 0; > PyObject *result; > const char* err_msg = ""; > /* Buffer large enough to hold a hex integer. We can't malloc. */ > @@ -440,6 +440,7 @@ > POSIX_CALL(setsid()); > #endif > > + reached_preexec = 1; > if (preexec_fn != Py_None && preexec_fn_args_tuple) { > /* This is where the user has asked us to deadlock their program. */ > result = PyObject_Call(preexec_fn, preexec_fn_args_tuple, NULL); > @@ -489,6 +490,10 @@ > } > unused = write(errpipe_write, cur, hex_errno + sizeof(hex_errno) - cur); > unused = write(errpipe_write, ":", 1); > + if (!reached_preexec) { > + /* Indicate to the parent that the error happened before exec(). */ > + unused = write(errpipe_write, "noexec", 6); > + } > /* We can't call strerror(saved_errno). It is not async signal safe. > * The parent process will look the error message up. */ > } else { > > -- > Repository URL: http://hg.python.org/cpython > > _______________________________________________ > Python-checkins mailing list > Python-checkins(a)python.org > http://mail.python.org/mailman/listinfo/python-checkins >

8 years, 9 months

Failed issue tracker submission

by Python tracker

The node specified by the designator in the subject of your message ("16712") does not exist. Subject was: "[issue16712] [status=closed; resolution=fixed; stage=committed/rejected]" Mail Gateway Help ================= Incoming messages are examined for multiple parts: . In a multipart/mixed message or part, each subpart is extracted and examined. The text/plain subparts are assembled to form the textual body of the message, to be stored in the file associated with a "msg" class node. Any parts of other types are each stored in separate files and given "file" class nodes that are linked to the "msg" node. . In a multipart/alternative message or part, we look for a text/plain subpart and ignore the other parts. . A message/rfc822 is treated similar tomultipart/mixed (except for special handling of the first text part) if unpack_rfc822 is set in the mailgw config section. Summary ------- The "summary" property on message nodes is taken from the first non-quoting section in the message body. The message body is divided into sections by blank lines. Sections where the second and all subsequent lines begin with a ">" or "|" character are considered "quoting sections". The first line of the first non-quoting section becomes the summary of the message. Addresses --------- All of the addresses in the To: and Cc: headers of the incoming message are looked up among the user nodes, and the corresponding users are placed in the "recipients" property on the new "msg" node. The address in the From: header similarly determines the "author" property of the new "msg" node. The default handling for addresses that don't have corresponding users is to create new users with no passwords and a username equal to the address. (The web interface does not permit logins for users with no passwords.) If we prefer to reject mail from outside sources, we can simply register an auditor on the "user" class that prevents the creation of user nodes with no passwords. Actions ------- The subject line of the incoming message is examined to determine whether the message is an attempt to create a new item or to discuss an existing item. A designator enclosed in square brackets is sought as the first thing on the subject line (after skipping any "Fwd:" or "Re:" prefixes). If an item designator (class name and id number) is found there, the newly created "msg" node is added to the "messages" property for that item, and any new "file" nodes are added to the "files" property for the item. If just an item class name is found there, we attempt to create a new item of that class with its "messages" property initialized to contain the new "msg" node and its "files" property initialized to contain any new "file" nodes. Triggers -------- Both cases may trigger detectors (in the first case we are calling the set() method to add the message to the item's spool; in the second case we are calling the create() method to create a new node). If an auditor raises an exception, the original message is bounced back to the sender with the explanatory message given in the exception. Return-Path: <python-dev(a)python.org> X-Original-To: report(a)bugs.python.org Delivered-To: roundup+tracker(a)psf.upfronthosting.co.za Received: from mail.python.org (mail.python.org [82.94.164.166]) by psf.upfronthosting.co.za (Postfix) with ESMTPS id 93DC71CDEC for <report(a)bugs.python.org>; Tue, 9 Oct 2012 17:16:41 +0200 (CEST) Received: from albatross.python.org (localhost [127.0.0.1]) by mail.python.org (Postfix) with ESMTP id 3XbhqY1FH2zR2h for <report(a)bugs.python.org>; Tue, 9 Oct 2012 17:16:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=python.org; s=200901; t=1349795801; bh=iCK/DXUZXT5YdN3qczalnWeJLXZntJSOwSJCLK4oXiY=; h=MIME-Version:Content-Type:Content-Transfer-Encoding:From:To: Subject:Message-Id:Date; b=SI5InhadwHC9jRtzWowdxRNjdaicnEoMCQwjiei8u4Bm5ENmn1E+BWLOHeXlEnVXE x7UffWiTa3swqNHrNtoNoChufCekDEvPkRE8uGsAp8gwxAQkVzZbjhIaq3P25Npl2v gIbfbBuyMBoq1R/lr9yJ2XY/mCRLfZ3X/p2bWHTk= Received: from localhost (HELO mail.python.org) (127.0.0.1) by albatross.python.org with SMTP; 09 Oct 2012 17:16:41 +0200 Received: from virt-7yvsjn.psf.osuosl.org (virt-7yvsjn.psf.osuosl.org [140.211.10.72]) by mail.python.org (Postfix) with ESMTP for <report(a)bugs.python.org>; Tue, 9 Oct 2012 17:16:40 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 From: python-dev(a)python.org To: report(a)bugs.python.org Subject: [issue16712] [status=closed; resolution=fixed; stage=committed/rejected] Message-Id: <3XbhqY1FH2zR2h(a)mail.python.org> Date: Tue, 9 Oct 2012 17:16:41 +0200 (CEST) TmV3IGNoYW5nZXNldCAzMzJiOTNjZTdiZjkgYnkgQmVuamFtaW4gUGV0ZXJzb24gaW4gYnJhbmNo ICczLjMnOgpjb21wYXJlIHNpbmdsZXRvbnMgYnkgaWRlbnRpdHkgbm90IGVxdWFsaXR5IChjbG9z ZXMgIzE2NzEyKQpodHRwOi8vaGcucHl0aG9uLm9yZy9jcHl0aG9uL3Jldi8zMzJiOTNjZTdiZjkK

8 years, 9 months

Issue #16153: PyUnicode_FromFormatV() must fail if the format string is invalid

by Victor Stinner

Hi, Does anyone know if there is a good reason why PyUnicode_FromFormatV() does not fail on invalid format string, but copies the format string as-if into the result? I would like to change this to raise a ValueError instead. PyUnicode_FromFormatV() is used by PyErr_Format(), so PyErr_Format() may now fail with a ValueError if the format string is invalid. Victor

8 years, 9 months

Re: [Python-Dev] cpython: Issue #16148: implemented PEP 424

by Antoine Pitrou

On Sat, 6 Oct 2012 14:12:36 +0200 (CEST) armin.ronacher <python-checkins(a)python.org> wrote: > http://hg.python.org/cpython/rev/a7ec0a1b0f7c > changeset: 79511:a7ec0a1b0f7c > parent: 79507:3c1df1ede882 > user: Armin Ronacher <armin.ronacher(a)active-4.com> > date: Sat Oct 06 14:03:24 2012 +0200 > summary: > Issue #16148: implemented PEP 424 > [...] > > +.. c:function:: Py_ssize_t PyObject_LengthHint(PyObject *o, Py_ssize_t default) > + > + Return an estimated length for the object *o*. First trying to return its > + actual length, then an estimate using ``__length_hint__``, and finally > + returning the default value. On error ``-1`` is returned. This is the > + equivalent to the Python expression ``operator.length_hint(o, default)``. > + You need a "versionadded" marker. > +.. function:: length_hint(obj, default=0) > + > + Return an estimated length for the object *o*. First trying to return its > + actual length, then an estimate using ``__length_hint__``, and finally > + returning the default value. > + Here as well. > -#ifndef Py_LIMITED_API > - PyAPI_FUNC(Py_ssize_t) _PyObject_LengthHint(PyObject *o, Py_ssize_t); > -#endif > +PyAPI_FUNC(int) _PyObject_HasLen(PyObject *o); > +PyAPI_FUNC(Py_ssize_t) PyObject_LengthHint(PyObject *o, Py_ssize_t); If _PyObject_HasLen is private, it shouldn't be in the Py_LIMITED_API. > diff --git a/Lib/test/test_enumerate.py b/Lib/test/test_enumerate.py > --- a/Lib/test/test_enumerate.py > +++ b/Lib/test/test_enumerate.py > @@ -1,4 +1,5 @@ > import unittest > +import operator > import sys > import pickle > > @@ -168,15 +169,13 @@ > x = range(1) > self.assertEqual(type(reversed(x)), type(iter(x))) > > - @support.cpython_only > def test_len(self): > # This is an implementation detail, not an interface requirement > - from test.test_iterlen import len > for s in ('hello', tuple('hello'), list('hello'), range(5)): > - self.assertEqual(len(reversed(s)), len(s)) > + self.assertEqual(operator.length_hint(reversed(s)), len(s)) You should still test len() as well, no? > + else { > + return res; > + } > + PyObject *hint = _PyObject_LookupSpecial(o, &PyId___length_hint__); Putting variable declarations in the middle of code blocks is not C89-compliant. You probably broke a couple of buildbots :-) > + if (_PyObject_HasLen(it->it_seq)) { > + seqsize = PySequence_Size(it->it_seq); > + if (seqsize == -1) > + return NULL; > + } > + else { > + return Py_NotImplemented; > + } Lacks a Py_INCREF? Regards Antoine. -- Software development and contracting: http://pro.pitrou.net

8 years, 9 months

Re: [Python-Dev] cpython: Issue #16148: implemented PEP 424

by Georg Brandl

Am 06.10.2012 14:12, schrieb armin.ronacher: > http://hg.python.org/cpython/rev/a7ec0a1b0f7c > changeset: 79511:a7ec0a1b0f7c > parent: 79507:3c1df1ede882 > user: Armin Ronacher <armin.ronacher(a)active-4.com> > date: Sat Oct 06 14:03:24 2012 +0200 > summary: > Issue #16148: implemented PEP 424 > > files: > Doc/c-api/object.rst | 7 ++ > Doc/library/operator.rst | 6 + > Include/abstract.h | 5 +- > Lib/test/test_enumerate.py | 9 +- > Lib/test/test_iterlen.py | 62 +++++++++---------- > Lib/test/test_itertools.py | 5 +- > Lib/test/test_operator.py | 25 ++++++++ > Lib/test/test_set.py | 2 - > Modules/operator.c | 27 ++++++++ > Objects/abstract.c | 80 +++++++++++++++---------- > Objects/bytearrayobject.c | 2 +- > Objects/bytesobject.c | 2 +- > Objects/iterobject.c | 11 ++- > Objects/listobject.c | 2 +- > 14 files changed, 162 insertions(+), 83 deletions(-) > > > diff --git a/Doc/c-api/object.rst b/Doc/c-api/object.rst > --- a/Doc/c-api/object.rst > +++ b/Doc/c-api/object.rst > @@ -342,6 +342,13 @@ > returned. This is the equivalent to the Python expression ``len(o)``. > > > +.. c:function:: Py_ssize_t PyObject_LengthHint(PyObject *o, Py_ssize_t default) > + > + Return an estimated length for the object *o*. First trying to return its > + actual length, then an estimate using ``__length_hint__``, and finally > + returning the default value. On error ``-1`` is returned. This is the > + equivalent to the Python expression ``operator.length_hint(o, default)``. Needs a versionadded. Since __length_hint__ is now official, it needs an entry in Doc/reference/datamodel.rst (which you can link to here.) > .. c:function:: PyObject* PyObject_GetItem(PyObject *o, PyObject *key) > > Return element of *o* corresponding to the object *key* or *NULL* on failure. > diff --git a/Doc/library/operator.rst b/Doc/library/operator.rst > --- a/Doc/library/operator.rst > +++ b/Doc/library/operator.rst > @@ -235,6 +235,12 @@ > > .. XXX: find a better, readable, example > > +.. function:: length_hint(obj, default=0) > + > + Return an estimated length for the object *o*. First trying to return its > + actual length, then an estimate using ``__length_hint__``, and finally > + returning the default value. This one also needs versionadded and a link to __length_hint__. > The :mod:`operator` module also defines tools for generalized attribute and item > lookups. These are useful for making fast field extractors as arguments for > :func:`map`, :func:`sorted`, :meth:`itertools.groupby`, or other functions that > diff --git a/Include/abstract.h b/Include/abstract.h > --- a/Include/abstract.h > +++ b/Include/abstract.h > @@ -403,9 +403,8 @@ > PyAPI_FUNC(Py_ssize_t) PyObject_Length(PyObject *o); > #define PyObject_Length PyObject_Size > > -#ifndef Py_LIMITED_API > - PyAPI_FUNC(Py_ssize_t) _PyObject_LengthHint(PyObject *o, Py_ssize_t); > -#endif > +PyAPI_FUNC(int) _PyObject_HasLen(PyObject *o); > +PyAPI_FUNC(Py_ssize_t) PyObject_LengthHint(PyObject *o, Py_ssize_t); Not sure if new functions should be included in the limited API. I seem to recall some discussion about giving Py_LIMITED_API a numeric value for the required API version? PEP 384 is silent about it. > /* > Guess the size of object o using len(o) or o.__length_hint__(). > diff --git a/Lib/test/test_enumerate.py b/Lib/test/test_enumerate.py > --- a/Lib/test/test_enumerate.py > +++ b/Lib/test/test_enumerate.py > @@ -1,4 +1,5 @@ > import unittest > +import operator > import sys > import pickle > > @@ -168,15 +169,13 @@ > x = range(1) > self.assertEqual(type(reversed(x)), type(iter(x))) > > - @support.cpython_only > def test_len(self): > # This is an implementation detail, not an interface requirement If it's not cpython_only anymore, this comment should also vanish? > - from test.test_iterlen import len > for s in ('hello', tuple('hello'), list('hello'), range(5)): > - self.assertEqual(len(reversed(s)), len(s)) > + self.assertEqual(operator.length_hint(reversed(s)), len(s)) > r = reversed(s) > list(r) > - self.assertEqual(len(r), 0) > + self.assertEqual(operator.length_hint(r), 0) > class SeqWithWeirdLen: > called = False > def __len__(self): > @@ -187,7 +186,7 @@ > def __getitem__(self, index): > return index > r = reversed(SeqWithWeirdLen()) > - self.assertRaises(ZeroDivisionError, len, r) > + self.assertRaises(ZeroDivisionError, operator.length_hint, r) > > > def test_gc(self): > diff --git a/Lib/test/test_iterlen.py b/Lib/test/test_iterlen.py > --- a/Lib/test/test_iterlen.py > +++ b/Lib/test/test_iterlen.py > @@ -45,31 +45,21 @@ > from test import support > from itertools import repeat > from collections import deque > -from builtins import len as _len > +from operator import length_hint > ## ------- Concrete Type Tests ------- > > @@ -92,10 +82,6 @@ > def setUp(self): > self.it = repeat(None, n) > > - def test_no_len_for_infinite_repeat(self): > - # The repeat() object can also be infinite > - self.assertRaises(TypeError, len, repeat(None)) Why is this removed? I can see it was duplicated in test_itertools (below), but you removed both instances. > diff --git a/Lib/test/test_itertools.py b/Lib/test/test_itertools.py > --- a/Lib/test/test_itertools.py > +++ b/Lib/test/test_itertools.py > @@ -1723,9 +1723,8 @@ > class LengthTransparency(unittest.TestCase): > > def test_repeat(self): > - from test.test_iterlen import len > - self.assertEqual(len(repeat(None, 50)), 50) > - self.assertRaises(TypeError, len, repeat(None)) > + self.assertEqual(operator.length_hint(repeat(None, 50)), 50) > + self.assertEqual(operator.length_hint(repeat(None), 12), 12) > > class RegressionTests(unittest.TestCase): > > diff --git a/Lib/test/test_operator.py b/Lib/test/test_operator.py > --- a/Lib/test/test_operator.py > +++ b/Lib/test/test_operator.py > @@ -410,6 +410,31 @@ > self.assertEqual(operator.__ixor__ (c, 5), "ixor") > self.assertEqual(operator.__iconcat__ (c, c), "iadd") > > + def test_length_hint(self): > + class X(object): > + def __init__(self, value): > + self.value = value > + > + def __length_hint__(self): > + if type(self.value) is type: > + raise self.value > + else: > + return self.value > + > + self.assertEqual(operator.length_hint([], 2), 0) > + self.assertEqual(operator.length_hint(iter([1, 2, 3])), 3) > + > + self.assertEqual(operator.length_hint(X(2)), 2) > + self.assertEqual(operator.length_hint(X(NotImplemented), 4), 4) > + self.assertEqual(operator.length_hint(X(TypeError), 12), 12) > + with self.assertRaises(TypeError): > + operator.length_hint(X("abc")) > + with self.assertRaises(ValueError): > + operator.length_hint(X(-2)) > + with self.assertRaises(LookupError): > + operator.length_hint(X(LookupError)) > + > + > def test_main(verbose=None): > import sys > test_classes = ( > diff --git a/Lib/test/test_set.py b/Lib/test/test_set.py > --- a/Lib/test/test_set.py > +++ b/Lib/test/test_set.py > @@ -848,8 +848,6 @@ > for v in self.set: > self.assertIn(v, self.values) > setiter = iter(self.set) > - # note: __length_hint__ is an internal undocumented API, > - # don't rely on it in your own programs > self.assertEqual(setiter.__length_hint__(), len(self.set)) > > def test_pickling(self): > diff --git a/Modules/operator.c b/Modules/operator.c > --- a/Modules/operator.c > +++ b/Modules/operator.c > @@ -208,6 +208,31 @@ > return (result == 0); > } > > +PyDoc_STRVAR(length_hint__doc__, > +"length_hint(obj, default=0) -> int\n" > +"Return an estimate of the number of items in obj.\n" > +"This is useful for presizing containers when building from an\n" > +"iterable.\n" > +"\n" > +"If the object supports len(), the result will be\n" > +"exact. Otherwise, it may over- or under-estimate by an\n" > +"arbitrary amount. The result will be an integer >= 0."); > + > +static PyObject *length_hint(PyObject *self, PyObject *args) > +{ > + PyObject *obj; > + Py_ssize_t defaultvalue = 0, res; > + if (!PyArg_ParseTuple(args, "O|n:length_hint", &obj, &defaultvalue)) { > + return NULL; > + } > + res = PyObject_LengthHint(obj, defaultvalue); > + if (res == -1 && PyErr_Occurred()) { > + return NULL; > + } > + return PyLong_FromSsize_t(res); > +} > + > + > PyDoc_STRVAR(compare_digest__doc__, > "compare_digest(a, b) -> bool\n" > "\n" > @@ -366,6 +391,8 @@ > > {"_compare_digest", (PyCFunction)compare_digest, METH_VARARGS, > compare_digest__doc__}, > + {"length_hint", (PyCFunction)length_hint, METH_VARARGS, > + length_hint__doc__}, > {NULL, NULL} /* sentinel */ > > }; > diff --git a/Objects/abstract.c b/Objects/abstract.c > --- a/Objects/abstract.c > +++ b/Objects/abstract.c > @@ -64,49 +64,67 @@ > } > #define PyObject_Length PyObject_Size > > +int > +_PyObject_HasLen(PyObject *o) { > + return (Py_TYPE(o)->tp_as_sequence && Py_TYPE(o)->tp_as_sequence->sq_length) || > + (Py_TYPE(o)->tp_as_mapping && Py_TYPE(o)->tp_as_mapping->mp_length); > +} > > /* The length hint function returns a non-negative value from o.__len__() > - or o.__length_hint__(). If those methods aren't found or return a negative > - value, then the defaultvalue is returned. If one of the calls fails, > - this function returns -1. > + or o.__length_hint__(). If those methods aren't found. If one of the calls ^^^^^ Sentence incomplete. > + fails this function returns -1. > */ > > Py_ssize_t > -_PyObject_LengthHint(PyObject *o, Py_ssize_t defaultvalue) > +PyObject_LengthHint(PyObject *o, Py_ssize_t defaultvalue) Should we put "#define _PyObject_LengthHint PyObject_LengthHint" in some header to make porting easier? > { > _Py_IDENTIFIER(__length_hint__); > - PyObject *ro, *hintmeth; > - Py_ssize_t rv; > - > - /* try o.__len__() */ > - rv = PyObject_Size(o); > - if (rv >= 0) > - return rv; > - if (PyErr_Occurred()) { > - if (!PyErr_ExceptionMatches(PyExc_TypeError)) > + Py_ssize_t res = PyObject_Length(o); > + if (res < 0 && PyErr_Occurred()) { > + if (!PyErr_ExceptionMatches(PyExc_TypeError)) { > return -1; > + } > PyErr_Clear(); > } > - > - /* try o.__length_hint__() */ > - hintmeth = _PyObject_LookupSpecial(o, &PyId___length_hint__); > - if (hintmeth == NULL) { > - if (PyErr_Occurred()) > + else { > + return res; > + } > + PyObject *hint = _PyObject_LookupSpecial(o, &PyId___length_hint__); > + if (hint == NULL) { > + if (PyErr_Occurred()) { > return -1; > - else > - return defaultvalue; > - } > - ro = PyObject_CallFunctionObjArgs(hintmeth, NULL); > - Py_DECREF(hintmeth); > - if (ro == NULL) { > - if (!PyErr_ExceptionMatches(PyExc_TypeError)) > - return -1; > - PyErr_Clear(); > + } > return defaultvalue; > } > - rv = PyLong_Check(ro) ? PyLong_AsSsize_t(ro) : defaultvalue; > - Py_DECREF(ro); > - return rv; > + PyObject *result = PyObject_CallFunctionObjArgs(hint, NULL); > + Py_DECREF(hint); > + if (result == NULL) { > + if (PyErr_ExceptionMatches(PyExc_TypeError)) { > + PyErr_Clear(); > + return defaultvalue; > + } > + return -1; > + } > + else if (result == Py_NotImplemented) { > + Py_DECREF(result); > + return defaultvalue; > + } > + if (!PyLong_Check(result)) { > + PyErr_Format(PyExc_TypeError, "Length hint must be an integer, not %s", We usually limit the string size here, e.g. "%.100s". > + Py_TYPE(result)->tp_name); > + Py_DECREF(result); > + return -1; > + } > + defaultvalue = PyLong_AsSsize_t(result); Not sure the micro-optimization is worth the confusion of reassigning defaultvalue. > + Py_DECREF(result); > + if (defaultvalue < 0 && PyErr_Occurred()) { > + return -1; > + } > + if (defaultvalue < 0) { > + PyErr_Format(PyExc_ValueError, "__length_hint__() should return >= 0"); Exception message is inconsistent with above: "Length hint" vs "__length_hint__()". > + return -1; > + } > + return defaultvalue; > } > diff --git a/Objects/iterobject.c b/Objects/iterobject.c > --- a/Objects/iterobject.c > +++ b/Objects/iterobject.c > @@ -76,9 +76,14 @@ > Py_ssize_t seqsize, len; > > if (it->it_seq) { > - seqsize = PySequence_Size(it->it_seq); > - if (seqsize == -1) > - return NULL; > + if (_PyObject_HasLen(it->it_seq)) { > + seqsize = PySequence_Size(it->it_seq); > + if (seqsize == -1) > + return NULL; > + } > + else { > + return Py_NotImplemented; An INCREF is missing here, as discussed on IRC. > + } > len = seqsize - it->it_index; > if (len >= 0) > return PyLong_FromSsize_t(len);

8 years, 9 months

Should vars() return modifiable dict?

by Serhiy Storchaka

For objects with __dict__ vars() returns modifiable dict: >>> class A(): ... pass ... >>> a = A() >>> a.x = 42 >>> vars(a) {'x': 42} >>> vars(a)['x'] = 43 >>> vars(a)['y'] = 44 >>> a.x, a.y, vars(a) (43, 44, {'y': 44, 'x': 43}) For globals vars() returns modifiable dict: >>> x = 42 >>> vars()['x'] 42 >>> vars()['x'] = 43 >>> vars()['y'] = 44 >>> vars()['x'], vars()['y'] (43, 44) For locals vars() returns... hmm, partially modifiable dict: >>> def f(): ... x = 42 ... print(vars()) ... vars()['x'] = 43 ... vars()['y'] = 44 ... print(x, vars()) ... >>> f() {'x': 42} 42 {'y': 44, 'x': 42} Should behavior of vars() be corrected for locals? Should vars() for objects with __slots__ [1] returns modifiable or non-modifiable dict? [1] http://bugs.python.org/issue13290

8 years, 9 months

Summary of Python tracker Issues

by Python tracker

ACTIVITY SUMMARY (2012-09-28 - 2012-10-05) Python tracker at http://bugs.python.org/ To view or respond to any of the issues listed below, click on the issue. Do NOT respond to this message. Issues counts and deltas: open 3770 (+16) closed 24149 (+43) total 27919 (+59) Open issues with patches: 1676 Issues opened (44) ================== #3982: support .format for bytes http://bugs.python.org/issue3982 reopened by exarkun #15111: Wrong ImportError message with importlib http://bugs.python.org/issue15111 reopened by brett.cannon #15379: Charmap decoding of no-BMP characters http://bugs.python.org/issue15379 reopened by serhiy.storchaka #16086: tp_flags: Undefined behaviour with 32 bits long http://bugs.python.org/issue16086 opened by haypo #16088: http.server's send_error could set the content-length of the e http://bugs.python.org/issue16088 opened by pitrou #16094: Tuple extraction in a lambda isn't supported by 2to3 http://bugs.python.org/issue16094 opened by GlitchMr #16095: urllib2 failing with squid proxy and digest authentication http://bugs.python.org/issue16095 opened by toobaz #16096: Get rid of dangerous integer overflow tricks http://bugs.python.org/issue16096 opened by serhiy.storchaka #16098: Bisect optimization in heapq.nsmallest is never used http://bugs.python.org/issue16098 opened by haldean #16099: robotparser doesn't support request rate and crawl delay param http://bugs.python.org/issue16099 opened by XapaJIaMnu #16100: Compiling vim with Python 3.3 support fails http://bugs.python.org/issue16100 opened by v_core #16101: Verify all imported modules at startup are needed http://bugs.python.org/issue16101 opened by brett.cannon #16102: uuid._netbios_getnode() is outdated http://bugs.python.org/issue16102 opened by serhiy.storchaka #16103: Help() fails at raw_input readline (IDLE 2.7.3, Win7, pythonw) http://bugs.python.org/issue16103 opened by terry.reedy #16104: Use multiprocessing in compileall script http://bugs.python.org/issue16104 opened by dholth #16105: Pass read only FD to signal.set_wakeup_fd http://bugs.python.org/issue16105 opened by felipecruz #16106: antigravity tests http://bugs.python.org/issue16106 opened by ezio.melotti #16107: distutils2.version doesn't str() "1.0.post1" correctly http://bugs.python.org/issue16107 opened by richard #16108: Include maintainer information in register/upload http://bugs.python.org/issue16108 opened by richard #16110: Provide logging.config.configParserConfig http://bugs.python.org/issue16110 opened by thbach #16111: Python 2.7.3 Windows MSI installer installs the VC++ 9 dlls di http://bugs.python.org/issue16111 opened by freaksterrao #16112: platform.architecture does not correctly escape argument to /u http://bugs.python.org/issue16112 opened by David.Benjamin #16113: Add SHA-3 (Keccak) support http://bugs.python.org/issue16113 opened by christian.heimes #16114: incorrect path in subprocess.Popen() FileNotFoundError message http://bugs.python.org/issue16114 opened by chris.jerdonek #16115: test that executable arg to Popen() takes precedence over args http://bugs.python.org/issue16115 opened by chris.jerdonek #16116: Can not install C extension modules to inside a venv on Python http://bugs.python.org/issue16116 opened by msmhrt #16117: python2.7.3 struct misaligned when returned http://bugs.python.org/issue16117 opened by iroli #16119: Python 2.7 _socket DLL import error on Windows Vista http://bugs.python.org/issue16119 opened by sk7 #16120: Use |yield from| in stdlib http://bugs.python.org/issue16120 opened by berker.peksag #16121: shlex.shlex.error_leader() reports incorrect line number http://bugs.python.org/issue16121 opened by Arfrever #16123: IDLE - deprecate running without a subprocess http://bugs.python.org/issue16123 opened by serwy #16124: fcntl_ioctl still not 100% sane with unsigned longs http://bugs.python.org/issue16124 opened by yaneurabeya #16125: open accepts arbitrary mode strings as long as they contain U http://bugs.python.org/issue16125 opened by nneonneo #16128: hashable documentation error http://bugs.python.org/issue16128 opened by max #16129: No good way to set 'PYTHONIOENCODING' when embedding python. http://bugs.python.org/issue16129 opened by ideasman42 #16132: ctypes incorrectly encodes .format attribute of memory views http://bugs.python.org/issue16132 opened by dabeaz #16133: asyncore.dispatcher.recv doesn't handle EAGAIN / EWOULDBLOCK http://bugs.python.org/issue16133 opened by Nidan #16134: Add support for RTMP schemes to urlparse http://bugs.python.org/issue16134 opened by Jorge.Gomes #16136: Removal of VMS support http://bugs.python.org/issue16136 opened by jcea #16137: Using time.asctime() with an array with negative tm_hour cause http://bugs.python.org/issue16137 opened by Viktor.Chynarov #16139: Python 3.3 fails when starting from read-only FS http://bugs.python.org/issue16139 opened by andrewjcg #16140: subprocess.Popen the os.close calls in _execute_child can rais http://bugs.python.org/issue16140 opened by gregory.p.smith #16141: Possible simplification for logging.StreamHandler exception ha http://bugs.python.org/issue16141 opened by gvanrossum #16142: ArgumentParser inconsistent with parse_known_args http://bugs.python.org/issue16142 opened by idank Most recent 15 issues with no replies (15) ========================================== #16141: Possible simplification for logging.StreamHandler exception ha http://bugs.python.org/issue16141 #16133: asyncore.dispatcher.recv doesn't handle EAGAIN / EWOULDBLOCK http://bugs.python.org/issue16133 #16132: ctypes incorrectly encodes .format attribute of memory views http://bugs.python.org/issue16132 #16128: hashable documentation error http://bugs.python.org/issue16128 #16124: fcntl_ioctl still not 100% sane with unsigned longs http://bugs.python.org/issue16124 #16121: shlex.shlex.error_leader() reports incorrect line number http://bugs.python.org/issue16121 #16117: python2.7.3 struct misaligned when returned http://bugs.python.org/issue16117 #16111: Python 2.7.3 Windows MSI installer installs the VC++ 9 dlls di http://bugs.python.org/issue16111 #16108: Include maintainer information in register/upload http://bugs.python.org/issue16108 #16102: uuid._netbios_getnode() is outdated http://bugs.python.org/issue16102 #16095: urllib2 failing with squid proxy and digest authentication http://bugs.python.org/issue16095 #16070: Structure and native Structure (LittleEndianStructure on Windo http://bugs.python.org/issue16070 #16067: UAC prompt for installation shows temporary file name http://bugs.python.org/issue16067 #16058: ConfigParser no longer deepcopy compatible in 2.7 http://bugs.python.org/issue16058 #16047: Tools/freeze no longer works in Python 3 http://bugs.python.org/issue16047 Most recent 15 issues waiting for review (15) ============================================= #16125: open accepts arbitrary mode strings as long as they contain U http://bugs.python.org/issue16125 #16123: IDLE - deprecate running without a subprocess http://bugs.python.org/issue16123 #16120: Use |yield from| in stdlib http://bugs.python.org/issue16120 #16115: test that executable arg to Popen() takes precedence over args http://bugs.python.org/issue16115 #16114: incorrect path in subprocess.Popen() FileNotFoundError message http://bugs.python.org/issue16114 #16113: Add SHA-3 (Keccak) support http://bugs.python.org/issue16113 #16112: platform.architecture does not correctly escape argument to /u http://bugs.python.org/issue16112 #16110: Provide logging.config.configParserConfig http://bugs.python.org/issue16110 #16108: Include maintainer information in register/upload http://bugs.python.org/issue16108 #16107: distutils2.version doesn't str() "1.0.post1" correctly http://bugs.python.org/issue16107 #16106: antigravity tests http://bugs.python.org/issue16106 #16105: Pass read only FD to signal.set_wakeup_fd http://bugs.python.org/issue16105 #16099: robotparser doesn't support request rate and crawl delay param http://bugs.python.org/issue16099 #16098: Bisect optimization in heapq.nsmallest is never used http://bugs.python.org/issue16098 #16096: Get rid of dangerous integer overflow tricks http://bugs.python.org/issue16096 Top 10 most discussed issues (10) ================================= #8800: add threading.RWLock http://bugs.python.org/issue8800 50 msgs #16112: platform.architecture does not correctly escape argument to /u http://bugs.python.org/issue16112 27 msgs #16105: Pass read only FD to signal.set_wakeup_fd http://bugs.python.org/issue16105 15 msgs #16079: list duplicate test names with patchcheck http://bugs.python.org/issue16079 14 msgs #3982: support .format for bytes http://bugs.python.org/issue3982 13 msgs #13290: get vars for object with __slots__ http://bugs.python.org/issue13290 12 msgs #16113: Add SHA-3 (Keccak) support http://bugs.python.org/issue16113 11 msgs #16074: bad error message in os.rename http://bugs.python.org/issue16074 10 msgs #12947: doctest directive examples in library/doctest.html lack the fl http://bugs.python.org/issue12947 9 msgs #16116: Can not install C extension modules to inside a venv on Python http://bugs.python.org/issue16116 9 msgs Issues closed (45) ================== #2489: Patch for bugs in pty.py http://bugs.python.org/issue2489 closed by gregory.p.smith #9650: format codes in time.strptime docstrings http://bugs.python.org/issue9650 closed by belopolsky #12069: test_signal.test_without_siginterrupt() failure on AMD64 OpenI http://bugs.python.org/issue12069 closed by haypo #13398: _cursesmodule does not build, doesn't find Python.h on Solaris http://bugs.python.org/issue13398 closed by jcea #13801: The Python 3 Docs don't highlight nonlocal http://bugs.python.org/issue13801 closed by georg.brandl #14161: python2 file __repr__ does not escape filename http://bugs.python.org/issue14161 closed by ezio.melotti #14331: Python/import.c uses a lot of stack space due to MAXPATHLEN http://bugs.python.org/issue14331 closed by gregory.p.smith #14446: Remove deprecated tkinter functions http://bugs.python.org/issue14446 closed by asvetlov #14503: docs: "yield from" breaks Pygments syntax coloring in doc exam http://bugs.python.org/issue14503 closed by georg.brandl #14997: IDLE tries to run shell window if line is completed with F5 ra http://bugs.python.org/issue14997 closed by asvetlov #15201: C argument errors and Python arguments error are different http://bugs.python.org/issue15201 closed by benjamin.peterson #15417: Add support for csh and fish in venv activation scripts http://bugs.python.org/issue15417 closed by asvetlov #15488: Closed files keep their buffer alive http://bugs.python.org/issue15488 closed by python-dev #15609: Format string: add more fast-path http://bugs.python.org/issue15609 closed by haypo #15756: subprocess.poll() does not handle errno.ECHILD "No child proce http://bugs.python.org/issue15756 closed by gregory.p.smith #15766: _imp.load_dynamic() does crash with non-ASCII path and uses th http://bugs.python.org/issue15766 closed by python-dev #15897: zipimport.c doesn't check return value of fseek() http://bugs.python.org/issue15897 closed by python-dev #15923: Building from a fresh clone breaks on Parser/asdl_c.py http://bugs.python.org/issue15923 closed by ezio.melotti #15979: Improve timeit documentation http://bugs.python.org/issue15979 closed by ezio.melotti #16001: small ints: cache string representation http://bugs.python.org/issue16001 closed by haypo #16029: pickle.dumps(xrange(sys.maxsize)) produces xrange(0) http://bugs.python.org/issue16029 closed by mark.dickinson #16030: xrange repr broken for large arguments http://bugs.python.org/issue16030 closed by mark.dickinson #16034: bz2 module appears slower in Python 3.x versus Python 2.x http://bugs.python.org/issue16034 closed by nadeem.vawda #16036: simplify int() signature docs http://bugs.python.org/issue16036 closed by python-dev #16065: setup.py: passing --prefix=/ makes --root ignored http://bugs.python.org/issue16065 closed by eric.araujo #16071: fix link to email.message.Message in mailbox docs http://bugs.python.org/issue16071 closed by r.david.murray #16077: fix code example in docs for built-in reduce() http://bugs.python.org/issue16077 closed by chris.jerdonek #16084: couple of code examples not highlighted in "What's new in Pyth http://bugs.python.org/issue16084 closed by mark.dickinson #16085: Minor config parser doc change http://bugs.python.org/issue16085 closed by r.david.murray #16087: How to open a csv file in universal new line mode? http://bugs.python.org/issue16087 closed by r.david.murray #16089: _elementtree.TreeBuilder broken with a non-C-deriving element_ http://bugs.python.org/issue16089 closed by pitrou #16090: but is needed somewhere in http://www.python.org/dev/peps/pep- http://bugs.python.org/issue16090 closed by georg.brandl #16091: changing sidebar links in http://docs.python.org/ http://bugs.python.org/issue16091 closed by python-dev #16092: test_recursion_limit in test_threading fails on Mac OS X in 3. http://bugs.python.org/issue16092 closed by ned.deily #16093: Documentation: links to 3.3 http://bugs.python.org/issue16093 closed by georg.brandl #16097: Minor fix in comment in codecs.py http://bugs.python.org/issue16097 closed by tim.golden #16109: urllib2.urlopen throws HTTP Error in python 2.7.2, 2.7.3, but http://bugs.python.org/issue16109 closed by pitrou #16118: Implement SHA-3 http://bugs.python.org/issue16118 closed by brett.cannon #16122: Allow *open* to accept file-like objects http://bugs.python.org/issue16122 closed by benjamin.peterson #16126: PyErr_Format format mismatch in _testcapimodule.c http://bugs.python.org/issue16126 closed by python-dev #16127: Correct mentions of narrow build in documentation and comments http://bugs.python.org/issue16127 closed by ezio.melotti #16130: "Porting to Python 3.3" needs to be fixed in "What's new In Py http://bugs.python.org/issue16130 closed by python-dev #16131: Pylauncher is being installed in Windows system folder http://bugs.python.org/issue16131 closed by loewis #16135: Removal of OS/2 support http://bugs.python.org/issue16135 closed by python-dev #16138: In the glossary there is a small typo about __len__() in the s http://bugs.python.org/issue16138 closed by asvetlov

8 years, 9 months

Re: [Python-Dev] [Python-checkins] cpython: Issue #14446: Remove deprecated tkinter functions: Delete an unused function to

by Andrew Svetlov

Thank you, Jesus. I've missed this function. On Fri, Oct 5, 2012 at 5:03 AM, jesus.cea <python-checkins(a)python.org> wrote: > http://hg.python.org/cpython/rev/e278f3ab0190 > changeset: 79484:e278f3ab0190 > user: Jesus Cea <jcea(a)jcea.es> > date: Fri Oct 05 04:02:41 2012 +0200 > summary: > Issue #14446: Remove deprecated tkinter functions: Delete an unused function to avoid a warning > > files: > Modules/_tkinter.c | 30 ------------------------------ > 1 files changed, 0 insertions(+), 30 deletions(-) > > > diff --git a/Modules/_tkinter.c b/Modules/_tkinter.c > --- a/Modules/_tkinter.c > +++ b/Modules/_tkinter.c > @@ -323,36 +323,6 @@ > #endif /* WITH_THREAD */ > > > -static char * > -AsString(PyObject *value, PyObject *tmp) > -{ > - if (PyBytes_Check(value)) > - return PyBytes_AsString(value); > - else if (PyUnicode_Check(value)) { > - PyObject *v = PyUnicode_AsUTF8String(value); > - if (v == NULL) > - return NULL; > - if (PyList_Append(tmp, v) != 0) { > - Py_DECREF(v); > - return NULL; > - } > - Py_DECREF(v); > - return PyBytes_AsString(v); > - } > - else { > - PyObject *v = PyObject_Str(value); > - if (v == NULL) > - return NULL; > - if (PyList_Append(tmp, v) != 0) { > - Py_DECREF(v); > - return NULL; > - } > - Py_DECREF(v); > - return PyBytes_AsString(v); > - } > -} > - > - > > #define ARGSZ 64 > > > -- > Repository URL: http://hg.python.org/cpython > > _______________________________________________ > Python-checkins mailing list > Python-checkins(a)python.org > http://mail.python.org/mailman/listinfo/python-checkins > -- Thanks, Andrew Svetlov

8 years, 9 months

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

2000

1999

Python-Dev October 2012