Mailman 3 May 2012 - Python-Dev

The step command of pdb is broken
by Xavier de Gaye 05 May '12

05 May '12

Issue http://bugs.python.org/issue13183 raises the point that the step command of pdb is broken. This issue is 6 months old. A patch and test case have been proposed. The 'Lifecycle of a Patch' at http://docs.python.org/devguide/patch.html says <quote> If your patch has not received any notice from reviewers (i.e., no comment made) after a substantial amount of time then you may email python-dev(a)python.org asking for someone to take a look at your patch. </quote> I am the author of pyclewn, a Vim front end to pdb and gdb, and I would be grateful for any progress on this issue. The following pdb session shows the problem when running the three modules main.py, foo.py and bar.py. After the second step command, pdb does not stop (as it should) at lines foo.py:5 and foo.py:6, nor does it stop to print the return value of increment(). ================================================= main.py 1 import foo 2 3 result = foo.increment(100) 4 print('result', result) foo.py 1 import bar 2 3 def increment(arg): 4 v = bar.value() 5 result = arg + v 6 return result bar.py 1 def value(): 2 return 5 ================================================= $ python -m pdb main.py > /path_to/main.py(1)<module>() -> import foo (Pdb) import sys; sys.version '3.3.0a2+ (default:2c27093fd11f, Apr 30 2012, 10:51:35) \n[GCC 4.3.2]' (Pdb) break bar.py:2 Breakpoint 1 at /path_to/bar.py:2 (Pdb) continue > /path_to/bar.py(2)value() -> return 5 (Pdb) step --Return-- > /path_to/bar.py(2)value()->5 -> return 5 (Pdb) step > /path_to/main.py(4)<module>() -> print('result', result) (Pdb) ================================================= Xavier

5 8

Another buildslave - Ubuntu again
by Senthil Kumaran 04 May '12

04 May '12

Hello, I just got a Ubuntu Server running at my disposal, which could be connected 24/7 for at least next 3 months. I am not sure how helpful it would be to have another buildbot on Ubuntu, but i wanted to play with it for a while (as I have more comfort with Ubuntu than any other Unix flavor) before I could change it to cover as OS which is not already covered by the buildbots. As instructed here - http://wiki.python.org/moin/BuildBot could someone please help create a slavename/slavepasswd on dinsdale.python.org. Also, I think the instructions in the wiki could be improved. I was not able to su - buildbot after installing through package manager. I shall edit it once I have set it up and running. Thanks, Senthil

4 13

Summary of Python tracker Issues
by Python tracker 04 May '12

04 May '12

ACTIVITY SUMMARY (2012-04-27 - 2012-05-04) Python tracker at http://bugs.python.org/ To view or respond to any of the issues listed below, click on the issue. Do NOT respond to this message. Issues counts and deltas: open 3399 ( -6) closed 23101 (+45) total 26500 (+39) Open issues with patches: 1452 Issues opened (26) ================== #13183: pdb skips frames after hitting a breakpoint and running step http://bugs.python.org/issue13183 reopened by loewis #14428: Implementation of the PEP 418 http://bugs.python.org/issue14428 reopened by neologix #14684: zlib set dictionary support inflateSetDictionary http://bugs.python.org/issue14684 opened by Sam.Rushing #14689: make PYTHONWARNINGS variable work in libpython http://bugs.python.org/issue14689 opened by petere #14690: Use monotonic time for sched, trace and subprocess modules http://bugs.python.org/issue14690 opened by haypo #14692: json.joads parse_constant callback not working anymore http://bugs.python.org/issue14692 opened by Jakob.Simon-Gaarde #14693: hashlib fallback modules should be built even if openssl *is* http://bugs.python.org/issue14693 opened by dov #14695: Tools/parser/unparse.py is out of date. http://bugs.python.org/issue14695 opened by mark.dickinson #14697: parser module doesn't support set displays or set comprehensio http://bugs.python.org/issue14697 opened by mark.dickinson #14698: test_posix failures - getpwduid()/initgroups()/getgroups() http://bugs.python.org/issue14698 opened by neologix #14700: Integer overflow in classic string formatting http://bugs.python.org/issue14700 opened by storchaka #14701: parser module doesn't support 'raise ... from' http://bugs.python.org/issue14701 opened by mark.dickinson #14702: os.makedirs breaks under autofs directories http://bugs.python.org/issue14702 opened by amcnabb #14703: Update PEP metaprocesses to describe PEP czar role http://bugs.python.org/issue14703 opened by ncoghlan #14705: Add 'bool' format character to PyArg_ParseTuple* http://bugs.python.org/issue14705 opened by larry #14709: http.client fails sending read()able Object http://bugs.python.org/issue14709 opened by Tobias.Steinrücken #14710: pkgutil.get_loader is broken http://bugs.python.org/issue14710 opened by Pavel.Aslanov #14711: Remove os.stat_float_times http://bugs.python.org/issue14711 opened by aronacher #14712: Integrate PEP 405 http://bugs.python.org/issue14712 opened by vinay.sajip #14713: PEP 414 installation hook fails with an AssertionError http://bugs.python.org/issue14713 opened by vinay.sajip #14714: PEp 414 tokenizing hook does not preserve tabs http://bugs.python.org/issue14714 opened by vinay.sajip #14715: test.support.DirsOnSysPath should be replaced by importlib.tes http://bugs.python.org/issue14715 opened by eric.smith #14716: Use unicode_writer API for str.format() http://bugs.python.org/issue14716 opened by haypo #14720: sqlite3 microseconds http://bugs.python.org/issue14720 opened by frankmillman #14721: httplib doesn't specify content-length header for POST request http://bugs.python.org/issue14721 opened by Arve.Knudsen #14722: Overflow in parsing 'float' parameters in PyArg_ParseTuple* http://bugs.python.org/issue14722 opened by storchaka Most recent 15 issues with no replies (15) ========================================== #14714: PEp 414 tokenizing hook does not preserve tabs http://bugs.python.org/issue14714 #14713: PEP 414 installation hook fails with an AssertionError http://bugs.python.org/issue14713 #14712: Integrate PEP 405 http://bugs.python.org/issue14712 #14709: http.client fails sending read()able Object http://bugs.python.org/issue14709 #14703: Update PEP metaprocesses to describe PEP czar role http://bugs.python.org/issue14703 #14695: Tools/parser/unparse.py is out of date. http://bugs.python.org/issue14695 #14689: make PYTHONWARNINGS variable work in libpython http://bugs.python.org/issue14689 #14680: pydoc with -w option does not work for a lot of help topics http://bugs.python.org/issue14680 #14679: Changes to html.parser break third-party code http://bugs.python.org/issue14679 #14674: Add link to RFC 4627 from json documentation http://bugs.python.org/issue14674 #14652: Better error messages for wsgiref validator failures http://bugs.python.org/issue14652 #14649: doctest.DocTestSuite error misleading when module has no docst http://bugs.python.org/issue14649 #14645: Generator does not translate linesep characters in certain cir http://bugs.python.org/issue14645 #14616: subprocess docs should mention pipes.quote/shlex.quote http://bugs.python.org/issue14616 #14584: Add gzip support to xmlrpc.server http://bugs.python.org/issue14584 Most recent 15 issues waiting for review (15) ============================================= #14722: Overflow in parsing 'float' parameters in PyArg_ParseTuple* http://bugs.python.org/issue14722 #14716: Use unicode_writer API for str.format() http://bugs.python.org/issue14716 #14712: Integrate PEP 405 http://bugs.python.org/issue14712 #14710: pkgutil.get_loader is broken http://bugs.python.org/issue14710 #14705: Add 'bool' format character to PyArg_ParseTuple* http://bugs.python.org/issue14705 #14701: parser module doesn't support 'raise ... from' http://bugs.python.org/issue14701 #14700: Integer overflow in classic string formatting http://bugs.python.org/issue14700 #14698: test_posix failures - getpwduid()/initgroups()/getgroups() http://bugs.python.org/issue14698 #14697: parser module doesn't support set displays or set comprehensio http://bugs.python.org/issue14697 #14695: Tools/parser/unparse.py is out of date. http://bugs.python.org/issue14695 #14693: hashlib fallback modules should be built even if openssl *is* http://bugs.python.org/issue14693 #14692: json.joads parse_constant callback not working anymore http://bugs.python.org/issue14692 #14690: Use monotonic time for sched, trace and subprocess modules http://bugs.python.org/issue14690 #14689: make PYTHONWARNINGS variable work in libpython http://bugs.python.org/issue14689 #14684: zlib set dictionary support inflateSetDictionary http://bugs.python.org/issue14684 Top 10 most discussed issues (10) ================================= #14127: add st_*time_ns fields to os.stat(), add ns keyword to os.*uti http://bugs.python.org/issue14127 20 msgs #14705: Add 'bool' format character to PyArg_ParseTuple* http://bugs.python.org/issue14705 16 msgs #13183: pdb skips frames after hitting a breakpoint and running step http://bugs.python.org/issue13183 13 msgs #14428: Implementation of the PEP 418 http://bugs.python.org/issue14428 13 msgs #14700: Integer overflow in classic string formatting http://bugs.python.org/issue14700 13 msgs #14304: Implement utf-8-bmp codec http://bugs.python.org/issue14304 11 msgs #14656: Add a macro for unreachable code http://bugs.python.org/issue14656 11 msgs #14693: hashlib fallback modules should be built even if openssl *is* http://bugs.python.org/issue14693 11 msgs #11352: Update cgi module doc http://bugs.python.org/issue11352 9 msgs #14662: shutil.move doesn't handle ENOTSUP raised by chflags on OS X http://bugs.python.org/issue14662 8 msgs Issues closed (41) ================== #6085: Logging in BaseHTTPServer.BaseHTTPRequestHandler causes lag http://bugs.python.org/issue6085 closed by orsenthil #7185: csv reader utf-8 BOM error http://bugs.python.org/issue7185 closed by r.david.murray #7707: multiprocess.Queue operations during import can lead to deadlo http://bugs.python.org/issue7707 closed by pitrou #9123: insecure os.urandom on VMS http://bugs.python.org/issue9123 closed by loewis #9154: Parser module doesn't understand function annotations. http://bugs.python.org/issue9154 closed by mark.dickinson #10433: Document unique behavior of 'getgroups' on OSX http://bugs.python.org/issue10433 closed by ned.deily #11839: argparse: unexpected behavior of default for FileType('w') http://bugs.python.org/issue11839 closed by Paolo.Elvati #14236: re: Docstring for \s and \S doesn’t mention Unicode http://bugs.python.org/issue14236 closed by ezio.melotti #14309: Deprecate time.clock() http://bugs.python.org/issue14309 closed by python-dev #14371: Add support for bzip2 compression to the zipfile module http://bugs.python.org/issue14371 closed by loewis #14387: Include\accu.h incompatible with Windows.h http://bugs.python.org/issue14387 closed by skrah #14427: urllib.request.Request get_header and header_items not documen http://bugs.python.org/issue14427 closed by orsenthil #14461: In re's positive lookbehind assertion documentation match() ca http://bugs.python.org/issue14461 closed by ezio.melotti #14519: In re's examples the example with scanf() contains wrong analo http://bugs.python.org/issue14519 closed by ezio.melotti #14521: math.copysign(1., float('nan')) returns -1. http://bugs.python.org/issue14521 closed by mark.dickinson #14558: Documentation for unittest.main does not describe some keyword http://bugs.python.org/issue14558 closed by ezio.melotti #14605: Make import machinery explicit http://bugs.python.org/issue14605 closed by brett.cannon #14610: configure script hangs on pthread verification and PTHREAD_SCO http://bugs.python.org/issue14610 closed by neologix #14618: remove modules_reloading from the interpreter state http://bugs.python.org/issue14618 closed by eric.snow #14642: Fix importlib.h build rule to not depend on hg http://bugs.python.org/issue14642 closed by loewis #14646: Require loaders set __loader__ and __package__ http://bugs.python.org/issue14646 closed by brett.cannon #14647: imp.reload() on a package leads to a segfault or a GC assertio http://bugs.python.org/issue14647 closed by brett.cannon #14666: test_sendall_interrupted hangs on FreeBSD with a zombi multipr http://bugs.python.org/issue14666 closed by pitrou #14669: test_multiprocessing failure on OS X Tiger http://bugs.python.org/issue14669 closed by neologix #14676: DeprecationWarning missing in default warning filters document http://bugs.python.org/issue14676 closed by sandro.tosi #14685: segfault in --without-threads build http://bugs.python.org/issue14685 closed by skrah #14686: SystemError in unicodeobject.c http://bugs.python.org/issue14686 closed by haypo #14687: Optimize str%tuple for the PEP 393 http://bugs.python.org/issue14687 closed by haypo #14688: Typos in sorting.rst http://bugs.python.org/issue14688 closed by rhettinger #14691: a code example not highlighted in http://docs.python.org/dev/l http://bugs.python.org/issue14691 closed by sandro.tosi #14694: Option to show leading zeros for bin/hex/oct http://bugs.python.org/issue14694 closed by mark.dickinson #14696: parser module doesn't support nonlocal statement http://bugs.python.org/issue14696 closed by mark.dickinson #14699: Calling a classmethod_descriptor directly raises a TypeError f http://bugs.python.org/issue14699 closed by python-dev #14704: NameError Issue in Multiprocessing http://bugs.python.org/issue14704 closed by mark.dickinson #14706: Inconsistent os.access os.X_OK on Solaris and AIX when running http://bugs.python.org/issue14706 closed by pitrou #14707: extend() puzzled me. http://bugs.python.org/issue14707 closed by loewis #14708: distutils's checking for MSVC compiler http://bugs.python.org/issue14708 closed by loewis #14717: In generator's .close() docstring there is one argument http://bugs.python.org/issue14717 closed by python-dev #14718: In the generator's try/finally statement a runtime error occur http://bugs.python.org/issue14718 closed by benjamin.peterson #14719: Lists: [[0]*N]*N != [[0 for _ in range(N)] for __ in range(N)] http://bugs.python.org/issue14719 closed by loewis #1303434: Please include pdb with windows distribution http://bugs.python.org/issue1303434 closed by loewis

2 1

Python program name
by Vinay Sajip 04 May '12

04 May '12

IIUC, the program name of the Python executable is set to whatever argv[0] is. Is there a reason for this, rather than using one of the various OS-specific APIs [1] for getting the name of the running executable? The reason I ask is that in a virtual environment (venv), the exe's path is the only thing you have to go on, and if you don't have that, you can't find the pyvenv.cfg file and hence the base Python from which the venv was created. Of course argv[0] is normally set to the executable's path, but there's at least one test (in test_sys) where Python is spawned (via subprocess) with argv[0] set to "nonexistent". If run from a venv created from a source build, with no Python 3.3 installed, this test fails because the spawned Python can't locate the locale encoding, and bails. It works when run from a source build ("./python ...") because the getpath.c code to find a prefix looks in the directory implied by argv[0] (in the case of "nonexistent" => "", i.e. the current directory) for "Modules/Setup", and also works from a venv if created from an installed Python 3.3 (since the value of sys.prefix is used as a fallback check, and that value will contain that Python). However, when run from a venv created from a source build, with no Python 3.3 installed, the error occurs. A workaround might be one of these: 1. Use an OS-specific API rather than argv[0] to get the executable's path for the processing done by getpath.c in all cases, or 2. If the file named by argv[0] doesn't exist, then use the OS-specific API to find the executable's path, and try with that, or 3. If using the current logic, no prefix is found, then use the OS-specific API to to find the executable's path, and try with that. I would prefer to use option 2 and change getpath.c / getpathp.c accordingly. Does anyone here see problems with that approach? Regards, Vinay Sajip [1] http://stackoverflow.com/a/933996

3 4

Re: [Python-Dev] [Python-checkins] cpython: avoid unitialized memory
by Eric V. Smith 04 May '12

04 May '12

On 5/4/2012 1:14 AM, benjamin.peterson wrote: > http://hg.python.org/cpython/rev/b0deafca6c02 > changeset: 76743:b0deafca6c02 > user: Benjamin Peterson <benjamin(a)python.org> > date: Fri May 04 01:14:03 2012 -0400 > summary: > avoid unitialized memory > > files: > Modules/posixmodule.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c > --- a/Modules/posixmodule.c > +++ b/Modules/posixmodule.c > @@ -3576,7 +3576,7 @@ > split_py_long_to_s_and_ns(PyObject *py_long, time_t *s, long *ns) > { > int result = 0; > - PyObject *divmod; > + PyObject *divmod = NULL; > divmod = PyNumber_Divmod(py_long, billion); How is that uninitialized if it's being set on the next line?

3 2

Re: [Python-Dev] [Python-checkins] cpython: Issue #14127: Add ns= parameter to utime, futimes, and lutimes.
by Benjamin Peterson 04 May '12

04 May '12

2012/5/3 larry.hastings <python-checkins(a)python.org>: > diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c > --- a/Modules/posixmodule.c > +++ b/Modules/posixmodule.c > @@ -3572,28 +3572,194 @@ > #endif /* HAVE_UNAME */ > > > +static int > +split_py_long_to_s_and_ns(PyObject *py_long, time_t *s, long *ns) > +{ > + int result = 0; > + PyObject *divmod; > + divmod = PyNumber_Divmod(py_long, billion); > + if (!divmod) > + goto exit; > + *s = _PyLong_AsTime_t(PyTuple_GET_ITEM(divmod, 0)); > + if ((*s == -1) && PyErr_Occurred()) > + goto exit; > + *ns = PyLong_AsLong(PyTuple_GET_ITEM(divmod, 1)); > + if ((*s == -1) && PyErr_Occurred()) > + goto exit; > + > + result = 1; > +exit: > + Py_XDECREF(divmod); > + return result; > +} > + > + > +typedef int (*parameter_converter_t)(PyObject *, void *); > + > +typedef struct { > + /* input only */ > + char path_format; > + parameter_converter_t converter; > + char *function_name; > + char *first_argument_name; > + PyObject *args; > + PyObject *kwargs; > + > + /* input/output */ > + PyObject **path; > + > + /* output only */ > + int now; > + time_t atime_s; > + long atime_ns; > + time_t mtime_s; > + long mtime_ns; > +} utime_arguments; > + > +#define DECLARE_UA(ua, fname) \ > + utime_arguments ua; \ > + memset(&ua, 0, sizeof(ua)); \ > + ua.function_name = fname; \ > + ua.args = args; \ > + ua.kwargs = kwargs; \ > + ua.first_argument_name = "path"; \ > + > +/* UA_TO_FILETIME doesn't declare atime and mtime for you */ > +#define UA_TO_FILETIME(ua, atime, mtime) \ > + time_t_to_FILE_TIME(ua.atime_s, ua.atime_ns, &atime); \ > + time_t_to_FILE_TIME(ua.mtime_s, ua.mtime_ns, &mtime) > + > +/* the rest of these macros declare the output variable for you */ > +#define UA_TO_TIMESPEC(ua, ts) \ > + struct timespec ts[2]; \ > + ts[0].tv_sec = ua.atime_s; \ > + ts[0].tv_nsec = ua.atime_ns; \ > + ts[1].tv_sec = ua.mtime_s; \ > + ts[1].tv_nsec = ua.mtime_ns > + > +#define UA_TO_TIMEVAL(ua, tv) \ > + struct timeval tv[2]; \ > + tv[0].tv_sec = ua.atime_s; \ > + tv[0].tv_usec = ua.atime_ns / 1000; \ > + tv[1].tv_sec = ua.mtime_s; \ > + tv[1].tv_usec = ua.mtime_ns / 1000 > + > +#define UA_TO_UTIMBUF(ua, u) \ > + struct utimbuf u; \ > + utimbuf.actime = ua.atime_s; \ > + utimbuf.modtime = ua.mtime_s > + > +#define UA_TO_TIME_T(ua, timet) \ > + time_t timet[2]; \ > + timet[0] = ua.atime_s; \ > + timet[1] = ua.mtime_s > + > + > +/* > + * utime_read_time_arguments() processes arguments for the utime > + * family of functions. > + * returns zero on failure. > + */ > +static int > +utime_read_time_arguments(utime_arguments *ua) > +{ > + PyObject *times = NULL; > + PyObject *ns = NULL; > + char format[24]; > + char *kwlist[4]; > + char **kw = kwlist; > + int return_value; > + > + *kw++ = ua->first_argument_name; > + *kw++ = "times"; > + *kw++ = "ns"; > + *kw = NULL; > + > + sprintf(format, "%c%s|O$O:%s", > + ua->path_format, > + ua->converter ? "&" : "", > + ua->function_name); > + > + if (ua->converter) > + return_value = PyArg_ParseTupleAndKeywords(ua->args, ua->kwargs, > + format, kwlist, ua->converter, ua->path, &times, &ns); > + else > + return_value = PyArg_ParseTupleAndKeywords(ua->args, ua->kwargs, > + format, kwlist, ua->path, &times, &ns); > + > + if (!return_value) > + return 0; > + > + if (times && ns) { > + PyErr_Format(PyExc_RuntimeError, Why not a ValueError or TypeError? > + "%s: you may specify either 'times'" > + " or 'ns' but not both", > + ua->function_name); > + return 0; > + } > + > + if (times && (times != Py_None)) { Conditions in parenthesis like this is not style. > + if (!PyTuple_CheckExact(times) || (PyTuple_Size(times) != 2)) { > + PyErr_Format(PyExc_TypeError, > + "%s: 'time' must be either" > + " a valid tuple of two ints or None", > + ua->function_name); > + return 0; > + } > + ua->now = 0; > + return (_PyTime_ObjectToTimespec(PyTuple_GET_ITEM(times, 0), > + &(ua->atime_s), &(ua->atime_ns)) != -1) > + && (_PyTime_ObjectToTimespec(PyTuple_GET_ITEM(times, 1), Put && on previous line like Python. > + &(ua->mtime_s), &(ua->mtime_ns)) != -1); > + } > + > + if (ns) { > + if (!PyTuple_CheckExact(ns) || (PyTuple_Size(ns) != 2)) { > + PyErr_Format(PyExc_TypeError, > + "%s: 'ns' must be a valid tuple of two ints", > + ua->function_name); > + return 0; > + } > + ua->now = 0; > + return (split_py_long_to_s_and_ns(PyTuple_GET_ITEM(ns, 0), > + &(ua->atime_s), &(ua->atime_ns))) > + && (split_py_long_to_s_and_ns(PyTuple_GET_ITEM(ns, 1), > + &(ua->mtime_s), &(ua->mtime_ns))); > + } > + > + /* either times=None, or neither times nor ns was specified. use "now". */ > + ua->now = 1; > + return 1; > +} -- Regards, Benjamin

7 7

PEP 377 : Allow __enter__() methods to skip the statement body : real world case
by Pierre Chanial 04 May '12

04 May '12

Hello, PEP 377 has been rejected for lack of use cases. Here is one. I'm writing an MPI-based application and in some cases, when there is less work items than processes, I need to create a new communicator excluding the processes that have nothing to do. This new communicator should finally be freed by the processes that had work to do (and only by them). If there is more work than processes, the usual communicator should be used. A neat way to do that would be to write: with filter_comm(comm, nworkitems) as newcomm: ... do work with communicator newcomm... the body being executed only by the processes that have work to do. It looks better than: if comm.size < nworkitems: newcomm = get_new_communicator(comm, nworkitems) else: newcomm = comm if comm.rank < nworkitems: try: ... do work with communicator newcomm... finally: if comm.size < nworkitems: newcomm.Free() Especially since I have to use that quite often. Cheers, Pierre

2 1

Re: [Python-Dev] cpython: Issue #14127: Fix two bugs with the Windows implementation.
by Georg Brandl 04 May '12

04 May '12

On 05/04/2012 11:32 AM, larry.hastings wrote: > http://hg.python.org/cpython/rev/fc5d2f4291ac > changeset: 76747:fc5d2f4291ac > user: Larry Hastings <larry(a)hastings.org> > date: Fri May 04 02:31:57 2012 -0700 > summary: > Issue #14127: Fix two bugs with the Windows implementation. Would be nice to mention what these bugs were, otherwise the commit message is not very helpful when doing e.g. bisect or annotate. Georg

1 0

Re: [Python-Dev] [Python-checkins] cpython: what is a invalid tuple?
by Stefan Krah 04 May '12

04 May '12

benjamin.peterson <python-checkins(a)python.org> wrote: > files: > Modules/posixmodule.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > > diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c > --- a/Modules/posixmodule.c > +++ b/Modules/posixmodule.c > @@ -3702,7 +3702,7 @@ > if (!PyTuple_CheckExact(times) || (PyTuple_Size(times) != 2)) { > PyErr_Format(PyExc_TypeError, > "%s: 'time' must be either" > - " a valid tuple of two ints or None", > + " a tuple of two ints or None", Unrelated to this commit, but 'time' should be 'times'. Stefan Krah

1 0

Re: [Python-Dev] [Python-checkins] cpython: avoid unitialized memory
by Stefan Krah 04 May '12

04 May '12

benjamin.peterson <python-checkins(a)python.org> wrote: > summary: > avoid unitialized memory > > diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c > --- a/Modules/posixmodule.c > +++ b/Modules/posixmodule.c > @@ -3576,7 +3576,7 @@ > split_py_long_to_s_and_ns(PyObject *py_long, time_t *s, long *ns) > { > int result = 0; > - PyObject *divmod; > + PyObject *divmod = NULL; > divmod = PyNumber_Divmod(py_long, billion); > if (!divmod) > goto exit; If I'm not mistaken, divmod was already unconditionally initialized by PyNumber_Divmod(). Stefan Krah

1 0