Mailman 3 August 2013 - Python-Dev

Re: [Python-Dev] [Python-checkins] peps: Use Guido's preferred wording re: line length
by Nick Coghlan 03 Aug '13

03 Aug '13

On 3 Aug 2013 12:45, "Terry Reedy" <tjreedy(a)udel.edu> wrote: > > > > On 8/2/2013 10:26 PM, Nick Coghlan wrote: >> >> >> On 3 Aug 2013 11:07, "Terry Reedy" <tjreedy(a)udel.edu >> <mailto:tjreedy@udel.edu>> wrote: >> > >> > On 8/2/2013 6:19 AM, nick.coghlan wrote: >> > >> >> +The Python standard library is conservative and requires limiting >> >> +lines to 79 characters (and docstrings/comments to 72). >> > >> > >> > If you (and Guido) mean that as a hard limit, then patchcheck should >> check line lengths as well as trailing whitespace. >> >> That raises issues when modifying existing non-compliant files, because >> it removes the human judgement on whether a non-compliance is worth >> fixing or not. > > > I meant tools/scripts/patchcheck.py, not the pre-commit hook. The check would inform (especially for old files) or remind (for new files) so that judgment could be applied. Ah, right. Yeah, that may be reasonable. A warning option on reindent.py may be a place to start if someone wanted to implement it. Whether or not patchcheck used that option would likely depend on the initial results of running it manually :) Cheers, Nick. > > _______________________________________________ > Python-checkins mailing list > Python-checkins(a)python.org > http://mail.python.org/mailman/listinfo/python-checkins

1 0

Re: [Python-Dev] [Python-checkins] peps: Use Guido's preferred wording re: line length
by Nick Coghlan 03 Aug '13

03 Aug '13

On 3 Aug 2013 11:07, "Terry Reedy" <tjreedy(a)udel.edu> wrote: > > On 8/2/2013 6:19 AM, nick.coghlan wrote: > >> +The Python standard library is conservative and requires limiting >> +lines to 79 characters (and docstrings/comments to 72). > > > If you (and Guido) mean that as a hard limit, then patchcheck should check line lengths as well as trailing whitespace. That raises issues when modifying existing non-compliant files, because it removes the human judgement on whether a non-compliance is worth fixing or not. Cheers, Nick. > _______________________________________________ > Python-checkins mailing list > Python-checkins(a)python.org > http://mail.python.org/mailman/listinfo/python-checkins

1 0

Summary of Python tracker Issues
by Python tracker 02 Aug '13

02 Aug '13

ACTIVITY SUMMARY (2013-07-26 - 2013-08-02) Python tracker at http://bugs.python.org/ To view or respond to any of the issues listed below, click on the issue. Do NOT respond to this message. Issues counts and deltas: open 4128 (+14) closed 26274 (+54) total 30402 (+68) Open issues with patches: 1856 Issues opened (53) ================== #10241: gc fixes for module m_copy attribute http://bugs.python.org/issue10241 reopened by pitrou #18562: Regex howto: revision pass http://bugs.python.org/issue18562 opened by akuchling #18563: No unit test for yiq to rgb and rgb to yiq converting functio http://bugs.python.org/issue18563 opened by vajrasky #18564: Integer overflow in socketmodule http://bugs.python.org/issue18564 opened by maker #18566: In unittest.TestCase docs for setUp() and tearDown() don't men http://bugs.python.org/issue18566 opened by py.user #18567: Python 2.7.5 CENTOS6 Error building dbm using bdb http://bugs.python.org/issue18567 opened by Denise.Mauldin #18570: OverflowError in division: wrong message http://bugs.python.org/issue18570 opened by marco.buttu #18571: Implementation of the PEP 446: non-inheriable file descriptors http://bugs.python.org/issue18571 opened by haypo #18572: Remove redundant note about surrogates in string escape doc http://bugs.python.org/issue18572 opened by stevenjd #18574: BaseHTTPRequestHandler.handle_expect_100() sends invalid respo http://bugs.python.org/issue18574 opened by Nikratio #18575: Fixing tarfile._mode when using gzip via ":gz" http://bugs.python.org/issue18575 opened by edulix #18576: Rename and document test.script_helper as test.support.script_ http://bugs.python.org/issue18576 opened by ncoghlan #18577: lru_cache enhancement: lru_timestamp helper function http://bugs.python.org/issue18577 opened by peter(a)psantoro.net #18578: Rename and document test.bytecode_helper as test.support.bytec http://bugs.python.org/issue18578 opened by ncoghlan #18579: Dereference after NULL check in listobject.c merge_hi() http://bugs.python.org/issue18579 opened by christian.heimes #18581: Duplicate test and missing class test in test_abc.py http://bugs.python.org/issue18581 opened by vajrasky #18582: PBKDF2 support http://bugs.python.org/issue18582 opened by christian.heimes #18583: Idle: enhance FormatParagraph http://bugs.python.org/issue18583 opened by terry.reedy #18585: Add a text truncation function http://bugs.python.org/issue18585 opened by pitrou #18586: Allow running benchmarks for Python 3 from same directory http://bugs.python.org/issue18586 opened by brett.cannon #18588: timeit examples should be consistent http://bugs.python.org/issue18588 opened by claymation #18590: 'Search' and 'Replace' dialogs don't work on quoted text in Wi http://bugs.python.org/issue18590 opened by Sarah #18591: threading.Thread.run returning a result http://bugs.python.org/issue18591 opened by James.Lu #18592: IDLE: Unit test for SearchDialogBase.py http://bugs.python.org/issue18592 opened by philwebster #18594: C accelerator for collections.Counter is slow http://bugs.python.org/issue18594 opened by scoder #18595: zipfile: symlinks etc. http://bugs.python.org/issue18595 opened by ronaldoussoren #18596: enable usage of AddressSanitizer in CPython [PATCH] http://bugs.python.org/issue18596 opened by halfie #18597: On Windows sys.stdin.readline() doesn't handle Ctrl-C properly http://bugs.python.org/issue18597 opened by Drekin #18598: Importlib, more verbosity please http://bugs.python.org/issue18598 opened by Lukáš.Němec #18600: email.policy doc example passes 'policy' to as_string, but tha http://bugs.python.org/issue18600 opened by r.david.murray #18602: "_io" module names itself "io" http://bugs.python.org/issue18602 opened by pitrou #18603: PyOS_mystricmp unused and no longer available http://bugs.python.org/issue18603 opened by christian.heimes #18604: Consolidate gui available checks in test.support http://bugs.python.org/issue18604 opened by terry.reedy #18605: 2.7: test_threading hangs on Solaris 9 http://bugs.python.org/issue18605 opened by automatthias #18606: Add statistics module to standard library http://bugs.python.org/issue18606 opened by stevenjd #18609: test_ctypes failure on AIX in PyEval_CallObjectWithKeywords http://bugs.python.org/issue18609 opened by David.Edelsohn #18610: wsgiref.validate expects wsgi.input read to give exactly one a http://bugs.python.org/issue18610 opened by Robin.Schoonover #18611: Mac: Some Python Launcher issues http://bugs.python.org/issue18611 opened by ronaldoussoren #18612: More elaborate documentation on how list comprehensions and ge http://bugs.python.org/issue18612 opened by uglemat #18614: Enhanced \N{} escapes for Unicode strings http://bugs.python.org/issue18614 opened by stevenjd #18615: sndhdr.whathdr could return a namedtuple http://bugs.python.org/issue18615 opened by Claudiu.Popa #18616: enable more ssl socket options with get_server_certificate http://bugs.python.org/issue18616 opened by underrun #18617: TLS and Intermediate Certificates http://bugs.python.org/issue18617 opened by dstufft #18620: multiprocessing page leaves out important part of Pool example http://bugs.python.org/issue18620 opened by Chris.Curvey #18621: site.py keeps too much stuff alive when it patches builtins http://bugs.python.org/issue18621 opened by pitrou #18622: reset_mock on mock created by mock_open causes infinite recurs http://bugs.python.org/issue18622 opened by michael.foord #18623: Factor out the _SuppressCoreFiles context manager http://bugs.python.org/issue18623 opened by pitrou #18624: Add alias for iso-8859-8-i which is the same as iso-8859-8 http://bugs.python.org/issue18624 opened by r.david.murray #18625: ks_c-5601-1987 is used by microsoft when it really means cp949 http://bugs.python.org/issue18625 opened by r.david.murray #18626: Make "python -m inspect <name>" dump the source of a module http://bugs.python.org/issue18626 opened by ncoghlan #18628: Better index entry for encoding declarations http://bugs.python.org/issue18628 opened by terry.reedy #18629: future division breaks timedelta division by integer http://bugs.python.org/issue18629 opened by exarkun #18618: Need an atexit.register equivalent that also works in subinter http://bugs.python.org/issue18618 opened by pitrou Most recent 15 issues with no replies (15) ========================================== #18629: future division breaks timedelta division by integer http://bugs.python.org/issue18629 #18621: site.py keeps too much stuff alive when it patches builtins http://bugs.python.org/issue18621 #18620: multiprocessing page leaves out important part of Pool example http://bugs.python.org/issue18620 #18616: enable more ssl socket options with get_server_certificate http://bugs.python.org/issue18616 #18615: sndhdr.whathdr could return a namedtuple http://bugs.python.org/issue18615 #18611: Mac: Some Python Launcher issues http://bugs.python.org/issue18611 #18610: wsgiref.validate expects wsgi.input read to give exactly one a http://bugs.python.org/issue18610 #18603: PyOS_mystricmp unused and no longer available http://bugs.python.org/issue18603 #18602: "_io" module names itself "io" http://bugs.python.org/issue18602 #18600: email.policy doc example passes 'policy' to as_string, but tha http://bugs.python.org/issue18600 #18595: zipfile: symlinks etc. http://bugs.python.org/issue18595 #18592: IDLE: Unit test for SearchDialogBase.py http://bugs.python.org/issue18592 #18588: timeit examples should be consistent http://bugs.python.org/issue18588 #18586: Allow running benchmarks for Python 3 from same directory http://bugs.python.org/issue18586 #18583: Idle: enhance FormatParagraph http://bugs.python.org/issue18583 Most recent 15 issues waiting for review (15) ============================================= #18621: site.py keeps too much stuff alive when it patches builtins http://bugs.python.org/issue18621 #18616: enable more ssl socket options with get_server_certificate http://bugs.python.org/issue18616 #18615: sndhdr.whathdr could return a namedtuple http://bugs.python.org/issue18615 #18614: Enhanced \N{} escapes for Unicode strings http://bugs.python.org/issue18614 #18610: wsgiref.validate expects wsgi.input read to give exactly one a http://bugs.python.org/issue18610 #18596: enable usage of AddressSanitizer in CPython [PATCH] http://bugs.python.org/issue18596 #18592: IDLE: Unit test for SearchDialogBase.py http://bugs.python.org/issue18592 #18590: 'Search' and 'Replace' dialogs don't work on quoted text in Wi http://bugs.python.org/issue18590 #18588: timeit examples should be consistent http://bugs.python.org/issue18588 #18585: Add a text truncation function http://bugs.python.org/issue18585 #18582: PBKDF2 support http://bugs.python.org/issue18582 #18575: Fixing tarfile._mode when using gzip via ":gz" http://bugs.python.org/issue18575 #18574: BaseHTTPRequestHandler.handle_expect_100() sends invalid respo http://bugs.python.org/issue18574 #18571: Implementation of the PEP 446: non-inheriable file descriptors http://bugs.python.org/issue18571 #18564: Integer overflow in socketmodule http://bugs.python.org/issue18564 Top 10 most discussed issues (10) ================================= #18585: Add a text truncation function http://bugs.python.org/issue18585 9 msgs #17449: dev guide appears not to cover the benchmarking suite http://bugs.python.org/issue17449 8 msgs #10241: gc fixes for module m_copy attribute http://bugs.python.org/issue10241 6 msgs #18257: Two copies of python-config http://bugs.python.org/issue18257 6 msgs #16248: Security bug in tkinter allows for untrusted, arbitrary code e http://bugs.python.org/issue16248 5 msgs #18558: Iterable glossary entry needs clarification http://bugs.python.org/issue18558 5 msgs #18570: OverflowError in division: wrong message http://bugs.python.org/issue18570 5 msgs #1666318: shutil.copytree doesn't give control over directory permission http://bugs.python.org/issue1666318 5 msgs #5845: rlcompleter should be enabled automatically http://bugs.python.org/issue5845 4 msgs #15893: Py_FrozenMain() resource leak and missing malloc checks http://bugs.python.org/issue15893 4 msgs Issues closed (47) ================== #3099: On windows, "import nul" always succeed http://bugs.python.org/issue3099 closed by tim.golden #5302: Allow package_data specs/globs to match directories http://bugs.python.org/issue5302 closed by larry #7443: test.support.unlink issue on Windows platform http://bugs.python.org/issue7443 closed by tim.golden #9035: os.path.ismount on windows doesn't support windows mount point http://bugs.python.org/issue9035 closed by tim.golden #11571: Turtle window pops under the terminal on OSX http://bugs.python.org/issue11571 closed by belopolsky #13266: Add inspect.unwrap(f) to easily unravel "__wrapped__" chains http://bugs.python.org/issue13266 closed by python-dev #13463: Fix parsing of package_data http://bugs.python.org/issue13463 closed by larry #15415: Add temp_dir() and change_cwd() to test.support http://bugs.python.org/issue15415 closed by python-dev #15699: PEP 3121, 384 Refactoring applied to readline module http://bugs.python.org/issue15699 closed by pitrou #15892: _PyImport_GetDynLoadFunc() doesn't check return value of fstat http://bugs.python.org/issue15892 closed by christian.heimes #16635: Interpreter not closing stdout/stderr on exit http://bugs.python.org/issue16635 closed by neologix #17350: Use STAF call python script will case 1124861 issue in 2.7.2 v http://bugs.python.org/issue17350 closed by terry.reedy #17557: test_getgroups of test_posix can fail on OS X 10.8 if more tha http://bugs.python.org/issue17557 closed by ned.deily #17616: wave.Wave_read and wave.Wave_write can be context managers http://bugs.python.org/issue17616 closed by r.david.murray #17899: os.listdir() leaks FDs if invoked on FD pointing to a non-dire http://bugs.python.org/issue17899 closed by larry #18023: msi product code for 2.7.5150 not in Tools/msi/uuids.py http://bugs.python.org/issue18023 closed by loewis #18071: Extension module builds fail on OS X with TypeError if Xcode c http://bugs.python.org/issue18071 closed by ned.deily #18112: PEP 442 implementation http://bugs.python.org/issue18112 closed by pitrou #18214: Stop purging modules which are garbage collected before shutdo http://bugs.python.org/issue18214 closed by pitrou #18325: test_kqueue fails in OpenBSD http://bugs.python.org/issue18325 closed by neologix #18441: Idle: Make test.support.requires('gui') skip when it should. http://bugs.python.org/issue18441 closed by terry.reedy #18472: Update PEP 8 to encourage modern conventions http://bugs.python.org/issue18472 closed by ncoghlan #18481: lcov report http://bugs.python.org/issue18481 closed by christian.heimes #18517: "xxlimited" extension declared incorrectly in setup.py http://bugs.python.org/issue18517 closed by ned.deily #18539: Idle 2.7: Calltip wrong if def contains float default value http://bugs.python.org/issue18539 closed by terry.reedy #18552: obj2ast_object() doesn't check return value of PyArena_AddPyOb http://bugs.python.org/issue18552 closed by christian.heimes #18555: type_set_bases() doesn't check return value of PyArg_UnpackTu http://bugs.python.org/issue18555 closed by christian.heimes #18559: _pickle: NULL ptr dereference when PyLong_FromSsize_t() fails http://bugs.python.org/issue18559 closed by christian.heimes #18560: builtin_sum() doesn't check return value of PyLong_FromLong() http://bugs.python.org/issue18560 closed by christian.heimes #18561: ctypes _build_callargs() doesn't check name for NULL http://bugs.python.org/issue18561 closed by christian.heimes #18565: Test for closing delegating generator with cleared frame (Issu http://bugs.python.org/issue18565 closed by python-dev #18568: Support \e escape code in strings http://bugs.python.org/issue18568 closed by stevenjd #18569: Set PATHEXT in the Windows installer http://bugs.python.org/issue18569 closed by loewis #18573: In unittest.TestCase.assertWarns doc there is some text about http://bugs.python.org/issue18573 closed by terry.reedy #18580: distutils compilers are unicode strings on OS X since Python 2 http://bugs.python.org/issue18580 closed by ned.deily #18584: examples in email.policy doc are fu'd http://bugs.python.org/issue18584 closed by r.david.murray #18587: urllib raises exception with string in 'errno' attribute http://bugs.python.org/issue18587 closed by r.david.murray #18589: cross-referencing doesn't work between the extending guide and http://bugs.python.org/issue18589 closed by pitrou #18593: Typo in Lib/multiprocessing/heap.py http://bugs.python.org/issue18593 closed by eli.bendersky #18599: _sha1module report "SHA" as its name http://bugs.python.org/issue18599 closed by christian.heimes #18601: Example "command-line interface to difflib" has typographical http://bugs.python.org/issue18601 closed by r.david.murray #18607: struct.unpack http://bugs.python.org/issue18607 closed by Andres.Adjimann #18608: Avoid keeping a strong reference to locale in the _io module http://bugs.python.org/issue18608 closed by pitrou #18613: wrong float plus/minus op result http://bugs.python.org/issue18613 closed by brett.cannon #18619: atexit leaks callbacks in subinterpreters http://bugs.python.org/issue18619 closed by pitrou #18627: Typo in Modules/hashlib.h http://bugs.python.org/issue18627 closed by python-dev #812369: module shutdown procedure based on GC http://bugs.python.org/issue812369 closed by pitrou

1 0

PEP 446: Open issues/questions
by Victor Stinner 02 Aug '13

02 Aug '13

Hi, I have a few more questions on the PEP 446: (A) How should we support support where os.set_inheritable() is not supported? Can we announce that os.set_inheritable() is always available or not? Does such platform exist? (B) Should subprocess make the file descriptors of pass_fds inheritable? If yes, should it be done before or after the fork? If it is done after the fork and before exec, it only affects the child process, at least on Linux (the file descriptor is still non-inheritable in the parent process). (C) Should we handle standard streams (0: stdin, 1: stdout, 2: stderr) differently? For example, os.dup2(fd, 0) should make the file descriptor 0 (stdin) inheritable or non-inheritable? On Windows, os.set_inheritable(fd, False) fails (error 87, invalid argument) on standard streams (0, 1, 2) and copies of the standard streams (created by os.dup()). Victor

4 28

PEP 442 aftermath: module globals at shutdown
by Antoine Pitrou 01 Aug '13

01 Aug '13

Hello, PEP 442 has now been committed in time for testing in Alpha 1. This paves the way for the removal of another well-known annoyance: the behaviour of module globals at shutdown. Now that reference cycles aren't a barrier to object finalization anymore, we shouldn't need to set module globals to None before trying to reclaim modules. (and then, we don't need to cache global functions for use in finalizers, either) I have a patch to suppress the hack in http://bugs.python.org/issue18214 Once I get to add some tests, I would like to commit it soon too! Regards Antoine.

4 6

Re: [Python-Dev] [Python-checkins] cpython (merge 3.3 -> default): Silence warning about set but unused variable inside compile_atom() in
by Ronald Oussoren 01 Aug '13

01 Aug '13

On 31 Jul, 2013, at 23:50, christian.heimes <python-checkins(a)python.org> wrote: > http://hg.python.org/cpython/rev/0e09588a3bc2 > changeset: 84939:0e09588a3bc2 > parent: 84937:809a64ecd5f1 > parent: 84938:83a55ca935f0 > user: Christian Heimes <christian(a)cheimes.de> > date: Wed Jul 31 23:48:04 2013 +0200 > summary: > Silence warning about set but unused variable inside compile_atom() in non-debug builds > > files: > Parser/pgen.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > > diff --git a/Parser/pgen.c b/Parser/pgen.c > --- a/Parser/pgen.c > +++ b/Parser/pgen.c > @@ -283,6 +283,7 @@ > > REQ(n, ATOM); > i = n->n_nchildren; > + (void)i; /* Don't warn about set but unused */ > REQN(i, 1); Why didn't you change this to "REQN(n->nchilderen, 1);" (and then remove variable "i")? Ronald > n = n->n_child; > if (n->n_type == LPAR) { > > -- > Repository URL: http://hg.python.org/cpython > _______________________________________________ > Python-checkins mailing list > Python-checkins(a)python.org > http://mail.python.org/mailman/listinfo/python-checkins

2 2