Python-Dev April 2016

python-dev@python.org

103 participants
81 discussions

Re: [Python-Dev] When should pathlib stop being provisional?
by Christophe Bal 07 Apr '16

07 Apr '16

As a simple user, pathlib simplifies playing with paths. A lot of things are easy to do. For example, Pathlib / "subfile" is so useful. I also have a subclass of pathlib.Path on github that makes easy seeking for files and directories. So keep alive pathlib ! Le 6 avr. 2016 13:06, "Paul Moore" <p.f.moore(a)gmail.com> a écrit : On 6 April 2016 at 00:45, Guido van Rossum <guido(a)python.org> wrote: > This does sound like it's the crucial issue, and it is worth writing > up clearly the pros and cons. Let's draft those lists in a thread > (this one's fine) and then add them to the PEP. We can then decide to: > > - keep the status quo > - change PurePath to inherit from str > - decide it's never going to be settled and kill pathlib.py > > (And yes, I'm dead serious about the latter, rather Solomonic option.) By the way, even if there's no solution that satisfies everyone to the "inherit from str" question, I'd still be unhappy if pathlib disappeared from the stdlib. It's useful for quick admin scripts that don't justify an external dependency. Those typically do quite a bit of path manipulation, and as such benefit from the improved API of pathlib over os.path. +1 on making (and documenting) a final decision on the "inherit from str" question -1 on removing pathlib just because that decision might not satisfy everyone Paul _______________________________________________ Python-Dev mailing list Python-Dev(a)python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/projetmbc%40gmail.com

1 0

Re: [Python-Dev] When should pathlib stop being provisional?
by Wes Turner 06 Apr '16

06 Apr '16

On Apr 6, 2016 1:26 AM, "Chris Angelico" <rosuav(a)gmail.com> wrote: > > On Wed, Apr 6, 2016 at 3:37 PM, Stephen J. Turnbull <stephen(a)xemacs.org> wrote: > > Chris Angelico writes: > > > > > Outside of deliberate tests, we don't create files on our disks > > > whose names are strings of random bytes; > > > > Wishful thinking. First, names made of control characters have often > > been deliberately used by miscreants to conceal their warez. Second, > > in some systems it's all too easy to create paths with components in > > different locales (the place I've seen it most frequently is in NFS > > mounts). I think that's much less true today, but perhaps that's only > > because my employer figured out that it was much less pain if system > > paths were pure ASCII so that it mostly didn't matter what encoding > > users chose for their subtrees. > > Control characters are still characters, though. You can take a > bytestring consisting of byte values less than 32, decode it as UTF-8, > and have a series of codepoints to work with. > > If your employer has "solved" the problem by restricting system paths > to ASCII, that's a fine solution for a single system with a single > ASCII-compatible encoding; a better solution is to mandate UTF-8 as > the file system encoding, as that's what most people are expecting > anyway. > > > It remains important to be able to handle nearly arbitrary bytestrings > > in file names as far as I can see. Please note that 100 million > > Japanese and 1 billion Chinese by and large still prefer their > > homegrown encodings (plural!!) to Unicode, while many systems are now > > defaulting filenames to UTF-8. There's plenty of room remaining for > > copying bytestrings to arguments of open and friends. > > Why exactly do they prefer these other encodings? Are they > representing characters that Unicode doesn't contain? If so, we have a > fundamental problem (no Python program is going to be able to cope > with these, without a third party library or some stupid mess of local > code); if not, you can always represent it as Unicode and encode it as > UTF-8 when it reaches the file system. Re-encoding is something that's > easy when you treat something as text, and impossible when you treat > it as bytes. > > So far, you're still actually agreeing with me: paths are *text*, but > sometimes we don't know the encoding (and that's a problem to be > solved). re: bytestring, unicode, encodings after e.g. os.path.split / Path.split: from "[Python-ideas] Type hints for text/binary data in Python 2+3 code" https://mail.python.org/pipermail/python-ideas/2016-March/038869.html >> would/will it be possible to use Typing.Text as a base class for even-more abstract string types https://mail.python.org/pipermail/python-ideas/2016-March/039016.html >> * Text.encoding >> * Text.lang (urn:ietf:rfc:3066) ... forgot to CC: >> * https://tools.ietf.org/html/rfc5646 "Tags for Identifying Languages" urn:ietf:rfc:5646 is this (Path) a narrower case of string types (#strypes), because after transformations we want to preserve string metadata like e.g encoding? I'd vote for * adding DirEntry.__path__ as a proxy to DirEntry.path * standardizing on __path__ (over .path) * because this operation *is* fundamentally similar to e.g. __str__ * operator.path pathify, pathifize > > ChrisA > _______________________________________________ > Python-Dev mailing list > Python-Dev(a)python.org > https://mail.python.org/mailman/listinfo/python-dev > Unsubscribe: https://mail.python.org/mailman/options/python-dev/wes.turner%40gmail.com

1 0

GSoC: looking for a student to help on FAT Python
by Victor Stinner 05 Apr '16

05 Apr '16

Hi, I am now looking for a Google Summer of Code (GSoC) student to help me of my FAT Python project, a new static optimizer for CPython 3.6 using specialization with guards. The FAT Python project is already fully functional, the code is written and tested. I need help to implement new efficient optimizations to "finish" the project and prove that my design allows to really run applications faster. FAT Python project: https://faster-cpython.readthedocs.org/fat_python.html fatoptimizer module: https://fatoptimizer.readthedocs.org/ Slides of my talk at FOSDEM: https://github.com/haypo/conf/raw/master/2016-FOSDEM/fat_python.pdf The "fatoptimizer" optimizer is written in pure Python. I'm looking for a student who knows compilers especially static optimizations like loop unrolling and function inlining. For concrete tasks, take a look at the TODO list: https://fatoptimizer.readthedocs.org/en/latest/todo.html Hurry up students! The deadline is in 1 week! (Sorry, I'm late for my project...) -- PSF GSoC, Python core projects: https://wiki.python.org/moin/SummerOfCode/2016/python-core All PSF GSoC projects: https://wiki.python.org/moin/SummerOfCode/2016 GSOC: https://developers.google.com/open-source/gsoc/ Victor

3 2

Py_SETREF vs. Py_XSETREF
by Serhiy Storchaka 04 Apr '16

04 Apr '16

Originally I proposed a pair of macros for safe reference replacing to reflects the duality of Py_DECREF/Py_XDECREF. [1], [2] The one should use Py_DECREF and the other should use Py_XDECREF. But then I got a number of voices for the single name [3], and no one voice (except mine) for the pair of names. Thus in final patches the single name Py_SETREF that uses Py_XDECREF is used. Due to adding some overhead in comparison with using Py_DECREF, this macros is not used in critical performance code such as PyDict_SetItem(). Now Raymond says that we should have separate Py_SETREF/Py_XSETREF names to avoid any overhead. [4] And so I'm raising this issue on Python-Dev. Should we rename Py_SETREF to Py_XSETREF and introduce new Py_SETREF that uses Py_DECREF? [1] http://comments.gmane.org/gmane.comp.python.devel/145346 [2] http://comments.gmane.org/gmane.comp.python.devel/145974 [3] http://bugs.python.org/issue26200#msg259784 [4] http://bugs.python.org/issue26200

6 5

review/proof docs about private memory heap
by J.E. Ogden 03 Apr '16

03 Apr '16

After digging through obmalloc.c to optimize some memory intensive code, I put a paper together on the entire private memory heap that may or may not be a useful addition to docs. I was hoping someone could review/proof it for errors in content. Not sure the policy on links but I've uploaded it to google drive: https://drive.google.com/open?id=0B6IkX5KnPHVLamwxSTNYR3dJYkE thanks, jon

1 0

Which version is better? Phyton 27 or Phyton 35?
by Roberto Martínez 02 Apr '16

02 Apr '16

Hi, I am having a hard time trying to choose one of this two products: Phyton 27: http://www.amazon.com/Phyton-27-Systemic-Bactericide-Fungicide/dp/B00VKPL8FU Phyton 35: http://www.amazon.com/Phyton-Bactericide-fungicide-Substitute-Liter/dp/B00B… Phyton 35 is announced as the "Substitute for Phyton 27" but I feel that Phyton 27 is more tested and have a bigger user base. Can you help to choose? Best regards, Roberto

5 4

Re: [Python-Dev] [Python-checkins] cpython: Python 8: no pep8, no chocolate!
by Brett Cannon 01 Apr '16

01 Apr '16

Are you planning on removing this after today? My worry about leaving it in is if it's a modified copy that follows your Python 8 April Fools joke then it will quite possibly trip people up who try and run pep8 but don't have it installed, leading them to wonder why the heck their imports are now all flagged as broken. On Thu, 31 Mar 2016 at 14:40 victor.stinner <python-checkins(a)python.org> wrote: > https://hg.python.org/cpython/rev/9aedec2dbc01 > changeset: 100818:9aedec2dbc01 > user: Victor Stinner <victor.stinner(a)gmail.com> > date: Thu Mar 31 23:30:53 2016 +0200 > summary: > Python 8: no pep8, no chocolate! > > files: > Include/patchlevel.h | 6 +- > Lib/pep8.py | 2151 ++++++++++++++++++++++++++++++ > Lib/site.py | 56 + > 3 files changed, 2210 insertions(+), 3 deletions(-) > > > diff --git a/Include/patchlevel.h b/Include/patchlevel.h > --- a/Include/patchlevel.h > +++ b/Include/patchlevel.h > @@ -16,14 +16,14 @@ > > /* Version parsed out into numeric values */ > /*--start constants--*/ > -#define PY_MAJOR_VERSION 3 > -#define PY_MINOR_VERSION 6 > +#define PY_MAJOR_VERSION 8 > +#define PY_MINOR_VERSION 0 > #define PY_MICRO_VERSION 0 > #define PY_RELEASE_LEVEL PY_RELEASE_LEVEL_ALPHA > #define PY_RELEASE_SERIAL 0 > > /* Version as a string */ > -#define PY_VERSION "3.6.0a0" > +#define PY_VERSION "8.0.0a0" > /*--end constants--*/ > > /* Version as a single 4-byte hex number, e.g. 0x010502B2 == 1.5.2b2. > diff --git a/Lib/pep8.py b/Lib/pep8.py > new file mode 100644 > --- /dev/null > +++ b/Lib/pep8.py > @@ -0,0 +1,2151 @@ > +#!/usr/bin/env python > +# pep8.py - Check Python source code formatting, according to PEP 8 > +# Copyright (C) 2006-2009 Johann C. Rocholl <johann(a)rocholl.net> > +# Copyright (C) 2009-2014 Florent Xicluna <florent.xicluna(a)gmail.com> > +# Copyright (C) 2014-2016 Ian Lee <ianlee1521(a)gmail.com> > +# > +# Permission is hereby granted, free of charge, to any person > +# obtaining a copy of this software and associated documentation files > +# (the "Software"), to deal in the Software without restriction, > +# including without limitation the rights to use, copy, modify, merge, > +# publish, distribute, sublicense, and/or sell copies of the Software, > +# and to permit persons to whom the Software is furnished to do so, > +# subject to the following conditions: > +# > +# The above copyright notice and this permission notice shall be > +# included in all copies or substantial portions of the Software. > +# > +# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > +# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > +# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > +# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS > +# BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN > +# ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN > +# CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE > +# SOFTWARE. > + > +r""" > +Check Python source code formatting, according to PEP 8. > + > +For usage and a list of options, try this: > +$ python pep8.py -h > + > +This program and its regression test suite live here: > +https://github.com/pycqa/pep8 > + > +Groups of errors and warnings: > +E errors > +W warnings > +100 indentation > +200 whitespace > +300 blank lines > +400 imports > +500 line length > +600 deprecation > +700 statements > +900 syntax error > +""" > +from __future__ import with_statement > + > +import os > +import sys > +import re > +import time > +import inspect > +import keyword > +import tokenize > +from optparse import OptionParser > +from fnmatch import fnmatch > +try: > + from configparser import RawConfigParser > + from io import TextIOWrapper > +except ImportError: > + from ConfigParser import RawConfigParser > + > +__version__ = '1.7.0' > + > +DEFAULT_EXCLUDE = '.svn,CVS,.bzr,.hg,.git,__pycache__,.tox' > +DEFAULT_IGNORE = 'E121,E123,E126,E226,E24,E704' > +try: > + if sys.platform == 'win32': > + USER_CONFIG = os.path.expanduser(r'~\.pep8') > + else: > + USER_CONFIG = os.path.join( > + os.getenv('XDG_CONFIG_HOME') or > os.path.expanduser('~/.config'), > + 'pep8' > + ) > +except ImportError: > + USER_CONFIG = None > + > +PROJECT_CONFIG = ('setup.cfg', 'tox.ini', '.pep8') > +TESTSUITE_PATH = os.path.join(os.path.dirname(__file__), 'testsuite') > +MAX_LINE_LENGTH = 79 > +REPORT_FORMAT = { > + 'default': '%(path)s:%(row)d:%(col)d: %(code)s %(text)s', > + 'pylint': '%(path)s:%(row)d: [%(code)s] %(text)s', > +} > + > +PyCF_ONLY_AST = 1024 > +SINGLETONS = frozenset(['False', 'None', 'True']) > +KEYWORDS = frozenset(keyword.kwlist + ['print']) - SINGLETONS > +UNARY_OPERATORS = frozenset(['>>', '**', '*', '+', '-']) > +ARITHMETIC_OP = frozenset(['**', '*', '/', '//', '+', '-']) > +WS_OPTIONAL_OPERATORS = ARITHMETIC_OP.union(['^', '&', '|', '<<', '>>', > '%']) > +WS_NEEDED_OPERATORS = frozenset([ > + '**=', '*=', '/=', '//=', '+=', '-=', '!=', '<>', '<', '>', > + '%=', '^=', '&=', '|=', '==', '<=', '>=', '<<=', '>>=', '=']) > +WHITESPACE = frozenset(' \t') > +NEWLINE = frozenset([tokenize.NL, tokenize.NEWLINE]) > +SKIP_TOKENS = NEWLINE.union([tokenize.INDENT, tokenize.DEDENT]) > +# ERRORTOKEN is triggered by backticks in Python 3 > +SKIP_COMMENTS = SKIP_TOKENS.union([tokenize.COMMENT, tokenize.ERRORTOKEN]) > +BENCHMARK_KEYS = ['directories', 'files', 'logical lines', 'physical > lines'] > + > +INDENT_REGEX = re.compile(r'([ \t]*)') > +RAISE_COMMA_REGEX = re.compile(r'raise\s+\w+\s*,') > +RERAISE_COMMA_REGEX = re.compile(r'raise\s+\w+\s*,.*,\s*\w+\s*$') > +ERRORCODE_REGEX = re.compile(r'\b[A-Z]\d{3}\b') > +DOCSTRING_REGEX = re.compile(r'u?r?["\']') > +EXTRANEOUS_WHITESPACE_REGEX = re.compile(r'[[({] | []}),;:]') > +WHITESPACE_AFTER_COMMA_REGEX = re.compile(r'[,;:]\s*(?: |\t)') > +COMPARE_SINGLETON_REGEX = re.compile(r'(\bNone|\bFalse|\bTrue)?\s*([=!]=)' > + r'\s*(?(1)|(None|False|True))\b') > +COMPARE_NEGATIVE_REGEX = re.compile(r'\b(not)\s+[^][)(}{ ]+\s+(in|is)\s') > +COMPARE_TYPE_REGEX = > re.compile(r'(?:[=!]=|is(?:\s+not)?)\s*type(?:s.\w+Type' > + r'|\s*$\s*([^)]*[^ )])\s*$)') > +KEYWORD_REGEX = re.compile(r'(\s*)\b(?:%s)\b(\s*)' % r'|'.join(KEYWORDS)) > +OPERATOR_REGEX = re.compile(r'(?:[^,\s])(\s*)(?:[-+*/|!<=>%&^]+)(\s*)') > +LAMBDA_REGEX = re.compile(r'\blambda\b') > +HUNK_REGEX = re.compile(r'^@@ -\d+(?:,\d+)? \+(\d+)(?:,(\d+))? @@.*$') > + > +# Work around Python < 2.6 behaviour, which does not generate NL after > +# a comment which is on a line by itself. > +COMMENT_WITH_NL = tokenize.generate_tokens(['#\n'].pop).send(None)[1] == > '#\n' > + > + > > +############################################################################## > +# Plugins (check functions) for physical lines > > +############################################################################## > + > + > +def tabs_or_spaces(physical_line, indent_char): > + r"""Never mix tabs and spaces. > + > + The most popular way of indenting Python is with spaces only. The > + second-most popular way is with tabs only. Code indented with a > mixture > + of tabs and spaces should be converted to using spaces exclusively. > When > + invoking the Python command line interpreter with the -t option, it > issues > + warnings about code that illegally mixes tabs and spaces. When using > -tt > + these warnings become errors. These options are highly recommended! > + > + Okay: if a == 0:\n a = 1\n b = 1 > + E101: if a == 0:\n a = 1\n\tb = 1 > + """ > + indent = INDENT_REGEX.match(physical_line).group(1) > + for offset, char in enumerate(indent): > + if char != indent_char: > + return offset, "E101 indentation contains mixed spaces and > tabs" > + > + > +def tabs_obsolete(physical_line): > + r"""For new projects, spaces-only are strongly recommended over tabs. > + > + Okay: if True:\n return > + W191: if True:\n\treturn > + """ > + indent = INDENT_REGEX.match(physical_line).group(1) > + if '\t' in indent: > + return indent.index('\t'), "W191 indentation contains tabs" > + > + > +def trailing_whitespace(physical_line): > + r"""Trailing whitespace is superfluous. > + > + The warning returned varies on whether the line itself is blank, for > easier > + filtering for those who want to indent their blank lines. > + > + Okay: spam(1)\n# > + W291: spam(1) \n# > + W293: class Foo(object):\n \n bang = 12 > + """ > + physical_line = physical_line.rstrip('\n') # chr(10), newline > + physical_line = physical_line.rstrip('\r') # chr(13), carriage > return > + physical_line = physical_line.rstrip('\x0c') # chr(12), form feed, ^L > + stripped = physical_line.rstrip(' \t\v') > + if physical_line != stripped: > + if stripped: > + return len(stripped), "W291 trailing whitespace" > + else: > + return 0, "W293 blank line contains whitespace" > + > + > +def trailing_blank_lines(physical_line, lines, line_number, total_lines): > + r"""Trailing blank lines are superfluous. > + > + Okay: spam(1) > + W391: spam(1)\n > + > + However the last line should end with a new line (warning W292). > + """ > + if line_number == total_lines: > + stripped_last_line = physical_line.rstrip() > + if not stripped_last_line: > + return 0, "W391 blank line at end of file" > + if stripped_last_line == physical_line: > + return len(physical_line), "W292 no newline at end of file" > + > + > +def maximum_line_length(physical_line, max_line_length, multiline): > + r"""Limit all lines to a maximum of 79 characters. > + > + There are still many devices around that are limited to 80 character > + lines; plus, limiting windows to 80 characters makes it possible to > have > + several windows side-by-side. The default wrapping on such devices > looks > + ugly. Therefore, please limit all lines to a maximum of 79 > characters. > + For flowing long blocks of text (docstrings or comments), limiting the > + length to 72 characters is recommended. > + > + Reports error E501. > + """ > + line = physical_line.rstrip() > + length = len(line) > + if length > max_line_length and not noqa(line): > + # Special case for long URLs in multi-line docstrings or comments, > + # but still report the error when the 72 first chars are > whitespaces. > + chunks = line.split() > + if ((len(chunks) == 1 and multiline) or > + (len(chunks) == 2 and chunks[0] == '#')) and \ > + len(line) - len(chunks[-1]) < max_line_length - 7: > + return > + if hasattr(line, 'decode'): # Python 2 > + # The line could contain multi-byte characters > + try: > + length = len(line.decode('utf-8')) > + except UnicodeError: > + pass > + if length > max_line_length: > + return (max_line_length, "E501 line too long " > + "(%d > %d characters)" % (length, max_line_length)) > + > + > > +############################################################################## > +# Plugins (check functions) for logical lines > > +############################################################################## > + > + > +def blank_lines(logical_line, blank_lines, indent_level, line_number, > + blank_before, previous_logical, previous_indent_level): > + r"""Separate top-level function and class definitions with two blank > lines. > + > + Method definitions inside a class are separated by a single blank > line. > + > + Extra blank lines may be used (sparingly) to separate groups of > related > + functions. Blank lines may be omitted between a bunch of related > + one-liners (e.g. a set of dummy implementations). > + > + Use blank lines in functions, sparingly, to indicate logical sections. > + > + Okay: def a():\n pass\n\n\ndef b():\n pass > + Okay: def a():\n pass\n\n\n# Foo\n# Bar\n\ndef b():\n pass > + > + E301: class Foo:\n b = 0\n def bar():\n pass > + E302: def a():\n pass\n\ndef b(n):\n pass > + E303: def a():\n pass\n\n\n\ndef b(n):\n pass > + E303: def a():\n\n\n\n pass > + E304: @decorator\n\ndef a():\n pass > + """ > + if line_number < 3 and not previous_logical: > + return # Don't expect blank lines before the first line > + if previous_logical.startswith('@'): > + if blank_lines: > + yield 0, "E304 blank lines found after function decorator" > + elif blank_lines > 2 or (indent_level and blank_lines == 2): > + yield 0, "E303 too many blank lines (%d)" % blank_lines > + elif logical_line.startswith(('def ', 'class ', '@')): > + if indent_level: > + if not (blank_before or previous_indent_level < indent_level > or > + DOCSTRING_REGEX.match(previous_logical)): > + yield 0, "E301 expected 1 blank line, found 0" > + elif blank_before != 2: > + yield 0, "E302 expected 2 blank lines, found %d" % > blank_before > + > + > +def extraneous_whitespace(logical_line): > + r"""Avoid extraneous whitespace. > + > + Avoid extraneous whitespace in these situations: > + - Immediately inside parentheses, brackets or braces. > + - Immediately before a comma, semicolon, or colon. > + > + Okay: spam(ham[1], {eggs: 2}) > + E201: spam( ham[1], {eggs: 2}) > + E201: spam(ham[ 1], {eggs: 2}) > + E201: spam(ham[1], { eggs: 2}) > + E202: spam(ham[1], {eggs: 2} ) > + E202: spam(ham[1 ], {eggs: 2}) > + E202: spam(ham[1], {eggs: 2 }) > + > + E203: if x == 4: print x, y; x, y = y , x > + E203: if x == 4: print x, y ; x, y = y, x > + E203: if x == 4 : print x, y; x, y = y, x > + """ > + line = logical_line > + for match in EXTRANEOUS_WHITESPACE_REGEX.finditer(line): > + text = match.group() > + char = text.strip() > + found = match.start() > + if text == char + ' ': > + # assert char in '([{' > + yield found + 1, "E201 whitespace after '%s'" % char > + elif line[found - 1] != ',': > + code = ('E202' if char in '}])' else 'E203') # if char in > ',;:' > + yield found, "%s whitespace before '%s'" % (code, char) > + > + > +def whitespace_around_keywords(logical_line): > + r"""Avoid extraneous whitespace around keywords. > + > + Okay: True and False > + E271: True and False > + E272: True and False > + E273: True and\tFalse > + E274: True\tand False > + """ > + for match in KEYWORD_REGEX.finditer(logical_line): > + before, after = match.groups() > + > + if '\t' in before: > + yield match.start(1), "E274 tab before keyword" > + elif len(before) > 1: > + yield match.start(1), "E272 multiple spaces before keyword" > + > + if '\t' in after: > + yield match.start(2), "E273 tab after keyword" > + elif len(after) > 1: > + yield match.start(2), "E271 multiple spaces after keyword" > + > + > +def missing_whitespace(logical_line): > + r"""Each comma, semicolon or colon should be followed by whitespace. > + > + Okay: [a, b] > + Okay: (3,) > + Okay: a[1:4] > + Okay: a[:4] > + Okay: a[1:] > + Okay: a[1:4:2] > + E231: ['a','b'] > + E231: foo(bar,baz) > + E231: [{'a':'b'}] > + """ > + line = logical_line > + for index in range(len(line) - 1): > + char = line[index] > + if char in ',;:' and line[index + 1] not in WHITESPACE: > + before = line[:index] > + if char == ':' and before.count('[') > before.count(']') and \ > + before.rfind('{') < before.rfind('['): > + continue # Slice syntax, no space required > + if char == ',' and line[index + 1] == ')': > + continue # Allow tuple with only one element: (3,) > + yield index, "E231 missing whitespace after '%s'" % char > + > + > +def indentation(logical_line, previous_logical, indent_char, > + indent_level, previous_indent_level): > + r"""Use 4 spaces per indentation level. > + > + For really old code that you don't want to mess up, you can continue > to > + use 8-space tabs. > + > + Okay: a = 1 > + Okay: if a == 0:\n a = 1 > + E111: a = 1 > + E114: # a = 1 > + > + Okay: for item in items:\n pass > + E112: for item in items:\npass > + E115: for item in items:\n# Hi\n pass > + > + Okay: a = 1\nb = 2 > + E113: a = 1\n b = 2 > + E116: a = 1\n # b = 2 > + """ > + c = 0 if logical_line else 3 > + tmpl = "E11%d %s" if logical_line else "E11%d %s (comment)" > + if indent_level % 4: > + yield 0, tmpl % (1 + c, "indentation is not a multiple of four") > + indent_expect = previous_logical.endswith(':') > + if indent_expect and indent_level <= previous_indent_level: > + yield 0, tmpl % (2 + c, "expected an indented block") > + elif not indent_expect and indent_level > previous_indent_level: > + yield 0, tmpl % (3 + c, "unexpected indentation") > + > + > +def continued_indentation(logical_line, tokens, indent_level, > hang_closing, > + indent_char, noqa, verbose): > + r"""Continuation lines indentation. > + > + Continuation lines should align wrapped elements either vertically > + using Python's implicit line joining inside parentheses, brackets > + and braces, or using a hanging indent. > + > + When using a hanging indent these considerations should be applied: > + - there should be no arguments on the first line, and > + - further indentation should be used to clearly distinguish itself as > a > + continuation line. > + > + Okay: a = (\n) > + E123: a = (\n ) > + > + Okay: a = (\n 42) > + E121: a = (\n 42) > + E122: a = (\n42) > + E123: a = (\n 42\n ) > + E124: a = (24,\n 42\n) > + E125: if (\n b):\n pass > + E126: a = (\n 42) > + E127: a = (24,\n 42) > + E128: a = (24,\n 42) > + E129: if (a or\n b):\n pass > + E131: a = (\n 42\n 24) > + """ > + first_row = tokens[0][2][0] > + nrows = 1 + tokens[-1][2][0] - first_row > + if noqa or nrows == 1: > + return > + > + # indent_next tells us whether the next block is indented; assuming > + # that it is indented by 4 spaces, then we should not allow 4-space > + # indents on the final continuation line; in turn, some other > + # indents are allowed to have an extra 4 spaces. > + indent_next = logical_line.endswith(':') > + > + row = depth = 0 > + valid_hangs = (4,) if indent_char != '\t' else (4, 8) > + # remember how many brackets were opened on each line > + parens = [0] * nrows > + # relative indents of physical lines > + rel_indent = [0] * nrows > + # for each depth, collect a list of opening rows > + open_rows = [[0]] > + # for each depth, memorize the hanging indentation > + hangs = [None] > + # visual indents > + indent_chances = {} > + last_indent = tokens[0][2] > + visual_indent = None > + last_token_multiline = False > + # for each depth, memorize the visual indent column > + indent = [last_indent[1]] > + if verbose >= 3: > + print(">>> " + tokens[0][4].rstrip()) > + > + for token_type, text, start, end, line in tokens: > + > + newline = row < start[0] - first_row > + if newline: > + row = start[0] - first_row > + newline = not last_token_multiline and token_type not in > NEWLINE > + > + if newline: > + # this is the beginning of a continuation line. > + last_indent = start > + if verbose >= 3: > + print("... " + line.rstrip()) > + > + # record the initial indent. > + rel_indent[row] = expand_indent(line) - indent_level > + > + # identify closing bracket > + close_bracket = (token_type == tokenize.OP and text in ']})') > + > + # is the indent relative to an opening bracket line? > + for open_row in reversed(open_rows[depth]): > + hang = rel_indent[row] - rel_indent[open_row] > + hanging_indent = hang in valid_hangs > + if hanging_indent: > + break > + if hangs[depth]: > + hanging_indent = (hang == hangs[depth]) > + # is there any chance of visual indent? > + visual_indent = (not close_bracket and hang > 0 and > + indent_chances.get(start[1])) > + > + if close_bracket and indent[depth]: > + # closing bracket for visual indent > + if start[1] != indent[depth]: > + yield (start, "E124 closing bracket does not match " > + "visual indentation") > + elif close_bracket and not hang: > + # closing bracket matches indentation of opening > bracket's line > + if hang_closing: > + yield start, "E133 closing bracket is missing > indentation" > + elif indent[depth] and start[1] < indent[depth]: > + if visual_indent is not True: > + # visual indent is broken > + yield (start, "E128 continuation line " > + "under-indented for visual indent") > + elif hanging_indent or (indent_next and rel_indent[row] == 8): > + # hanging indent is verified > + if close_bracket and not hang_closing: > + yield (start, "E123 closing bracket does not match " > + "indentation of opening bracket's line") > + hangs[depth] = hang > + elif visual_indent is True: > + # visual indent is verified > + indent[depth] = start[1] > + elif visual_indent in (text, str): > + # ignore token lined up with matching one from a previous > line > + pass > + else: > + # indent is broken > + if hang <= 0: > + error = "E122", "missing indentation or outdented" > + elif indent[depth]: > + error = "E127", "over-indented for visual indent" > + elif not close_bracket and hangs[depth]: > + error = "E131", "unaligned for hanging indent" > + else: > + hangs[depth] = hang > + if hang > 4: > + error = "E126", "over-indented for hanging indent" > + else: > + error = "E121", "under-indented for hanging > indent" > + yield start, "%s continuation line %s" % error > + > + # look for visual indenting > + if (parens[row] and > + token_type not in (tokenize.NL, tokenize.COMMENT) and > + not indent[depth]): > + indent[depth] = start[1] > + indent_chances[start[1]] = True > + if verbose >= 4: > + print("bracket depth %s indent to %s" % (depth, start[1])) > + # deal with implicit string concatenation > + elif (token_type in (tokenize.STRING, tokenize.COMMENT) or > + text in ('u', 'ur', 'b', 'br')): > + indent_chances[start[1]] = str > + # special case for the "if" statement because len("if (") == 4 > + elif not indent_chances and not row and not depth and text == > 'if': > + indent_chances[end[1] + 1] = True > + elif text == ':' and line[end[1]:].isspace(): > + open_rows[depth].append(row) > + > + # keep track of bracket depth > + if token_type == tokenize.OP: > + if text in '([{': > + depth += 1 > + indent.append(0) > + hangs.append(None) > + if len(open_rows) == depth: > + open_rows.append([]) > + open_rows[depth].append(row) > + parens[row] += 1 > + if verbose >= 4: > + print("bracket depth %s seen, col %s, visual min = > %s" % > + (depth, start[1], indent[depth])) > + elif text in ')]}' and depth > 0: > + # parent indents should not be more than this one > + prev_indent = indent.pop() or last_indent[1] > + hangs.pop() > + for d in range(depth): > + if indent[d] > prev_indent: > + indent[d] = 0 > + for ind in list(indent_chances): > + if ind >= prev_indent: > + del indent_chances[ind] > + del open_rows[depth + 1:] > + depth -= 1 > + if depth: > + indent_chances[indent[depth]] = True > + for idx in range(row, -1, -1): > + if parens[idx]: > + parens[idx] -= 1 > + break > + assert len(indent) == depth + 1 > + if start[1] not in indent_chances: > + # allow to line up tokens > + indent_chances[start[1]] = text > + > + last_token_multiline = (start[0] != end[0]) > + if last_token_multiline: > + rel_indent[end[0] - first_row] = rel_indent[row] > + > + if indent_next and expand_indent(line) == indent_level + 4: > + pos = (start[0], indent[0] + 4) > + if visual_indent: > + code = "E129 visually indented line" > + else: > + code = "E125 continuation line" > + yield pos, "%s with same indent as next logical line" % code > + > + > +def whitespace_before_parameters(logical_line, tokens): > + r"""Avoid extraneous whitespace. > + > + Avoid extraneous whitespace in the following situations: > + - before the open parenthesis that starts the argument list of a > + function call. > + - before the open parenthesis that starts an indexing or slicing. > + > + Okay: spam(1) > + E211: spam (1) > + > + Okay: dict['key'] = list[index] > + E211: dict ['key'] = list[index] > + E211: dict['key'] = list [index] > + """ > + prev_type, prev_text, __, prev_end, __ = tokens[0] > + for index in range(1, len(tokens)): > + token_type, text, start, end, __ = tokens[index] > + if (token_type == tokenize.OP and > + text in '([' and > + start != prev_end and > + (prev_type == tokenize.NAME or prev_text in '}])') and > + # Syntax "class A (B):" is allowed, but avoid it > + (index < 2 or tokens[index - 2][1] != 'class') and > + # Allow "return (a.foo for a in range(5))" > + not keyword.iskeyword(prev_text)): > + yield prev_end, "E211 whitespace before '%s'" % text > + prev_type = token_type > + prev_text = text > + prev_end = end > + > + > +def whitespace_around_operator(logical_line): > + r"""Avoid extraneous whitespace around an operator. > + > + Okay: a = 12 + 3 > + E221: a = 4 + 5 > + E222: a = 4 + 5 > + E223: a = 4\t+ 5 > + E224: a = 4 +\t5 > + """ > + for match in OPERATOR_REGEX.finditer(logical_line): > + before, after = match.groups() > + > + if '\t' in before: > + yield match.start(1), "E223 tab before operator" > + elif len(before) > 1: > + yield match.start(1), "E221 multiple spaces before operator" > + > + if '\t' in after: > + yield match.start(2), "E224 tab after operator" > + elif len(after) > 1: > + yield match.start(2), "E222 multiple spaces after operator" > + > + > +def missing_whitespace_around_operator(logical_line, tokens): > + r"""Surround operators with a single space on either side. > + > + - Always surround these binary operators with a single space on > + either side: assignment (=), augmented assignment (+=, -= etc.), > + comparisons (==, <, >, !=, <=, >=, in, not in, is, is not), > + Booleans (and, or, not). > + > + - If operators with different priorities are used, consider adding > + whitespace around the operators with the lowest priorities. > + > + Okay: i = i + 1 > + Okay: submitted += 1 > + Okay: x = x * 2 - 1 > + Okay: hypot2 = x * x + y * y > + Okay: c = (a + b) * (a - b) > + Okay: foo(bar, key='word', *args, **kwargs) > + Okay: alpha[:-i] > + > + E225: i=i+1 > + E225: submitted +=1 > + E225: x = x /2 - 1 > + E225: z = x **y > + E226: c = (a+b) * (a-b) > + E226: hypot2 = x*x + y*y > + E227: c = a|b > + E228: msg = fmt%(errno, errmsg) > + """ > + parens = 0 > + need_space = False > + prev_type = tokenize.OP > + prev_text = prev_end = None > + for token_type, text, start, end, line in tokens: > + if token_type in SKIP_COMMENTS: > + continue > + if text in ('(', 'lambda'): > + parens += 1 > + elif text == ')': > + parens -= 1 > + if need_space: > + if start != prev_end: > + # Found a (probably) needed space > + if need_space is not True and not need_space[1]: > + yield (need_space[0], > + "E225 missing whitespace around operator") > + need_space = False > + elif text == '>' and prev_text in ('<', '-'): > + # Tolerate the "<>" operator, even if running Python 3 > + # Deal with Python 3's annotated return value "->" > + pass > + else: > + if need_space is True or need_space[1]: > + # A needed trailing space was not found > + yield prev_end, "E225 missing whitespace around > operator" > + elif prev_text != '**': > + code, optype = 'E226', 'arithmetic' > + if prev_text == '%': > + code, optype = 'E228', 'modulo' > + elif prev_text not in ARITHMETIC_OP: > + code, optype = 'E227', 'bitwise or shift' > + yield (need_space[0], "%s missing whitespace " > + "around %s operator" % (code, optype)) > + need_space = False > + elif token_type == tokenize.OP and prev_end is not None: > + if text == '=' and parens: > + # Allow keyword args or defaults: foo(bar=None). > + pass > + elif text in WS_NEEDED_OPERATORS: > + need_space = True > + elif text in UNARY_OPERATORS: > + # Check if the operator is being used as a binary operator > + # Allow unary operators: -123, -x, +1. > + # Allow argument unpacking: foo(*args, **kwargs). > + if (prev_text in '}])' if prev_type == tokenize.OP > + else prev_text not in KEYWORDS): > + need_space = None > + elif text in WS_OPTIONAL_OPERATORS: > + need_space = None > + > + if need_space is None: > + # Surrounding space is optional, but ensure that > + # trailing space matches opening space > + need_space = (prev_end, start != prev_end) > + elif need_space and start == prev_end: > + # A needed opening space was not found > + yield prev_end, "E225 missing whitespace around operator" > + need_space = False > + prev_type = token_type > + prev_text = text > + prev_end = end > + > + > +def whitespace_around_comma(logical_line): > + r"""Avoid extraneous whitespace after a comma or a colon. > + > + Note: these checks are disabled by default > + > + Okay: a = (1, 2) > + E241: a = (1, 2) > + E242: a = (1,\t2) > + """ > + line = logical_line > + for m in WHITESPACE_AFTER_COMMA_REGEX.finditer(line): > + found = m.start() + 1 > + if '\t' in m.group(): > + yield found, "E242 tab after '%s'" % m.group()[0] > + else: > + yield found, "E241 multiple spaces after '%s'" % m.group()[0] > + > + > +def whitespace_around_named_parameter_equals(logical_line, tokens): > + r"""Don't use spaces around the '=' sign in function arguments. > + > + Don't use spaces around the '=' sign when used to indicate a > + keyword argument or a default parameter value. > + > + Okay: def complex(real, imag=0.0): > + Okay: return magic(r=real, i=imag) > + Okay: boolean(a == b) > + Okay: boolean(a != b) > + Okay: boolean(a <= b) > + Okay: boolean(a >= b) > + Okay: def foo(arg: int = 42): > + > + E251: def complex(real, imag = 0.0): > + E251: return magic(r = real, i = imag) > + """ > + parens = 0 > + no_space = False > + prev_end = None > + annotated_func_arg = False > + in_def = logical_line.startswith('def') > + message = "E251 unexpected spaces around keyword / parameter equals" > + for token_type, text, start, end, line in tokens: > + if token_type == tokenize.NL: > + continue > + if no_space: > + no_space = False > + if start != prev_end: > + yield (prev_end, message) > + if token_type == tokenize.OP: > + if text == '(': > + parens += 1 > + elif text == ')': > + parens -= 1 > + elif in_def and text == ':' and parens == 1: > + annotated_func_arg = True > + elif parens and text == ',' and parens == 1: > + annotated_func_arg = False > + elif parens and text == '=' and not annotated_func_arg: > + no_space = True > + if start != prev_end: > + yield (prev_end, message) > + if not parens: > + annotated_func_arg = False > + > + prev_end = end > + > + > +def whitespace_before_comment(logical_line, tokens): > + r"""Separate inline comments by at least two spaces. > + > + An inline comment is a comment on the same line as a statement. > Inline > + comments should be separated by at least two spaces from the > statement. > + They should start with a # and a single space. > + > + Each line of a block comment starts with a # and a single space > + (unless it is indented text inside the comment). > + > + Okay: x = x + 1 # Increment x > + Okay: x = x + 1 # Increment x > + Okay: # Block comment > + E261: x = x + 1 # Increment x > + E262: x = x + 1 #Increment x > + E262: x = x + 1 # Increment x > + E265: #Block comment > + E266: ### Block comment > + """ > + prev_end = (0, 0) > + for token_type, text, start, end, line in tokens: > + if token_type == tokenize.COMMENT: > + inline_comment = line[:start[1]].strip() > + if inline_comment: > + if prev_end[0] == start[0] and start[1] < prev_end[1] + 2: > + yield (prev_end, > + "E261 at least two spaces before inline > comment") > + symbol, sp, comment = text.partition(' ') > + bad_prefix = symbol not in '#:' and (symbol.lstrip('#')[:1] > or '#') > + if inline_comment: > + if bad_prefix or comment[:1] in WHITESPACE: > + yield start, "E262 inline comment should start with > '# '" > + elif bad_prefix and (bad_prefix != '!' or start[0] > 1): > + if bad_prefix != '#': > + yield start, "E265 block comment should start with '# > '" > + elif comment: > + yield start, "E266 too many leading '#' for block > comment" > + elif token_type != tokenize.NL: > + prev_end = end > + > + > +def imports_on_separate_lines(logical_line): > + r"""Imports should usually be on separate lines. > + > + Okay: import os\nimport sys > + E401: import sys, os > + > + Okay: from subprocess import Popen, PIPE > + Okay: from myclas import MyClass > + Okay: from foo.bar.yourclass import YourClass > + Okay: import myclass > + Okay: import foo.bar.yourclass > + """ > + line = logical_line > + if line.startswith('import '): > + found = line.find(',') > + if -1 < found and ';' not in line[:found]: > + yield found, "E401 multiple imports on one line" > + > + > +def module_imports_on_top_of_file( > + logical_line, indent_level, checker_state, noqa): > + r"""Imports are always put at the top of the file, just after any > module > + comments and docstrings, and before module globals and constants. > + > + Okay: import os > + Okay: # this is a comment\nimport os > + Okay: '''this is a module docstring'''\nimport os > + Okay: r'''this is a module docstring'''\nimport os > + Okay: try:\n import x\nexcept:\n pass\nelse:\n pass\nimport y > + Okay: try:\n import x\nexcept:\n pass\nfinally:\n > pass\nimport y > + E402: a=1\nimport os > + E402: 'One string'\n"Two string"\nimport os > + E402: a=1\nfrom sys import x > + > + Okay: if x:\n import os > + """ > + def is_string_literal(line): > + if line[0] in 'uUbB': > + line = line[1:] > + if line and line[0] in 'rR': > + line = line[1:] > + return line and (line[0] == '"' or line[0] == "'") > + > + allowed_try_keywords = ('try', 'except', 'else', 'finally') > + > + if indent_level: # Allow imports in conditional statements or > functions > + return > + if not logical_line: # Allow empty lines or comments > + return > + if noqa: > + return > + line = logical_line > + if line.startswith('import ') or line.startswith('from '): > + if checker_state.get('seen_non_imports', False): > + yield 0, "E402 module level import not at top of file" > + elif any(line.startswith(kw) for kw in allowed_try_keywords): > + # Allow try, except, else, finally keywords intermixed with > imports in > + # order to support conditional importing > + return > + elif is_string_literal(line): > + # The first literal is a docstring, allow it. Otherwise, report > error. > + if checker_state.get('seen_docstring', False): > + checker_state['seen_non_imports'] = True > + else: > + checker_state['seen_docstring'] = True > + else: > + checker_state['seen_non_imports'] = True > + > + > +def compound_statements(logical_line): > + r"""Compound statements (on the same line) are generally discouraged. > + > + While sometimes it's okay to put an if/for/while with a small body > + on the same line, never do this for multi-clause statements. > + Also avoid folding such long lines! > + > + Always use a def statement instead of an assignment statement that > + binds a lambda expression directly to a name. > + > + Okay: if foo == 'blah':\n do_blah_thing() > + Okay: do_one() > + Okay: do_two() > + Okay: do_three() > + > + E701: if foo == 'blah': do_blah_thing() > + E701: for x in lst: total += x > + E701: while t < 10: t = delay() > + E701: if foo == 'blah': do_blah_thing() > + E701: else: do_non_blah_thing() > + E701: try: something() > + E701: finally: cleanup() > + E701: if foo == 'blah': one(); two(); three() > + E702: do_one(); do_two(); do_three() > + E703: do_four(); # useless semicolon > + E704: def f(x): return 2*x > + E731: f = lambda x: 2*x > + """ > + line = logical_line > + last_char = len(line) - 1 > + found = line.find(':') > + while -1 < found < last_char: > + before = line[:found] > + if ((before.count('{') <= before.count('}') and # {'a': 1} > (dict) > + before.count('[') <= before.count(']') and # [1:2] (slice) > + before.count('(') <= before.count(')'))): # (annotation) > + lambda_kw = LAMBDA_REGEX.search(before) > + if lambda_kw: > + before = line[:lambda_kw.start()].rstrip() > + if before[-1:] == '=' and > isidentifier(before[:-1].strip()): > + yield 0, ("E731 do not assign a lambda expression, > use a " > + "def") > + break > + if before.startswith('def '): > + yield 0, "E704 multiple statements on one line (def)" > + else: > + yield found, "E701 multiple statements on one line > (colon)" > + found = line.find(':', found + 1) > + found = line.find(';') > + while -1 < found: > + if found < last_char: > + yield found, "E702 multiple statements on one line > (semicolon)" > + else: > + yield found, "E703 statement ends with a semicolon" > + found = line.find(';', found + 1) > + > + > +def explicit_line_join(logical_line, tokens): > + r"""Avoid explicit line join between brackets. > + > + The preferred way of wrapping long lines is by using Python's implied > line > + continuation inside parentheses, brackets and braces. Long lines can > be > + broken over multiple lines by wrapping expressions in parentheses. > These > + should be used in preference to using a backslash for line > continuation. > + > + E502: aaa = [123, \\n 123] > + E502: aaa = ("bbb " \\n "ccc") > + > + Okay: aaa = [123,\n 123] > + Okay: aaa = ("bbb "\n "ccc") > + Okay: aaa = "bbb " \\n "ccc" > + Okay: aaa = 123 # \\ > + """ > + prev_start = prev_end = parens = 0 > + comment = False > + backslash = None > + for token_type, text, start, end, line in tokens: > + if token_type == tokenize.COMMENT: > + comment = True > + if start[0] != prev_start and parens and backslash and not > comment: > + yield backslash, "E502 the backslash is redundant between > brackets" > + if end[0] != prev_end: > + if line.rstrip('\r\n').endswith('\\'): > + backslash = (end[0], len(line.splitlines()[-1]) - 1) > + else: > + backslash = None > + prev_start = prev_end = end[0] > + else: > + prev_start = start[0] > + if token_type == tokenize.OP: > + if text in '([{': > + parens += 1 > + elif text in ')]}': > + parens -= 1 > + > + > +def break_around_binary_operator(logical_line, tokens): > + r""" > + Avoid breaks before binary operators. > + > + The preferred place to break around a binary operator is after the > + operator, not before it. > + > + W503: (width == 0\n + height == 0) > + W503: (width == 0\n and height == 0) > + > + Okay: (width == 0 +\n height == 0) > + Okay: foo(\n -x) > + Okay: foo(x\n []) > + Okay: x = '''\n''' + '' > + Okay: foo(x,\n -y) > + Okay: foo(x, # comment\n -y) > + """ > + def is_binary_operator(token_type, text): > + # The % character is strictly speaking a binary operator, but the > + # common usage seems to be to put it next to the format > parameters, > + # after a line break. > + return ((token_type == tokenize.OP or text in ['and', 'or']) and > + text not in "()[]{},:.;@=%") > + > + line_break = False > + unary_context = True > + for token_type, text, start, end, line in tokens: > + if token_type == tokenize.COMMENT: > + continue > + if ('\n' in text or '\r' in text) and token_type != > tokenize.STRING: > + line_break = True > + else: > + if (is_binary_operator(token_type, text) and line_break and > + not unary_context): > + yield start, "W503 line break before binary operator" > + unary_context = text in '([{,;' > + line_break = False > + > + > +def comparison_to_singleton(logical_line, noqa): > + r"""Comparison to singletons should use "is" or "is not". > + > + Comparisons to singletons like None should always be done > + with "is" or "is not", never the equality operators. > + > + Okay: if arg is not None: > + E711: if arg != None: > + E711: if None == arg: > + E712: if arg == True: > + E712: if False == arg: > + > + Also, beware of writing if x when you really mean if x is not None -- > + e.g. when testing whether a variable or argument that defaults to > None was > + set to some other value. The other value might have a type (such as a > + container) that could be false in a boolean context! > + """ > + match = not noqa and COMPARE_SINGLETON_REGEX.search(logical_line) > + if match: > + singleton = match.group(1) or match.group(3) > + same = (match.group(2) == '==') > + > + msg = "'if cond is %s:'" % (('' if same else 'not ') + singleton) > + if singleton in ('None',): > + code = 'E711' > + else: > + code = 'E712' > + nonzero = ((singleton == 'True' and same) or > + (singleton == 'False' and not same)) > + msg += " or 'if %scond:'" % ('' if nonzero else 'not ') > + yield match.start(2), ("%s comparison to %s should be %s" % > + (code, singleton, msg)) > + > + > +def comparison_negative(logical_line): > + r"""Negative comparison should be done using "not in" and "is not". > + > + Okay: if x not in y:\n pass > + Okay: assert (X in Y or X is Z) > + Okay: if not (X in Y):\n pass > + Okay: zz = x is not y > + E713: Z = not X in Y > + E713: if not X.B in Y:\n pass > + E714: if not X is Y:\n pass > + E714: Z = not X.B is Y > + """ > + match = COMPARE_NEGATIVE_REGEX.search(logical_line) > + if match: > + pos = match.start(1) > + if match.group(2) == 'in': > + yield pos, "E713 test for membership should be 'not in'" > + else: > + yield pos, "E714 test for object identity should be 'is not'" > + > + > +def comparison_type(logical_line, noqa): > + r"""Object type comparisons should always use isinstance(). > + > + Do not compare types directly. > + > + Okay: if isinstance(obj, int): > + E721: if type(obj) is type(1): > + > + When checking if an object is a string, keep in mind that it might be > a > + unicode string too! In Python 2.3, str and unicode have a common base > + class, basestring, so you can do: > + > + Okay: if isinstance(obj, basestring): > + Okay: if type(a1) is type(b1): > + """ > + match = COMPARE_TYPE_REGEX.search(logical_line) > + if match and not noqa: > + inst = match.group(1) > + if inst and isidentifier(inst) and inst not in SINGLETONS: > + return # Allow comparison for types which are not obvious > + yield match.start(), "E721 do not compare types, use > 'isinstance()'" > + > + > +def python_3000_has_key(logical_line, noqa): > + r"""The {}.has_key() method is removed in Python 3: use the 'in' > operator. > + > + Okay: if "alph" in d:\n print d["alph"] > + W601: assert d.has_key('alph') > + """ > + pos = logical_line.find('.has_key(') > + if pos > -1 and not noqa: > + yield pos, "W601 .has_key() is deprecated, use 'in'" > + > + > +def python_3000_raise_comma(logical_line): > + r"""When raising an exception, use "raise ValueError('message')". > + > + The older form is removed in Python 3. > + > + Okay: raise DummyError("Message") > + W602: raise DummyError, "Message" > + """ > + match = RAISE_COMMA_REGEX.match(logical_line) > + if match and not RERAISE_COMMA_REGEX.match(logical_line): > + yield match.end() - 1, "W602 deprecated form of raising exception" > + > + > +def python_3000_not_equal(logical_line): > + r"""New code should always use != instead of <>. > + > + The older syntax is removed in Python 3. > + > + Okay: if a != 'no': > + W603: if a <> 'no': > + """ > + pos = logical_line.find('<>') > + if pos > -1: > + yield pos, "W603 '<>' is deprecated, use '!='" > + > + > +def python_3000_backticks(logical_line): > + r"""Backticks are removed in Python 3: use repr() instead. > + > + Okay: val = repr(1 + 2) > + W604: val = `1 + 2` > + """ > + pos = logical_line.find('`') > + if pos > -1: > + yield pos, "W604 backticks are deprecated, use 'repr()'" > + > + > > +############################################################################## > +# Helper functions > > +############################################################################## > + > + > +if sys.version_info < (3,): > + # Python 2: implicit encoding. > + def readlines(filename): > + """Read the source code.""" > + with open(filename, 'rU') as f: > + return f.readlines() > + isidentifier = re.compile(r'[a-zA-Z_]\w*$').match > + stdin_get_value = sys.stdin.read > +else: > + # Python 3 > + def readlines(filename): > + """Read the source code.""" > + try: > + with open(filename, 'rb') as f: > + (coding, lines) = tokenize.detect_encoding(f.readline) > + f = TextIOWrapper(f, coding, line_buffering=True) > + return [l.decode(coding) for l in lines] + f.readlines() > + except (LookupError, SyntaxError, UnicodeError): > + # Fall back if file encoding is improperly declared > + with open(filename, encoding='latin-1') as f: > + return f.readlines() > + isidentifier = str.isidentifier > + > + def stdin_get_value(): > + return TextIOWrapper(sys.stdin.buffer, errors='ignore').read() > +noqa = re.compile(r'# no(?:qa|pep8)\b', re.I).search > + > + > +def expand_indent(line): > + r"""Return the amount of indentation. > + > + Tabs are expanded to the next multiple of 8. > + > + >>> expand_indent(' ') > + 4 > + >>> expand_indent('\t') > + 8 > + >>> expand_indent(' \t') > + 8 > + >>> expand_indent(' \t') > + 16 > + """ > + if '\t' not in line: > + return len(line) - len(line.lstrip()) > + result = 0 > + for char in line: > + if char == '\t': > + result = result // 8 * 8 + 8 > + elif char == ' ': > + result += 1 > + else: > + break > + return result > + > + > +def mute_string(text): > + """Replace contents with 'xxx' to prevent syntax matching. > + > + >>> mute_string('"abc"') > + '"xxx"' > + >>> mute_string("'''abc'''") > + "'''xxx'''" > + >>> mute_string("r'abc'") > + "r'xxx'" > + """ > + # String modifiers (e.g. u or r) > + start = text.index(text[-1]) + 1 > + end = len(text) - 1 > + # Triple quotes > + if text[-3:] in ('"""', "'''"): > + start += 2 > + end -= 2 > + return text[:start] + 'x' * (end - start) + text[end:] > + > + > +def parse_udiff(diff, patterns=None, parent='.'): > + """Return a dictionary of matching lines.""" > + # For each file of the diff, the entry key is the filename, > + # and the value is a set of row numbers to consider. > + rv = {} > + path = nrows = None > + for line in diff.splitlines(): > + if nrows: > + if line[:1] != '-': > + nrows -= 1 > + continue > + if line[:3] == '@@ ': > + hunk_match = HUNK_REGEX.match(line) > + (row, nrows) = [int(g or '1') for g in hunk_match.groups()] > + rv[path].update(range(row, row + nrows)) > + elif line[:3] == '+++': > + path = line[4:].split('\t', 1)[0] > + if path[:2] == 'b/': > + path = path[2:] > + rv[path] = set() > + return dict([(os.path.join(parent, path), rows) > + for (path, rows) in rv.items() > + if rows and filename_match(path, patterns)]) > + > + > +def normalize_paths(value, parent=os.curdir): > + """Parse a comma-separated list of paths. > + > + Return a list of absolute paths. > + """ > + if not value: > + return [] > + if isinstance(value, list): > + return value > + paths = [] > + for path in value.split(','): > + path = path.strip() > + if '/' in path: > + path = os.path.abspath(os.path.join(parent, path)) > + paths.append(path.rstrip('/')) > + return paths > + > + > +def filename_match(filename, patterns, default=True): > + """Check if patterns contains a pattern that matches filename. > + > + If patterns is unspecified, this always returns True. > + """ > + if not patterns: > + return default > + return any(fnmatch(filename, pattern) for pattern in patterns) > + > + > +def _is_eol_token(token): > + return token[0] in NEWLINE or token[4][token[3][1]:].lstrip() == > '\\\n' > +if COMMENT_WITH_NL: > + def _is_eol_token(token, _eol_token=_is_eol_token): > + return _eol_token(token) or (token[0] == tokenize.COMMENT and > + token[1] == token[4]) > + > > +############################################################################## > +# Framework to run all checks > > +############################################################################## > + > + > +_checks = {'physical_line': {}, 'logical_line': {}, 'tree': {}} > + > + > +def _get_parameters(function): > + if sys.version_info >= (3, 3): > + return [parameter.name > + for parameter > + in inspect.signature(function).parameters.values() > + if parameter.kind == parameter.POSITIONAL_OR_KEYWORD] > + else: > + return inspect.getargspec(function)[0] > + > + > +def register_check(check, codes=None): > + """Register a new check object.""" > + def _add_check(check, kind, codes, args): > + if check in _checks[kind]: > + _checks[kind][check][0].extend(codes or []) > + else: > + _checks[kind][check] = (codes or [''], args) > + if inspect.isfunction(check): > + args = _get_parameters(check) > + if args and args[0] in ('physical_line', 'logical_line'): > + if codes is None: > + codes = ERRORCODE_REGEX.findall(check.__doc__ or '') > + _add_check(check, args[0], codes, args) > + elif inspect.isclass(check): > + if _get_parameters(check.__init__)[:2] == ['self', 'tree']: > + _add_check(check, 'tree', codes, None) > + > + > +def init_checks_registry(): > + """Register all globally visible functions. > + > + The first argument name is either 'physical_line' or 'logical_line'. > + """ > + mod = inspect.getmodule(register_check) > + for (name, function) in inspect.getmembers(mod, inspect.isfunction): > + register_check(function) > +init_checks_registry() > + > + > +class Checker(object): > + """Load a Python source file, tokenize it, check coding style.""" > + > + def __init__(self, filename=None, lines=None, > + options=None, report=None, **kwargs): > + if options is None: > + options = StyleGuide(kwargs).options > + else: > + assert not kwargs > + self._io_error = None > + self._physical_checks = options.physical_checks > + self._logical_checks = options.logical_checks > + self._ast_checks = options.ast_checks > + self.max_line_length = options.max_line_length > + self.multiline = False # in a multiline string? > + self.hang_closing = options.hang_closing > + self.verbose = options.verbose > + self.filename = filename > + # Dictionary where a checker can store its custom state. > + self._checker_states = {} > + if filename is None: > + self.filename = 'stdin' > + self.lines = lines or [] > + elif filename == '-': > + self.filename = 'stdin' > + self.lines = stdin_get_value().splitlines(True) > + elif lines is None: > + try: > + self.lines = readlines(filename) > + except IOError: > + (exc_type, exc) = sys.exc_info()[:2] > + self._io_error = '%s: %s' % (exc_type.__name__, exc) > + self.lines = [] > + else: > + self.lines = lines > + if self.lines: > + ord0 = ord(self.lines[0][0]) > + if ord0 in (0xef, 0xfeff): # Strip the UTF-8 BOM > + if ord0 == 0xfeff: > + self.lines[0] = self.lines[0][1:] > + elif self.lines[0][:3] == '\xef\xbb\xbf': > + self.lines[0] = self.lines[0][3:] > + self.report = report or options.report > + self.report_error = self.report.error > + > + def report_invalid_syntax(self): > + """Check if the syntax is valid.""" > + (exc_type, exc) = sys.exc_info()[:2] > + if len(exc.args) > 1: > + offset = exc.args[1] > + if len(offset) > 2: > + offset = offset[1:3] > + else: > + offset = (1, 0) > + self.report_error(offset[0], offset[1] or 0, > + 'E901 %s: %s' % (exc_type.__name__, > exc.args[0]), > + self.report_invalid_syntax) > + > + def readline(self): > + """Get the next line from the input buffer.""" > + if self.line_number >= self.total_lines: > + return '' > + line = self.lines[self.line_number] > + self.line_number += 1 > + if self.indent_char is None and line[:1] in WHITESPACE: > + self.indent_char = line[0] > + return line > + > + def run_check(self, check, argument_names): > + """Run a check plugin.""" > + arguments = [] > + for name in argument_names: > + arguments.append(getattr(self, name)) > + return check(*arguments) > + > + def init_checker_state(self, name, argument_names): > + """ Prepares a custom state for the specific checker plugin.""" > + if 'checker_state' in argument_names: > + self.checker_state = self._checker_states.setdefault(name, {}) > + > + def check_physical(self, line): > + """Run all physical checks on a raw input line.""" > + self.physical_line = line > + for name, check, argument_names in self._physical_checks: > + self.init_checker_state(name, argument_names) > + result = self.run_check(check, argument_names) > + if result is not None: > + (offset, text) = result > + self.report_error(self.line_number, offset, text, check) > + if text[:4] == 'E101': > + self.indent_char = line[0] > + > + def build_tokens_line(self): > + """Build a logical line from tokens.""" > + logical = [] > + comments = [] > + length = 0 > + prev_row = prev_col = mapping = None > + for token_type, text, start, end, line in self.tokens: > + if token_type in SKIP_TOKENS: > + continue > + if not mapping: > + mapping = [(0, start)] > + if token_type == tokenize.COMMENT: > + comments.append(text) > + continue > + if token_type == tokenize.STRING: > + text = mute_string(text) > + if prev_row: > + (start_row, start_col) = start > + if prev_row != start_row: # different row > + prev_text = self.lines[prev_row - 1][prev_col - 1] > + if prev_text == ',' or (prev_text not in '{[(' and > + text not in '}])'): > + text = ' ' + text > + elif prev_col != start_col: # different column > + text = line[prev_col:start_col] + text > + logical.append(text) > + length += len(text) > + mapping.append((length, end)) > + (prev_row, prev_col) = end > + self.logical_line = ''.join(logical) > + self.noqa = comments and noqa(''.join(comments)) > + return mapping > + > + def check_logical(self): > + """Build a line from tokens and run all logical checks on it.""" > + self.report.increment_logical_line() > + mapping = self.build_tokens_line() > + > + if not mapping: > + return > + > + (start_row, start_col) = mapping[0][1] > + start_line = self.lines[start_row - 1] > + self.indent_level = expand_indent(start_line[:start_col]) > + if self.blank_before < self.blank_lines: > + self.blank_before = self.blank_lines > + if self.verbose >= 2: > + print(self.logical_line[:80].rstrip()) > + for name, check, argument_names in self._logical_checks: > + if self.verbose >= 4: > + print(' ' + name) > + self.init_checker_state(name, argument_names) > + for offset, text in self.run_check(check, argument_names) or > (): > + if not isinstance(offset, tuple): > + for token_offset, pos in mapping: > + if offset <= token_offset: > + break > + offset = (pos[0], pos[1] + offset - token_offset) > + self.report_error(offset[0], offset[1], text, check) > + if self.logical_line: > + self.previous_indent_level = self.indent_level > + self.previous_logical = self.logical_line > + self.blank_lines = 0 > + self.tokens = [] > + > + def check_ast(self): > + """Build the file's AST and run all AST checks.""" > + try: > + tree = compile(''.join(self.lines), '', 'exec', PyCF_ONLY_AST) > + except (ValueError, SyntaxError, TypeError): > + return self.report_invalid_syntax() > + for name, cls, __ in self._a

2 1

Summary of Python tracker Issues
by Python tracker 01 Apr '16

01 Apr '16

ACTIVITY SUMMARY (2016-03-25 - 2016-04-01) Python tracker at http://bugs.python.org/ To view or respond to any of the issues listed below, click on the issue. Do NOT respond to this message. Issues counts and deltas: open 5471 (+10) closed 32971 (+33) total 38442 (+43) Open issues with patches: 2379 Issues opened (32) ================== #26643: regrtest: rework libregrtest.save_env submodule http://bugs.python.org/issue26643 opened by haypo #26646: Allow built-in module in package http://bugs.python.org/issue26646 opened by Daniel Shaulov #26647: ceval: use Wordcode, 16-bit bytecode http://bugs.python.org/issue26647 opened by Demur Rumed #26648: csv.reader Error message indicates to use deprecated http://bugs.python.org/issue26648 opened by Philip Martin #26650: calendar: OverflowErrors for year == 1 and firstweekday > 0 http://bugs.python.org/issue26650 opened by mjpieters #26651: Deprecate register_adapter() and register_converter() in sqlit http://bugs.python.org/issue26651 opened by berker.peksag #26652: Cannot install Python 2.7.11 on Windows Server 2008 R2 http://bugs.python.org/issue26652 opened by Hung-Hsuan Chen #26654: asyncio is not inspecting keyword arguments of functools.parti http://bugs.python.org/issue26654 opened by iceboy #26656: Documentation for re.compile is a bit outdated http://bugs.python.org/issue26656 opened by Sworddragon #26657: Directory traversal with http.server and SimpleHTTPServer on w http://bugs.python.org/issue26657 opened by Thomas #26658: test_os fails when run on Windows ramdisk http://bugs.python.org/issue26658 opened by jkloth #26659: slice() leaks memory when part of a cycle http://bugs.python.org/issue26659 opened by Kevin Modzelewski #26660: tempfile.TemporaryDirectory() cleanup exception on Windows if http://bugs.python.org/issue26660 opened by Laurent.Mazuel #26661: python fails to locate system libffi http://bugs.python.org/issue26661 opened by rkuska #26662: configure/Makefile doesn't check if "python" command works, ne http://bugs.python.org/issue26662 opened by haypo #26663: asyncio _UnixWritePipeTransport._close abandons unflushed writ http://bugs.python.org/issue26663 opened by Robert Smallshire #26664: find a bug in activate.fish of venv of cpython3.6 http://bugs.python.org/issue26664 opened by 鄭景文 #26665: pip is not bootstrapped by default on 2.7 http://bugs.python.org/issue26665 opened by Axel #26666: File object hook to modify select(ors) event mask http://bugs.python.org/issue26666 opened by zwol #26667: Update importlib to accept pathlib.Path objects http://bugs.python.org/issue26667 opened by brett.cannon #26668: Remove Lib/test/test_importlib/regrtest.py? http://bugs.python.org/issue26668 opened by haypo #26669: time.localtime(float("NaN")) does not raise a ValueError on al http://bugs.python.org/issue26669 opened by gregory.p.smith #26671: Clean up path_converter in posixmodule.c http://bugs.python.org/issue26671 opened by serhiy.storchaka #26672: regrtest missing in the module name http://bugs.python.org/issue26672 opened by Axel #26673: Tkinter error when opening IDLE configuration menu http://bugs.python.org/issue26673 opened by wysaard #26677: pyvenv: activate.fish breaks $PATH for bash scripts http://bugs.python.org/issue26677 opened by Florian.Dold #26678: Incorrect linking to elements in datetime package http://bugs.python.org/issue26678 opened by andymaier #26679: curses: Descripton of KEY_NPAGE and KEY_PPAGE inverted http://bugs.python.org/issue26679 opened by Robert Bachmann #26680: Incorporating float.is_integer into the numeric tower and Deci http://bugs.python.org/issue26680 opened by Robert Smallshire2 #26682: Ttk Notebook tabs do not show with 1-2 char names http://bugs.python.org/issue26682 opened by terry.reedy #26683: Questionable terminology for describing what locals() does http://bugs.python.org/issue26683 opened by rhettinger #26685: Raise errors from socket.close() http://bugs.python.org/issue26685 opened by martin.panter Most recent 15 issues with no replies (15) ========================================== #26677: pyvenv: activate.fish breaks $PATH for bash scripts http://bugs.python.org/issue26677 #26672: regrtest missing in the module name http://bugs.python.org/issue26672 #26669: time.localtime(float("NaN")) does not raise a ValueError on al http://bugs.python.org/issue26669 #26667: Update importlib to accept pathlib.Path objects http://bugs.python.org/issue26667 #26665: pip is not bootstrapped by default on 2.7 http://bugs.python.org/issue26665 #26663: asyncio _UnixWritePipeTransport._close abandons unflushed writ http://bugs.python.org/issue26663 #26661: python fails to locate system libffi http://bugs.python.org/issue26661 #26660: tempfile.TemporaryDirectory() cleanup exception on Windows if http://bugs.python.org/issue26660 #26656: Documentation for re.compile is a bit outdated http://bugs.python.org/issue26656 #26652: Cannot install Python 2.7.11 on Windows Server 2008 R2 http://bugs.python.org/issue26652 #26626: test_dbm_gnu http://bugs.python.org/issue26626 #26618: _overlapped extension module of asyncio uses deprecated WSAStr http://bugs.python.org/issue26618 #26615: Missing entry in WRAPPER_ASSIGNMENTS in update_wrapper's doc http://bugs.python.org/issue26615 #26609: Wrong request target in test_httpservers.py http://bugs.python.org/issue26609 #26600: MagickMock __str__ sometimes returns MagickMock instead of str http://bugs.python.org/issue26600 Most recent 15 issues waiting for review (15) ============================================= #26685: Raise errors from socket.close() http://bugs.python.org/issue26685 #26680: Incorporating float.is_integer into the numeric tower and Deci http://bugs.python.org/issue26680 #26679: curses: Descripton of KEY_NPAGE and KEY_PPAGE inverted http://bugs.python.org/issue26679 #26671: Clean up path_converter in posixmodule.c http://bugs.python.org/issue26671 #26661: python fails to locate system libffi http://bugs.python.org/issue26661 #26658: test_os fails when run on Windows ramdisk http://bugs.python.org/issue26658 #26657: Directory traversal with http.server and SimpleHTTPServer on w http://bugs.python.org/issue26657 #26651: Deprecate register_adapter() and register_converter() in sqlit http://bugs.python.org/issue26651 #26650: calendar: OverflowErrors for year == 1 and firstweekday > 0 http://bugs.python.org/issue26650 #26648: csv.reader Error message indicates to use deprecated http://bugs.python.org/issue26648 #26647: ceval: use Wordcode, 16-bit bytecode http://bugs.python.org/issue26647 #26646: Allow built-in module in package http://bugs.python.org/issue26646 #26643: regrtest: rework libregrtest.save_env submodule http://bugs.python.org/issue26643 #26642: Replace stdout and stderr with simple standard printers at Pyt http://bugs.python.org/issue26642 #26639: Tools/i18n/pygettext.py: replace deprecated imp module with im http://bugs.python.org/issue26639 Top 10 most discussed issues (10) ================================= #26488: hashlib command line interface http://bugs.python.org/issue26488 15 msgs #26647: ceval: use Wordcode, 16-bit bytecode http://bugs.python.org/issue26647 15 msgs #26624: Windows hangs in call to CRT setlocale() http://bugs.python.org/issue26624 10 msgs #18844: allow weights in random.choice http://bugs.python.org/issue18844 8 msgs #26632: __all__ decorator http://bugs.python.org/issue26632 6 msgs #26658: test_os fails when run on Windows ramdisk http://bugs.python.org/issue26658 6 msgs #26680: Incorporating float.is_integer into the numeric tower and Deci http://bugs.python.org/issue26680 6 msgs #23551: IDLE to provide menu link to PIP gui. http://bugs.python.org/issue23551 5 msgs #23735: Readline not adjusting width after resize with 6.3 http://bugs.python.org/issue23735 5 msgs #26606: logging.baseConfig is missing the encoding parameter http://bugs.python.org/issue26606 5 msgs Issues closed (30) ================== #15117: Please document top-level sqlite3 module variables http://bugs.python.org/issue15117 closed by berker.peksag #18691: sqlite3.Cursor.execute expects sequence as second argument. http://bugs.python.org/issue18691 closed by berker.peksag #19065: sqlite3 timestamp adapter chokes on timezones http://bugs.python.org/issue19065 closed by berker.peksag #22218: Fix more compiler warnings "comparison between signed and unsi http://bugs.python.org/issue22218 closed by haypo #22854: Documentation/implementation out of sync for IO http://bugs.python.org/issue22854 closed by martin.panter #23758: Improve documenation about num_params in sqlite3 create_functi http://bugs.python.org/issue23758 closed by berker.peksag #23804: SSLSocket.recv(0) receives up to 1024 bytes http://bugs.python.org/issue23804 closed by martin.panter #25195: mock.ANY doesn't match mock.MagicMock() object http://bugs.python.org/issue25195 closed by berker.peksag #25256: Add sys.debug_build public variable to check if Python was com http://bugs.python.org/issue25256 closed by haypo #25276: Intermittent segfaults on PPC64 AIX 3.x http://bugs.python.org/issue25276 closed by haypo #25289: test_strptime hangs sometimes on AMD64 Windows7 SP1 3.x buildb http://bugs.python.org/issue25289 closed by haypo #25940: SSL tests failed due to expired svn.python.org SSL certificate http://bugs.python.org/issue25940 closed by martin.panter #26130: redundant local copy of a char pointer in classify in Parser\p http://bugs.python.org/issue26130 closed by berker.peksag #26492: Exhausted array iterator should left exhausted http://bugs.python.org/issue26492 closed by serhiy.storchaka #26494: Double deallocation on iterator exhausting http://bugs.python.org/issue26494 closed by serhiy.storchaka #26591: datetime datetime.time to datetime.time comparison does nothin http://bugs.python.org/issue26591 closed by belopolsky #26616: A bug in datetime.astimezone() method http://bugs.python.org/issue26616 closed by belopolsky #26640: xmlrpc.server imports xmlrpc.client http://bugs.python.org/issue26640 closed by brett.cannon #26641: doctest doesn't support packages http://bugs.python.org/issue26641 closed by haypo #26644: SSLSocket.recv(-1) triggers SystemError http://bugs.python.org/issue26644 closed by martin.panter #26645: argparse prints help messages to stdout instead of stderr by d http://bugs.python.org/issue26645 closed by serhiy.storchaka #26649: Fail update installation: 'utf-8' codec can't decode http://bugs.python.org/issue26649 closed by haypo #26653: bisect raises a TypeError when hi is None http://bugs.python.org/issue26653 closed by rhettinger #26655: pathlib glob case sensitivity issue on Windows http://bugs.python.org/issue26655 closed by SilentGhost #26670: Add a developer mode: -X dev command line option http://bugs.python.org/issue26670 closed by haypo #26674: 【typo】 Japanese Documentation http://bugs.python.org/issue26674 closed by ezio.melotti #26675: Appending to a large list flushes old entries http://bugs.python.org/issue26675 closed by Swaprava Nath #26676: Add missing XMLPullParser to ElementTree.__all__ http://bugs.python.org/issue26676 closed by martin.panter #26681: decorators for attributes http://bugs.python.org/issue26681 closed by ethan.furman #26684: pathlib.Path.with_name() and .with_suffix do not allow combini http://bugs.python.org/issue26684 closed by ethan.furman

1 0

The future of Python: fixing broken error handling in Python 8
by Ryan Gonzalez 01 Apr '16

01 Apr '16

Python's exception handling system is currently badly brokeTypeError: unsupported operand type(s) for +: 'NoneType' and 'NoneType'n. Therefore, with the recent news of the joyous release of Python 8 ( https://mail.python.org/pipermail/python-dev/2016-March/143603.html), I have decided to propose a revolutionary idea: safe mock objects. A "safe" mock object (qualified name `_frozensafemockobjectimplementation.SafeMockObjectThatIsIncludedWithPython8`; Java-style naming was adopted for readability purposes; comments are now no longer necessary) is a magic object that supports everything and returns itself. Since examples speak more words than are in the Python source code, here are some (examples, not words in the Python source code): a = 1 b = None c = a + b # Returns a _frozensafemockobjectimplementation.SafeMockObjectThatIsIncludedWithPython8 print(c) # Prints the empty string. d = c+1 # All operations on `_frozensafemockobjectimplementation.SafeMockObjectThatIsIncludedWithPython8`'s return a new one. e = d.xyz(1, 2, 3) # `e` is now a `_frozensafemockobjectimplementation.SafeMockObjectThatIsIncludedWithPython8`. def f(): assert 0 # Causes the function to return a `_frozensafemockobjectimplementation.SafeMockObjectThatIsIncludedWithPython8`. raise 123 # Does the same thing. print(L) # L is undefined, so it becomes a `_frozensafemockobjectimplementation.SafeMockObjectThatIsIncludedWithPython8`. Safe mock objects are obviously the Next Error Handling Revolution ™. Unicode errors now simply disappear and return more `_frozensafemockobjectimplementation.SafeMockObjectThatIsIncludedWithPython8`s. As for `try` and `catch` (protest the naming of `except`!!) statements, they will be completely ignored. The `try`, `except`, and `finally` bodies will all be executed in sequence, except that printing and returning values with an `except` statement does nothing: try: xyz = None.a # `xyz` becomes a `_frozensafemockobjectimplementation.SafeMockObjectThatIsIncludedWithPython8`. except: print(123) # Does nothing. return None # Does nothing. finally: return xyz # Returns a `_frozensafemockobjectimplementation.SafeMockObjectThatIsIncludedWithPython8`. Aggressive error handling (as shown in PanicSort [https://xkcd.com/1185/]) that does destructive actions (such as `rm -rf /`) will always execute the destructive code, encouraging more honest development. In addition, due to errors simply being ignored, nothing can ever quite go wrong. All discussions about a safe navigation operator can now be immediately halted, since any undefined attributes will simply return a `_frozensafemockobjectimplementation.SafeMockObjectThatIsIncludedWithPython8`. Although I have not yet destroy--I mean, improved CPython to allow for this amazing idea, I have created a primitive implementation of the `_frozensafemockobjectimplementation` module: https://github.com/kirbyfan64/_frozensafemockobjectimplementation I hope you will all realize that this new idea is a drastic improvement over current technologies and therefore support it, because we can Make Python Great Again™. -- Ryan [ERROR]: Your autotools build scripts are 200 lines longer than your program. Something’s wrong. http://kirbyfan64.github.io/

1 0

Adding a Pip GUI to IDLE and idlelib (GSOC project)
by Terry Reedy 01 Apr '16

01 Apr '16

Summary: There are two prospective Google Summer of Code (GSOC) students applying to work on writing a gui interface to the basic pip functions needed by beginners. I expect Google to accept their proposals. Before I commit to mentoring a student (sometime in April), I would like to be sure, by addressing any objections now, that I will be able to commit the code when ready (August or before). Long version: In February 2015, Raymond Hettinger opened tracker issue "IDLE to provide menu options for using PIP" https://bugs.python.org/issue23551#msg236906 The menu options would presumably open dialog boxes defined in a new module such as idlelib.pipgui. Raymond gave a list of 9 features he thought would be useful to pip beginners. Donald Stufft (pip maintainer) answered that he already wanted someone to write a pip gui, to be put somewhere, and that he would give advice on interfacing (which he has). I answered that I had also had a vague idea of a pip gui, and thought it should be a stand-alone window invoked by a single IDLE menu item, just as turtledemo can be now. Instead of multiple dialogs (for multiple IDLE menu items), there could be, for instance, multiple tabs in a ttk.Notebook. Some pages might implement more than 1 of the features on Raymond's list. Last September, I did some proof-of-concept experiments and changed the title to "IDLE to provide menu link to PIP gui". In January, when Terri Oda requested Core Python GSOC project ideas, I suggested the pip gui project. I believe Raymond's list can easily be programmed in the time alloted. I also volunteered to help mentor. Since then, two students have submitted competent prototypes (on the tracker issue above) that show that they can write a basic tkinter app and revise in response to reviews. My current plan is to add idlelib/pipgui.py (or perhaps pip.py) to 3.5 and 3.6. The file will be structured so that it can either be run as a separate process ('python -m idlelib.pipgui' either at a console or in a subprocess call) or imported into a running process. IDLE would currently use a subprocess call, but if IDLE is restructured into a single-window, multi-tab application, it might switch to using an import. I would document the new IDLE menu entry in the current IDLE page. Separately from the pip gui project, I plan, at some point, to add a new 'idlelib' section that documents public entry points to generally useful idlelib components. If I do that before next August, I would add an entry for pipgui (which would say that details of the GUI are subject to change). Possible objections: 1. One might argue that if pipgui is written so as to not depend on IDLE, then it, like turtledemo, should be located elsewhere, possibly in Tools/scrips. I would answer that managing packages, unlike running turtle demos, *is* an IDE function. 2. One might argue that adding a new module with a public entry point, in a maintenance release, somehow abuses the license granted by PEP434, in a way that declaring a public interface in an existing module would not. If this is sustained, I could not document the new module for 3.5. Thoughts? -- Terry Jan Reedy

3 3

← Newer
1
2
3
4
5
6
7
8
9
Older →

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

2000

1999

Python-Dev April 2016