Mailman 3 December 2017 - Python-Dev

When val=b'', but val == b'' returns False - bytes initialization
by Jonathan Underwood Dec. 27, 2017

Dec. 27, 2017

Hello, I am not sure if this is expected behaviour, or a bug. In a C extension module, if I create and return an empty bytes object like this: val = PyBytes_FromStringAndSize (NULL, 20); Py_SIZE(val) = 0; Then from the Python interpreter's perspective: isinstance(val, bytes) returns True print(val) returns b'' print(repr(val)) returns b'' BUT val == b'' returns False. On the other hand, initializing the underlying memory: val = PyBytes_FromStringAndSize (NULL, 20); PyBytes_AS_STRING (val); c[0] = '\0'; Py_SIZE(val) = 0; Then, from the Python interpreter, val == b'' returns True, as expected. So, my question is: is this the expected behaviour, or a bug? I was slightly surprised to have to initialize the storage. On the other hand, I can perhaps also see it might be expected, since the docs do say that PyBytes_FromStringAndSize will not initialize the underlying storage. Please cc me on any replies - am not subscribed to the list. Many thanks, Jonathan

2 2

Guarantee ordered dict literals in v3.7?
by Stefan Krah Dec. 23, 2017

Dec. 23, 2017

Hello, would it be possible to guarantee that dict literals are ordered in v3.7? The issue is well-known and the workarounds are tedious, example: https://mail.python.org/pipermail/python-ideas/2015-December/037423.html If the feature is guaranteed now, people can rely on it around v3.9. Stefan Krah

40 148

pep-0557 dataclasses top level module vs part of collections?
by Gregory P. Smith Dec. 22, 2017

Dec. 22, 2017

It seems a suggested use is "from dataclasses import dataclass" But people are already familiar with "from collections import namedtuple" which suggests to me that "from collections import dataclass" would be a more natural sounding API addition. But the dataclasses module has additional APIs beyond @dataclass which clearly do not belong at the top level in collections. Idea: How about making the current dataclasses.dataclass decorator function instead be a callable class instance (ie: it still functions as property, todays dataclasses.dataclass becomes collections.dataclass.__call__) with all of the current contents of the dataclasses module as attributes of a collections.dataclass class/instance singleton? It feels like a more natural API to me: from collections import dataclass @dataclass class ... and the following APIs show up on dataclass itself: dataclass.Field, dataclass.field, dataclass.fields, dataclass.make, dataclass.astuple, dataclass.replace, dataclass.asdict, dataclass.FrozenInstanceError, dataclass.InitVar instead of being in a separate dataclasses module and being a different style of thing to import than namedtuple. [ if this was discussed earlier for this pep and rejected and I missed it, my apologies, just drop me a reference to that thread if you've got one ] This isn't a blocker for me. I like having a dataclass implementation no matter how we arrange it. If we go with what's checked in today, a top level dataclasses module, so be it. I'm not going to bikeshed this to death it just feels odd to have such an API outside of collections but figured it was worth suggesting. Part of me just doesn't like the plural dataclasses module name. I can get over that. -gps

3 3

Summary of Python tracker Issues
by Python tracker Dec. 22, 2017

Dec. 22, 2017

ACTIVITY SUMMARY (2017-12-15 - 2017-12-22) Python tracker at https://bugs.python.org/ To view or respond to any of the issues listed below, click on the issue. Do NOT respond to this message. Issues counts and deltas: open 6342 (+12) closed 37819 (+64) total 44161 (+76) Open issues with patches: 2456 Issues opened (52) ================== #30697: segfault in PyErr_NormalizeException() after memory exhaustion https://bugs.python.org/issue30697 reopened by brett.cannon #32335: Failed Python build on Fedora 27 https://bugs.python.org/issue32335 opened by amitg-b14 #32336: Save OrderedDict import in argparse https://bugs.python.org/issue32336 opened by rhettinger #32337: Dict order is now guaranteed, so add tests and doc for it https://bugs.python.org/issue32337 opened by rhettinger #32338: Save OrderedDict import in re https://bugs.python.org/issue32338 opened by serhiy.storchaka #32339: Make the dict type used in csv.DictReader configurable https://bugs.python.org/issue32339 opened by serhiy.storchaka #32343: Leak Sanitizer reports memory leaks while building using ASAN https://bugs.python.org/issue32343 opened by kirit1193 #32345: EIO from write() is only fatal if print() contains a newline https://bugs.python.org/issue32345 opened by Creideiki #32346: Speed up slot lookup for class creation https://bugs.python.org/issue32346 opened by pitrou #32347: System Integrity Protection breaks shutil.copystat() https://bugs.python.org/issue32347 opened by Ryan Govostes #32352: `inspect.getfullargspec` doesn't work fine for some builtin ca https://bugs.python.org/issue32352 opened by thautwarm #32353: Add docs about Embedding with an frozen module limitation. https://bugs.python.org/issue32353 opened by Decorater #32354: Unclear intention of deprecating Py_UNICODE_TOLOWER / Py_UNICO https://bugs.python.org/issue32354 opened by ideasman42 #32358: json.dump: fp must be a text file object https://bugs.python.org/issue32358 opened by qingyunha #32359: Add getters for all SSLContext internal configuration https://bugs.python.org/issue32359 opened by njs #32360: Save OrderedDict imports in various stdlibs. https://bugs.python.org/issue32360 opened by inada.naoki #32361: global / nonlocal interference : is this a bug, a feature or a https://bugs.python.org/issue32361 opened by Camion #32362: multiprocessing.connection.Connection misdocumented as multipr https://bugs.python.org/issue32362 opened by Amery #32363: Deprecate task.set_result() and task.set_exception() https://bugs.python.org/issue32363 opened by asvetlov #32364: Add AbstractFuture and AbstractTask https://bugs.python.org/issue32364 opened by asvetlov #32367: [Security] CVE-2017-17522: webbrowser.py in Python does not va https://bugs.python.org/issue32367 opened by vstinner #32368: Segfault when compiling many conditional expressions https://bugs.python.org/issue32368 opened by snordhausen #32370: Wrong ANSI encoding used by subprocess for some locales https://bugs.python.org/issue32370 opened by Segev Finer #32371: Delay-loading of python dll is impossible when using some C ma https://bugs.python.org/issue32371 opened by Pierre Chatelier #32372: Optimize out __debug__ at the AST level https://bugs.python.org/issue32372 opened by serhiy.storchaka #32373: Add socket.getblocking() method https://bugs.python.org/issue32373 opened by yselivanov #32374: Document that m_traverse for multi-phase initialized modules c https://bugs.python.org/issue32374 opened by encukou #32375: Compilation warnings in getpath.c with gcc on Ubuntu / -D_FORT https://bugs.python.org/issue32375 opened by pitrou #32378: test_npn_protocols broken with LibreSSL 2.6.1+ https://bugs.python.org/issue32378 opened by christian.heimes #32380: functools.singledispatch interacts poorly with methods https://bugs.python.org/issue32380 opened by Ethan Smith #32381: Python 3.6 cannot reopen .pyc file with non-ASCII path https://bugs.python.org/issue32381 opened by tianjg #32384: Generator tests is broken in non-CPython implementation https://bugs.python.org/issue32384 opened by isaiahp #32387: Disallow untagged C extension import on major platforms https://bugs.python.org/issue32387 opened by pitrou #32388: Remove cross-version binary compatibility https://bugs.python.org/issue32388 opened by pitrou #32390: AIX (xlc_r) compile error with Modules/posixmodule.c: Function https://bugs.python.org/issue32390 opened by Michael.Felt #32391: Add StreamWriter.wait_closed() https://bugs.python.org/issue32391 opened by asvetlov #32392: subprocess.run documentation does not have **kwargs https://bugs.python.org/issue32392 opened by oprypin #32393: nav menu jitter in old documentation https://bugs.python.org/issue32393 opened by Joseph Hendrey #32394: socket lib beahavior change in 3.6.4 https://bugs.python.org/issue32394 opened by skn78 #32395: asyncio.StreamReader.readuntil is not general enough https://bugs.python.org/issue32395 opened by Bruce Merry #32396: Implement method to write/read to serials without blocking on https://bugs.python.org/issue32396 opened by jabdoa #32397: textwrap output may change if you wrap a paragraph twice https://bugs.python.org/issue32397 opened by larry #32398: OSX C++ linking workaround in distutils breaks other packages https://bugs.python.org/issue32398 opened by esuarezsantana #32399: _uuidmodule.c cannot build on AIX - different typedefs of uuid https://bugs.python.org/issue32399 opened by Michael.Felt #32400: inspect.isdatadescriptor false negative https://bugs.python.org/issue32400 opened by chnlior #32401: No module named '_ctypes' https://bugs.python.org/issue32401 opened by YoSTEALTH #32402: Coverity: CID 1426868/1426867: Null pointer dereferences in t https://bugs.python.org/issue32402 opened by vstinner #32403: date, time and datetime alternate constructors should take fas https://bugs.python.org/issue32403 opened by p-ganssle #32404: fromtimestamp does not call __new__ in datetime subclasses https://bugs.python.org/issue32404 opened by p-ganssle #32408: Performance regression in urllib.proxy_bypass_environment https://bugs.python.org/issue32408 opened by xiang.zhang #32409: venv activate.bat is UTF-8 encoded but uses current console co https://bugs.python.org/issue32409 opened by Jac0 #32410: Implement loop.sock_sendfile method https://bugs.python.org/issue32410 opened by asvetlov Most recent 15 issues with no replies (15) ========================================== #32410: Implement loop.sock_sendfile method https://bugs.python.org/issue32410 #32408: Performance regression in urllib.proxy_bypass_environment https://bugs.python.org/issue32408 #32404: fromtimestamp does not call __new__ in datetime subclasses https://bugs.python.org/issue32404 #32403: date, time and datetime alternate constructors should take fas https://bugs.python.org/issue32403 #32402: Coverity: CID 1426868/1426867: Null pointer dereferences in t https://bugs.python.org/issue32402 #32400: inspect.isdatadescriptor false negative https://bugs.python.org/issue32400 #32393: nav menu jitter in old documentation https://bugs.python.org/issue32393 #32384: Generator tests is broken in non-CPython implementation https://bugs.python.org/issue32384 #32380: functools.singledispatch interacts poorly with methods https://bugs.python.org/issue32380 #32378: test_npn_protocols broken with LibreSSL 2.6.1+ https://bugs.python.org/issue32378 #32372: Optimize out __debug__ at the AST level https://bugs.python.org/issue32372 #32371: Delay-loading of python dll is impossible when using some C ma https://bugs.python.org/issue32371 #32362: multiprocessing.connection.Connection misdocumented as multipr https://bugs.python.org/issue32362 #32360: Save OrderedDict imports in various stdlibs. https://bugs.python.org/issue32360 #32358: json.dump: fp must be a text file object https://bugs.python.org/issue32358 Most recent 15 issues waiting for review (15) ============================================= #32410: Implement loop.sock_sendfile method https://bugs.python.org/issue32410 #32402: Coverity: CID 1426868/1426867: Null pointer dereferences in t https://bugs.python.org/issue32402 #32399: _uuidmodule.c cannot build on AIX - different typedefs of uuid https://bugs.python.org/issue32399 #32390: AIX (xlc_r) compile error with Modules/posixmodule.c: Function https://bugs.python.org/issue32390 #32388: Remove cross-version binary compatibility https://bugs.python.org/issue32388 #32387: Disallow untagged C extension import on major platforms https://bugs.python.org/issue32387 #32384: Generator tests is broken in non-CPython implementation https://bugs.python.org/issue32384 #32378: test_npn_protocols broken with LibreSSL 2.6.1+ https://bugs.python.org/issue32378 #32374: Document that m_traverse for multi-phase initialized modules c https://bugs.python.org/issue32374 #32373: Add socket.getblocking() method https://bugs.python.org/issue32373 #32372: Optimize out __debug__ at the AST level https://bugs.python.org/issue32372 #32363: Deprecate task.set_result() and task.set_exception() https://bugs.python.org/issue32363 #32353: Add docs about Embedding with an frozen module limitation. https://bugs.python.org/issue32353 #32347: System Integrity Protection breaks shutil.copystat() https://bugs.python.org/issue32347 #32346: Speed up slot lookup for class creation https://bugs.python.org/issue32346 Top 10 most discussed issues (10) ================================= #32361: global / nonlocal interference : is this a bug, a feature or a https://bugs.python.org/issue32361 20 msgs #32030: PEP 432: Rewrite Py_Main() https://bugs.python.org/issue32030 15 msgs #32259: Misleading "not iterable" Error Message when generator return https://bugs.python.org/issue32259 14 msgs #32387: Disallow untagged C extension import on major platforms https://bugs.python.org/issue32387 11 msgs #25749: asyncio.Server class documented but not exported https://bugs.python.org/issue25749 9 msgs #32394: socket lib beahavior change in 3.6.4 https://bugs.python.org/issue32394 9 msgs #17852: Built-in module _io can lose data from buffered files at exit https://bugs.python.org/issue17852 8 msgs #32221: Converting ipv6 address to string representation using getname https://bugs.python.org/issue32221 8 msgs #32338: Save OrderedDict import in re https://bugs.python.org/issue32338 7 msgs #32346: Speed up slot lookup for class creation https://bugs.python.org/issue32346 7 msgs Issues closed (61) ================== #15216: Add encoding & errors parameters to TextIOWrapper.reconfigure( https://bugs.python.org/issue15216 closed by inada.naoki #15852: typos in curses argument error messages https://bugs.python.org/issue15852 closed by asvetlov #19764: subprocess: use PROC_THREAD_ATTRIBUTE_HANDLE_LIST with STARTUP https://bugs.python.org/issue19764 closed by vstinner #20493: select module: loop if the timeout is too large (OverflowError https://bugs.python.org/issue20493 closed by asvetlov #24539: StreamReaderProtocol.eof_received() should return True to keep https://bugs.python.org/issue24539 closed by asvetlov #24795: Make event loops with statement context managers https://bugs.python.org/issue24795 closed by asvetlov #25074: Bind logger and waninigs modules for asyncio __del__ methods https://bugs.python.org/issue25074 closed by asvetlov #25675: doc for BaseEventLoop.run_in_executor() says its a coroutine, https://bugs.python.org/issue25675 closed by asvetlov #26188: Provide more helpful error message when `await` is called insi https://bugs.python.org/issue26188 closed by asvetlov #26357: asyncio.wait loses coroutine return value https://bugs.python.org/issue26357 closed by asvetlov #27746: ResourceWarnings in test_asyncio https://bugs.python.org/issue27746 closed by asvetlov #28212: Closing server in asyncio is not efficient https://bugs.python.org/issue28212 closed by asvetlov #28697: asyncio.Lock, Condition, Semaphore docs don't mention `async w https://bugs.python.org/issue28697 closed by asvetlov #28942: await expressions in f-strings https://bugs.python.org/issue28942 closed by yselivanov #29042: os.path.exists should not throw "Embedded NUL character" excep https://bugs.python.org/issue29042 closed by vstinner #29344: sock_recv not detected a coroutine https://bugs.python.org/issue29344 closed by asvetlov #29517: "Can't pickle local object" when uses functools.partial with m https://bugs.python.org/issue29517 closed by yselivanov #29558: Provide run_until_complete inside loop https://bugs.python.org/issue29558 closed by asvetlov #29689: Asyncio-namespace helpers for async_generators https://bugs.python.org/issue29689 closed by asvetlov #29711: When you use stop_serving in proactor loop it's kill all liste https://bugs.python.org/issue29711 closed by yselivanov #29889: test_asyncio fails always https://bugs.python.org/issue29889 closed by asvetlov #29970: Severe open file leakage running asyncio SSL server https://bugs.python.org/issue29970 closed by asvetlov #30014: Speedup DefaultSelectors.modify() by 2x https://bugs.python.org/issue30014 closed by asvetlov #30050: Please provide a way to disable the warning printed if the sig https://bugs.python.org/issue30050 closed by yselivanov #30539: Make Proactor public in asyncio.ProactorEventLoop https://bugs.python.org/issue30539 closed by yselivanov #31059: asyncio.StreamReader.read hangs if n<0 https://bugs.python.org/issue31059 closed by asvetlov #31094: asyncio: get list of connected clients https://bugs.python.org/issue31094 closed by asvetlov #31901: atexit callbacks should be run at subinterpreter shutdown https://bugs.python.org/issue31901 closed by pitrou #32250: Add asyncio.current_task() and asyncio.all_tasks() funcitons https://bugs.python.org/issue32250 closed by asvetlov #32276: there is no way to make tempfile reproducible (i.e. seed the u https://bugs.python.org/issue32276 closed by serhiy.storchaka #32287: Import of _pyio module failed on cygwin https://bugs.python.org/issue32287 closed by erik.bray #32306: Clarify map API in concurrent.futures https://bugs.python.org/issue32306 closed by pitrou #32315: can't run any scripts with 2.7.x, 32 and 64-bit https://bugs.python.org/issue32315 closed by terry.reedy #32318: Remove "globals()" call from "socket.accept()" https://bugs.python.org/issue32318 closed by yselivanov #32323: urllib.parse.urlsplit() must not lowercase() IPv6 scope value https://bugs.python.org/issue32323 closed by asvetlov #32331: Fix socket.type on OSes with SOCK_NONBLOCK https://bugs.python.org/issue32331 closed by yselivanov #32340: ValueError: time data 'N/A' does not match format '%Y%m%d' https://bugs.python.org/issue32340 closed by r.david.murray #32341: itertools "generators"? https://bugs.python.org/issue32341 closed by rhettinger #32342: safe_power(): CID 1426161: Integer handling issues (DIVIDE_B https://bugs.python.org/issue32342 closed by vstinner #32344: Explore whether peephole.c tuple of constants folding can be a https://bugs.python.org/issue32344 closed by serhiy.storchaka #32348: Optimize asyncio.Future schedule/add/remove callback https://bugs.python.org/issue32348 closed by yselivanov #32349: Add detailed return value information for set.intersection fun https://bugs.python.org/issue32349 closed by rhettinger #32350: pip can't handle MSVC warnings containing special characters https://bugs.python.org/issue32350 closed by paul.moore #32351: Use fastpath in asyncio.sleep if delay<0 https://bugs.python.org/issue32351 closed by asvetlov #32355: Optimize asyncio.gather() https://bugs.python.org/issue32355 closed by yselivanov #32356: asyncio: Make transport.pause_reading()/resume_reading() idemp https://bugs.python.org/issue32356 closed by yselivanov #32357: Optimize asyncio.iscoroutine() and loop.create_task() for non- https://bugs.python.org/issue32357 closed by yselivanov #32365: Reference leak: test_ast test_builtin test_compile https://bugs.python.org/issue32365 closed by serhiy.storchaka #32366: suggestion:html.escape(s, quote=True) escape \n to <br /> https://bugs.python.org/issue32366 closed by r.david.murray #32369: test_subprocess: last part of test_close_fds() doesn't check w https://bugs.python.org/issue32369 closed by izbyshev #32376: Unusable syntax error reported when Python keyword in a f-stri https://bugs.python.org/issue32376 closed by r.david.murray #32377: Difference in ressurrection behavior with __del__ in py2 vs. p https://bugs.python.org/issue32377 closed by pitrou #32379: MRO computation could be faster https://bugs.python.org/issue32379 closed by pitrou #32382: Python mulitiprocessing.Queue fail to get according to correct https://bugs.python.org/issue32382 closed by pitrou #32383: subprocess.Popen() is slower than subprocess.run() https://bugs.python.org/issue32383 closed by Николай Соколов #32385: Clean up the C3 MRO algorithm implementation. https://bugs.python.org/issue32385 closed by serhiy.storchaka #32386: dynload_next.c is obsolete https://bugs.python.org/issue32386 closed by benjamin.peterson #32389: urllib3 wrong computation of 'Content-Length' for file upload https://bugs.python.org/issue32389 closed by r.david.murray #32405: clr: AttributeError: 'module' object has no attribute 'AddRefe https://bugs.python.org/issue32405 closed by r.david.murray #32406: Doc: The new dataclasses module is not documented https://bugs.python.org/issue32406 closed by eric.smith #32407: lib2to3 doesn't work when zipped https://bugs.python.org/issue32407 closed by r.david.murray

1 0

f-strings
by Wagner Herculano Dec. 22, 2017

Dec. 22, 2017

Good evening, I'm Wagner Herculano from Brazil. I was trying to do a table exercise with number 5 and tried formatting spaces and did not find it in PEP 498 documentation. Finally I found a way, if possible, include this example in the documentation please. Below is my script with the desired formatting about table of 5. n = 5 for i in range(1,11): print(f'{n} x {i:>2} = {n*i:>2}') Result 5 x 1 = 5 5 x 2 = 10 5 x 3 = 15 5 x 4 = 20 5 x 5 = 25 5 x 6 = 30 5 x 7 = 35 5 x 8 = 40 5 x 9 = 45 5 x 10 = 50 ----------- Sorry my English, I needed to use Google Translate Best Regards, Wagner Herculano

6 9

Re: [Python-Dev] Guarantee ordered dict literals in v3.7?
by Steven D'Aprano Dec. 20, 2017

Dec. 20, 2017

On Wed, Dec 20, 2017 at 03:23:16PM -0800, Chris Barker wrote: > On Wed, Dec 20, 2017 at 2:31 AM, Steven D'Aprano <steve(a)pearwood.info> > wrote: > > Even when it works, the guarantee is quite weak. For instance, even > > the object type is not preserved: > > > > py> class MyDict(dict): > > ... pass > > ... > > py> d = MyDict() > > py> x = eval(repr(d)) > > py> assert d == x > > py> assert type(d) == type(x) > > Traceback (most recent call last): > > File "<stdin>", line 1, in <module> > > AssertionError > > > > Oh come on! If you subclass, and don't override __repr__ -- you're written > a (very slightly) broken class (OK, a class with a broken __repr__). Why is it broken? Is it documented somewhere that every subclass MUST override __repr__? If there's a bug here, and I'm not sure that there is, the bug is in dict itself, for having a repr which isn't friendly to subclasses. But in practice, why would I care? Obviously sometimes I do care, and for debugging it is often good to have a custom repr for subclasses, but it isn't mandatory or even always useful. Especially since in practice, it isn't that common to round-trip repr though eval (apart from the REPL itself, of course). -- Steve

1 0

Usefulness of binary compatibility accross Python versions?
by Antoine Pitrou Dec. 20, 2017

Dec. 20, 2017

Hello, Nowadays we have an official mechanism for third-party C extensions to be binary-compatible accross feature releases of Python: the stable ABI. But, for non-stable ABI-using C extensions, there are also mechanisms in place to *try* and ensure binary compatibility. One of them is the way in which we add tp_ slots to the PyTypeObject structure. Typically, when adding a tp_XXX slot, you also need to add a Py_TPFLAGS_HAVE_XXX type flag to signal those static type structures that have been compiled against a recent enough PyTypeObject definition. This way, extensions compiled against Python N-1 are supposed to "still work": as they don't have Py_TPFLAGS_HAVE_XXX set, the core Python runtime won't try to access the (non-existing) tp_XXX member. However, beside internal code complication, it means you need to add a new Py_TPFLAGS_HAVE_XXX each time we add a slot. Since we have only 32 such bits available (many of them already taken), it is a very limited resource. Is it worth it? (*) Can an extension compiled against Python N-1 really claim to be compatible with Python N, despite other possible differences? (*) we can't extend the tp_flags field to 64 bits, precisely because of the binary compatibility problem... Regards Antoine.

4 11

Revisiting old enhancement requests
by Steven D'Aprano Dec. 20, 2017

Dec. 20, 2017

What is the best practice for revisiting old enhancement requests on the tracker, if I believe that the time is right to revisit a rejected issue from many years ago? (Nearly a decade.) Should I raise a new enhancement request and link back to the old one, or re-open the original? Thanks, -- Steve

2 1

PEP 489: module m_traverse called with NULL module state
by Antoine Pitrou Dec. 19, 2017

Dec. 19, 2017

Hello, After debugging a crash on AppVeyor for a submitter's PR (see https://github.com/python/cpython/pull/4611 ), I came to the following diagnosis: converting the "atexit" module (which is a built-in C extension) to PEP 489 multiphase initialization can lead to its m_traverse function (and presumably also m_clear and m_free) to be called while not module state is yet registered: that is, `PyModule_GetState(self)` when called from m_traverse returns NULL! Is that an expected or known subtlety? Regards Antoine.

3 7

Question on a seemingly useless doctest
by Erik Bray Dec. 19, 2017

Dec. 19, 2017

Hi all, I have a ticket [1] that's hung up on a failure in one doctest in the form of sage.doctest.sources.FileDocTestSource._test_enough_doctests. This test has been there since, it seems, as long as the current doctest framework has been in place and nobody seems to have questioned it. Its expected output is generated from the Sage sources themselves, and can change when tests are added or removed to any module (if any of those tests should be "skipped"). Over the years the expected output to this test has just been updated as necessary. But in taking a closer look at the test--and I could be mistaken--but it's not even a useful test. It's *attempting* to validate that the doctest parser skips tests when it's supposed to. But it performs this validation by...implementing its own, less robust doctest parser, and comparing the results of that to the results of the real doctest parser. Sometimes--in fact often--the comparison is wrong (as the test itself acknowledges). This doesn't seem to me a correct or useful way to validate the doctest parser. If there are cases that the real doctest parser should be tested against, then unit tests/regression tests should be written that simply test the real doctest parser against those cases and check the results. Having essentially a real doctest parser, and a "fake" one that's incorrect doesn't make sense to me, unless there's something about this I'm misunderstanding. I would propose to just remove the test. If there are any actual regressions it's responsible for catching then more focused regression tests should be written for those cases. Erik [1] https://trac.sagemath.org/ticket/24261#comment:24

1 1