Python-Dev May 2018

python-dev@python.org

103 participants
88 discussions

Re: [Python-Dev] PEP 574 (pickle 5) implementation and backport available

by Matthew Rocklin

Hi all, I agree that compression is often a good idea when moving serialized objects around on a network, but for what it's worth I as a library author would always set compress=False and then handle it myself as a separate step. There are a few reasons for this: 1. Bandwidth is often pretty good, especially intra-node, on high performance networks, or on decent modern discs (NVMe) 2. I often use different compression technologies in different situations. LZ4 is a great all-around default, but often snappy, blosc, or z-standrad are better suited. This depends strongly on the characteristics of the data. 3. Very often data often isn't compressible, or is already in some compressed form, such as in images, and so compressing only hurts you. In general, my thought is that compression is a complex topic with enough intricaces that setting a single sane default that works 70+% of the time probably isn't possible (at least not with the applications that I get exposed to). Instead of baking a particular method into pickle.dumps I would recommend trying to solve this problem through documentation, pointing users to the various compression libraries within the broader Python ecosystem, and perhaps pointing to one of the many blogposts that discuss their strengths and weaknesses. Best, -matt

2 years, 2 months

PEP 574 (pickle 5) implementation and backport available

by Antoine Pitrou

Hi, While PEP 574 (pickle protocol 5 with out-of-band data) is still in draft status, I've made available an implementation in branch "pickle5" in my GitHub fork of CPython: https://github.com/pitrou/cpython/tree/pickle5 Also I've published an experimental backport on PyPI, for Python 3.6 and 3.7. This should help people play with the new API and features without having to compile Python: https://pypi.org/project/pickle5/ Any feedback is welcome. Regards Antoine.

2 years, 2 months

Summary of Python tracker Issues

by Python tracker

ACTIVITY SUMMARY (2018-05-18 - 2018-05-25) Python tracker at https://bugs.python.org/ To view or respond to any of the issues listed below, click on the issue. Do NOT respond to this message. Issues counts and deltas: open 6699 (+13) closed 38700 (+63) total 45399 (+76) Open issues with patches: 2638 Issues opened (54) ================== #27485: urllib.splitport -- is it official or not? https://bugs.python.org/issue27485 reopened by serhiy.storchaka #27535: Ignored ResourceWarning warnings leak memory in warnings regis https://bugs.python.org/issue27535 reopened by vstinner #33330: Better error handling in PyImport_Cleanup() https://bugs.python.org/issue33330 reopened by vstinner #33573: statistics.median does not work with ordinal scale https://bugs.python.org/issue33573 opened by W deW #33575: Python relies on C undefined behavior float-cast-overflow https://bugs.python.org/issue33575 opened by gregory.p.smith #33576: Make exception wrapping less intrusive for __set_name__ calls https://bugs.python.org/issue33576 opened by ncoghlan #33578: cjkcodecs missing getstate and setstate implementations https://bugs.python.org/issue33578 opened by libcthorne #33579: calendar.timegm not always an inverse of time.gmtime https://bugs.python.org/issue33579 opened by eitan.adler #33581: Document "optional components that are commonly included in Py https://bugs.python.org/issue33581 opened by Antony.Lee #33582: formatargspec deprecated but does nto emit DeprecationWarning. https://bugs.python.org/issue33582 opened by mbussonn #33586: 2.7.15 missing release notes on download page https://bugs.python.org/issue33586 opened by ericvw #33587: inspect.getsource performs unnecessary filesystem stat call wh https://bugs.python.org/issue33587 opened by Pankaj Pandey #33590: sched.enter priority has no impact on execution https://bugs.python.org/issue33590 opened by sahilmn #33591: ctypes does not support fspath protocol https://bugs.python.org/issue33591 opened by mrh1997 #33592: Document contextvars C API https://bugs.python.org/issue33592 opened by Elvis.Pranskevichus #33594: add deprecation since 3.5 for a few methods of inspect. https://bugs.python.org/issue33594 opened by mbussonn #33595: FIx references to lambda "arguments" https://bugs.python.org/issue33595 opened by adelfino #33597: Compact PyGC_Head https://bugs.python.org/issue33597 opened by inada.naoki #33598: ActiveState Recipes links in docs, and the apparent closure of https://bugs.python.org/issue33598 opened by tritium #33600: [EASY DOC] Python 2: document that platform.linux_distribution https://bugs.python.org/issue33600 opened by vstinner #33601: [EASY DOC] Py_UTF8Mode is not documented https://bugs.python.org/issue33601 opened by serhiy.storchaka #33602: Remove set and queue references from Data Types https://bugs.python.org/issue33602 opened by adelfino #33603: Subprocess Thread handles grow with each call and aren't relea https://bugs.python.org/issue33603 opened by GranPrego #33604: HMAC default to MD5 marked as to be removed in 3.6 https://bugs.python.org/issue33604 opened by mbussonn #33605: Detect accessing event loop from a different thread outside of https://bugs.python.org/issue33605 opened by hniksic #33606: Improve logging performance when logger disabled https://bugs.python.org/issue33606 opened by vinay.sajip #33607: [subinterpreters] Explicitly track object ownership (and alloc https://bugs.python.org/issue33607 opened by eric.snow #33608: [subinterpreters] Add a cross-interpreter-safe mechanism to in https://bugs.python.org/issue33608 opened by eric.snow #33609: Document that dicts preserve insertion order https://bugs.python.org/issue33609 opened by yselivanov #33610: IDLE: Make multiple improvements to CodeContext https://bugs.python.org/issue33610 opened by terry.reedy #33613: test_multiprocessing_fork: test_semaphore_tracker_sigint() fai https://bugs.python.org/issue33613 opened by vstinner #33614: Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x https://bugs.python.org/issue33614 opened by vstinner #33615: test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x https://bugs.python.org/issue33615 opened by vstinner #33616: typing.NoReturn is undocumented https://bugs.python.org/issue33616 opened by srittau #33617: subprocess.Popen etc do not accept os.PathLike in passed seque https://bugs.python.org/issue33617 opened by altendky #33618: Support TLS 1.3 https://bugs.python.org/issue33618 opened by christian.heimes #33623: Fix possible SIGSGV when asyncio.Future is created in __del__ https://bugs.python.org/issue33623 opened by yselivanov #33624: Implement subclass hooks for asyncio abstract classes https://bugs.python.org/issue33624 opened by asvetlov #33625: Release GIL for grp.getgr{nam,gid} and pwd.getpw{nam,uid} https://bugs.python.org/issue33625 opened by wg #33627: test-complex of test_numeric_tower.test_complex() crashes inte https://bugs.python.org/issue33627 opened by vstinner #33630: test_posix: TestPosixSpawn fails on PPC64 Fedora 3.x https://bugs.python.org/issue33630 opened by vstinner #33632: undefined behaviour: signed integer overflow in threadmodule.c https://bugs.python.org/issue33632 opened by pitrou #33635: OSError when using pathlib.Path.rglob() to list device files https://bugs.python.org/issue33635 opened by Victor Domingos #33637: pip cannot build extensions for debug Python https://bugs.python.org/issue33637 opened by Ivan.Pozdeev #33638: condition lock not re-acquired https://bugs.python.org/issue33638 opened by christof #33639: Use high-performance os.sendfile() in shutil.copy* https://bugs.python.org/issue33639 opened by giampaolo.rodola #33640: uuid: endian of the bytes argument is not documented https://bugs.python.org/issue33640 opened by vstinner #33641: Add links to RFCs https://bugs.python.org/issue33641 opened by serhiy.storchaka #33642: IDLE: Use variable number of lines in CodeContext https://bugs.python.org/issue33642 opened by cheryl.sabella #33643: Mock functions with autospec STILL don't support assert_called https://bugs.python.org/issue33643 opened by dybi #33644: Fix signatures of tp_finalize handlers in testing code. https://bugs.python.org/issue33644 opened by serhiy.storchaka #33645: Importing bs4 fails with -3 option in Python 2.7.15 https://bugs.python.org/issue33645 opened by fschulze #33647: Make string.replace accept a dict instead of two arguments https://bugs.python.org/issue33647 opened by paalped #33648: unused with_c_locale_warning option in configure should be rem https://bugs.python.org/issue33648 opened by eitan.adler Most recent 15 issues with no replies (15) ========================================== #33644: Fix signatures of tp_finalize handlers in testing code. https://bugs.python.org/issue33644 #33643: Mock functions with autospec STILL don't support assert_called https://bugs.python.org/issue33643 #33641: Add links to RFCs https://bugs.python.org/issue33641 #33635: OSError when using pathlib.Path.rglob() to list device files https://bugs.python.org/issue33635 #33624: Implement subclass hooks for asyncio abstract classes https://bugs.python.org/issue33624 #33616: typing.NoReturn is undocumented https://bugs.python.org/issue33616 #33606: Improve logging performance when logger disabled https://bugs.python.org/issue33606 #33602: Remove set and queue references from Data Types https://bugs.python.org/issue33602 #33600: [EASY DOC] Python 2: document that platform.linux_distribution https://bugs.python.org/issue33600 #33598: ActiveState Recipes links in docs, and the apparent closure of https://bugs.python.org/issue33598 #33595: FIx references to lambda "arguments" https://bugs.python.org/issue33595 #33594: add deprecation since 3.5 for a few methods of inspect. https://bugs.python.org/issue33594 #33591: ctypes does not support fspath protocol https://bugs.python.org/issue33591 #33586: 2.7.15 missing release notes on download page https://bugs.python.org/issue33586 #33582: formatargspec deprecated but does nto emit DeprecationWarning. https://bugs.python.org/issue33582 Most recent 15 issues waiting for review (15) ============================================= #33648: unused with_c_locale_warning option in configure should be rem https://bugs.python.org/issue33648 #33645: Importing bs4 fails with -3 option in Python 2.7.15 https://bugs.python.org/issue33645 #33644: Fix signatures of tp_finalize handlers in testing code. https://bugs.python.org/issue33644 #33642: IDLE: Use variable number of lines in CodeContext https://bugs.python.org/issue33642 #33641: Add links to RFCs https://bugs.python.org/issue33641 #33639: Use high-performance os.sendfile() in shutil.copy* https://bugs.python.org/issue33639 #33630: test_posix: TestPosixSpawn fails on PPC64 Fedora 3.x https://bugs.python.org/issue33630 #33625: Release GIL for grp.getgr{nam,gid} and pwd.getpw{nam,uid} https://bugs.python.org/issue33625 #33623: Fix possible SIGSGV when asyncio.Future is created in __del__ https://bugs.python.org/issue33623 #33618: Support TLS 1.3 https://bugs.python.org/issue33618 #33617: subprocess.Popen etc do not accept os.PathLike in passed seque https://bugs.python.org/issue33617 #33616: typing.NoReturn is undocumented https://bugs.python.org/issue33616 #33609: Document that dicts preserve insertion order https://bugs.python.org/issue33609 #33604: HMAC default to MD5 marked as to be removed in 3.6 https://bugs.python.org/issue33604 #33602: Remove set and queue references from Data Types https://bugs.python.org/issue33602 Top 10 most discussed issues (10) ================================= #33614: Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x https://bugs.python.org/issue33614 13 msgs #32911: Doc strings no longer stored in body of AST https://bugs.python.org/issue32911 10 msgs #33462: reversible dict https://bugs.python.org/issue33462 10 msgs #33597: Compact PyGC_Head https://bugs.python.org/issue33597 8 msgs #33615: test__xxsubinterpreters crashed on x86 Gentoo Refleaks 3.x https://bugs.python.org/issue33615 8 msgs #33618: Support TLS 1.3 https://bugs.python.org/issue33618 8 msgs #33355: Windows 10 buildbot: 15 min timeout on test_mmap.test_large_fi https://bugs.python.org/issue33355 7 msgs #33521: Add 1.32x faster C implementation of asyncio.isfuture(). https://bugs.python.org/issue33521 7 msgs #33579: calendar.timegm not always an inverse of time.gmtime https://bugs.python.org/issue33579 7 msgs #19251: bitwise ops for bytes of equal length https://bugs.python.org/issue19251 6 msgs Issues closed (61) ================== #19950: Document that unittest.TestCase.__init__ is called once per te https://bugs.python.org/issue19950 closed by gregory.p.smith #20941: pytime.c:184 and pytime.c:218: runtime error, outside the rang https://bugs.python.org/issue20941 closed by vstinner #26819: _ProactorReadPipeTransport pause_reading()/resume_reading() br https://bugs.python.org/issue26819 closed by asvetlov #28547: Python to use Windows Certificate Store https://bugs.python.org/issue28547 closed by Jean-Philippe Landry #29428: Doctest documentation unclear about multi-line fixtures https://bugs.python.org/issue29428 closed by willingc #30877: possibe typo in json/scanner.py https://bugs.python.org/issue30877 closed by serhiy.storchaka #30940: Documentation for round() is incorrect. https://bugs.python.org/issue30940 closed by serhiy.storchaka #31106: os.posix_fallocate() generate exception with errno 0 https://bugs.python.org/issue31106 closed by ned.deily #31493: IDLE cond context: fix code update and font update timers https://bugs.python.org/issue31493 closed by terry.reedy #31868: Null pointer dereference in ndb.ndbm get when used with a defa https://bugs.python.org/issue31868 closed by serhiy.storchaka #32708: test_sendfile() hangs on AMD64 FreeBSD 10.x Shared 3.x buildbo https://bugs.python.org/issue32708 closed by vstinner #32831: IDLE: Add docstrings and tests for codecontext https://bugs.python.org/issue32831 closed by terry.reedy #33037: Skip sending/receiving after SSL transport closing https://bugs.python.org/issue33037 closed by asvetlov #33109: argparse: make new 'required' argument to add_subparsers defau https://bugs.python.org/issue33109 closed by ned.deily #33263: Asyncio server enters an invalid state after a request with SO https://bugs.python.org/issue33263 closed by asvetlov #33321: Add a Linux clang ubsan undefined behavior sanitizer buildbot https://bugs.python.org/issue33321 closed by gregory.p.smith #33353: test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs https://bugs.python.org/issue33353 closed by vstinner #33354: Python2: test_ssl fails on non-ASCII path https://bugs.python.org/issue33354 closed by vstinner #33421: Missing documentation for typing.AsyncContextManager https://bugs.python.org/issue33421 closed by levkivskyi #33430: Import secrets module in secrets examples https://bugs.python.org/issue33430 closed by steven.daprano #33441: Expose the sigset_t converter via private API https://bugs.python.org/issue33441 closed by serhiy.storchaka #33447: Asynchronous lambda syntax https://bugs.python.org/issue33447 closed by yselivanov #33454: Mismatched C function signature in _xxsubinterpreters.channel_ https://bugs.python.org/issue33454 closed by serhiy.storchaka #33475: Fix converting AST expression to string and optimize parenthes https://bugs.python.org/issue33475 closed by serhiy.storchaka #33514: async and await as keywords not mentioned in What’s New In P https://bugs.python.org/issue33514 closed by hroncok #33516: unittest.mock: Add __round__ to supported magicmock methods https://bugs.python.org/issue33516 closed by vstinner #33518: Add PEP to glossary https://bugs.python.org/issue33518 closed by vstinner #33528: os.getentropy support https://bugs.python.org/issue33528 closed by David Carlier #33537: Help on importlib.resources outputs the builtin open descripti https://bugs.python.org/issue33537 closed by serhiy.storchaka #33540: socketserver: Add an opt-in option to get Python 3.6 behaviour https://bugs.python.org/issue33540 closed by vstinner #33541: Remove private and apparently unused __pad function https://bugs.python.org/issue33541 closed by belopolsky #33542: _ipconfig_getnode incorrectly selects a DUID as a MAC address https://bugs.python.org/issue33542 closed by serhiy.storchaka #33544: Asyncio Event.wait() is a hold over from before awaitable, and https://bugs.python.org/issue33544 closed by asvetlov #33546: asyncio.Condition should become awaitable in 3.9 https://bugs.python.org/issue33546 closed by asvetlov #33556: leftover thread crumb in threading.ident docstring https://bugs.python.org/issue33556 closed by zach.ware #33565: strange tracemalloc results https://bugs.python.org/issue33565 closed by thehesiod #33574: Conversion of Number to String(str(number)) https://bugs.python.org/issue33574 closed by eric.smith #33577: remove wrapping of __set_name__ exceptions in RuntimeError https://bugs.python.org/issue33577 closed by carljm #33580: Make binary/text file glossary entries follow most common "see https://bugs.python.org/issue33580 closed by serhiy.storchaka #33583: PyObject_GC_Resize() doesn't relink GCHead https://bugs.python.org/issue33583 closed by inada.naoki #33584: Fix several minor bugs in asyncio https://bugs.python.org/issue33584 closed by serhiy.storchaka #33585: re.sub calls repl function one time too many for catch-all reg https://bugs.python.org/issue33585 closed by serhiy.storchaka #33588: Unicode function arguments aren't preserved https://bugs.python.org/issue33588 closed by steven.daprano #33589: Remove dummy member in GCHead https://bugs.python.org/issue33589 closed by inada.naoki #33593: Support heapq on typed arrays? https://bugs.python.org/issue33593 closed by rhettinger #33596: fix memory leak in lib/json/scanner.py py_make_scanner https://bugs.python.org/issue33596 closed by serhiy.storchaka #33599: Copying objects subclassed from SimpleNamespace doesn't work https://bugs.python.org/issue33599 closed by serhiy.storchaka #33611: Fatal Python error: Py_Initialize: unable to load the file sys https://bugs.python.org/issue33611 closed by vstinner #33612: Assertion failure in PyThreadState_Clear https://bugs.python.org/issue33612 closed by vstinner #33619: libffi detection via pkg-config is broken https://bugs.python.org/issue33619 closed by benjamin.peterson #33620: requests.Session doesn't properly handle closed keep-alive ses https://bugs.python.org/issue33620 closed by Jonathan Lynch #33621: repr(threading._DummyThread) always fails. https://bugs.python.org/issue33621 closed by fabioz #33622: Fix errors handling in the garbage collector https://bugs.python.org/issue33622 closed by serhiy.storchaka #33626: test_sendfile_fallback_close_peer_in_middle_of_receiving() fai https://bugs.python.org/issue33626 closed by vstinner #33628: IDLE: Code cleanup on codecontext https://bugs.python.org/issue33628 closed by terry.reedy #33629: test_importlib creates a coredump on AMD64 FreeBSD 10.x Shared https://bugs.python.org/issue33629 closed by vstinner #33631: [ValueError] _strptime.py can't handle 12-hr format strings us https://bugs.python.org/issue33631 closed by ammar2 #33633: smtplib msg['To] = appends instead of assigning https://bugs.python.org/issue33633 closed by r.david.murray #33634: Buildbot configuration issue on Windows7 buildbots https://bugs.python.org/issue33634 closed by zach.ware #33636: Unexpected behavior with * and arrays https://bugs.python.org/issue33636 closed by steven.daprano #33646: os.fspath() bypasses __fspath__ for str subclasses https://bugs.python.org/issue33646 closed by serhiy.storchaka

2 years, 2 months

"make test" routinely fails to terminate

by Skip Montanaro

On the 3.7 branch, "make test" routinely fails to terminate. (Pretty vanilla Ubuntu 17.10 running on a Dell Laptop. Nothing esoteric at all) Lately, it's been one of the multiprocessing tests. After a long while (~2000 seconds), I kill it, then it complains many times about lack of a valid_signals attribute in the signal module: ====================================================================== ERROR: test_remove_signal_handler_error2 (test.test_asyncio.test_unix_events.SelectorEventLoopSignalTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/skip/src/python/cpython/Lib/unittest/mock.py", line 1191, in patched return func(*args, **keywargs) File "/home/skip/src/python/cpython/Lib/test/test_asyncio/test_unix_events.py", line 219, in test_remove_signal_handler_error2 m_signal.valid_signals = signal.valid_signals AttributeError: module 'signal' has no attribute 'valid_signals' ---------------------------------------------------------------------- Ran 1967 tests in 36.058s FAILED (errors=362, skipped=11) test test_asyncio failed /home/skip/src/python/cpython/Lib/asyncio/base_events.py:605: ResourceWarning: unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=False> source=self) Re-running test 'test_signal' in verbose mode then reruns test_signal in verbose mode. Earlier today, a run succeeded, so I'm guessing a race condition exists in the test system. I recall encountering a similar problem a few weeks ago and discovered this open ticket: https://bugs.python.org/issue33099 Should I expect this as the normal behavior? Skip

2 years, 2 months

FINAL WEEK FOR 3.7.0 CHANGES!

by Ned Deily

This is it! We are down to THE FINAL WEEK for 3.7.0! Please get your feature fixes, bug fixes, and documentation updates in before 2018-05-21 ~23:59 Anywhere on Earth (UTC-12:00). That's about 7 days from now. We will then tag and produce the 3.7.0 release candidate. Our goal continues been to be to have no changes between the release candidate and final; AFTER NEXT WEEK'S RC1, CHANGES APPLIED TO THE 3.7 BRANCH WILL BE RELEASED IN 3.7.1. Please double-check that there are no critical problems outstanding and that documentation for new features in 3.7 is complete (including NEWS and What's New items), and that 3.7 is getting exposure and tested with our various platorms and third-party distributions and applications. Those of us who are participating in the development sprints at PyCon US 2018 here in Cleveland can feel the excitement building as we work through the remaining issues, including completing the "What's New in 3.7" document and final feature documentation. (We wish you could all be here.) As noted before, the ABI for 3.7.0 was frozen as of 3.7.0b3. You should now be treating the 3.7 branch as if it were already released and in maintenance mode. That means you should only push the kinds of changes that are appropriate for a maintenance release: non-ABI-changing bug and feature fixes and documentation updates. If you find a problem that requires an ABI-altering or other significant user-facing change (for example, something likely to introduce an incompatibility with existing users' code or require rebuilding of user extension modules), please make sure to set the b.p.o issue to "release blocker" priority and describe there why you feel the change is necessary. If you are reviewing PRs for 3.7 (and please do!), be on the lookout for and flag potential incompatibilities (we've all made them). Thanks again for all of your hard work towards making 3.7.0 yet another great release - coming to a website near you on 06-15! Release Managerly Yours, --Ned https://www.python.org/dev/peps/pep-0537/ -- Ned Deily nad(a)python.org -- []

2 years, 2 months

PEP: 576 Title: Rationalize Built-in function classes

by mark

Hi, At the language summit this year, there was some discussion of PEP 575. I wanted to simplify the PEP, but rather than modify that PEP, Nick Coghlan encouraged me to write an alternative PEP instead. PEP 576 aims to fulfill the same goals as PEP 575, but with fewer changes and to be fully backwards compatible. The PEP can be viewed here: https://github.com/python/peps/blob/master/pep-0576.rst Cheers, Mark. P.S. I'm happy to have discussion of this PEP take place via GitHub, rather than the mailing list, but I thought I would follow the conventional route for now.

2 years, 2 months

My fork lacks a 3.7 branch - can I create it somehow?

by Skip Montanaro

My GitHub fork of the cpython repo was made awhile ago, before a 3.7 branch was created. I have no remotes/origin/3.7. Is there some way to create it from remotes/upstream/3.7? I asked on GitHub's help forums. The only recommendation was to to delete my fork and recreate it. That seemed kind of drastic, and I will do it if that's really the only way, but this seems like functionality Git and/or GitHub probably supports. Thx, Skip

2 years, 2 months

Re: [Python-Dev] PEP: 576 Title: Rationalize Built-in function classes

by Jeroen Demeyer

For the record: the only reason that I replied on GitHub was because the proposal was not yet posted (as far as I know) to any mailing list. Typically, a post is made to a mailing list more or less at the same time as creating the PEP. In this case, there was a delay of a few days, maybe also because of unrelated issues with the compilation of the PEPs.

2 years, 2 months

Procedure for adding new public C API

by Serhiy Storchaka

Please don't forgot to perform the following steps when add a new public C API: * Document it in Doc/c-api/. * Add an entry in the What's New document. * Add it in Doc/data/refcounts.dat. * Add it in PC/python3.def. If you want to include it in the limited API, wrap its declaration with: #if !defined(Py_LIMITED_API) || Py_LIMITED_API+0 >= 0x03080000 #endif (use the correct Python version of introducing a feature in the comparison) If you don't want to include it in the limited API, wrap its declaration with: #ifndef Py_LIMITED_API #endif You are free of adding private C API, but its name should start with _Py or _PY and its declaration should be wrapped with: #ifndef Py_LIMITED_API #endif

2 years, 2 months

Reminder: Please elaborate commit messages

by Victor Stinner

Hi, In https://bugs.python.org/issue33531, Andrew Svetlov wrote "Fixed failed sendfile tests on Windows (at least I hope so)." without giving any bpo number or a commit number. So I looked at latest commits and I found: --- commit e2537521916c5bf88fcf54d4654ff1bcd332be4a Author: Andrew Svetlov <andrew.svetlov(a)gmail.com> Date: Mon May 21 12:03:45 2018 +0300 Fix asyncio flaky tests (#7023) --- Please try to write better error messages for people who will dig into the Git history in 1, 5 or 10 years: * Usually, it's better to open a bug. Here you could give the full error message, mention on which platform the test fails, etc. * Mention which tests are affected * Maybe even give an extract of the error message of the fixed test in the commit message I know that it's more effort and fixing flaky tests is annoying and may require multiple iterations, but again, please think to people who will have to read the Git history later... I was able able to rebuild the context of this commit from a comment of https://bugs.python.org/issue33531 Victor

2 years, 2 months

← Newer
1
2
3
4
5
6
7
8
9
Older →

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

2000

1999

Python-Dev May 2018