2016-04-24 23:16 GMT+02:00 Raymond Hettinger firstname.lastname@example.org:
On Apr 24, 2016, at 1:16 PM, Victor Stinner email@example.com wrote: I proposed to not try to optimize ceval.c to fetch (oparg, opval) in a single 16-bit operation. It should be easy to implement it later, but I prefer to focus on changing the format of the bytecode.
Improving instruction decoding was the whole point and it was what kicked-off the work on the patch. It is also where most of the performance improvement comes from and isn't the difficult part of the patch. The persnickety parts of the patch lay elsewhere, so there is really nothing to be gained gutting out our actual objective.
The OPs original patch had already gotten this part done and it ran fine for me.
Oh wait, my phrasing is unclear. I do want optimize the (opcode, oparg) fetch, I just suggested to split the patch in two parts, and first review carefully the first part.