In itself, the code clean up you have done is a good thing in the sense that you re-organized things and in my understanding, they look good now. In some of the teams I've been granted to work, there was a rule stating that whenever a dev would work on an enhancement/bugfix, he would create a separate ticket that would track all code refactoring related to his work. The strategy is quite different here and the suggestion was to have your refactoring be part of an enhancement/bugfix. The most valuable argument in favor of all the current reviewers is Guido van Rossum's comment on the effect of having git blame made harder.
For some of the projects I'm currently working on, we have code cleanup teams where members are affected expressly to refactoring code. We might end up needing such things in the future but for now, it is wiser to leave the code as is and focus on fixing actual problems.

Q::Drone's Co-Founder and Co-CEO
Hervé "Kyle" MUTOMBO

Envoyé depuis le web.