
July 6, 2021
10:22 p.m.
On 7/6/2021 12:29 PM, Brian Curtin wrote:
Before looking at the code, my first question would be about the description: "I kinda ran out of time, i suspect more testing is due."
If you were out of time then it's probably not done and maybe lacks the tests you initially thought it did, so did you find the time Tests were added later the same day. The opening comment should have been edited (I made an attempt at it).
and/or is the PR done?
Asked on PR. -- Terry Jan Reedy